archive
/
matrix-spec-proposals
mirror of https://github.com/matrix-org/matrix-spec-proposals
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
pull/3664/head
DeepBlueV7.X 4 years ago committed by GitHub
parent df9aab5220
commit 00b0ef9aa6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File

10
proposals/3664-notifications-for-relations.md
Unescape Escape View File

@ -18,7 +18,7 @@ can adjust them to their own wishes.
### New push rule condition: `related_event_match` ### New push rule condition: `related_event_match`
Notifications for relation based features need to distinguish, what type of Notifications for relation based features need to distinguish what type of
relation was used and potentially match on the content of the related-to event. relation was used and potentially match on the content of the related-to event.
To do that we introduce a new type of condition: `related_event_match`. This is To do that we introduce a new type of condition: `related_event_match`. This is
@ -38,7 +38,7 @@ event. Such a condition could look like this:
This condition can be used to notify me whenever someone sends a reply to my This condition can be used to notify me whenever someone sends a reply to my
messages. messages.
- `rel_type` is the relation type. For the sake of compatibility replies - `rel_type` is the relation type. For the sake of compatibility, replies
should be matched as if they were sent in the relation format from should be matched as if they were sent in the relation format from
[MSC2674](https://github.com/matrix-org/matrix-doc/pull/2674) with a [MSC2674](https://github.com/matrix-org/matrix-doc/pull/2674) with a
`rel_type` of `m.in_reply_to`. If the event has any relation of this type, `rel_type` of `m.in_reply_to`. If the event has any relation of this type,
@ -90,8 +90,8 @@ testing for an existing `.m.rule.reply` in the default rules.
To enable notifications for replies without relying on the reply fallback, but To enable notifications for replies without relying on the reply fallback, but
with similar semantics we also define a new default push rule. The proposed with similar semantics we also define a new default push rule. The proposed
push rule differs slightly from the old behaviour, because it only notifies you push rule differs slightly from the old behaviour, because it only notifies you
for replies to your events, but it does not notify you for replies to events, for replies to your events, but it does not notify you for replies to events
which contained your display name or matrix ID. The rule should look like this: containing your display name or matrix ID. The rule should look like this:
```json5 ```json5
{ {
@ -155,7 +155,7 @@ relations only added as a fallback are ignored. (Currently `is_falling_back` key
is in a bit of a weird location. Maybe this can be amended in the threading MSC is in a bit of a weird location. Maybe this can be amended in the threading MSC
to be a bit more generic before it is added to the spec.) to be a bit more generic before it is added to the spec.)
Adding a new rule that causes notifications, forces users to change their Adding a new rule that causes notifications will force users to change their
notification settings again. In this case, a user who disabled notifications notification settings again. In this case, a user who disabled notifications
for mentions (or set them to silent) may be surprised to suddenly start for mentions (or set them to silent) may be surprised to suddenly start
receiving noisy notifications for replies. Worse, in the transition period, receiving noisy notifications for replies. Worse, in the transition period,

Write Preview
Loading…
Cancel
Save