You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/test/units/parsing
Adrian Likins dd0189839e Fix bug (#18355) where encrypted inventories fail 18355 (#18373)
* Fix bug (#18355) where encrypted inventories fail

This is first part of fix for #18355
* Make DataLoader._get_file_contents return bytes

The issue #18355 is caused by a change to inventory to
stop using _get_file_contents so that it can handle text
encoding itself to better protect against harmless text
encoding errors in ini files (invalid unicode text in
comment fields).

So this makes _get_file_contents return bytes so it and other
callers can handle the to_text().

The data returned by _get_file_contents() is now a bytes object
instead of a text object. The callers of _get_file_contents() have
been updated to call to_text() themselves on the results.

Previously, the ini parser attempted to work around
ini files that potentially include non-vailid unicode
in comment lines. To do this, it stopped using
DataLoader._get_file_contents() which does the decryption of
files if vault encrypted. It didn't use that because _get_file_contents
previously did to_text() on the read data itself.

_get_file_contents() returns a bytestring now, so ini.py
can call it and still special case ini file comments when
converting to_text(). That also means encrypted inventory files
are decrypted first.

Fixes #18355
8 years ago
..
utils Clean up shebangs for various files. 8 years ago
vault Many Cleanups to vault 8 years ago
yaml Move uses of to_bytes, to_text, to_native to use the module_utils version (#17423) 8 years ago
__init__.py Making the switch to v2 10 years ago
test_addresses.py allow for non standard hostnames 9 years ago
test_data_loader.py Fix bug (#18355) where encrypted inventories fail 18355 (#18373) 8 years ago
test_mod_args.py Revert "Track local_action internally to prevent it from being overridden" 9 years ago
test_splitter.py New unit tests for #13630 fix 9 years ago
test_unquote.py Break apart a looped dependency to show a warning when parsing playbooks 9 years ago