You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/test/units
Adrian Likins dd0189839e Fix bug (#18355) where encrypted inventories fail 18355 (#18373)
* Fix bug (#18355) where encrypted inventories fail

This is first part of fix for #18355
* Make DataLoader._get_file_contents return bytes

The issue #18355 is caused by a change to inventory to
stop using _get_file_contents so that it can handle text
encoding itself to better protect against harmless text
encoding errors in ini files (invalid unicode text in
comment fields).

So this makes _get_file_contents return bytes so it and other
callers can handle the to_text().

The data returned by _get_file_contents() is now a bytes object
instead of a text object. The callers of _get_file_contents() have
been updated to call to_text() themselves on the results.

Previously, the ini parser attempted to work around
ini files that potentially include non-vailid unicode
in comment lines. To do this, it stopped using
DataLoader._get_file_contents() which does the decryption of
files if vault encrypted. It didn't use that because _get_file_contents
previously did to_text() on the read data itself.

_get_file_contents() returns a bytestring now, so ini.py
can call it and still special case ini file comments when
converting to_text(). That also means encrypted inventory files
are decrypted first.

Fixes #18355
8 years ago
..
cli set galaxy unit test server to None (#18298) 8 years ago
contrib Add a new vmware inventory script backed by pyvmomi (#15967) 8 years ago
errors Relocate use of ERROR to display class, to avoid doubling up 9 years ago
executor Change `v2_playbook_on_start` logic to positively detect legacy plugins 8 years ago
inventory Changing up how host (in)equality is checked 9 years ago
inventory_test_data/group_vars Merge branch 'v2_final' into devel_switch_v2 9 years ago
mock Fix bug (#18355) where encrypted inventories fail 18355 (#18373) 8 years ago
module_utils Set ansible_os_family correctly under KDE neon 8 years ago
modules Clean up shebangs for various files. 8 years ago
parsing Fix bug (#18355) where encrypted inventories fail 18355 (#18373) 8 years ago
playbook Fix uninitialized variable in deserialize method (#18037) 8 years ago
plugins Clean up shebangs for various files. 8 years ago
template Merge branch 'threaded_receiver' into devel 8 years ago
utils FEATURE: adding variable serial batches 8 years ago
vars Make ini parsing slightly more robust 8 years ago
__init__.py Making the switch to v2 10 years ago