You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Rob Smith 761fe8cc04 Fix an issue where git-pull fails with AttributeError ... As part of 94f3b9bfab the code was changed to support dynamically adding localhost to the inventory. This change introduced an crash when run via ansible-pull ``` Starting ansible-pull at 2014-01-20 23:09:57 Traceback (most recent call last): File "/tmp/ansible/bin/ansible", line 157, in <module> (runner, results) = cli.run(options, args) File "/tmp/ansible/bin/ansible", line 82, in run hosts = inventory_manager.list_hosts(pattern) File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 372, in list_hosts result = [ h.name for h in self.get_hosts(pattern) ] File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 136, in get_hosts subset = self._get_hosts(self._subset) File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 177, in _get_hosts that = self.__get_hosts(p) File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 198, in __get_hosts hpat = self._hosts_in_unenumerated_pattern(name) File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 275, in _hosts_in_unenumerated_pattern ungrouped.add_host(new_host) AttributeError: 'NoneType' object has no attribute 'add_host' ``` The root cause is there is no group for the host to be added to. I fixed this case by creating the ungrouped group when it doesn't exist and then adding the host to the newly added group. This fixes the regression for me.		12 years ago
..
callback_plugins	Update various copyrights. Not complete, but sufficient.	12 years ago
inventory	Fix an issue where git-pull fails with AttributeError	12 years ago
module_utils	When not finding a host in ~/.ssh/known_hosts, the return value is 0 if the host just is not found. We then never check the system host file in /etc. This fixes the code to check /etc on any failure, not just a bad return code.	12 years ago
playbook	Revert "Merge pull request #5325 from angstwad/add-su-support"	12 years ago
runner	Revert "Merge pull request #5325 from angstwad/add-su-support"	12 years ago
utils	Revert "Merge pull request #5325 from angstwad/add-su-support"	12 years ago
__init__.py	Update various copyrights. Not complete, but sufficient.	12 years ago
callbacks.py	Update various copyrights. Not complete, but sufficient.	12 years ago
color.py	Update various copyrights. Not complete, but sufficient.	12 years ago
constants.py	Revert "Merge pull request #5325 from angstwad/add-su-support"	12 years ago
errors.py	Update various copyrights. Not complete, but sufficient.	12 years ago
module_common.py	Update various copyrights. Not complete, but sufficient.	12 years ago