1737 Commits (fdfba6aa6842af709d3c5d72adba8a5cfbaa463d)

Author	SHA1	Message	Date
Bernhard Weitzhofer	210d711553	Add module postgresql_privs ... This Module allows to manage privileges on PostgreSQL database objects (currently: tables, sequences, functions, databases, schemas, languages and tablespaces) as well as group role memberships. It is basically a wrapper around most of the functionality of PostgreSQL's GRANT and REVOKE statements with additional detection of changes and support for dry-runs (check-mode). postgresql_privs should work with PostgreSQL 8.4 and above. Python Module psycopg2 is required on the remote host.	12 years ago
Bernhard Weitzhofer	c2a7314a5f	user module: return public SSH key ... Return public SSH key if the user module is called with generate_ssh_key=yes. Since "user" doesn't overwrite files, this also allows querying of existing public keys. Used in playbooks together with the "register" keyword, the returned key can be passed to the "authorized_key" module allowing easy setup of SSH public key authentication between remote hosts.	12 years ago
Michael DeHaan	96d014581a	Merge pull request #2605 from b6d/postgresql_user-quote-pwd ... Use psycopg2's string handling to escape password string	12 years ago
James Martin	7609c5e0d0	Errors in documentation.	12 years ago
James Martin	93d0ccd1e1	Added catch-all exception for stats collection.	12 years ago
Michael DeHaan	06b988e2d5	Create the .ssh dir if it does not already exist.	12 years ago
Blair Zajac	5d0f78d571	ec2_facts: add ansible_ec2_placement_region key/value pair for EC2 region.	12 years ago
Serge van Ginderachter	684cfecda9	package and upgrade are not mutually exclusive, but when both were set, upgrade didn't happen	12 years ago
Serge van Ginderachter	d3dee7a8a2	add default=yes in upgrade argument spec	12 years ago
Serge van Ginderachter	4a729ebf3a	apt module: part rewrite of the upgrade logic, consistently checking ... the executable paths, adding 'safe' as an alias to yes, and adding 'full' to allow aptitude full-upgrade as an alternative to apt-get dist-upgrade	12 years ago
Michael DeHaan	3e58768344	Merge pull request #2646 from sevein/git-shallow-clone ... Add support for shallow clones in the git module	12 years ago
Michael DeHaan	34bacc468c	Merge pull request #2627 from jsmartin/riak ... Adds a riak module	12 years ago
Michael DeHaan	b869551a4c	Merge pull request #2628 from victorcoder/devel ... Typo in docs	12 years ago
Jesús García Crespo	62d7e6b006	Add --depth support in the git module	12 years ago
Michael DeHaan	29209c4913	Style fixes so "make pep8" is clean.	12 years ago
Serge van Ginderachter	5c0daf9e0a	When saving to dest, check if we get redirected, and use the new ... location header to set the dest file name if we only provided a target dir. Only save if dest not modified.	12 years ago
Victor Castell	e874bf86c3	Typo in docs	12 years ago
James Martin	f60ec80fca	initial commit.	12 years ago
Victor Castell	c5c942c674	Enable virt module to work with different libvirt connection uris. This allow to work with all libvirt supported VMs.	12 years ago
Gareth Rees	c45b54c1cf	Add separate step update_cache example	12 years ago
milan	735db1775c	allow URL spec for install	12 years ago
lwade	c1d251cbdc	Add availability zone parameter	12 years ago
Bernhard Weitzhofer	770680180b	Use psycopg2's string handling to escape password string ... This allows the password to contain single quotes and should make it safe to use randomly generated passwords (provided passwords can be represented in the connection encoding).	12 years ago
Brian Coca	a0422bd534	Added 'validate' feature to copy and template modules, now you can add a check to force copy to fail if the check fails. ... had to add entry in file for it to accept as a option even though file itself ignores it. Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	12 years ago
Blair Zajac	1aa2f9749e	ec2_vol: do no work if the instance has a volume mounted at the device.	12 years ago
Blair Zajac	96cbd61d5e	ec2_vol: update docs to match default device_name values for Unix/Windows.	12 years ago
Michael DeHaan	b82cda646d	Fixup authorized key doc formatting	12 years ago
Michael DeHaan	110d2b6ec5	Fixup ec2 doc formatting and use complex args format to break up long lines.	12 years ago
Michael DeHaan	aebe1030dc	Add version added info for s3 module.	12 years ago
Michael DeHaan	9ca7d52364	Merge pull request #2554 from magnusart/s3-overwrite-param ... New try: s3 overwrite and checksum support	12 years ago
Michael DeHaan	c624577145	Merge pull request #2550 from joelsemar/devel ... adds private_ip param to ec2 module	12 years ago
Michael DeHaan	ee4e2dfbfc	Fixup module docs.	12 years ago
Michael DeHaan	3694e4ef80	Merge branch 'devel' of git://github.com/gregswift/ansible into devel	12 years ago
Michael DeHaan	3263356bf4	Merge pull request #2446 from b6d/postgresql_db-module-extension ... postgresql_db: add args lc_collate, lc_ctype	12 years ago
Michael DeHaan	0440c48fe0	Merge pull request #2559 from mavimo/feature/documentation-vagrant ... vagrant module documentation	12 years ago
Michael DeHaan	f7a53d24e7	Merge pull request #2558 from jochu/mysql-password ... mysql_db: use --password= instead of -p in dump/import	12 years ago
Michael DeHaan	3f89a3ba1c	Merge pull request #2552 from lwade/ec2docs ... Updated and improved the documentation (examples)	12 years ago
Michael DeHaan	307c9d132c	Merge pull request #2571 from Tinche/service ... Service module changed to terminate early if only enabled specified	12 years ago
Michael DeHaan	75316656de	Merge pull request #2542 from chrishoffman/npm ... Adding npm module	12 years ago
Michael DeHaan	f4eb02ce16	Merge pull request #2537 from j2sol/rax ... Provide functionality to work with Rackspace's public cloud	12 years ago
tin	b528ca7c80	Additional example in service documentation.	12 years ago
tin	7d1ff1bd38	Changed the service module to terminate early if only changing the enabled state. ... Expanded the documentation slightly.	12 years ago
Chris Hoffman	b25d445324	Updating version added, tweaking instantiation	12 years ago
Michael DeHaan	8d99ef7113	Merge pull request #2563 from gw0/fix-lineinfile ... Improved backrefs example in lineinfile.	12 years ago
Michael DeHaan	cbeda6dbfb	Fix typo in message.	12 years ago
gw0 [http://gw.tnode.com/]	acd5426094	Improved backrefs example in lineinfile.	12 years ago
mavimo	a8f966cd06	Moved choises in the right place	12 years ago
mavimo	e102d8807a	moved dependencies in the right place	12 years ago
Jeffrey Chu	50fa0898db	mysql_db: use --password= instead of -p in dump/import	12 years ago
Magnus Andersson	455fd612d3	Added functionality for md5 checksum together with a new overwrite param ... to indicate that remote file should be overwritten if a file with the same filename exists.	12 years ago
lwade	2233a4a6f3	Updated and improved the documentation (examples)	12 years ago
Joel Semar	d9c2dcf7de	adds private_ip param to ec2 module	12 years ago
James Martin	319b69075a	Typo in documentation.	12 years ago
Bernhard Weitzhofer	8456cb8e52	postgresql_user: fix docstrings ... Change documentation of "state" param to refer to user (role) state instead of database state. Change 2 function docstrings to reflect the code	12 years ago
Chris Hoffman	2580adaeaa	Adding npm module	12 years ago
Lorin Hochstein	9289db18b4	upgrade should obey check mode	12 years ago
Lorin Hochstein	614642f8e9	Use aptitude safe-upgrade for apt upgrade=yes ... Use aptitude safe-upgrade instead of apt-get upgrade to implement apt: upgrade=yes. Using aptitude ensures that missing dependencies will also be installed. Fixes #2540	12 years ago
Michael DeHaan	304c447bd2	Merge pull request #2530 from mavimo/patch-1 ... Vagrant module - fixed version_added	12 years ago
Michael DeHaan	a325741ab0	Merge pull request #2531 from Afterburn/devel ... Suppressed output and updated documentation	12 years ago
Michael DeHaan	4b2a26c4c9	Merge pull request #2533 from mavimo/documentation-version_added ... Double quoted version_added in documentation	12 years ago
Michael DeHaan	207439ef6c	Merge pull request #2534 from victorcoder/devel ... Examples must use "name" parameter instead of "guest" for virt module, b...	12 years ago
Jesse Keating	34e585024c	Fix up docs and add ability to insert files ... Files can be inserted during server creation (like a fully formed authorized_keys file). This code allows that to happen. Docs were updated for formatting, location, and to add the new entry for files.	12 years ago
Jesse Keating	9027a9b021	Initial commit of rax library ... This library provides functionality for the Rackspace Public Cloud by way of the official pyrax SDK (https://github.com/rackspace/pyrax). At this time only the cloudservers service is functional. Instances can be created or deleted. Idempotency is provided on matching instances with the same name, flavor, image, and metadata values within a given region. pyrax usage does require a credentials file written out to hold username and API key. See pyrax documentation for details (https://github.com/rackspace/pyrax/blob/master/docs/pyrax_doc.md)	12 years ago
mavimo	00a94024f4	Chnge description as list inside string	12 years ago
Victor Castell	199da48504	Examples must use "name" parameter instead of "guest" for virt module, both works though but code explicitly expects name as the guest VM identifier.	12 years ago
mavimo	cafc12c680	Double quoted version_added in documentation	12 years ago
mujahideen	6d5852529b	Suppressed output and updated documentation	12 years ago
Marco Vito Moscaritolo	2f318b604c	Fixed error in version_added ... SSIA	12 years ago
Michael DeHaan	36bcfb5d49	Merge branch 'lineinfile' of git://github.com/Tinche/ansible into lif	12 years ago
Michael DeHaan	befad8f71f	Merge pull request #2442 from lwade/vol_os_detection ... add better OS detection for BDM	12 years ago
Michael DeHaan	cdf5e006ff	Merge pull request #2508 from tgerla/devel ... Add some examples for local_action and rsync	12 years ago
Alexander Bulimov	0fee59dc86	fixed and extended documentation for lvg module	12 years ago
Brian Coca	5ad3c0603d	now check moded returnes 'changed' instead of failure when there are ... modifications needed. Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	12 years ago
tin	ca581840ef	Added additional lineinfile documentation. ... A little more unit testing.	12 years ago
tin	f9b70822d2	Fixed to the lineinfile module. ... Added the backrefs parameter to the lineinfile module. Added tests for the backrefs functionality of the lineinfile module.	12 years ago
Tim Gerla	0e01085ab6	Add some examples for local_action and rsync	12 years ago
Johan Wirén	550cf2979e	Fixed webdocs rendering error	12 years ago
Greg Swift	34a38a74b1	Extend authorized_keys module for use with alternate AuthorizedKeysFile configurations	12 years ago
Bernhard Weitzhofer	fd6b4c2257	"gem"-module: replace python 2.5 language feature ... replace conditional expression with python 2.4-compatible if/else statements	12 years ago
Michael DeHaan	84b641c96d	Add state to rhn_channel docs	12 years ago
Michael DeHaan	3c5890f42b	Ensure that when transferring a file to a directory the name of the file is the correct basename and not 'source'.	12 years ago
Michael DeHaan	cd0dd2a6ad	Merge pull request #2496 from lorin/mycnf-quotes ... Strip quotes when parsing my.cnf	12 years ago
Michael DeHaan	fee201428f	Fix RHN module YAML docs formatting	12 years ago
Michael DeHaan	861bee3e36	Quoting	12 years ago
Michael DeHaan	518007a1ba	Fix version added attribute, update docs URL	12 years ago
Lorin Hochstein	c9990b801e	Strip quotes when parsing my.cnf ... Remove leading/trailing single or double quotes when parsing the my.cnf file in mysql_user and mysql_db. Do this so that these modules parse the my.cnf file the same way that the mysql client does. From: http://dev.mysql.com/doc/refman/5.0/en/option-files.html You can optionally enclose the value within single quotation marks or double quotation marks, which is useful if the value contains a “#” comment character. Fixes #2405	12 years ago
Bernhard Weitzhofer	b7f3d6ac92	postgresql_db: add args lc_collate, lc_ctype ... Allow the specification of additional locale settings (lc_collate and lc_ctype) when creating a new database (state=present). Fail if the specified database already exists with different locale/encoding settings. (These settings can't be changed for existing databases as far as I know, and failing seems better than suggesting that no change was necessary by returning changed=False)	12 years ago
Michael DeHaan	7f4718bca4	Merge pull request #2490 from szinck/devel ... Added SunOS (Solaris, illumos, etc) service management	12 years ago
Michael DeHaan	4f4ee3693f	Merge pull request #2440 from jochu/service-chkconfig-add ... attempt to add service to chkconfig when suggested	12 years ago
Michael DeHaan	97d2c955a8	Merge pull request #2437 from hspencer77/additional-ec2-instance-attribute-support ... Added additional filter options for instances for EC2 and Eucalyptus	12 years ago
Michael DeHaan	c163f5af9e	Minor consistency tweak, pwd => password	12 years ago
Michael DeHaan	b68f81a727	Merge pull request #2489 from vincentvdk/devel ... rhn_channel module	12 years ago
Shaun Zinck	8a6ef8c69a	service: fix typo 'err' in SunOS service class	12 years ago
Vincent Van der Kussen	81a113ad6b	Removed false info	12 years ago
Vincent Van der Kussen	255f2b868f	Removed info about hard coded user/pwd in the documentation part	12 years ago
Paul Sbarra	b545b4c5fc	service: add systemd template support	12 years ago
Paul Sbarra	4cfda2a965	service: fix systemd compilation error with --check	12 years ago
Vincent Van der Kussen	98406462d1	Made user and password options that can be passed to the module	12 years ago
Shaun Zinck	60bfd38820	Added SunOS (Solaris, illumos, etc) service management using svcadm and svcs commands	12 years ago
Vincent Van der Kussen	38c41b6f9e	renamed module	12 years ago
Vincent Van der Kussen	3a626032ae	added rhn_channel module	12 years ago
Vincent Van der Kussen	1388bb7859	Added module rhn_channel	12 years ago
Jeffrey Chu	18b6091da1	Add quotes around postgresql database name	12 years ago
Dag Wieers	a10d74f703	Improve Linux network facts incl. bridges, ppp, wwan devices ... This patch adds all interfaces (even inactive ones) to setup output.	12 years ago
Piotr Kweclich	2e4c02f93e	disabled appending file with garbage when regexp didn't match.	12 years ago
Michael DeHaan	b70c26dc45	Merge pull request #2466 from sfromm/issue2449 ... Limit scope of arguments to service_control() in service module	12 years ago
Michael DeHaan	5c1b436923	Merge pull request #2451 from lwade/pythoninterpreter ... Changed python interpreter to be consistent in these modules as compared...	12 years ago
Michael DeHaan	cef817c3b4	Merge pull request #2458 from CodeBlock/devel ... Fix broken virtualenv link in pip documentation.	12 years ago
Stephen Fromm	b694b9a66e	Fixes for get_remote_head in git module ... See issue #2471 This fixes get_remote_head() to be smarter about how to check remote head. It checks if it is a remote branch or tag and then checks for the remote object id associated with it. If it is sha1, get_remote_head() returns it as-is since there doesn't appear to be a way to check a remote repository for a specific object/sha1. is_remote_tag() is added to help out the new functionalit in get_remote_head(). In main(), if check_mode is true and version is a sha1, the module now checks to see if the object is present.	12 years ago
Stephen Fromm	5194a71a70	Limit scope of arguments to service_control() in service module ... This fixes handling of arguments (module argument) in service_control(). It is now locally scoped such that modifications to it, in the case of a systemd host, do not later impact subsequent calls to service_control(). See issue #2449. Without patch: ansible-service[6177]: Command /usr/bin/systemctl stop cups cups , daemonize True With patch: ansible-service[6475]: Command /usr/bin/systemctl start cups , daemonize True I also updated the comments to reflect the case where systemd is really being called.	12 years ago
Ricky Elrod	9af40aa99a	Fix broken virtualenv link in pip documentation.	12 years ago
lwade	9dda148679	Changed python interpreter to be consistent in these modules as compared to all others.	12 years ago
lwade	a8de66facc	adding windows-specific ebs recommendation	12 years ago
lwade	e2805e5a06	add better OS detection for BDM	12 years ago
Jeffrey Chu	f1829a0f86	attempt to add service to chkconfig when suggested	12 years ago
Jeffrey Chu	efc98a09fe	fail when service cannot be found by chkconfig	12 years ago
Harold Spencer Jr	7ab876f19f	Added additional filter options for instances for EC2 and Eucalyptus	12 years ago
Michael DeHaan	9bd586acdb	Fix bzr module documentation, name is the primary attribute.	12 years ago
Michael DeHaan	1a5ac9d149	Name should be the primary attribute for the 'parent' in the bzr module.	12 years ago
Michael DeHaan	61c1616fe5	Fix version_added attribute on the bzr module	12 years ago
Michael DeHaan	ce39c18b14	Fixup template documentation so webdocs can generate.	12 years ago
Michael DeHaan	79c22f4f03	Merge pull request #2370 from andreparames/bzr-module ... New Bazaar module	12 years ago
Michael DeHaan	13c44ace95	Merge pull request #2421 from robparrott/ec2-idempotency ... Make ec2 module idempotent with Amazon EC2 via client-token attribute.	12 years ago
Michael DeHaan	600b0bc5f1	Merge pull request #2357 from abulimov/lvg-module ... lvg module for managing LVM volume groups	12 years ago
Michael DeHaan	d7a2ac2c57	Merge pull request #2401 from sfromm/git-check-mode ... Add check mode to git module	12 years ago
Michael DeHaan	6b566cfc1e	Merge pull request #2404 from lorin/mysql-mycnf-user ... .my.cnf: default to login when no user specified	12 years ago
Michael DeHaan	79efc04bdf	Merge pull request #2406 from lorin/mysql-socket-doc ... Document mysql_(user,db) login_unix_socket option	12 years ago
Michael DeHaan	ff4f9f217b	Merge pull request #2407 from jcftang/setup-osx-facts ... Added osrelease and osversion as well as changed the way sysctl is calle...	12 years ago
Michael DeHaan	917c11ebd7	Merge pull request #2355 from jcftang/macports ... Teach the macports module to activate/deactivate packages	12 years ago
Michael DeHaan	4ee08aafa3	Merge pull request #2356 from abulimov/lvol-patch ... lvol patch for Debian Squeeze	12 years ago
Michael DeHaan	11d3bd4025	Merge pull request #2375 from sergevanginderachter/user-non-unique ... Add nonunique option to user module, translating to the -o/--non-unique ...	12 years ago
Michael DeHaan	61e2ed8402	Merge pull request #2387 from bcoca/template_overrides_note ... added docs about in template overrides	12 years ago
Michael DeHaan	d4f7b45395	Merge pull request #2418 from davehughes/pip-fix-run-directory ... pip module - run from the system's temp directory to avoid permissions problem	12 years ago
Michael DeHaan	4dcddcbbec	Merge pull request #2427 from andrew-d/andrew-add-homebrew ... Add Homebrew module	12 years ago
Michael DeHaan	7be78d503c	Merge pull request #2430 from b6d/nagios-module-icingacfg ... nagios module: add common locactions of icinga.cfg	12 years ago
Michael DeHaan	3ee53a2760	Merge pull request #2429 from b6d/nagios-module-fix ... "nagios" module: fix NameError/'host' not defined	12 years ago
Michael DeHaan	138bfece39	Merge pull request #2424 from lwade/simples3 ... Basic groundwork for s3 module.	12 years ago
Michael DeHaan	565db8cd40	Merge pull request #2420 from robparrott/vagrant ... added vagrant module with cleanup	12 years ago
Bernhard Weitzhofer	2e60692082	nagios module: add common locactions of icinga.cfg ... Icinga should be compatible to Nagios (in our case the nagios module works well with our Icinga installation)	12 years ago
Bernhard Weitzhofer	aa7ea10826	"nagios" module: fix NameError/'host' not defined ... Add missing 'host' variable, which is read a few lines later on in some cases.	12 years ago
Andrew Dunham	b4347b08a2	Add Homebrew module	12 years ago
lwade	1748bc2a5b	Basic groundwork for s3 module.	12 years ago
Andrew Dunham	e63d008ae8	Fix --include-dependencies parameter on RubyGems >= 2.0.0	12 years ago
Rob Parrott	096d4dece4	modified ec2 module to use EC2 idempotency via client-token attribute.	12 years ago
Rob Parrott	416f25eaff	added vagrant module	12 years ago
Michael DeHaan	94eefac456	Merge pull request #2391 from bcoca/apt_lock_exception ... now catches lock exceptions from apt and returns friendly message	12 years ago
David Hughes	dd79d66dba	Run pip command from the system's temp directory	12 years ago
Jimmy Tang	935514cde8	Added osrelease and osversion as well as changed the way sysctl is called on OSX	12 years ago
Lorin Hochstein	1de91d2181	Document mysql_(user,db) login_unix_socket option ... mysql_user and mysql_db both take a login_unix_socket option. This patch adds docs that describe how to use it.	12 years ago
Lorin Hochstein	6fd5770dfd	.my.cnf: default to login when no user specified ... When using a .my.cnf file, when there is no user variable defined, default to the login user. This change has the mysql_user module behavior match the behavior of the mysql command-line client. Also adds an example .my.cnf to the docs.	12 years ago
Stephen Fromm	73772a41e6	Add check mode to git module ... Related to issue #2114. This hooks in check_mode to git module. This will exit with changed=True at the following places: * If the repo has not been cloned * If the destination has local modifications, this will exit with changed=True. This is because reset() will exit anyways if there are local mods and force is False. * If the remote HEAD commit id is not the same as that of the local HEAD. This is determined by get_remote_head() that runs 'git ls-remote' to determine remote HEAD. Lastly, if this is run with check_mode enabled, this will exit with changed=False before fetch() is invoked so that no local mods are made.	12 years ago
Serge van Ginderachter	cb2b7a4e17	rename user option nonunique tot non_unique	12 years ago
Serge van Ginderachter	f980ec37bb	Add nonunique option to user module, translating to the -o/--non-unique option to useradd and usermod.	12 years ago
Michael DeHaan	fc8d9377d5	Merge pull request #2396 from johanwiren/obsd_facts ... Added OpenBSD facts	12 years ago
Michael DeHaan	e3e649a963	Merge pull request #2393 from davehughes/pip-expand-virtualenv-path ... pip module - expand user home directory variables in virtualenv parameter	12 years ago
Johan Wirén	61256a7e83	Added OpenBSD facts	12 years ago
Daniel Hokka Zakrisson	fc227fbd37	Restore force in copy since arguments are no longer clobbered ... Fixes #2388.	12 years ago
Alexander Bulimov	902d6347c7	now using 'type=' for module parameters, replaced lambda with list comprehensions, simplyfied extend/reduce part of module, renamed dev parameter to pvs	12 years ago
Jimmy Tang	32bf6050c7	Teach the macports module to activate/deactivate packages ... Deactivating a package from macports does not remove the files, it just unstages it from the runtime environment. Activating a package re-enables it.	12 years ago
David Hughes	08100bd798	Expand any user home variable in pip module's virtualenv parameter	12 years ago
Michael DeHaan	b87e7c0f19	Let the pip module return output.	12 years ago
Brian Coca	4f9c61d673	now actually import exception to be usable	12 years ago
Brian Coca	4a2276bb4b	now catches lock exceptoins on apt and returns friendly message instead of ... traceback Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	12 years ago
Brian Coca	3313667dcf	added docs about in template overrides ... Signed-off-by: Brian Coca <bcoca@tablethotels.com>	12 years ago
Michael DeHaan	f46721add1	Temporarily disable force logic on copy module	12 years ago
Michael DeHaan	e307658350	Merge pull request #2376 from peterjanes/devel ... Use login_host for import and dump operations	12 years ago
Patrik Lundin	88a840e52f	Dont exit in FreeBSD/NetBSD subclass in check mode ... * As the FIXMEs note: only exit if enable state is going to change. * This is already handled in service_enable_rcconf() being called by both subclasses.	12 years ago
Peter Janes	f6f7d3559d	Use login_host for import and dump operations	12 years ago
Dag Wieers	50b7964f8e	Fix the documentation booleans so they use "yes" and "no" ... Both modules seboolean and zfs have not been adapted since they defer from the default (either by having a 'null' or special state, or prefering "on"/"off" for state indication.	12 years ago
Alexander Bulimov	c8c0fe945b	various fixes in lvg module, added ability to reduce and extend VG, added Physical Extent parameter, added explicit creation of physical volumes	12 years ago
André Paramés	264d83c0a3	Added Bazaar module, based on the Git module	12 years ago
Alexander Bulimov	259d994253	lvg module for managing LVM volume groups	12 years ago
Alexander Bulimov	a3b4488028	lvol patch for Debian Squeeze	12 years ago
Michael DeHaan	bdb231213d	Add type casting to user/group modules, remove executable bit from other modules	12 years ago
Michael DeHaan	5c7aa08ed5	Merge pull request #2316 from dominis/devel ... Citrix NetScaler module	12 years ago
Michael DeHaan	8c212ac9b6	Merge pull request #2272 from skvidal/nagios_cmd ... add (un)silence_nagios and command actions to the nagios module	12 years ago
Michael DeHaan	3d8bb6c2e0	Merge branch 'alpine' of git://github.com/fabaff/ansible into devel ... Conflicts: library/setup	12 years ago
Michael DeHaan	ba51fc12f9	Updated copy documentation.	12 years ago
Patrick Pelletier	c7c7a63ee5	Add support to directly set content in copy module	12 years ago
Michael DeHaan	4da04b2176	Merge pull request #2294 from mmoya/bug-fixes ... file module should check invalid arguments (fixes #2135)	12 years ago
Michael DeHaan	2d575ddd09	Update fetch documentation	12 years ago
Michael DeHaan	c3e625e6f0	Make URI module default to 30 seconds.	12 years ago
Michael DeHaan	b2c8ed9cc2	Merge pull request #2279 from dorfsmay/fetch-fail_on_missing ... Added a fail_on_missing option to fetch.	12 years ago
Michael DeHaan	fd038d373a	Merge pull request #2273 from dorfsmay/pullreq-use_proxy ... Added a use_proxy option to get_url.	12 years ago
Michael DeHaan	bb696e88b4	Merge pull request #2286 from gavares/url_timeout ... Add socket timeout to uri module.	12 years ago
Michael DeHaan	c7d780a09a	Merge pull request #2337 from dparalen/wait_fix ... EC2 Wait fix	12 years ago
Michael DeHaan	033c7d9df2	Merge pull request #2274 from jcftang/setup-osx-facts ... Start of more OSX facts for setup	12 years ago
Michael DeHaan	80cd277d97	Merge pull request #2334 from pieska/upstream ... allow use of backrefs in lineinfile	12 years ago
Michael DeHaan	9069ad1f42	Merge pull request #2283 from eest/openbsd_pkg ... Add openbsd_pkg: package management for OpenBSD.	12 years ago
milan	6259091449	fixed case and punctuation	12 years ago
milan	9932c9ff11	fix documentation	12 years ago
milan	d32d899161	waiting enhancements	12 years ago
milan	78d1e2483a	avoid the instance start--state-fetch race	12 years ago
Nikolay Panov	03c0b8dcb2	Fixed 'service'. Now it respect 'enabled=no' as well.	12 years ago
Andreas Piesk	84ee05a3c0	allow use of backrefs in lineinfile	12 years ago
Fabian Affolter	a5e4947d6f	Support for detecting Alpine Linux	12 years ago
Michael DeHaan	9763ae8e21	Merge pull request #2319 from sfromm/svn-check ... Update subversion module to work better with check mode	12 years ago
Michael DeHaan	bd600c1cbc	Merge pull request #2323 from laixer/devel ... Respect gem_source option if specified	12 years ago
Michael DeHaan	9980cfcc60	Merge pull request #2318 from sfromm/issue2317 ... Consider service stopped if rc is 1	12 years ago
Vadim Berezniker	b9a3cc551e	Respect gem_source option if specified	12 years ago
Jim Kleckner	92844d3dcd	Minor spelling fixes	12 years ago
Stephen Fromm	bd64641400	Update subversion module to work better with check mode ... Adds needs_update() method which will inspect the checkout for the current revision and then the HEAD. If the local check out is behind HEAD, this will report changed=True and supply the revision numbers.	12 years ago
Stephen Fromm	6e35392f92	Consider service stopped if rc is 1 ... Per LSB spec, consider service stopped if rc from 'service status' is 1. Added comment with url to LSB spec reference.	12 years ago
Nandor Sivok	74ced2d80c	netscaler module initial commit	12 years ago
Daniel Hokka Zakrisson	3d49f74df6	Make apt upgrade=dist work and make its argument handling more idiomatic ... Fixes #2287.	12 years ago
asad-at-srt	e581bbcafc	Update mysql_db ... The target parameter is not required, the DOCUMENTATION section was in error.	12 years ago
Daniel Hokka Zakrisson	a225058457	Merge pull request #2298 from junegunn/get_url-force ... get_url: should always download the file when force is set	12 years ago
Seth Vidal	2f2a02cb49	add docs to mount module using LABEL and UUID	12 years ago
Johan Wirén	e53826b088	Corrected formatting in docs for the gem-module	12 years ago
Junegunn Choi	7f556d8939	should always download when force is set	12 years ago
Maykel Moya	ee7f8d018e	file module should check invalid arguments (fixes #2135)	12 years ago
Grant Gavares	cd51c7f234	Add socket timeout to uri module. ... The uri module can be configured to abort after a specified timeout if it cannot connect to the configured uri. This prevents a uri action from hanging indefinitely when the remote endpoint cannot be reached because it is unavailable, there is a firewall in place etc. The default behavior is left unchanged: timeout=None This change also introduces a new type for module_parameters: int Code was added to perform conversion from string -> int type in module_common.py. The new type was required in order to play nice with httplib2 which refuses to accept (and convert) anything other than a numeric type for the timeout value.	12 years ago
Patrik Lundin	f485eb28f5	Teach setup about OpenBSD package manager. ... * We cannot depend on the path because FreeBSD for example uses the same path.	12 years ago
Patrik Lundin	eb6398f168	Add openbsd_pkg: package management for OpenBSD. ... * Code influenced by the service module but without classes. * Thanks to @dhozac for input and review. * Thanks to @johanwiren for getting me to push this out the door.	12 years ago
Yves Dorfsman	c9a201eb43	fixed typos	12 years ago
Yves Dorfsman	377351f6fd	Clarified that proxy can be changed via an variable.	12 years ago
Yves Dorfsman	e45a0fd61d	Added a fail_on_missing option to fetch.	12 years ago
Daniel Hokka Zakrisson	622b8dfe32	Merge pull request #2271 from MWGriffin/patch-1 ... Update get_url	12 years ago
Daniel Hokka Zakrisson	8f917a5a9f	slurp: import base64 as module_common no longer does	12 years ago
Jimmy Tang	7653c4ac6c	Start of more OSX facts for setup ... Added a Darwin family, commit acc1c004 had added some network facts but weren't being shown as the Darwin family wasn't in use. This commit reveals these facts. A Darwin(Hardware) class has also been created ready to be populated with hardware facts.	12 years ago
Yves Dorfsman	3270a0adcd	Added a use_proxy option to get_url.	12 years ago
Michael Griffin	5bfd648dc8	Update get_url ... Small syntactic correction: Removed trailing double-quote from example.	12 years ago
Seth Vidal	677dcc56ae	add (un)silence_nagios and command actions to the nagios module ... also fix a typo with the check_mode check	12 years ago
Michael DeHaan	6ecdef6b88	Type checking on library/apt means the upgrade parameter is now properly True/False	12 years ago
Michael DeHaan	4132f8953e	Fixup the rabbitmq YAML documentation so we can generate docs for it.	12 years ago
Michael DeHaan	129e0b8baf	Log tracebacks to syslog when using fireball mode.	12 years ago
Michael DeHaan	f9824838c3	Merge pull request #2251 from chrishoffman/rabbitmq ... Rabbitmq parameters module	12 years ago
Michael DeHaan	6ebf16bf33	Some very minor stylistic tweaks to the gem module.	12 years ago
Michael DeHaan	64c1cc3efd	Merge branch 'gem' of git://github.com/johanwiren/ansible into devel	12 years ago
Michael DeHaan	66a596dd5d	fix MySQL user doc formatting issue	12 years ago
Michael DeHaan	ff58623f8b	Fix apt module documentation formatting.	12 years ago
Michael DeHaan	d04c4ef0c7	Merge pull request #2249 from jcftang/devel ... Use opkg module as basis for macports module	12 years ago
Michael DeHaan	2994ec022d	Merge pull request #2242 from jmandel/devel ... Allow relative creates/removes path with `chdir`	12 years ago
Michael DeHaan	7749b34546	Merge branch 'new_branch_for_apt_squashed' of git://github.com/RaymiiOrg/ansible-1 into devel ... Conflicts: library/apt	12 years ago
Michael DeHaan	26826c3bde	Merge pull request #2235 from marktheunissen/mysql-idempotent-explanation ... Add mysql user documentation about idempotent playbooks	12 years ago
Michael DeHaan	38ab9b50c7	Merge branch 'setup_network2' of git://github.com/nigelm/ansible into devel	12 years ago
Michael DeHaan	8099e4ac26	Merge pull request #2240 from dorfsmay/pullreq-fetch-doc ... Doc that fetch returns ok when src not present.	12 years ago
Michael DeHaan	22d20b4994	Merge pull request #2244 from fdavis/virt_doc_fix ... virt module doc fix	12 years ago
Michael DeHaan	273005a380	Merge pull request #2226 from skinp/openwrt_support ... Adding support for OpenWrt	12 years ago
Michael DeHaan	d9d5970858	Merge pull request #2222 from sfromm/issue2114 ... Update various modules for check_mode	12 years ago
Jimmy Tang	f32f3fc7e2	Use opkg module as basis for macports module ... This module is pretty simplistic, it is derived from the opkg module.	12 years ago
Chris Hoffman	79fb0aad28	Adding RabbitMQ module to handle parameters	12 years ago
Johan Wirén	6e44c72761	Removed urlparsing of gemsource. Not needed	12 years ago
Jan-Piet Mens	00bd581945	Add ISO8601 date/time format to setup ... Zulu time and one with microseconds, useful for timestamping Add TZ	12 years ago
fdavis	427b49c12c	virt module doc fix	12 years ago
Johan Wirén	637210be1f	Added gem module	12 years ago
Chris Hoffman	b1478fdab7	Updating docs	12 years ago
Josh Mandel	7c772c6af5	Add remote user_id to ansible facts	12 years ago
Josh Mandel	6250b64ef9	Use relative creates/removes path with chdir	12 years ago
Michael DeHaan	b5ad1ce768	In django module if no virtualenv is specified, don't choke	12 years ago
Michael DeHaan	1e5d5fc263	Be consistent about underscore usage.	12 years ago
Ton Kersten	7b51f67128	Squashed commit of the following: ... commit 076501459322cf6c14de742e504339d80ffdeed5 Author: Ton Kersten <tonk@tonkersten.com> Date: Thu Feb 28 21:32:57 2013 +0100 Added date and time facts to setup	12 years ago
Yves Dorfsman	7cedb7d432	Doc that fetch returns ok when src not present.	12 years ago
Mark Theunissen	34bed2fa2e	Fix bug from copy-paste	12 years ago
Remy van Elst	f094d65fdd	apt update	12 years ago
Remy van Elst	5289fa72b6	apt upgrade support	12 years ago
Mark Theunissen	45949c7643	Add mysql user documentation	12 years ago
Ton Kersten	05c70ca712	Squashed commit of the following: ... commit e057ea671395ec8847f920a63cf9524f5c8fde5f Author: Ton Kersten <tonk@tonkersten.com> Date: Thu Feb 28 13:02:25 2013 +0100 Fixed the service command not working On Ubuntu 1[02].04 the service name was not recognized because there is a SysV style init script, but not an upstart config file. Example: The `ntp` client. Also removed extra spaces at the end of the lines, while at it.	12 years ago
Nigel Metheringham	e2643cb55f	Broke BSD ifconfig parser into chunks for subclassing ... This allows minor changes to be handled by adding a new parse line function to the subclass	12 years ago
Nigel Metheringham	acc1c004d4	Restructured inheritance of BSD network classes ... Now all BSD network classes directly inherit from Network as well as from the generic BSD network class. This removes the need for itersubclasses().	12 years ago
Patrick Pelletier	2778ee0eb5	Adding support for OpenWrt	12 years ago
Stephen Fromm	8f0d8a8546	Update various modules for check_mode ... This updates the following modules to support check_mode: * apt_key * apt_repository * easy_install * pip - will always report changed due to the way it handles state * seboolean * selinux * slurp - since nothing changes, it just adds that it supports check_mode * subversion - reports changed when checking out new repo and when updating. * supervisorctl * svr4pkg See issue #2114.	12 years ago
Daniel Hokka Zakrisson	1fe744d2af	Fix apt module's boolean check to expect converted value ... Fixes #2218.	12 years ago
Michael DeHaan	0342b054fd	Merge pull request #2215 from tastychutney/devel ... Updated virtualenv note	12 years ago
Scott Anderson	dc476a12a6	Updated virtualenv note	12 years ago
Michael DeHaan	0fc317de08	Merge pull request #2212 from jhoekx/lvol-module ... Add lvol module to manage logical volumes.	12 years ago
Daniel Hokka Zakrisson	e33e84d24e	Merge pull request #2213 from huberteff/devel ... Work around hanging module. Thanks to Daniel Hozac for the tip.	12 years ago
Hubert Feyrer	acf8ee9d61	Work around hanging module. Thanks to Daniel Hozac for the tip.	12 years ago
Jeroen Hoekx	01a9d79e11	Add lvol module to manage logical volumes.	12 years ago
Michael DeHaan	b1a4fab7e1	Merge pull request #2208 from tastychutney/devel ... Better documentation, removed runfcgi, added createcachetable	12 years ago
Scott Anderson	36eeb7562a	Better documentation, removed runfcgi, added createcachetable, merge with Michael's changes	12 years ago
Michael DeHaan	7dbfad8225	baby-JSON not supported, let selinux module warn using regular JSON	12 years ago
Michael DeHaan	d251e68ac5	Resolve merge	12 years ago
Michael DeHaan	1366c663eb	Merge branch 'copy-diff-take2' of git://github.com/stoned/ansible into better_diff ... Conflicts: library/file	12 years ago
Michael DeHaan	9e2cb42b4f	Add some aliases for django manage, mainly around underscores, and use the newer (easier) way to do module docs. Also ... add list of avail commands to docs.	12 years ago
Scott Anderson	06890085d2	Django manage.py administration module	12 years ago
Michael DeHaan	7090ad3aac	Merge pull request #2195 from tbielawa/NOOP ... First try and making the nagios module NOOPpable	12 years ago
Michael DeHaan	c485cb3700	Remove some tab/space issues in previous commits.	12 years ago
Michael DeHaan	6a487409db	Merge branch 'postgresql-check-mode' of git://github.com/cocoy/ansible into devel	12 years ago
Michael DeHaan	0e1ba5e676	Prevent SVN checkouts from failing due self signed certs.	12 years ago
Michael DeHaan	9f083bfca3	Merge pull request #2207 from marktheunissen/mysql-pass-and-password ... Adding back support for pass=	12 years ago
Mark Theunissen	234d31bf72	Adding back support for pass=	12 years ago
Daniel Hokka Zakrisson	93f02d614b	Merge pull request #2187 from dhozac/argument-type-check ... Add type checking for module arguments, converting as much as possible	12 years ago
Tim Bielawa	b0bd0a0f4a	Making the nagios module NOOPpable	12 years ago
Stoned Elipot	10e9f1fc1e	Implement --diff for the copy module.	12 years ago
Seth Vidal	f02ea15f0c	command: make sure that all _handle_aliases() calls returns {} ... module_common: also work if there are no aliases (shell, command, etc) modules	12 years ago
Seth Vidal	b54887b03c	make sure ec2_secret_key is set to no_log=True	12 years ago
Michael DeHaan	3c40ce5700	Better detection of whether a service is managed by systemd or not.	12 years ago
Michael DeHaan	596c98320a	Service module now knows a little more about systemd. This module is ... really due for some refactoring, but telling how a service is managed is a little fuzzy anyway. on a systemd system typoing the service will now give you a rather systemd specific error which is somewhat suboptimal.	12 years ago
Michael DeHaan	4be3b06842	Run chkconfig enable/disable only when needed. TODO, apply same logic to update-rc.d/systemd	12 years ago
Rodney Quillo	3bf088c084	Fix tabs/spaces.	12 years ago
Michael DeHaan	0380ba7177	If running is given as the state value instead of 'started', still return the correct end state.	12 years ago
Michael DeHaan	624a952c5c	The service module made some assumptions about how a service should be managed based on what was installed on the system in terms of service ... management tools, which meant upstart services on CentOS6 were not startable. This tweak allows things like vmware-tools to be controlled via the service module. More testing on other distributions (particularly with systemd) is presumably needed.	12 years ago
Daniel Hokka Zakrisson	578ec127fb	Remove choices=BOOLEANS as it is no longer needed	12 years ago
Michael DeHaan	582f088e7e	Fix module docs formatting	12 years ago
Michael DeHaan	c86b34dae1	Lots of docsite additions for new features + cleanup lineinfile YAML docs	12 years ago
Daniel Hokka Zakrisson	df798d0688	Use argument type checking to convert to boolean	12 years ago
Michael DeHaan	b75b9681a8	more places to use yaml.safe_load	12 years ago
Michael DeHaan	69a199727c	Merge pull request #2180 from jsmartin/cloudformation ... CloudFormation support.	12 years ago
Michael DeHaan	878eb5a9b1	Merge pull request #2185 from lwade/devel ... Issue #2158 - add VPC subnet ID support	12 years ago
Michael DeHaan	ac41a9d1f0	Merge pull request #2175 from tyll/devel ... mysql_db/user: Use password for my.cnf	12 years ago
Michael DeHaan	8b3ebf0d10	mark when various new flags were added to the pip & easy_install modules	12 years ago
Michael DeHaan	9b32ab7ec2	Merge pull request #2150 from jhoekx/venv-command ... Venv command	12 years ago
lwade	0486c7d51a	missed a spot.	12 years ago
lwade	30ac2edc33	Adding VPC subnet ID support	12 years ago
Michael DeHaan	b739a5860a	Merge branch 'lineinfile_improvements' of git://github.com/leucos/ansible into devel ... Conflicts: library/lineinfile	12 years ago
Michael DeHaan	e1f1722e9e	Docs tweak to setup module.	12 years ago
Michael DeHaan	275bd1f400	Merge branch 'setup_filter_argument' of git://github.com/leucos/ansible into devel	12 years ago
Michael DeHaan	9cea292665	Clean up OS family code	12 years ago
Ton Kersten	cf23d64a88	Conflicts: ... library/setup	12 years ago
Ton Kersten	4d67608a10	Squashed commit of the following: ... commit 1c9b2a6035913969b515862e37e7e1aca24529e0 Author: Ton Kersten <tonk@master.tonkersten.com> Date: Tue Feb 19 15:54:36 2013 +0100 Added osfamily fact	12 years ago
Michael DeHaan	7b2c8b302f	Merge pull request #2146 from dagwieers/thirsty-force ... Add force= and make thirsty= an alias for backward compatibility	12 years ago
Michael DeHaan	467556708a	Merge pull request #2145 from leucos/sysctl_no_file_check ... Better sysctl module file check	12 years ago
Daniel Hokka Zakrisson	274f15b52c	Fix version_added for insertbefore in lineinfile	12 years ago
Michael DeHaan	333b6bbaac	Show how to use the more simplified way of including EXAMPLES in docs. We should update ... all module docs to do this.	12 years ago
Michael DeHaan	5a1aef5372	Merge branch 'local-chroot-support-v2' of git://github.com/mmoya/ansible into testing	12 years ago
James Martin	fa63a9b5f4	CloudFormation support.	12 years ago
Michel Blanc	92c679142f	Optimizes using fnmatch only if needed ... Skips fnmatch'ing if there is only a '*' in filter.	12 years ago
Michel Blanc	633fdede38	Fixes duplicate code ... Fixed duplicate call for file attributes checking	12 years ago
Johan Wirén	ee517ea53c	Added support for --check in zfs module	12 years ago
Till Maas	cc8fbe34f2	mysql_user: handle unnecessary GRANT revocation	12 years ago
Till Maas	813d2335ad	mysql_db/user: Use password for my.cnf ... According to the MySQL docs[0] the password should be stored after 'password=' instead of 'pass='. [0] http://dev.mysql.com/doc/refman/5.1/en/password-security-user.html	12 years ago
Michel Blanc	008dc4831e	Improves lineinfile and adds file attr option ... Added path expanding for dest in lineinfile Added common file arguments to lineinfile so the module gets owner, group, mode and SE options. Decorated existing example to demonstate usage of file options and added a couple more examples Message is not set accordingly when file attributes were changed 'absent' handling code now handles the case where the file doesn't exists (was issuing a Traceback before) File attribute handling code has been added to the 'absent' handling function too. File attributes handling has been grouped in 'def check_file' since it's required in both places. 'absent' mode now returns a message like it's counterpart 'present', telling if file attributes were altered and if lines have matched.	12 years ago
Daniel Hokka Zakrisson	c364e4c77b	cron: Work even without initial crontab ... Fixes #2165.	12 years ago
Michel Blanc	7c270078f4	Moved key filtering ... Key filtering moved before returning results	12 years ago
Maykel Moya	5e68143c46	Check presence of files under /proc before opening them	12 years ago
Maykel Moya	8b27085c34	Prevent traceback when /etc/mtab is not available ... * get_file_contents returns None when file is not available. When /etc/mtab is pointing to /proc/mounts and /proc is not mounted, mtab.split will traceback.	12 years ago
Michel Blanc	627577ecc9	Fixes unused var and avoid reassigning keys ... Changed code so key doesn't get reassigned in loop Made use of filtr variable	12 years ago
Michel Blanc	139e06d9af	Added more examples for the filter option in setup ... Added examples covering all available globs Added a use case of filtering only facts returned by facter	12 years ago
Michel Blanc	5f4a24557b	Adds example for filter option in setup module ... Added an example on how to filter keys returned by the module.	12 years ago
Michel Blanc	75b687247a	Adds filter option to setup module ... Adds facts filtering using fnmatch, via the 'filter' option. Usage: ansible -m setup -a 'filter=ansible_*_mb'	12 years ago
Michael DeHaan	a875b63703	Merge pull request #2152 from dagwieers/pause-doc ... pause: Fix small documentation glitch	12 years ago
Dag Wieers	486889bbbd	Add force= and make thirsty= an alias for backward compatibility	12 years ago
Dag Wieers	577f491368	pause: Fix small documentation glitch	12 years ago
Rodney Quillo	621eb5eccc	Add postgresql_db and postgresql_use checkmode.	12 years ago
Michael DeHaan	7a7d02073a	Merge pull request #2119 from jpmens/uri_json ... uri: load JSON for content-type: application/json	12 years ago
Jeroen Hoekx	9f65233e96	Easy_install and pip module support a virtualenv_command parameter. ... This allows flexible selection of the Python version to use while creating the virtualenv.	12 years ago
Jan-Piet Mens	b448cc8eff	uri: load JSON for content-type: application/json ... document check prefix of content-type and merge dicts amend doc load JSON into 'json' subkey	12 years ago
Jeroen Hoekx	01e66c6687	Add virtualenv_site_packages param to easy_install	12 years ago
Michael DeHaan	7834d021b9	Merge pull request #2138 from bcoca/2137_fix_setup_bsdjails ... fixes freebsd setup issues with jails	12 years ago
Michael DeHaan	ae599d8a61	Merge pull request #2115 from kavink/devel ... teach apt module to support --check mode	12 years ago
Michel Blanc	e0496634c5	Removes useless empty string write ... It s not necessary to write an empty string for the file to be created.	12 years ago
Michel Blanc	6f9d28c8b1	Changed when new sysctl file is created ... When destination sysctl file is missing, it is created. But, for idempotency purposes, the creation process now takes place just before it is used, in the main code path so an empty file is not left over if the code module.fail_jsons before the file is really used.	12 years ago
Michel Blanc	0eaa936ba0	Removes exception is sysctl file is missing ... When syscl file was missing, sysctl module was complaining about it and bailing out. This behaviour prevents usage of /etc/sysctl.d directory, present in some distributions. This patch accepts a missing sysctl.conf file so sysctl.d directory can be used. However, it will bail out if the destination directory doesn't exist.	12 years ago
lwade	107733b174	Add support for security group id parameter, remove default for group name (since AWS already sets a default). ISSUE #2029	12 years ago
Brian Coca	aa713d72ef	fixes freebsd setup issues with jails ... Signed-off-by: Brian Coca <bcoca@tablethotels.com>	12 years ago
Kavin Kankeshwar	0f166d870a	teach lineinfile module to support --check mode	12 years ago
Kavin Kankeshwar	53924b4599	teach apt module to support --check mode	12 years ago
Daniel Hokka Zakrisson	3f2fd22ed4	Don't consider packages missing from the cache an error on remove ... Fixes #2017.	12 years ago
Daniel Hokka Zakrisson	d2bf205a5d	Fix #2125 and clean up a few things along the way	12 years ago