Commit Graph

24337 Commits (e7286ed43c1307f30f4bd643dc4ded5a3a74558e)
 

Author SHA1 Message Date
Gabriele e7286ed43c Fixing nxos_vtp_domain (#5036) 8 years ago
Gabriele c19e3b5924 Fixing nxos_vrrp (#5035) 8 years ago
Gabriele f89cb1717c Fixing nxos_vtp_password (#5037) 8 years ago
Gabriele b897b497c1 Fixing nxos_vtp_version (#5038) 8 years ago
Matt Davis 66a1b15f89 remove broken ansible_user_uid fact from Windows setup 8 years ago
Ryan Brown 135b92bf4e Check status of finished spot instance requests (#4990)
Per #3877, the code to wait for spot instance requests to finish would
hang for the full wait time if any spot request failed for any reason.
This commit introduces status checks for spot requests, so if the
request fails, finishes, or is cancelled the task will fail/succeed
accordingly.

One edge case introduced here is tha if a user terminates the instance
associated with the request manually it won't fail the play, under the
presumption that the user *wants* the instance terminated.
8 years ago
Brian Coca 22d29be478 1st draft of include docs 8 years ago
Toshio Kuratomi 132fcc434b Set some hosts privileged so they can perform mount tests (#5087) 8 years ago
Jiri Tyr 2b145a0052 Fixing bind mount pattern in the mount module (#5084) 8 years ago
Peter Sprygada 58a5ec6c51 fixes junos_command module paring of wait_for strings (#5083)
The junos_command module wasn't properly parsing strings to apply
conditionals due to the return value not being converted to json
before the results where handed to the runner.
8 years ago
Peter Sprygada 9ed01d0cfd fixes junos_template ignoring the action directive (#5080)
This updates the junos_template to properly process the action
directive when loading the configuration.
8 years ago
Toshio Kuratomi 9436d013d4 Fix mount default options -- should be defaults, not default 8 years ago
John R Barker 177dcadbc0 deprecated _template network modules: Rename in modules-core (#5072) 8 years ago
Jiri Tyr be1036f461 Ultimate fix of the mount module for Linux (#5055) 8 years ago
John R Barker f7b10720ac typo in module name (#5062) 8 years ago
Kevin Carter e2e7f20e34 apt: fix cache time handling (#1517)
This change is in response to issue #1497 where the apt module would not properly updating the apt cache in some situations and never returned a state change on cache update when the module was used without or without an item to be installed or upgraded.

The change simply allows the apt module to update the cache when update_cache option is used without or without a set cache_valid_time.
If cache_valid_time is set and the on disk mtime for apt cache is ">" the provided amount of seconds, which now has a default of 0, the apt cache will be updated. Additionally if no upgrade, package, or deb is installed or changed but the apt cache is updated the module will return a changed state which will help users to know that the state of the environment has changed due to a task operation, even if it was only an apt cache update.

fixes #1497

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
8 years ago
Peter Sprygada 0a85e64b4a fixes exception raised due to KeyError (#5068)
The vyos_config module would error when looking for a key called `updates`
in module.params.  There is no such key.  This fixes the problem.
8 years ago
Peter Sprygada 73cf85d677 catches exception if conditional cannot be parsed (#5067)
If the conditional cannot be parsed, the module will now catch the exception
and return a well formed failed message.

fixes #5060
8 years ago
Peter Sprygada da4c11241f fixes error when 'delete ...' config command is specified but doesn't exist (#5064)
The junos_config module will generate an exception if a 'delete ...' config
command is attempted to be loaded into a device configuration.  This change
will first check to see if the delete command is valid and filter it out
of the change set if it is not valid.

fixes #5040
8 years ago
Nathaniel Case aa82f48dc8 Network module code cleanup (#5061)
* Fix imports in junos_template

* Python 3 compatibility in eos_command

* Python 3 compatibility for ios_command

* Clean up issues with ios_facts

* Python 3 compatibility for ios_facts

* Import shuffle in ios_template

* Python 3 compatibility for iosxr_command

* Clean up iosxr_facts.py

* Python 3 compatibility for iosxr_facts

* Python 3 compatibility for junos_command

* Python 3 compatibility for ops_command

* Cleanup issues with ops_facts

* Python 3 compatibility for ops_facts

* Cleanup issues with ops_template

* Python 3 compatibility for vyos_command

* Cleanup issues with vyos_facts

* Python 3 compatibility for vyos_facts
8 years ago
Nathaniel Case 6ae0342a0a Fix imports in junos_template (#5059) 8 years ago
David Shrewsbury d0f7af4b09 Fix os_network's create_network() call for older shade versions (#5058)
A value for the project_id parameter to shade's create_network()
call was always being sent, even if no value for 'project' was
supplied. This was breaking folks with older versions of shade
(< 1.6).

Fixes PR https://github.com/ansible/ansible-modules-core/issues/3567
8 years ago
Matt Clay 25d829c8f2 Detect tar type (bsd, gnu) and only use gnu tar. (#4352)
* Detect tar type (bsd, gnu) and only use gnu tar.

* Revert return code checking for TgzArchive.
8 years ago
Nathaniel Case 9b286b1775 eos_facts cleanup (#5057)
* dict.iteritems does not exist in Python 3

Now just dict.items
six.iteritems handles the change

* Addresses point 1

Unsure if this is a good idea or not.

* Addresses point 2

This shouldn't have any particular change, just marks load_comments as abstract

* Remove unused import

Addresses point 3

* Clarify invalid subset error message

Addresses point 4
8 years ago
Chris Houseknecht 0e4b470ee2 Let docker-py handle decoding and JSON parsing of stream data. Fixes #4930. 8 years ago
Chris Houseknecht 9432adfaf7 Put requested devices in correct format to enable config comparison. Fixes #5000. 8 years ago
Peter Sprygada 0ef16b44ca fixes exception being raised when show configuration command issued (#5047)
The junos_command expects commands to be returned as xml by default but
`show configuration [options]` will return text not xml.  This fix
will set the output format for any command that starts with `show
configuration` to text

fixes #4628
8 years ago
Peter Sprygada a5b32fa0d1 fixes return passing output from command through jxmlease in junos_command (#5044)
The return string from the commands was not being passed through the
jxmlease library and therefore being returned as a string instead of a
json data structure.  This also adds back the missing xml key in the
return that includes the raw xml string.

fixes #5001
8 years ago
Aditya Marella c3f815a6f6 Docker module: add support for OomScoreAdj
* docker-py param name oom_score_adj
* translates to OomScoreAdj in the docker remote API
* setting version_added to "2.2"
8 years ago
shaung bcbeed244b Fix #4504 Respect timeout option when starting/stopping/restarting containers. 8 years ago
Denis Tiago c0c5b9a50a fix health instances count when we have more than one lb in asg 8 years ago
Jiri Tyr 5a9f5918d3 Fixing bind mount on Linux (#1942) (#4439)
* Fixing bind mount on Linux

* Fixing broken implementation
8 years ago
Andrew Gaffney 460b0e1ab6 Match existing INI file entry with leading whitespace (fixes #4997) (#4998) 8 years ago
Senthil Kumar Ganesan 4504f2d8c7 Update minimum required version and ssh rate limit (#4995) 8 years ago
Matt Clay efaed0b68d Revert "Set PRIVILEGED=true for Linux integration tests. (#4993)"
This reverts commit fb779bf30c.
8 years ago
Matt Clay 2b33d55442 Set PRIVILEGED=true for Linux integration tests. (#4993)
This should allow test_mount tests to run on Shippable.
8 years ago
Matt Clay 1854337eb1 Fix handling of ansible-doc errors. (#4992) 8 years ago
Toshio Kuratomi 08874e4bf6 Fix #3153 again (#4989) 8 years ago
Peter Sprygada 654a38897f fixes exception raised when nxos_facts uses nxapi transport (#4988)
This fixes a condition where an exception is raised when collecting `interface`
facts and the transport is set to nxapi in the nxos_nxapi module.

fixes ansible/ansible#17691
8 years ago
Toshio Kuratomi 27759ee58f Working subset of mount fixes (#4987)
* Fixing bind mount on Linux

* The latest update from jtyr doesn't pass integration tests.

Manually select the changes that are necessary to fix the bug with
unmounting
8 years ago
Peter Sprygada df6b7703bb fixes default value in docstring for http (#4985)
The docstring incorrectly stated the default value for http is yes when
indeed its no.  This fixes the docstring
8 years ago
Peter Sprygada 88b2c7e1f6 fixes bug where setting state=absent in nxos_nxapi is not idempotent (#4984)
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device.  This will
fix that problem.

This also updates the docstring to correctly reflect https as default=no

fixes #4955
depends on ansible/ansible#17728
8 years ago
John R Barker f63e5d078e Force is not a 2.2 feature
9b5e6bbfa1 incorrectly chopped some text around
8 years ago
Matt Clay da8538698b Add shellcheck to sanity checks. (#4976)
Also disable deprecation warnings during module validation.
8 years ago
Trond Hindenes 0da88d4744 win_feature_docs_update (#4421) 8 years ago
Timothy Appnel 6647e8c271 Fixes grammatical error in assert module example (#4972) 8 years ago
Ryan S. Brown 93737f819a Accept JSON type as the content of policy_json parameter on `iam_policy` module 8 years ago
Søren Kröger 61144f4da9 Added single_transaction and quick to db_dump (#3687)
It was missing before, ...
8 years ago
JesseEmond 6ddbc63b1d Unarchive stop passing file mode to tar command (#4179)
Fixes #4063.

Tar does not use this parameter on extraction (-x) or diff (-d)(the
only two cases where it is passed in unarchive). It only uses it on
creation:
https://www.gnu.org/software/tar/manual/html_section/tar_33.html

Providing `unarchive` with a file mode of `0755` (octal) makes it pass
the argument `--mode 493` (493 = 0755 in decimal) to `tar`, which then
fails while verifying it (because it contains an invalid octal char
'9'). Not passing the parameter to tar solves the issue.
8 years ago
Marius Gedminas 9509224768 postgresql_db: fix inverted 'changed' logic when state=absent (#4934)
Fixes #4933.
8 years ago