Commit Graph

45160 Commits (e0f6c17857d6a5758fbe5e2018ab897b76784dbc)
 

Author SHA1 Message Date
Abhijeet Kasurde e0f6c17857 Fixed typo in task_executor (#57461)
Changed 'requied' to 'required'

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Chris Van Heuveln 7aa0d26fda nxos_bfd_global / NxosCmdRef initial commit (#56317)
* nxos_bfd_global: initial commit

This is an initial POC with just a few commands included.  The code has been written somewhat generically so that it can act as a best practices template for re-use in future modules. The implementation follows the yaml cmd_ref style to define each command's getter/setter/type/default. It supports platform-specific defaults.

The basic logic is to collect all relevant data in a `cmd_ref` dict and pass that around to various methods.

In the BFD case the devices don't provide JSON output so we have to screen-scrape with show runs.

BFD does not support present/absent states so there is no state param.

BFD has three different property types to handle. We can add add'l types as needed:

- int
- int_list (list of ints)
- str (needs support for 'no' keyword)

* Use get_capabilities to find platform type

* PR comment fixes, round 1

* Minor cleanups

* nxos_bfd_global: create NxosCmdRef in module_utils

This commit just takes the latest bfd global code and moves the bulk
of the code into new `class NxosCmdRef` in `module_utils/nxos/nxos.py`.

The only remaining code in `nxos_bfd_global.py` are the calls from `main()`.

* Add remaining command properties and documentation

* update argument_spec

* Add check for _exclude; add sanity test

* Add targets files for bfd

* Context and state absent updates

* Add dict support to cmd_ref

* Changed remaining list commands to dict usage

* Add idempotence check for dict

* Fix existing overwrite bug

* Move pattern matching logic into its own method

* add support for 'command: absent'

* Add `get_platform_shortname`; update BFD platform-specific settings

* /absent/deleted/

* /sh/show/ in prepare_nxos_tests

* add dict check to get_platform_shortname

* Add normalize_defaults()

* UTs for bfd_global

* support yaml for both py2/py3

* update cmd_ref doc header

* Fix python2.6 incompatibility with dict comprehensions

* Fix bfd_global doc header (yaml syntax fail)

* more shippable fixes

* yet more shippable fixes

* shippable: remove r' ' wrappers

* docfix - remove ':'

* escape regex ctl chars in yaml table

* remove extra blank lines

* Fix str(None) issue

* Command context updates

* import PY2,PY3 instead of import sys

* fix ordereddict import & parent_context

* try/except for yaml import

* fix import issue for ordereddict

* remove epdb

* nxosCmdRef_import_check() workaround for shippable

* fix PEP ws errors
5 years ago
Will Thames f65ac2cf23 Add tests for #56147 (#57256)
Tests are separate for easier backporting
5 years ago
Ondra Machacek d88739367e ovirt: Resolve also list of hrefs (#57299) 5 years ago
Marcus Watkins 6e94b472e8 Fix #56640: Map k8s ansible keys to api keys (#57418)
* Fix #56643: Map ansible keys to api keys

* Remove errant print line

* Fix pep8 issue

* Fix doc line

* Added test for validate_certs -> verify_ssl translation for k8s module
5 years ago
Martin Nečas 8a02901e5f ovirt vmpool fix (#57453) 5 years ago
Ian Wienand 6f06fc9945 openssh_keypair: make fingerprint result a string (#57295)
The extant documentation says that the fingerprint return value is a
single string, but it is currently being returned as a split list.
Convert the returned value to a string as documented, and add some
basic test-case coverage for the return values.
5 years ago
smile37773 c6097a268c rename modules azure_rm_..._facts to azure_rm_..._info (#57395) 5 years ago
Mike Wiebe 870d8bf10b Fix nxos_vtp_version test (#57358) 5 years ago
Mike Wiebe 7c73dd3e78 nxos_install_os: Fix nxapi local failures (#55993)
* Fix nxapi failures

* Remove logit debug calls

* Remove msg_timestamps

* Fix code alignment issue
5 years ago
Mike Wiebe 1dc3fe5317 Add new logging facilties defaults (#57144) 5 years ago
Matt Clay 817ec5ab48 Add PyYAML check for libyaml support. 5 years ago
Matt Clay d758d5bab1 Disable code-smell tests on Python 2.6. 5 years ago
Matt Clay 490edbdc48 Add python version checking when using --tox. 5 years ago
Matt Clay 58f6604efa Support passing CFLAGS and LDFLAGS. 5 years ago
Matt Clay 7a4dc4b1b0 Comment on OBJC_DISABLE_INITIALIZE_FORK_SAFETY. 5 years ago
Matt Clay d80ef9e64b Update typed-ast version to support Python 3.8. 5 years ago
Matt Clay d9fcf95758 Add missing Python 2.6 constraint for voluptuous. 5 years ago
Matt Clay 14f8aa622e Add missing constraints for hcloud requirement. 5 years ago
Simon Dodsley 1637aeea29 Make purefa_pgsnap module handle its own exit correctly (#56954) 5 years ago
Matt Clay a05be890ad Fix podman_image_info parsing of podman output.
Stripping the output from `podman image ls -q` prevents passing
a blank image ID to `podman image inspect`, which would fail.
5 years ago
Sandra McCann 3136007032 update docsite breadcrumbs from sphinx_rtd_theme (#57316)
* improve breadcrumbs
* get edit on github working again
5 years ago
Sandra McCann 96693600f9 2.9 roadmap dates (#57420)
* add dates to 2.9 roadmap, remove alpha phase
5 years ago
Andrey Klychkov ea9a0f36f3 postgresql_table: 57352 bugfix, add schema handling (#57391)
* 57352 bugfix, add schema handling

* 57352 bugfix, added a changelog fragment

* 57352 bugfix, added tests for rename

* 57352 bugfix, fixed tests

* 57352 bugfix, fixed typos, cosmetic changes
5 years ago
jelle van der Waa 7a3914bd8b Support `--valid_pgpkeys` option in Git module ()
PR #55396

Make Git module support `--valid-pgpkeys` option, which allows
configuring a list of valid PGP fingerprints which are compared with the
used PGP fingerprint if verify_commit is true. This requires
verify_commit to be set to 'yes'.

Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
5 years ago
xuxiaowei0512 05e6339c49 option is marked as required but specifies a default (#57257)
* required and default are conflicting
5 years ago
xuxiaowei0512 229d20b6d9 update ce_facts (#57187) 5 years ago
xuxiaowei0512 9c3ae4c1f4 update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)
* update lib/ansible/plugins/action/ce.py
5 years ago
Kevin Breit 919f70c357 New module - meraki_malware (#56929)
* Initial commit for meraki_malware module
- Allows for manipulation of malware configuration

* Add full documentation and improve code coverage

* Add diff support

* Type change

* Sanity check fixes

* Convert org_id from str to int for consistency

* Sanity fixes again

* Fix argument type errors

* Remove ignore items for some Meraki modules so shippable is happy
5 years ago
Kevin Breit 8bcf9b5734 meraki_network - Restructure execution logic (#56818)
* Restructure meraki_network to be simpler and work for all int tests

* Enable all integration tests and enhance error reports

* Slight tweaks to integration tests
5 years ago
Daniel Mellado Area 091bebcbf7 Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.
5 years ago
Kevin Breit 72f2d05b6f meraki_content_filtering - Enable check mode (#54638)
* Add support for check mode.

* Add diff support
- Need to analyze diff for accuracy
- Updated check mode changed value

* Improve test coverage

* Remove a duplicate integration test
5 years ago
Kevin Breit 6da2d40500 meraki_admin - Enable check mode (#54499)
* Add support for check mode

* Add changelog fragment

* Add diff support
- Fix a few changed status
- Removed auth_key check since that's done in module_utils now
5 years ago
Ed Costello 30aeab4709 Make aws_ses_identity module work when region is provided via environment or config. (#51627)
fixes #51531
5 years ago
Martin Krizek 46f8bd47ce file: return 'useful' error message for recursion error (#57222)
* file: return 'useful' error message for recursion error

Fixes #56397

* Fix line length

* Re-phrase the error message
5 years ago
Martin Krizek 18f2ed63e0
file: fix setting relative paths for src for hard links (#56055) 5 years ago
Martin Krizek 705d0201cf
file: fix setting attributes for symlinked file (#57217) 5 years ago
Fred-sun 206f18dcca Update azure_rm_mysqlserver related document (#57382) 5 years ago
Fred-sun 9b6a295ca5 Update azure_rm_mysqlfirewallrule related document (#57384) 5 years ago
Sviatoslav Sydorenko dfaa72297c Fix an RST link to the changelog config in docs 5 years ago
Martin Nečas 6e9eac74f0 ovirt vmpools creating vm options (#55815)
* ovirt vm pools add vm vars

* remove cloud init persist

* ovirt vm pools add nics

* ovirt vm pools add vm docs

* ovirt vm pools update docs

* ovirt vm pools update cloud_init docs

* update ovirt_vm_pools docs

* correct ovirt vm pools version_added
5 years ago
Jordan Borean b5b75daaa5
win_chocolatey - honour version when bootstrapping chocolatey and fix package listing (#57208)
* win_chocolatey - honour version when bootstrapping chocolatey

* skip upgrade all step

* Fix install latest step

* Remove test changes now that Chocolatey is released

* tweak the package version detection
5 years ago
Matt Clay b1e6ad9754
Limit Python 2.6 units to modules & module_utils. (#57377) 5 years ago
James Cassell 1fb0335243 group_chars: default change warning only when needed 5 years ago
Jill R 47cfbd6605
Add integration test provider for vmware (#55772)
* Add integration test provider for vmware

This change adds a new remote cloud provider option for vmware,
supporting dynamic environments running on worldstream.nl as well as
static environments specific by the user in a cloud-config template.
5 years ago
Abhijeet Kasurde b8b0a2a20c aws: Update description for iam_role (#57346)
If IAM Role is created without description using aws cli or UI,
then Ansible failed to update description for such IAM role.
This fixes such condition.

Fixes: #52942

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Chris Archibald 57b3160f13 new feature (#57320) 5 years ago
dw 3fadf4a1cb Fix file descriptor leak in lineinfile module. (#57328) 5 years ago
Alan Rominger 256d1a9947 Add Chris Meyers to the tower team (#57349) 5 years ago
Fred-sun 1ddb37cdc2 Update azure_rm_mariadbserver related document (#57333) 5 years ago