Commit Graph

30107 Commits (d834412eadccca6428501544f398d1bb59084e98)
 

Author SHA1 Message Date
Ricardo Carrillo Cruz 13b2f11139 Do not assert session name on idempotent eos banner (#23402)
* Check for proper response key on eos_banner map_config_to_obj

If we run the task with 'login' banner, the 'show banner' command
will return a dict containing key 'loginBanner'.
However for motd, it will just return 'motd'.
Yay naming consistency!

* Do not assert session exists on eos_banner response not changing device
8 years ago
Ricardo Carrillo Cruz ba7ba7adc3 Check for proper response key on eos_banner map_config_to_obj (#23399)
If we run the task with 'login' banner, the 'show banner' command
will return a dict containing key 'loginBanner'.
However for motd, it will just return 'motd'.
Yay naming consistency!
8 years ago
Ricardo Carrillo Cruz ce9826d76e Fix eos_banner basic-motd eapi asserts (#23398)
The commands in EAPI does not contain the plain command sent to the
device as a one liner, but it is split in cmd/input keys.
8 years ago
Ricardo Carrillo Cruz 2cc2b8fb4d Add missing provider to eos_banner basic-motd eapi test (#23396)
Otherwise this stalls and timeouts, it doesn't have creds to run.
8 years ago
Matt Clay 48eeab8a53 Fix errors reported by pylint. (#23282)
* Fix pylint misplaced-bare-raise errors.
* Fix pylint return-in-init error.
* Fix pylint bad-format-character error.
* Fix pylint too-many-format-args errors.
* Fix pylint too-few-format-args errors.
* Fix pylint truncated-format-string error.
8 years ago
Matt Clay 9e1bf1c6f2 Update fedora24 Dockerfile to resolve dnf issue. 8 years ago
John R Barker 6633ae1afa look_for_keys & allow_agent actually added in 2.4
https://github.com/ansible/ansible/pull/22429 was merged, though not cherry picked into stable-2.3, so update docs
8 years ago
Guillaume Coré 3c75808c5c fix incorrect parsing of xfs_info
when device name ends with 'data' line matches in :
-                if 'data ' in line:

closes #23352
8 years ago
Toshio Kuratomi dcc63c8f93 Fix imports and pep8 problems so CI can pass again. 8 years ago
Ricardo Carrillo Cruz 3537b24742 Unhardcode the port and protocol on eos EAPI (#23350)
We were hard-coding the protocol, port and validate_certs on
eos EAPI via the action plugin.
Put defaults on the eos_argument_spec and pull those values from it.
8 years ago
Toshio Kuratomi 5f4673b5ae Update metadata for openssl_csr 8 years ago
Ganesh Nalawade 0cd50f0706 Fix #22880 junos_config update issue (#23333)
For update parameter add 'override' as acceptable value.
'override' name is in sync with junos naming convention.
8 years ago
Chris Alfonso 394cb3477b Fixes loginBanner plucking over eapi transport when loginBanner isn't set. (#23363) 8 years ago
Ganesh Nalawade 990ba90380 Fix #23360 junos_config set format issue (#23365) 8 years ago
Nathaniel Case 98c23a3342 Attempt to clear up nxos_mtu tests and documentation (#23361)
nxos_system wasn't added until 2.3, so nxos_mtu should have been deprecated
then.
8 years ago
nerzhul 637e9942ff Nsupdate idempotency fix 8 years ago
Yanis Guenane 2705e7a8aa crypto: Add new module openssl_csr (#21004)
This new module allows one to automate the generation of OpenSSL
Certificate Signing Request. It supports SAN extension.
8 years ago
Matt Clay 40e88dadbe Disable zypper tests for CI due to timeouts. 8 years ago
Peter Sprygada f0008248d4 fix iosxr commands to encode json (#23346)
the command dict in the iosxr module_utils wasn't encoding the request
to json.  this patch will fix that problem
8 years ago
John R Barker 13dc02d49d More network_debug_troubleshooting.html (#23335)
More "unable to open shell" -> network_debug_troubleshooting.html
8 years ago
Takuya Sato dff35bc205 ecs_taskdefinition module : Convert environment variables to string (#23297)
Before modification, it fails unless it is a string type
8 years ago
John R Barker 529df8640b 'unable to open shell' -> direct to web help (#23267)
* 'unable to open shell' -> direct to web help

The "unable to open shell" error is returned for a number of different,
direct people to online docs (we we can update out of band of releases)
to guide them though the various solutions.

* fix pep8 errors
8 years ago
Varadharajan 4540853a50 Pass CSRF token along with Jenkins POST requests (#23250) 8 years ago
Matt Davis b71b157fb3 Cleanse CLIXML from win_shell stderr (#23329)
prunes all but Error stream values
8 years ago
Matt Davis 8d291f91ee improve become_method: runas error handling (#23328)
Prescriptive errors for username/password issues and NTLM/Kerb auth failures, cleans up exception noise.
8 years ago
Dag Wieers e66c98281e Small consistency fixes (#23294) 8 years ago
Ricardo Carrillo Cruz b9b4e68206 Check text key exists on eos_banner absent case (#23319)
This can fail if we don't check the key exists.
8 years ago
Ricardo Carrillo Cruz 4571ff0b52 Fix eapi basic-login asserts (#23318)
The asserts where not checking the commands sent to the device
8 years ago
Ricardo Carrillo Cruz cf30f0f27d Fix asserts on ios_banner tests (#23315)
The contain assert was broken.
8 years ago
Chris Alfonso 3a78861cb5 Fixes #23308 ios_banner: KeyError: 'text' on state: absen (#23313) 8 years ago
Ricardo Carrillo Cruz d268471739 Fix basic-login eapi tests for eos_banner (#23304)
We should be passing the provider dict, not the transport.
8 years ago
John R Barker f22702eee2 enable ios_facts tests again (#23310) 8 years ago
Adrian Likins a936ea1333 update the flake8 config in tox.ini 8 years ago
Nathaniel Case d890167575 Fix nxos_facts for nxapi transport (#23302)
* Partial revert of 2e476e64cd

This broke handling of nxos_facts over nxapi

* Fix nxos_facts tests not run in isolation
8 years ago
John R Barker 485affeb12 eapi & nxapi: Document validate_certs (#23305)
* Document validate_certs for eapu & nxapi

* formatting
8 years ago
Tim Rupp 780b2f2c84 Fixes pylint errors (#23279)
Reported by gundalow, this fixes pylint errors in F5 modules
8 years ago
Will Thames b3a15e9ac3 [cloud] New AWS ec2_vpc_endpoint module for creating/deleting VPC endpoints (#20212)
* New AWS VPC Endpoint module for creating and deleting VPC endpoints

* Fix for python3, update version_added, fix flake8 issues

Change exception syntax for python 3
Update version_added to 2.3
Fix some minor flake8 issues

* ec2_vpc_endpoint: improve standards compliance

* Better documentation
* Return results in camel case format
* Improved exception handling
* Added `policy_file` argument
* Add ANSIBLE_METADATA

* Fix version_added

* Update ansible metadata to have metadata_version field
8 years ago
Benjamin Jolivot f74a9abbda fortios_ipv4_policy.py state=absent Fix 23239 (#23242)
* Resolve #23239:
  - path is missing when state=absent
  - update doc for unclear policy ID
  - required params based on state

* Fix pep8 + doc

* Fix doc

* Another doc problem...

* doc

* Update doc fot policy ID

* Fix doc string

* fix required in doc

* fix required in doc Required when I(state=present).
8 years ago
Ricardo Carrillo Cruz 2571d2f64b Refactor openvswitch_db module (#23288)
The openvswitch_db module uses the ovs-vsctl binary to
address changes.
On other network modules we follow the pattern of returning 'commands'
as part of the result, containing the commands run on the target device.
Follow that for code consistency and maintenance.
Also, adding state param, which allows to add/remove keys on columns.
8 years ago
Nathaniel Case e8538213fa Fix various junos errors (#23278) 8 years ago
Ganesh Nalawade 0b8ca98c48 Fix junos rollback id validate issue (#23283) 8 years ago
Matt Clay 1daa69d685 Initial pylint support for ansible-test sanity. 8 years ago
Toshio Kuratomi 572e9a8959 Update the metadata of the proxysql modules to 1.0 final format 8 years ago
James Cammarata a567c5de65 Only insert notified host if it's not already notified for certain cases
Fixes #18178
8 years ago
bmildren 21ab4343e3 Adding support for ProxySQL (#19872)
* Adding support for ProxySQL
8 years ago
Brian Coca 00231c29ba Revert "keep ansible_local as top level var, always present"
This reverts commit 97cb2016d8.

It was causing issues downstream as facts seem to be merged back for
subsequent tasks. Will restore if I ever figure out how to avoid that.
8 years ago
Matt Clay a6ca849643 Fix PEP 8 issues. 8 years ago
JP Mens 5a0b2fe3be dig lookup-plugin: add support for specifying rdclass (#10493)
* add support for specifying rdclass

* fix exception
8 years ago
Nathaniel Case 597bca3129 junos_config: Remove reliance on ability to output configuration in `set` format (#23225)
* Remove reliance on ability to output configuration in `set` format
* Support multiple warnings per rpc-reply
8 years ago
John R Barker 01e27b1083 Typo 8 years ago