Nsupdate idempotency fix

8 years ago · 637e9942ff
parent 2705e7a8aa
commit 637e9942ff
1 changed files with 6 additions and 5 deletions
--- a/lib/ansible/modules/network/nsupdate.py
+++ b/lib/ansible/modules/network/nsupdate.py
@ -223,13 +223,14 @@ class RecordManager(object):
                self.dns_rc = self.modify_record()
                if self.dns_rc != 0:
                    result['msg'] = "Failed to update DNS record (rc: %d)" % self.dns_rc
-        else:
-            result['changed'] = False

-        if self.dns_rc != 0:
-            result['failed'] = True
+            if self.dns_rc != 0:
+                result['failed'] = True
+            else:
+                result['changed'] = True
+
        else:
-            result['changed'] = True
+            result['changed'] = False

        return result