Commit Graph

7005 Commits (d5ab52eb58f48c1ba7d2cefeb610c415e440cb1c)
 

Author SHA1 Message Date
Hans-Joachim Kliemeck d5ab52eb58 fixxed tests 9 years ago
Hans-Joachim Kliemeck c0b2080ae1 fixed problems related to userpricincipalname (user@domain) and undefined variables
fixed variable capitalization
9 years ago
Hans-Joachim Kliemeck 10ce1f92aa fixxed problem with match @ 9 years ago
Hans-Joachim Kliemeck 45249fb042 only call set-acl if necessary 9 years ago
Hans-Joachim Kliemeck 3a5d4576c6 as suggested by @marcind, convert to boolean 9 years ago
Hans-Joachim Kliemeck 7978afe1fd fixed documentation 9 years ago
Hans-Joachim Kliemeck cda7e96fcc added userprincipal support 9 years ago
Hans-Joachim Kliemeck 7c8e3f4da1 added separate module to change owner, since win_acl is ACL only and should not be more complex 9 years ago
Brian Coca 05f53f2b95 Merge pull request #200 from schwartzmx/module/win_acl
win_acl Module

talked to @cchurch, merging this for now, need to open ticket to address the 2008 issue
9 years ago
Toshio Kuratomi 8ce3104bc5 Convert from dos line endings to unix because dos line endings break our documentation build. 9 years ago
Brian Coca fdb4a58f97 added version_added and fixed some doc parsing issues 9 years ago
Brian Coca 6e01848602 Merge pull request #837 from jemmyw/consul-http-checks
Add consul http checks to consul.py
9 years ago
Toshio Kuratomi 96af56d750 Merge pull request #1106 from groks/crypttab-strip-fix
Fix bug #1105 - incorrect use of lstrip()
9 years ago
Steve c5924aff74 Fix bug #1105 - incorrect use of lstrip()
Remove only the literal prefix '/dev/mapper/' - not any of the characters
in '/dev/mapper/' - from the name param of the crypttab module.
9 years ago
Brian Coca 15480e3d04 fixed option in examples 9 years ago
Charles Paul 51bb65c9a3 reference instance_id in docs, fixes for calls to fail_json 9 years ago
Brian Coca 561d768f44 Merge pull request #1076 from trondhindenes/win_package_bugfix
turned off strict msi code checking
9 years ago
Brian Coca a155f7ee34 Merge pull request #1071 from nlandais/devel
Adding fix to get around bug found with the New-Website command when…
9 years ago
Brian Coca cc69ac1513 Merge pull request #1064 from dreamcat4/feature/win_fw-hotfixes
hotfixes: module windows/win_firewall_rules
9 years ago
Brian Coca 4a0e757196 Merge pull request #370 from nsg/full-attachments-support
Add attachments support to slack module.
9 years ago
Brian Coca 06210612ee Merge pull request #251 from kdisneur/hotfix/tap-prefixed-by-homebrew
Remove `homebrew-` prefix when checking if repo has already been tapped
9 years ago
Brian Coca 0e56b95f5c Merge pull request #1068 from luiseterc/devel
Fix bug #1067
9 years ago
Jeremy Wells cf4b4be901 Add consul http checks to consul.py
Consul module already supports ttl and script checks. This commit adds
http checks.
9 years ago
Stefan Berggren df90e3b162 Merge pull request #1 from ramondelafuente/feature/nsg-full-attachment-support
module guidelines compliency
9 years ago
Trond Hindenes b9d842ecd6 turned out strict msi code checking 9 years ago
Nicolas Landais d1dcf8e06b Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 9 years ago
Ramon de la Fuente d14bb33a03 updated the examples to the new Slack API 9 years ago
Ramon de la Fuente 8ffc11713f module guidelines compliency 9 years ago
Brian Coca 205115ea1f updated to use shared region docs from ec2 9 years ago
Brian Coca 8d3122169d added missing GPL licences
fixes #508
9 years ago
Brian Coca 8903d0d968 Merge pull request #557 from perzizzle/gtm_wide_ip
Module for managing F5 GTM wide ip
9 years ago
Brian Coca 5302de2686 Merge pull request #732 from tobywf/homebrew_validation
Homebrew: Allow colons, direct check for outdated formula
9 years ago
Brian Coca b8c19e6531 Merge pull request #1039 from indrajitr/homebrew-update
homebrew: Improve 'argument_spec' handling
9 years ago
Brian Coca 30e7f4a934 Merge pull request #1066 from jhawkesworth/documentation_win_environment_limitations
Document win_environment limitations
9 years ago
Luis Rodriguez 6e80ed57d2 Fix bug #1067 9 years ago
= 576b5e2fc3 Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 9 years ago
Brian Coca 6336838354 Merge pull request #1059 from sivel/sys-exit-removal
sys.exit removal from various modules
9 years ago
Dreamcat4 ece9c2b43a fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
9 years ago
James Cammarata 0ff1776a84 Updating version for 2.0.0-0.3.beta1 release 9 years ago
Matt Martz 32bdecef9a Merge pull request #1060 from sivel/open-iscsi-examples
Fix open_iscsi EXAMPLES section
9 years ago
Dreamcat4 dcaa794949 fix: update documentation with new module name "win_firewall_rule" 9 years ago
Dreamcat4 469d22df97 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
9 years ago
Dreamcat4 6c5a4a14ef fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
9 years ago
Dreamcat4 2654789af7 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
9 years ago
Matt Martz 9d015665b8 Fix open_iscsi EXAMPLES section 9 years ago
Matt Martz e68d9315c1 sys.exit removal for system/capabilities.py 9 years ago
Matt Martz eac4493421 sys.exit removal for notification/mail.py 9 years ago
Matt Martz abf7ee579e sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 9 years ago
Matt Martz 55dab7cd1b sys.exit removal for cloud/misc/ovirt.py 9 years ago
Matt Martz b82ebdde19 sys.exit removal for cloud/xenserver_facts.py 9 years ago