Commit Graph

21319 Commits (c9556887728a1686033abc2a09e728aef6751abf)
 

Author SHA1 Message Date
Adrian Likins 41d6f5c635 out.split('\n') -> out.splitlines() (#17879)
foo.split('\n') is picky about the type of 'foo'.
if 'foo' is a bytes type, then foo.split('\n')
will fail on py3 with:

   TypeError: a bytes-like object is required, not 'str'

The foo.split('\n') change isn't strictly required
when run_command returns native str types, but it
is more idiomatic and conceptually also supports other
line endings.
8 years ago
Scott Butler 02b08b1b0c Added new nav breadcrumbs 8 years ago
Pablo SEMINARIO b233f3ed3c Fix minor typo on testing paths example 8 years ago
James Cammarata 0a86ddc251 Move searching for roles in the cur basedir to last
Searching the DEFAULT_ROLES_PATH and the roles basedir should come
before this, and it has been a long standing oversight.

Fixes #17882
8 years ago
Mark Szymanski 3a6743fb54 Allowing hostcolor colours to be set 8 years ago
Brian Coca d9d7e413a5 fixed storing of cwd 8 years ago
Toshio Kuratomi 23305540b4 Make ini parsing slightly more robust
Prior to this commit, the ini parser would fail if the inventory was
not 100% utf-8.  This commit makes this slightly more robust by
omitting full line comments from that requirement.

Fixes #17593
8 years ago
Brian Coca 74b7590211 better inventory error messages 8 years ago
John R Barker 0dea70bf37 asa_template wasn't ever officially released
asa_template was added during 2.2 development, and removed before 2.2 hit RC1 so no need to give notice of deprecation.
8 years ago
James Cammarata d09f57fb3a Check for substates in is_failed before checking main state failure
Fixes #17882
8 years ago
Brian Coca 72e6ffad47 added script to unify repos
in case i forget how to do this, can be deleted afterwards
8 years ago
Toshio Kuratomi 08a58ae025 Fix for run_command tests now that it returns native strings 8 years ago
Brian Coca 125a8d3c65 no need for warnings in first_found 8 years ago
Brian Coca 54ce6a9b7a fix for include_role conflating vars/directives 8 years ago
Brian Coca d4b2ea3ec8 include_role process name from options, not task 8 years ago
Toshio Kuratomi 965dcabed2 Update submodule refs for the command fix with new run_command 8 years ago
Adrian Likins d0bdfc2abb Specify run_command decode error style as arg (#17886)
* Specify run_command decode error style as arg

Instead of getting the stdout/stderr text from
run_command, and then decoding to utf-8 with a
particular error scheme, use the 'errors' arg
to run_command so it does that itself.

* Use 'surrogate_or_replace' instead of 'replace'

For the text decoding error scheme in run_command calls.

* Let the local_facts run_command use default errors

* fix typo
8 years ago
Adrian Likins 2addc09050 cast/copy keys() to list to avoid py3 errors
In py3, dict.keys() is a view and not a copy of the
dicts keys, so attempting to delete items from the dict
while iterating over the keys results int

RuntimeError: dictionary changed size during iteration

Resolve by casting .keys() to a list() type.
8 years ago
Adrian Likins 9f673e0725 open anziballs payload 'wb' for py3 8 years ago
Brian Coca 828dcd0f40 updated devel to 2.3 (#17884)
* updated devel to 2.3

* got missing 2.2/2.3 conversions
8 years ago
Toshio Kuratomi ddd20627a4 Make run_command return native strings
This changes the return value on python3   Return value on python2 was
already byte strings (which is the native str type there.)
8 years ago
Chris Houseknecht ab93d5aae4 Merge pull request #17873 from chouseknecht/fix_3964
Let docker-py decode pull response
8 years ago
James Cammarata 447ab0ab95 Bumping devel version to 2.3.0 8 years ago
Chris Houseknecht fa7e572a96
Let docker-py decode pull response 8 years ago
James Cammarata 78a02555e5 Updating CHANGELOG and release versions for 2.1.2 8 years ago
Matt Davis 64d9de6b25 bump core submodule ref 8 years ago
John R Barker 4643bb4c6a New modules (#17870)
Full review of new modules
8 years ago
Peter Sprygada 15ee97d214 added network updates to CHANGELOG 8 years ago
Brian Coca 814e3069b9 added forman callback plugin to changelog 8 years ago
Brian Coca 49ce0c8bac only change dir to playdir if local
fixes #17869
fixes #17770
8 years ago
Toshio Kuratomi 5bc3cb278c Remove unicode escape (#17866)
* Remove unicode-escape which is not present on python3

Alternative fix for #17305

* Enable the assemble test on python3

* Fix other problems with assemble on python3
8 years ago
Toshio Kuratomi ddb3f91562 Update submodule refs 8 years ago
Guido Günther 14a9bd6a1c Add foreman callback plugin (#17141) 8 years ago
Toshio Kuratomi f72b123584 On python3, subprocess needs another arg to pass extra file descriptors 8 years ago
Toshio Kuratomi 64c446d9c0 Normalize text and byte type in the ssh plugin helper method that builds up an ssh command (#17860)
Mostly cleanups to make the code more efficient, more pythonic, and obey
the unicode sandwich strategy more but also Fixes #17832
8 years ago
Peter Sprygada b0cd624aef fixes issue with run_commands raising error (#17861)
The junos run_commands() method should raise an error when an RpcError is
returned but didn't when using display=text.  This fixes that error
8 years ago
Peter Sprygada 50c445c356 switches the kickstart arg from True to False for eos (#17858)
The kickstart kwarg should be set to False for eos based devices and
was set to True.  This change cleans up problems loading json output
from cli commands

All eos_command test cases are now passing successfully

fixes #17441
8 years ago
Peter Sprygada 512ef49c8a adds new exception for adding condition statements to Conditional (#17859)
When adding condition statements, the Conditional instance will now generate
an AddConditionError if is unable to map the condition to a function in the
instance
8 years ago
Matt Davis a4e5187661 bump core submodule ref for windows async_wrapper bugfix 8 years ago
Matt Davis aa0ad073b8 bugfixes to JSON junk filter, added unit/integration tests to exercise (#17834) 8 years ago
James Cammarata 657506cddd Ensure the "attempts" key is set in the final result for do/until loops
Fixes #17258
8 years ago
Senthil Kumar Ganesan 7e0074263d Remove the dellosX_template module (#17836) 8 years ago
Matt Clay 21857e8618 Disable privileged mode on Shippable. (#17844) 8 years ago
Matt Davis 60b322e3ca bump core submodule ref for async_wrapper fixes 8 years ago
Indrajit Raychaudhuri becb4765c3 Add homebrew in squash_actions list (#16966)
`homebrew`, like other package modules in the existing `squash_actions` list can
benefit from `with_items` loops optimization.
8 years ago
Brian Coca dfff608ceb dzdo prompt fix
fixed tests
dzdo has 2 paths now, with and w/o password
fixes #17838
8 years ago
Brian Coca 6008fbd5cf fix fact gathering flag 8 years ago
Brian Coca 24e81ddd1c add ssh error message to failure 8 years ago
James Cammarata e4ee9de3f4 Fixing parentage of include_role objects for param inheritance
Fixes #17686
8 years ago
Peter Sprygada 6be2f0bded fixes unicode conversation from junos get_config() method (#17841)
The junos config should convert the returning configuration to unicode
not str.  This fixes that issue.
8 years ago