Commit Graph

48369 Commits (c1f280ba6e4a1e5867720e8c8426bc451ad32126)
 

Author SHA1 Message Date
Sloane Hertel c1f280ba6e
Inventory CLI - Ignore settings for when vars plugins should run (#65073)
* Inventory CLI - Ignore settings for when vars plugins should run and just always run them

* Add note to porting guide

* Fix loading vars plugins

* changelog

* Remove a staging test for ansible-inventory since it ignores that setting
5 years ago
Gonéri Le Bouder 8f1af61851
vmware_guest: relax the requirements of the tests (#65192)
- 128MB or RAM is enough for most of the cases
- 1VCPU is also enough
5 years ago
Nabil BENDAFI 277dd54d45 Fix/archive empty file (#64895)
* Remove call to filecompare to fix issue with empty file exclusion from archive

* Add empty file
5 years ago
gaoruifeng f9f7a0c60e fix syntax issue (#65166)
- can disabled  
+ can be disabled
5 years ago
Riccardo Murri e4196f99e0 one_vm: Fix typo in error message. (#65253)
##### SUMMARY
Fix a (likely) copy+paste error in error message in the `one_vm` module.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
5 years ago
Nate Coraor 2d6f716d37 Add 'bhyve' as a valid brand for SmartOS vmadm (#65200) 5 years ago
Matt Martz b08e7daf46 Do not treat AnsibleUndefined as being unsafe (#65202)
* Do not treat AnsibleUndefined as being unsafe. Fixes #65198

* fix yaml formatting
5 years ago
Jeffrey van Pelt f37dbf859b os_security_group_rule fix port matching when protocol is any (#59055)
* Added logic to match on protocol 'any'

I personally use this to remove the default created egress rules from
security groups.

* Fixes for ansible-test
5 years ago
Satyajit Bulage 5f8ec4d46e Handle LibraryError exception in postgresql_db (#65229)
* Added changes into changelogs/fragments
* Removed no longer used 'LibraryError'.

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
5 years ago
Mike Wiebe 89954e6ef5 Test fix (#65132) 5 years ago
Mike Wiebe 4d69648893 Add default log level for new facitlity (#65197) 5 years ago
Trevor Pounds 8daa42bb3d Support non-KV and KV v1/v2 secret engines (#64288)
* Support generic and KV v1/v2 secret engines.

Fixes #41132
Fixes #50598
Fixes #54462
Fixes #64150

* Update KV v2 compatibility notes/usage docs.

* Add tests for KV v1/v2 and generic secrets engines.

* Add changelog fragment.

* Add KV v2 behavior changes to porting guide.

* Fix pylint blacklisted name warnings.
5 years ago
Andrew Klaus e74cf5e4b3 Fix: OpenBSD syspatch module bug (#57259)
* Append is not a list

* Adding new example. Renaming reboot var to match other modules

* syspatch: Fixing if statement logic issue to properly compare integer

* Syspatch: Using get_bin_path to find path. Revert to reboot_needed instead of reboot_required.

* syspatch: Fix wording in playbook example
5 years ago
Rostyslav a8fa432096 Add --override-arguments option to win_chocolatey module (#65101)
* Add --override-arguments option to win_chocolatey module

* Fix version and argument type

* Added changelog fragment and tests
5 years ago
Felix Fontein 63b94fca7e docker_container and docker_network: avoid None errors (#65018)
* Avoid None errors.

* Add changelog.
5 years ago
Felix Fontein f4d45ffdff
docker_container: change network_host default behavior for Ansible 2.14 (#64635)
* Update network_mode docs.

* Announce default change for 2.14.

* Add changelog fragment.
5 years ago
Felix Fontein 0b8b5baecd
docker_container: add support for --cpus (#64683)
* Add support for --cpus.

* Adjust PR #.

* Add version_added.
5 years ago
Anatoly Kamchatnov ebdb581e63 Fix typos in `ansible.cfg` comments
PR #65177
5 years ago
Michael Cassaniti a096cd08c5 docker_swarm_service: Sort lists when checking for changes (#63887)
* docker_swarm_service: Sort lists when checking for changes

When two lists are checked for changes in this module, the lists are 
reported changed when the order of the items is different. This PR 
resolves this issue.

* docker_swarm_service: Minor typo fix

* docker_swarm_service: Another minor typo

* docker_swarm_service: Should use sorted(), not sort()

* docker_swarm_service: Sort lists of dictionaries

* docker_swarm_service: Fix style issues in tests

* docker_swarm_service: Updates to integration tests

* docker_swarm_service: Casting string types within lists when comparing

* docker_swarm_service: Special handling of unordered networks with ordered aliases

* docker_swarm_service: Sorting network lists

* docker_swarm_serivce: Better unit test code coverage for lists and networks

* docker_swarm_service: Fixed coding style for sanity tests

* docker_swarm_service: More coding style fixes

* docker_swarm_service: Ignoring test for Python < 3

* docker_swarm_service: Update to version info check for backwards compatibility

* docker_swarm_service: Added change fragment #63887

* docker_swarm_service: Better handling of missing sort key for dictionary of lists

* docker_swarm_service: Preventing sorts from modifying in-place

Co-Authored-By: Felix Fontein <felix@fontein.de>

* docker_swarm_service: Removed spurious import in test

* docker_swarm_service: Preventing sorts from modifying more data in-place

Co-Authored-By: Felix Fontein <felix@fontein.de>
5 years ago
Rohit Gohri 136dc27572 [yarn] Set name_version when version is not specified (#62348)
* Set name_version when version is not specified, fix #55097

This will default to installing the latest version available

* Add changelog fragment

* update changelog
5 years ago
Gonéri Le Bouder eb3da65886
vmware_rest_client: pass object to get_tags_for_dynamic_obj (#65156)
This patch fix the `vmware_cluster_info` functional-tests.
`get_tags_for_dynamic_obj()` expects an object, not the object ID in a
string.

Without this patch, the `vmware_cluster_info` module fails.
`get_tags_for_object()` raises the following exception:

```
vmware.vapi.exception.CoreException: Expected VapiStruct instance or python dictionary, but received str
```

The patch partially reverts changes introduce in:
35cc26f8c0

See: http://vmware.github.io/vsphere-automation-sdk-rest/6.5/operations/com/vmware/cis/tagging/tag_association.list_attached_tags-operation.html
5 years ago
Gonéri Le Bouder 239213baee
vmware_guest: do not use autoselect_datastore in test (#65191)
Disable the use of `autoselect_datastore` until https://github.com/ansible/ansible/issues/58541
is fixed.
5 years ago
John Chen c73288ad53 user - compare macOS user properties using same type (#62973)
self._get_user_property returns a string, so when doing a comparison
using this value, cast the second variable to a string so that the
comparison behaves correctly
* Add changelog
* Add to_text import
* Add integration test
5 years ago
Pavan Bidkar d4c4c92c97 Fix issue 64503. Added pool to relocate spec (#64544)
VM relocate to destination host works without pool param when hosts are part of same cluster. but spec.pool is required when hosts are part different clusters.

Closes: #64503
5 years ago
Chris Budzilowicz 0ab21fd1ec add note re required forward slash on url (#65203) 5 years ago
Markus Bergholz cba9abcbec elbv2 - print() statement results an task failure, even if the task itself was successfull (#65183) 5 years ago
Sam Doran d3f6943446
Remove postgresql_shared integration test (#65133)
Move test tasks into appropriate integration test
5 years ago
Jan Meerkamp 315cc2f3ea VMware: vcenter_folder checks nested parent folder path (#62741)
added possibility to create Subfolder by defining full path below datacenter

Closes: #64442
5 years ago
Diane Wang d05d5cfc39 VMware: add new module vmware_guest_controller (#59615)
Add the `vmware_guest_controller` module.
5 years ago
Nilashish Chakraborty 62c4ff8174
Fix legacy facts keys having redundant underscore (#65167)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
5 years ago
nmandy-git 3dc113fd9a Update notes in vmware_guest about SysPrep Windows Guest (#65055) 5 years ago
Abhijeet Kasurde d7039b6633
VMware: Fix typo in fail_json in vmware_guest_powerstate (#65162)
Fixed typo from "chanaged" to "changed"

Fixes: #65161

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
DaveD dc59880c31 vmware_deploy_ovf: Use correct datastore in multi-datacenter environment
Fixes: #63920 

Need to pass the datacenter to assure we get the correct datastore managed object Id.
5 years ago
Jie (Link) Zheng 41b199a936 Fortinet's new module for fortios_system_global (#64817) 5 years ago
Prasad Katti 95bd92da04 Add integration tests for aws lightsail (#63770)
* Add integration tests for aws lightsail

* lightsail - use module_defaults instead of aws_connection_info

* lightsail tests - assert instance state on create

* Fix yaml syntax error

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* [lightsail] create keypair as part of the testsuite

* Fix lightsail actions in compute-policy

* Add ability to delete keypair in lightsail_keypair
5 years ago
Mark Chappell 6e652ae6df Improve consistency of IAM_{role,user,group} behaviour (#64258)
* iam_user: use AnsibleAWSModule.client to fetch connection rather than C&P code

* iam_role: Add deprecation warning so we can switch purge_polices default behaviour from true to false

* iam_user/role/group: Rename 'managed_policy' and 'purge_policy'

Rename from singluar to plural (we accept a *list* of policies), and add aliases for the old values.

* Cleanup documentation

* Changelog
5 years ago
Felix Fontein 784e507671 module sanity checks: improve alias handling (#59060)
* add_file_common_args is only of interest on top-level.
* Handle undocumented arguments in one place.
* Update ignore.txt
* Add changelog
5 years ago
Egor Zaitsev f3575c5025 docs: add solution to timeout errors to docs (#65140) 5 years ago
Alicia Cozine b0c8e7926f link from quickstart page to Network Getting Started (#65150) 5 years ago
Michael Mayer d52af75c68 Add aws elb multiple host header support (#65021)
* Add support for aws elbv2 multiple host header actions

* Add example of multiple host header

* Add test for multiple host headers

* Add missing quote

* Update test/integration/targets/elb_application_lb/tasks/test_modifying_alb_listeners.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Update test/integration/targets/elb_application_lb/tasks/test_modifying_alb_listeners.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Remove debug statements
5 years ago
Felix Fontein d1c58bc942
#59522: adjust messages (#65129)
* Adjust messages.

* Fix one more.
5 years ago
Maxime Guyot c08f536260 Add support for all_projects in OpenStack inventory module (#55965) 5 years ago
Gregory Schevchenko c6301a9fc7 fix utils.color.stringc: enclosure non printable sequences in SOH,STX (#64751)
* ansible.utils.color.stringc: add wrap_nonvisible_chars flag in stringc
* add exaplanation for `wrap_nonvisible_chars` case in utils.stringc
* add changelog entry
5 years ago
Dusan Matejka 1a7823af03 Added missing logout to zabbix_user_info module (#65146) 5 years ago
nillvitor ede62b8ad4 Update influxdb_write.py (#65117)
Remove duplicated line
5 years ago
Mark Chappell f1311d3e98 Rewrite iam_policy using boto3 (#63924)
* reworked iam_policy

* Deprecate policy_document option

* deprecate defaulting skip_duplicates to true

* No longer explicitly catch ParamValidationError.

ParamValidationErrror is already caught by ClientError

* Work with complex policy objects rather than json documents

comparisons can better cope with the special cases (eg True vs "True" )

* Enable check_mode tests and fix related 'changed' bug

* changelog

* doc cleanup based on review
5 years ago
Sam Doran 426e37ea92
postgresql_privs - fix sort comparison (#65125)
The result of .sort() is None, not the sorted object. The comparison was comparing the result of the .sort() method and not the sorted values.
5 years ago
Mads Jensen 6a763d7133 Remove uneeded Python version compatibility checks. (#64076) 5 years ago
Xu Yuandong da8ec327cc Update plugins/netconf/ce.py to fix a bug(failed to get veriosn information via neocnf). (#65065)
* fix version fail.

* add a changelog fragment.

* Update ce.py

* Rename plugins-netconf-ce-fix.yaml to 65065-plugins-netconf-ce-fix.yaml

* Update ce.py
5 years ago
Reid Wahl e16e6fac92 Fixes #28325: Add ansible_ssh_host_key_<algorithm>_public_subtype fact for each public host key algorithm (#28449) 5 years ago