ansible

Commit Graph

Author	SHA1	Message	Date
James Cammarata	af4f0bd008	Fix for "argument must be an int, or have a fileno() method" error The issue was that, when forks == 1, the _executor() function was being called with None for the value of new_stdin. Fixes #3841, #3902	11 years ago
James Cammarata	978af89175	Disallow running async tasks with lookup plugins Fixes #2897	11 years ago
James Cammarata	ed3e4aff84	Place retry file in the user's home dir instead of /var/lib/tmp Addresses CVE-2013-4260: predictable filename used for failed results in world writable directory.	11 years ago
James Cammarata	6bf5d19506	SSH connection plugin creates ControlPersist socket files in a secure directory Files were being created in /tmp, but will now be created in $HOME/.ansible/cp/ Addresses CVE-2013-4259: ansible uses a socket with predictable filename in /tmp	11 years ago
Stoned Elipot	f0743fc32a	Introduce the 'always_run' task clause. The 'always_run' task clause allows one to execute a task even in check mode. While here implement Runner.noop_on_check() to check if a runner really should execute its task, with respect to check mode option and 'always_run' clause. Also add the optional 'jinja2' argument to check_conditional() : it allows to give this function a jinja2 expression without exposing the 'jinja2_compare' implementation mechanism.	11 years ago
Michael Scherer	2bdba17a85	make sure ssh do not ask password For some reason, ssh seems to ask for password even when PasswordAuthentication is set to no, adding PreferredAuthentications with the 2 options removed do the trick.	11 years ago
Kavin Kankeshwar	7ac3bbc198	resolved #3609 Change max_fail_pct to max_fail_percentage as recommended	11 years ago
Kavin Kankeshwar	3f247fcbe3	fixes ansible/ansible#3609 Add max_fail_pct to playbook parameter, to complement serial option, So if total number of failures execeed max_fail_pct * total number of hosts, do not go to the next serial batch	11 years ago
smoothify	494043947d	Add support for role defaults. These are variables on a per role basis with lowest precedence.	11 years ago
Petr Svoboda	e3adfbf5f8	Add tests for undefined variable detection Tests `test_playbook_undefined_varsX_fail` check if ansible detects undefined variables when `error_on_undefined_vars` is enabled. These tests fail without "Improve behavior with error_on_undefined_vars enabled" patch. Tests `test_playbook_undefined_varsX_ignore` check if ansible ignores undefined variables when `error_on_undefined_vars` is disabled. Also modify PlayBook._run_task_internal() so error_on_undefined_vars is testable.	11 years ago
Petr Svoboda	fff4f1da33	Improve behavior with error_on_undefined_vars enabled Pass fail_on_undefined flag to recursive calls to `template` function, so more undefined variables are detected. Works only for Jinja style variables. Undefined legacy variables are never detected.	11 years ago
Brian Harring	31061213fa	Fix inconsistency in hostvars access. Previously, hostvars would only expose a keys() list of hosts that had been seen yet- however you could explicitly access the host if you knew the name, and get the content that way. This precludes template code from being able to safely access information about other hosts if any limiters/tags were in use. Additionally, the object was inconsistent for hostvars['myhost'] access and [x[1] for x in hostvars.items() if x[0] == 'myhost'] access; this is due to the original derivation from the dict object. .items() would be handled by dict.items(), using the passed in setup_cache values without using the actual lookup content. This patch rebases the class implementation to a py2.6 dictmixin, fixing those issues and restoring behaviour to match what the docs claim.	11 years ago
Brian Harring	902183ac0e	Enforce alphanumeric ordering for plugins grabbed via glob. If this isn't done, it's left to directory ordering which can result in indeterminent behaviour.	11 years ago
James Cammarata	39628d012d	Minor fix to ipv6 detection for inventory with -i For link-local addresses, it is sometimes necessary to append the interface to use for the ipv6 address. This patch extends the ipv6 regex to allow for '%ifnameX' at the end. See https://bugzilla.redhat.com/show_bug.cgi?id=136852 for more info	11 years ago
Michael Scherer	3aac187387	fix ssh connection plugin to work with ipv6 address Due to various inconsistencies of ssh and sftp regarding ipv6 and ipv4 handling, some special arguments must be passed, and the ipv6 must be passed in a specific format.	11 years ago
Michael Scherer	c9d28e10ad	add support for using a ipv6 in -i testing with a ipv6 : ansible -u misc -i '[2002::c23e]:22,' '*' -m ping fail due to parsing of ':' as a separator of port/ip with ipv4. This commit add support for properly parsing 2002::c23 and the bracket notation [2002::ce]:2222	11 years ago
Matt Saunders	9fd1b174f5	Fixed tiny bug with _meta handling in external inventory scripts	11 years ago
James Cammarata	5847720746	Fixing a small bug with the new role dependency feature The block that added the original list of roles was indented too far, and was only being reached if a role had dependencies. This resulted in roles without dependencies from being added to the list of roles. Credit goes to looped for reporting and diagnosing the issue.	11 years ago
Michael DeHaan	42648e2f0a	Merge branch 'role_dependencies' of git://github.com/jimi1283/ansible into jimi1283-role_dependencies	11 years ago
Michael DeHaan	dacd311474	Removing synchronize momentarily as it looks like this won't make 1.3 dates	11 years ago
James Cammarata	d8a7a2d1b2	Adding evaluation of role vars as the dep tree is built This allows variables to be inserted into the role scope specifically while also being inserted into the global scope.	11 years ago
James Cammarata	e12b99dba6	Small cleanup, no need to call _get_role_path a second time	11 years ago
James Cammarata	9a401e73a6	Adding support for role dependencies. Fixes #3686 Dependencies are enabled by adding a new directory/file named meta/main.yml to the role. The format of the dependencies are: dependencies: - { role: foo, x: 1, y: 2 } - { role: bar, x: 3, y: 4 } ... Dependencies inherit variables as they are seen at the time of the dependency inclusion. For example, if foo(x=1, y=2) has a dependency on bar(x=3,z=4), then bar will have variables (x=3,y=2,z=4). Different roles can have dependencies on the same role, and this variable inheritence allows for the reuse of generic roles quite easily. For example: Role 'car' has the following dependencies: dependencies: - { role: wheel, n: 1 } - { role: wheel, n: 2 } - { role: wheel, n: 3 } - { role: wheel, n: 4 } Role 'wheel' has the following dependencies: dependencies: - { role: tire } - { role: brake } The role 'car' is then used as follows: - { role: car, type: honda } And tasks/main.yml in each role simply contains the following: - name: {{ type }} whatever {{ n }} command: echo '' TASK: [honda tire 1] TASK: [honda brake 1] TASK: [honda wheel 1] TASK: [honda tire 2] TASK: [honda brake 2] TASK: [honda wheel 2] TASK: [honda tire 3] TASK: [honda brake 3] TASK: [honda wheel 3] TASK: [honda tire 4] TASK: [honda brake 4] TASK: [honda wheel 4] TASK: [I'm a honda] <- (this is in roles/car/tasks/main.yml)	11 years ago
James Cammarata	ad595eadea	Enable error_on_undefined_vars by default	11 years ago
Luca Berruti	eee278e02b	fix	11 years ago
Luca Berruti	5048218ab5	Fix: with_items and complex_args	11 years ago
Serge van Ginderachter	173586b871	Ensure plugin_loader.all() only loads one instance by ensuring all basedirs, plugin paths and extra paths are handled as absolute paths and are checked to not add any doubles. This fixes the corner case where e.g. the user has an additional plugin path configured to a dir relative to his playbooks or inventory location, which also matches the _plugin subdir relative to one of the basedirs in the play. For most plugins this doesn't show as an obvious issue except for callback_plugins, which might fire more than once. Other plugins (inventory and template plugins) might unnecessarily be ran twice. e.g. ansible.cfg has callback_plugins = ./plays/callback_plugins and plays/ contains a playbook file: . ├── ansible.cfg ├── inventory └── plays ├── callback_plugins │ └── timestamp.py └── site.yml modified: lib/ansible/utils/plugins.py	11 years ago
Michael DeHaan	bc02e20503	Merge branch 'rsynctake2' into devel Conflicts: CHANGELOG.md	11 years ago
Michael DeHaan	17aa0d12de	Merge pull request #3814 from ftao/inventory_dir_abs fix inventory.basedir is not absolute path when hostfile is startswith "./"	11 years ago
Abhijit Menon-Sen	1a90d01ba9	Fix some typos discovered during casual reading	11 years ago
ftao	51a180b150	fix inventory.basedir is not absolute path when hostfile is startswith "./"	11 years ago
Michael DeHaan	f8c97d6e79	Style/docs cleanup, and also improve an error message.	11 years ago
Michael DeHaan	aeb8649da5	Merge branch 'ansible-rsync-take2' of git://github.com/tima/ansible into rsynctake2	11 years ago
Michael DeHaan	4d1f447908	Merge pull request #3650 from bcoca/forking_optimizations forking least possible	11 years ago
Michael DeHaan	baffa8df72	These fields are booleans.	11 years ago
Michael DeHaan	633abca916	Merge branch 'nocolor' of git://github.com/amenonsen/ansible into devel	11 years ago
Michael DeHaan	ee11d69697	Merge branch 'better_ini_errors2' of git://github.com/bcoca/ansible into devel	11 years ago
Michael Vogt	89bc43cab0	support i18n on sudo failure	11 years ago
Serge van Ginderachter	9991a530ab	fix an encoding bug in copy content = lookup plugin closes #3518	11 years ago
Michael DeHaan	66b29b6813	Merge branch 'feature/gh-3789-inventory-file' of https://github.com/resmo/ansible into devel	11 years ago
Michael DeHaan	1d13ec2da3	Construct the multiprocessing manager only once.	11 years ago
René Moser	e8272e365d	implemented 'inventory_file' variable. Closes GH-3789.	11 years ago
Timothy Appnel	2288a11b6a	Implemented setup method in rsync action module.	11 years ago
Timothy Appnel	4a9635e04e	Straighten out local-remote-delegate logic in rsync action module. Force set delegate to local if one is not defined.	11 years ago
Timothy Appnel	adbca9d251	Fixed identity key logic.	11 years ago
Timothy Appnel	9f170f579a	Introduced ansible-rsync to core.	11 years ago
James Cammarata	ceff3b6ba3	Minor modification to set_fact with_items patch Previous patch was reverted due to the fact that there was an issue with the results not always being a dictionary (they're sometimes a unicode string, ie. when the with_items is used with yum). This minor change corrects that by checking for a dict object.	11 years ago
James Cammarata	8be2fc745b	Revert "Check for ansible_facts in results for with_ tasks" This reverts commit `1a4e6e415e`.	11 years ago
Serge van Ginderachter	1a4e6e415e	Check for ansible_facts in results for with_ tasks that loop over a lookup plugin. Fixes #3704 and #3735	11 years ago
Serge van Ginderachter	40e60c947d	Host specifiers should be sorted to ensure consistent behavior, hosts should look like this: hosts: webservers:&boston:!rack42 So when applying the host selectors, run those without the "&" first, then the &s, then the !s. Closes #3500	11 years ago
Abhijit Menon-Sen	0c96d8af6e	Add a nocolor setting to ansible.cfg	11 years ago
Brian Coca	a937a6a66d	now bad ini entries will throw friendlier error Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	11 years ago
Michael DeHaan	4cbfe3be57	Merge pull request #3773 from cchurch/devel Update callbacks used for async tasks	11 years ago
Michael DeHaan	ff44c981e9	Merge pull request #3770 from rishid/devel Add support for INI comments that begin with '#' or ';'	11 years ago
Michael DeHaan	99775176ff	Merge pull request #3623 from ralph-tice/fix_3567_2 changed role path template to read all vars instead of just extra_vars	11 years ago
Chris Church	6ba4331161	Correctly check for failed status from an async task. Use runner_on_async_failed callback (instead of runner_on_failed) when an async task times out. Add runner_on_async_ok callback when a task is started in fire and forget mode.	11 years ago
rishid	d18c90ed8f	Add support for INI comments that begin with '#' or ';' Ini file format does not have a standard but ';' is used more often than '#' for comments	11 years ago
Michael DeHaan	56a00e0667	Remove dead code.	11 years ago
Michael DeHaan	8955ac1eda	If the result of a dynamic inventory script contains a "_meta" hash at top level and the _meta hash contains a "hostvars", don't call --host hostname for any elements and just serve them directly for performance enhancements with the external inventory script and a large number of hosts.	11 years ago
Michael DeHaan	1c6b81233c	Merge pull request #3692 from tima/action-init Added support of an optional init method for action modules like rsync that need to alter the connection and other inject data before it's established.	11 years ago
Michael DeHaan	dec43f7a2b	PEP8 indent fix.	11 years ago
Michael DeHaan	3dbe65def2	PEP8 indent fix	11 years ago
Michael DeHaan	76fd769704	Merge pull request #3685 from mspaulding06/indexed_items Indexed items lookup plugin	11 years ago
Michael DeHaan	c0ab417ef9	Don't iterate across strings in with_nested.	11 years ago
James Cammarata	82c806979b	Only use LOG_LOCK in log_flock if a runner is not specified Fixes issue #3466 - When ansible can't authenticate against a host, and your answer is no, ansible crash.	11 years ago
James Cammarata	ba38d6bc16	Adding support for hashed known_hosts entries Fixes Issue #3716 - SSH known host checking needs to understand hashed known hosts	11 years ago
Brian Coca	581a0c9f59	now correctly 'types' value pairs that are passed as options to jinja override Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	11 years ago
Michael DeHaan	0335d05f43	Check against None around playbook basedir	11 years ago
Michael DeHaan	bdef7f1774	Merge pull request #3711 from ashorin/devel Allow --diff on UTF-8 encoded files and templates	11 years ago
Michael DeHaan	44d060628e	Merge pull request #3706 from lorin/sudo_user_breakage Fix sudo_user copy error	11 years ago
Michael DeHaan	daf5ecc7c9	Merge pull request #3684 from stoned/fix-3668 Add extra module path early during playbook parsing.	11 years ago
Michael DeHaan	83481b32cc	Merge pull request #3657 from zqad/devel Fix playbook-local host_vars when running from .	11 years ago
Michael DeHaan	3ebbb56479	Merge pull request #3654 from MaxIV-KitsControls/devel Fix nested loop for more than 3 elements	11 years ago
Michael DeHaan	7813290969	Merge pull request #3645 from stoned/stringify-conditional-2 stringify conditional before handing it to Jinja2 for evaluation.	11 years ago
Andrey Shorin	664215eb02	Allow --diff on UTF-8 encoded files and templates	11 years ago
Lorin Hochstein	a303fca193	Fix sudo_user copy regression Treat errno 13 (permission denied) as one of the special cases in atomic_move. This type of error can occur because of sudo'ing to non-root user. Fixes #3705	12 years ago
Timothy Appnel	11beb38c66	Added support of an optional setup method for action modules like rsync that need to alter the connection and other inject data before it's established.	12 years ago
Matt Spaulding	5d15515bbf	Add indexed_items lookup plugin	12 years ago
Stoned Elipot	841093921b	Add extra module path early during playbook parsing. This should fix issue #3668 Also prevent an extra module path to be added multiple times.	12 years ago
Jonas Eriksson	16efb45735	Fix playbook-local host_vars when running from . Since ansible 1.2, it became possible to place a host_vars directory in the same directory as a playbook, making it possible to keep host_vars local to that playbook there. However, due to python's os.path.dirname, a action such as: $ ansible-playbook pb.yml ..would not pick up the host_vars as os.path.dirname("pb.yml") returns "", unlike the unix command dirname that would return ".". Substituting "pb.yml" on the command line with "./pb.yml" would do the trick, but is not always intuitive. This patch solves the problem until python solves issue18547 [1]. [1] http://bugs.python.org/issue18547	12 years ago
Vincent Hardion	09ef7751e1	Fix nested loop for more than 3 elements - combine flatten list for each nested level instead once at the end	12 years ago
Brian Coca	576962d335	now if you set fork to 0 or a number higher than the number of hosts, it will be readjusted to the number of hosts runner is going to deal with. Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	12 years ago
Stoned Elipot	a1503c4d59	stringify conditional before handing it to Jinja2 for evaluation. This should fix simple conditionals like: when: ansible_selinux While here add tests for ansible.utils.check_conditional() in "jinja2_compare mode".	12 years ago
WAKAYAMA Shirou	0ce99e391f	fix: if a path is symlink and trying to chmod, OSError Exception will be raised.	12 years ago
Michael DeHaan	f0eafff1b4	Merge pull request #3621 from sergevanginderachter/rename2flattened also rename plugin name in error message	12 years ago
Ralph Tice	2383a8205c	changed role path template to read all vars instead of just extra_vars	12 years ago
Serge van Ginderachter	b40295910d	also rename plugin name in error message	12 years ago
Michael DeHaan	2fe25f19dc	Fix to group_by module as a result of previous conditional upgrades.	12 years ago
Michael DeHaan	e3f213e030	Fixup error reporting.	12 years ago
Michael DeHaan	c07dd07767	Add raw copy support (raw=yes), tweak tempfile error message string.	12 years ago
Michael DeHaan	0cf5e5cec3	Merge branch 'devel' of git://github.com/bradleyy/ansible into together	12 years ago
Michael DeHaan	0756aa406a	Change conditional operation workflow. Conflicts: lib/ansible/utils/__init__.py	12 years ago
Michael DeHaan	7f462a346a	Work in progress on merging changed_when.	12 years ago
Michael DeHaan	88720516a1	Merge branch 'changed_when' of git://github.com/stoned/ansible into changed_when	12 years ago
Michael DeHaan	f592340f7f	Merge branch 'playbook-skip-tags' of git://github.com/dekked/ansible into skip_tags	12 years ago
Michael DeHaan	3baa55a314	Merge branch 'devel' of git://github.com/sjmudd/ansible into sjmudd_ranges	12 years ago
Michael DeHaan	62b39d3de5	Fix for saving conditionals in variable expressions.	12 years ago
Michael DeHaan	bf70dfc1a0	When a role/include has a conditional, add that conditional ahead of any on the task, not behind, so it can short circuit.	12 years ago
Michael DeHaan	419661542b	Added some pipes.quote ops to make sure paths with spaces in them are ok.	12 years ago
Michael DeHaan	192d9f8b89	Merge pull request #3607 from stoned/use-AnsibleFilterError Use AnsibleFilterError exception	12 years ago

1 2 3 4 5 ...

1868 Commits (c093bd4f4f343a74d3a424a6a078e2718234da98)