Commit Graph

43812 Commits (bb61d7527f48e61ff04d56c2678b5283f38c704a)
 

Author SHA1 Message Date
Chris Keller ffa014e680 Adding ovirt_event Module (#51760) (#52982)
* Adding ovirt_event Module (#51760)

* Update lib/ansible/modules/cloud/ovirt/ovirt_event.py

Co-Authored-By: nasx <ckeller@redhat.com>

* Update lib/ansible/modules/cloud/ovirt/ovirt_event.py

Co-Authored-By: nasx <ckeller@redhat.com>

* Update lib/ansible/modules/cloud/ovirt/ovirt_event.py

Co-Authored-By: nasx <ckeller@redhat.com>

* Update lib/ansible/modules/cloud/ovirt/ovirt_event.py

Co-Authored-By: nasx <ckeller@redhat.com>

* Update lib/ansible/modules/cloud/ovirt/ovirt_event.py

Co-Authored-By: nasx <ckeller@redhat.com>

* Update lib/ansible/modules/cloud/ovirt/ovirt_event.py

Co-Authored-By: nasx <ckeller@redhat.com>

* Cleaning up Copyright, Documentation and Examples section per Akasurde.

* Minor formatting change in examples
6 years ago
Glandos d784b77cb4 Remove dependency to psycopg2 with dump/restore (#53323)
* Remove dependency to psycopg2 with dump/restore

'dump' and 'restore' state only need pg_dump and pg_restore. These tools
don't use psycopg2 so this change tries to avoid the use of it in these
cases.

The db_exists test was replaced with an error detection when piping to
compression program, using a FIFO file. This effectively reverts #39483,
that was a fix for #39412.

* Fix typo

* Add changelog fragment

* Add note for dump and restore not requiring psycopg2

* Fix YAML syntax

* Update lib/ansible/modules/database/postgresql/postgresql_db.py

Co-Authored-By: Glandos <bugs-github@antipoul.fr>
6 years ago
Mariusz Mazur c2699e2a57 kubevirt: add kubevirt_pvc module with CDI support (#53327) 6 years ago
Ondra Machacek 272fa9ead4 kubevirt: Simplify VM parameters (#53340) 6 years ago
Sam Doran a4b2ce5e13
Add test to ordered integration tests to exercise shuffle code path (#53138)
This is meant to exercise the code path not test for randomness, though it somewhat does that.
6 years ago
Chris Archibald dbcfb3d0fe Update to na_ontap_firewall_policy (#51976)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Fix issue and unit tests

* update to firewall

* fix import issues

* Revert "Revert "changes to clusteR""

This reverts commit 2713c75f31.

* fix docs

* stop pylint on unicode line, line can only be run in python2

* Review comment

* add pylint skip

* add pylint skip
6 years ago
Chris Van Heuveln 591e0ffb69 nxos_user: auth.yaml test: stronger test password needed (#53533)
Basic passwords are rejected by the nxos device unless `no password strength-check`
is configured. This change just makes the password meet the minimum strength checks.
6 years ago
Chris Van Heuveln c5de2233d0 nxos_pim_rp_address: N7K sanity test fix when removing rp w/pfx-list (#53556)
The N7K is another platform that raises an error when trying to remove
an RP w/prefix-list specified. These tests are now skipped for N7K.
6 years ago
Chris Van Heuveln c1e9f594d2 nxos_ospf_vrf: sanity.yaml test: fix timer_throttle_lsa_hold (#53561)
* The test was setting `lsa max` value to 2222 but the default `lsa hold` value is 5000.

* `hold` must be less than `max` or else the device raises a clierror, so I just added a lower non-default `hold` value to satisfy the cli.
6 years ago
Matthew Butch cd5c64c818 FreeIPA: Fix ipa_user password option (#48453)
Maintain idempotency in ipa_user while user update.
6 years ago
Rhys Campbell 8d00ccf60f Change listDatabases exception handling (#53605) 6 years ago
Felix Fontein 3117900b1e docker_container: show warnings, fix/improve tests (#53440)
* Output warnings from docker daemon on container create and update.

* Accept warning for blkio_weight instead of idempotency.

* Value quoting.

* Avoid loop variable conflict.

* Add changelog.

* Make one test case faster.

* Add 'Docker warning: ' prefix.

* Add a generalized warning reporting function.
6 years ago
Hannes Ljungberg 7bb174214c docker_swarm_service: Add option rollback_config (#53594)
* Add rollback_config

* Add change log fragment

* Fix broken test

* Actually fix broken tests

* Add rollback_config example

* Default rollback_config as None

* Abort early if rollback_config does not exist
6 years ago
mtward 73ba6a9bc8 VMware: return failure when shutdownguest fails with timeout (#52952)
If the state_change_timeout was exceeded in shutdownguest, there was no failure.  This adds a failure in that case.
6 years ago
Zim Kalinowski 9413a6c3f1 proper approach to query paged resources (#53500)
* proper approach to query paged resources

* fixed pep8

* removed unnecessary check
6 years ago
Trishna Guha a41028244d
Add platform facts in network facts modules (#51434)
* Add platform facts in network facts modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add vyos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add iosxr

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add junos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix pep8

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update unit test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix vyos_facts unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix ios_facts unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix iosxr unittests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix junos test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
6 years ago
Nilashish Chakraborty 5cd7bf39dd
Update frr_facts (#53439)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
6 years ago
Chris Van Heuveln b678139e68 nxos_igmp_interface: argument_spec for oif_ps breaks when 'default' (#53136)
The `oif_ps` attr expects a list of dicts but it also supports keyword 'default'.
When the playbook specifies `oif_ps: default` the `nxos_igmp_interface` module fails:

```
"msg": "Elements value for option oif_ps is of type <type 'str'> and we were unable to convert to dict: dictionary requested, could not parse JSON or key=value"
```

This test used to work afaik so I believe `AnsibleModule` may have changed at some point to enforce strict type checking, causing this failure. I did not see another way to handle both list & str types for the same attr so I just set it to `raw`.

`nxos_igmp_interface/tests/common/sanity` now has 100% pass rate.
6 years ago
Bojan Vitnik e775434a52 XenServer: Documentation improvements and fixes for XenServer related modules (#53498)
- More info added to module docs.
 - Fixed errors and typos in module docs.
 - Added parameter types to module docs.
 - Some error messages are fixed and/or changed to be more helpful.
 - Some code comments changed and added.
 - Updated unit tests that test changed error messages.
 - Improved module examples.
 - Improved docs for custom_params xenserver_guest module parameter
6 years ago
Jordan Borean acf3e73250
win_chocolatey: Fix up validate_certs default value (#53614) 6 years ago
Jordan Borean 830a11dd38
test: optimize win_psmodule tests (#53431) 6 years ago
Hannes Ljungberg 57f706e5a0 docker_swarm_service: Extend mount options (#53559)
* Add mount options

* Remove mount readonly default

* Fix driver_config test

* Add documentation

* Add changelog fragment

* Properly indent tmpfs_ options

* Use correct service suffix for mount tests

* Check for None value on tmpfs usage check

* Document change of mounts.readonly return key

* Use correct change log type

* Really use correct change log type

* Revert changing mount.readonly to read_only
6 years ago
Felix Fontein c75da35595 Removing a swarm node does not work with docker-py < 2.4.0, since it calls client.inspect_node(). (#53565)
For the same reason, docker_node requires docker >= 2.4.0.
6 years ago
Mahesh Paolini-Subramanya be7b8dc047 Update elb_target_group.py (#52882)
* Update elb_target_group.py

`successful_response_codes` only gets set when the `health_check_protocol` parameter is set
6 years ago
Matt Clay 5134ba95ca
Fix conditionals integration test. (#53583)
* Fix inventory for conditionals test.
* Remove extra groups from conditionals test.
6 years ago
Matt Clay 6588df505c Improve display of test timeout message. 6 years ago
Matt Clay 2c59d88154 Fix yamllint issue. 6 years ago
Matt Clay 0c4785720d Add extensions to changelog fragments. 6 years ago
Matt Clay 40318b49b2 Check extensions on changelog fragments. 6 years ago
Matt Clay 37bfa92076 Disable DevTest Labs tests. 6 years ago
Matt Clay 5c866fc17e Move fragment to correct location. 6 years ago
Adam Miller 7b98ff6a31 fix pkg name nevra parsing regex in dnf (#53572) 6 years ago
Matt Clay 9546761407 Fix coverage stub generation in CI. 6 years ago
Matt Clay 8fe9eb7b92 Show invalid coverage paths with verbosity > 1. 6 years ago
Simon Dodsley 54293fed3c Update purefa_facts module to support NVMe and preferred arrays (#53567) 6 years ago
Simon Dodsley 679e75189b Update purefa_ds to support new directory services format (#52865)
* Update purefa_facts to collect admin accounts

* Update purefa_ds to support new Directory Services format
from Purity 5.2.0
6 years ago
Simon Dodsley 8062b9c0f3 Update purefa_facts to collect admin accounts (#52856) 6 years ago
Matt Clay 7c0bc9e4ac Fix no-assert code-smell regex. 6 years ago
Jason Witkowski be39e757e3 apply node_id parameter to swarm node removal (#53503) 6 years ago
Matt Martz 414440e323
Allow dict2items to work with hostvars (#53538) 6 years ago
Martin Krizek 4e39b9fe02 apt: clarify cache_valid_time (#53442) 6 years ago
Sebastian Meyer 3f97abc6e2 Add PyYAML to docs requirements.txt (#53521)
When building the docs in a virtualenv we need to install PyYAML in
addition to sphinx, otherwise the `import yaml` will fail.
6 years ago
dthvt a1457a6276 ec2_vpc_dhcp_option_facts - fix filters ref URL (#53468) 6 years ago
Sebastian Meyer 7a91c8e6ae Fix undefined label playbooks_reuse_includes warn (#53522)
e1687e05a6 introduced additional
seealsos to playbooks_reuse_includes, but the label has to be _above_
the section heading for them to work.
6 years ago
ndswartz 26d87a912b Added eseries base with tests (#49269) 6 years ago
Brian Coca 8940732b58
Configurable and parallel gather facts (#49399)
* Configurable list of facts modules (#31783)

 - allow for args dict for specific modules
 - add way to pass parameters
 - avoid facts poluting test
 - move to 'facts gathered' flag
 - add 'gathering' setting tests
 - allow parallel option in case serialization is too slow
 - added support to automatically map network facts
   uses "smart" connection mapping
6 years ago
Brian Coca 90bcff3d92
allow nontype configdata (#53365) 6 years ago
Hannes Ljungberg 25a8e47783 Order options alphabetically (#53511) 6 years ago
Pierre-yves Fontaniere 1dba160d9d Adds SKU to properties returned by get_system_inventory (#53464) 6 years ago
Felix Fontein caf7fd2245 openssl_*: improve passphrase handling for private keys in PyOpenSSL (#53489)
* Raise OpenSSLBadPassphraseError if passphrase is wrong.

* Improve handling of passphrase errors.

Current behavior for modules is: if passphrase is wrong (or wrongly specified), fail.
Current behavior for openssl_privatekey is: if passphrase is worng (or wrongly specified), regenerate.

* Add changelog.

* Add tests.

* Adjustments for some versions of PyOpenSSL.

* Update lib/ansible/modules/crypto/openssl_certificate.py

Improve text.

Co-Authored-By: felixfontein <felix@fontein.de>
6 years ago