Sloane Hertel
da9edd7760
expect - fix argument spec error with timeout=null ( #82522 )
...
* Fix using timeout=null to wait indefinitely
* fix error message
10 months ago
Abhijeet Kasurde
a69fab86bc
ansible-test - remove Fedora 38 container and remote support
...
Fixes : #82022
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
10 months ago
Matt Clay
78c9090986
Don't hard-code Alpine version in container test
10 months ago
Brian Coca
596c75c2bc
uri action plugin check_mode support update ( #82484 )
...
Also updated base action messages to be more specific
10 months ago
Brian Coca
6c2895fd88
ansible-config dedupe ini plugin entries ( #82498 )
...
added test for ini file integrity, also ensuring no dupes
10 months ago
Harshvardhan Sharma
623e0eee42
Add Alp-Dolomite to Suse family list ( #82496 )
10 months ago
Abhijeet Kasurde
53ddc1648e
deb822_repository: handle idempotency ( #82483 )
...
* deb822_repository: handle idempotency
Sort the parameters in order to handle idempotency
Fixes : #82454
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
10 months ago
Felix Fontein
6c647aa263
Interpret double newlines as paragraph breaks in documentation strings. ( #82465 )
10 months ago
Sloane Hertel
caa86cc4df
Add the task info for tombstoned module/action plugins ( #82451 )
...
* Add the task info for tombstoned plugins
* Fix deprecation for 'include' by removing it from BUILTIN_TASKS which skip the plugin loader lookup
* changelog
remove obsolete unit test using 'include'
* Update changelogs/fragments/improve-tombstone-error.yml
10 months ago
Sloane Hertel
b5649f9686
Remove more Python 2 handling from tests ( #82449 )
10 months ago
Matt Clay
71a5212586
Add skips for encrypt unit tests for Python 3.13
10 months ago
Brian Coca
6e4a5acfbd
lineinfile, remove incorrect/unused 'others' option ( #82436 )
...
* move incorrect, unused 'others' option
this was to document 'file' options are usable .. but we already
import the file fragment to document those options.
* removed now bad ignore
10 months ago
Matt Clay
c75624fbdc
ansible-test - Enable shellcheck SC2164
10 months ago
Matt Clay
3c432fea43
ansible-test - Update base/default test containers
10 months ago
Matt Clay
a1958eefed
Fix plugin_loader integration test error handling
10 months ago
Matt Clay
630e5dda25
Clean up shellcheck issues in tests
10 months ago
Matt Clay
e1bcb8a534
Remove unused unit test code
10 months ago
Brian Coca
29b2405b84
Revert "Fix older external connection plugins without _sub_plugin declaration ( #79372 )" ( #82473 )
...
This reverts commit ef1e01aa8b
.
broken tests
10 months ago
J vanBemmel
ef1e01aa8b
Fix older external connection plugins without _sub_plugin declaration ( #79372 )
...
fixes https://github.com/ansible/ansible/issues/79371
* Check for sub=={} too
* Add a test case for older plugins that do not define '_sub_plugin'
* Add test for legacy plugins
10 months ago
Brian Coca
55065c0042
Role fixes ( #82339 )
...
* Various fixes to roles
- static property is now properly set
- role_names and other magic vars now have full list
- role public/private var loading is now done when adding to play.roles instead of on each var query
- added tests
Co-authored-by: Felix Fontein <felix@fontein.de>
10 months ago
Abhijeet Kasurde
fa92228b50
Replace unwelcoming words ( #82413 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
10 months ago
Brian Coca
4479c9df13
Fix plugin set option ( #82300 )
...
* plugin config, ensure set_option correctly casts
until now we relied on plugin author getting the right type, now
the config system itself will process as it would for set_options
10 months ago
Mark Chappell
5346009d2c
ansible-test - Allow multiple documents in the YAML stream for EXAMPLES ( #82355 )
...
* Allow multiple documents in the YAML stream for EXAMPLES.
* Add integration test
* linting
10 months ago
snipfoo
8328153121
Run all handlers with the same `listen` topic when notified from another handler ( #82364 )
...
Fixes #82363
10 months ago
Sloane Hertel
fe81164fe5
ansible-galaxy - fix exit code for failed role import ( #82193 )
11 months ago
Abhijeet Kasurde
7f2ad7eea6
assemble: fixed missing parameter error ( #82360 )
...
* content is an optional parameter for _get_diff_data API
Fixes : #82359
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Brian Coca
a9919dd7f6
lookups, make file searching use better is_role ( #82290 )
...
* lookups, make file searching use better is_role
The dwim function will internally try by detecting tasks/main['','.yml','.yaml]
but this is far from optimial, the existince of role path in vars is much better
indicator that we can use to pass a hint
* updated test to avoid main.yml
11 months ago
Danny Luwel
9b002d2e63
check if there attributes to set ( #78707 )
...
Fixes : #76727
11 months ago
Sviatoslav Sydorenko
dd0138ba21
🧪 Replace GitHub SVN integration test with local TLS ( #82334 )
...
* Run svn integration test locally with TLS
This patch uses a `trustme` to make an ephemeral CA, and server, and
client TLS artifacts for testing. These are integrated into the Apache
web server via it's `mod_ssl`.
Resolves #82207
* Replace GitHub SVN HTTPS URL w/ localhost over TLS
This change gets rid of the need to use GitHub, which is just about to
drop support for SVN [[1]]. Moreover, it eliminates the need to use
external network for any SVN commands in the test.
[1]: https://github.blog/2023-01-20-sunsetting-subversion-support/
11 months ago
Brian Coca
6ebefaceb6
Better errors for delegate_to ( #82319 )
...
Handle empty result of templating
Also skip work when we omit
11 months ago
Sloane Hertel
3a42a00368
Targeted fix for installing roles with symlinks containing '..' ( #82165 )
...
Set the tarfile attribute to a normalized value from unfrackpath instead
of validating path parts and omiting potentially invald parts
Allow tarfile paths/links containing '..', '$', '~' as long as the
normalized realpath is in the tarfile's role directory
11 months ago
Brian Coca
1dd0d6fad7
remote log info ( #81711 )
...
Both posix and powershell avenues updated to allow for customized string logging on remote
Co-authored-by: Jordan Borean <jborean93@gmail.com>
11 months ago
Matt Clay
4208bdbbcd
ansible-test - Update nios-test-container to 3.0.0
11 months ago
Abhijeet Kasurde
265f5e724c
apt_repository: Do not convert symlink repo to a normal file ( #82271 )
...
* apt_repository: Do not convert symlink repo to a normal file
* module manually writes to repo files. If the file is a symlink
module used to re-write and convert a symlink to a normal file.
This fix tracks the symlink and keeps the changes intact.
Fixes : #49809
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Abhijeet Kasurde
e6e19e37f7
validate-modules: Check for correct values in choice ( #82266 )
...
* validate-modules: Check for correct values in choice
* validate-modules test now checks the length of choices and
correct option values inside the choice.
Fixes : #82179
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Fix sanity tests
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
---------
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Martin Krizek
afd45aca6a
ansible-test - remove rhel 9.2 test remote ( #82211 )
...
Fixes #82024
11 months ago
Sebbo94BY
e0bf76e3db
Issue #80267 : Remove user not found warning ( #80291 )
...
Co-authored-by: Sebi94nbg <sebastian.kraetzig@4g-server.eu>
11 months ago
Martin Krizek
d664f13b4a
Allow include_tasks handlers for searching role subdirs ( #82248 )
...
Fixes #82241
11 months ago
Chris Francy
a4b00793be
Update known_hosts module to better handle @cert-authority keys ( #70340 )
...
Signed-off-by: Chris Francy <zoredache@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Abhijeet Kasurde
ce9d268ab8
unarchive: force unarchive if the symlink target changes ( #82253 )
...
Fixes : #30420
Original PR from nrwahl2 (https://github.com/ansible/ansible/pull/30463 )
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Herman van Rink
d6a8df3218
csvfile - add a keycol parameter to specify in which column to search. ( #82242 )
11 months ago
Martin Krizek
c35e0e8fd8
Re-enable "group removal" integration test for dnf5 ( #82250 )
...
Fixed in https://github.com/rpm-software-management/dnf5/pull/1013
11 months ago
Abhijeet Kasurde
fbdb666411
ansible-test: Added Fedora 39 ( #82218 )
...
* Fedora 39 remote
* Fedora 39 container
Fixes : #82018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Abhijeet Kasurde
1a759659fe
Enable vendored copy of distutils in entry_point test ( #82232 )
...
* Enable use of vendored copy of distutils by removing
the environment variable SETUPTOOLS_USE_DISTUTILS
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Brian Coca
8b102dca4a
wait_for, fallback to read for non mmapable files ( #82064 )
...
* also handle oserror, added debug jic
11 months ago
Brian Coca
f6d7dd0840
displaly. log, handle when caplevel is already taken care of ( #82227 )
...
reneables ansible logging
11 months ago
Abhijeet Kasurde
f8cdec6324
ansible-test: Downgrade containerd for Fedora 39 ( #82231 )
...
* containerd 1.6.23 on Fedora 39 causes issue. Downgrading
to containered to 1.6.19-2 works.
* See: https://bugzilla.redhat.com/show_bug.cgi?id=2237396
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Abhijeet Kasurde
a45dc10b8f
ansible-test: Skip modularity test for Fedora 39 and up ( #82230 )
...
* Modularity is deprecated in Fedora 39 and onwards,
Skip modularity tests
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
11 months ago
Brian Coca
6e448edc63
no_log avoid masking booleans ( #82217 )
...
* no_log avoid masking booleans
* clog
* fix issues
11 months ago
Matt Martz
f42984eeb3
Fix ManifestControl dataclass to work with future annotations ( #82215 )
...
* Fix ManifestControl dataclass to work with future annotations
* Add tests
11 months ago
Brian Coca
3d9e5c8b9d
fix pc misuse ( #82157 )
...
use the more up to date 'task' as play_context only has the 'initial' values.
11 months ago
Brian Coca
8825e60add
ansible-pull: expand destinantion directoy to avoid purgin in / ( #82030 )
...
* expand destinantion directoy to avoid purgin in /
bad things could happen and help alone is not enough
11 months ago
Martin Krizek
0bab08ee33
ansible-test - Add RHEL 9.3 support ( #82178 )
...
Fixes #82020
11 months ago
Brian Coca
4a84a9b3db
copy keep suffix on temp file for validation ( #82158 )
...
Also updated test to require suffix
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
11 months ago
Martin Krizek
a8b6ef7e7c
flush_handlers: handle a failure in a nested block with force_handlers ( #81572 )
...
Fixes #81532
ci_complete
11 months ago
Dellucifer
f2b5c33349
fixed typos in the documentation ( #82077 )
12 months ago
Matt Clay
fd009a073a
Remove sefcontext support plugin
...
It was only used by the subversion test, but is no longer required.
12 months ago
Matt Clay
0e6942a4d7
Remove unused unit test code ( #82168 )
12 months ago
Abhijeet Kasurde
c5b68ef16d
Update Python3
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
12 months ago
Matt Clay
98407fc00e
Remove unused validate-modules unit test code
12 months ago
Matt Clay
dae4e2f07f
Remove unused/unreachable unit test code ( #82160 )
12 months ago
Matt Clay
0be33551d7
Remove unit tests dependent on systemd bindings ( #82161 )
...
These do no not run as part of our test suite.
12 months ago
Abhijeet Kasurde
78c16d983e
Remove type_regex testcase
...
This is leftover testcase for type checker regex removed in
https://github.com/ansible/ansible/pull/82153
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
12 months ago
Matt Clay
9dd3eafa14
ansible-test - Use pylint unidiomatic-typecheck
...
This replaces the regex based check previously used within the validate-modules sanity test.
NOTE: The pylint check overlaps with a similar check for pep8.
Both are used, since the pep8 based check is more nuanced than the one in pylint.
For example, allowing `is` checks, but not `==` comparisons.
If the pylint check is ignored, the pep8 check would still be relevant.
12 months ago
Martin Krizek
7538668731
Check strict before failing to respect skip_broken ( #80795 )
...
Fixes #80590
12 months ago
Matt Clay
916a20fccd
Ignore coverage of test code that does not run
12 months ago
JustinWayland
dec9eeb2e5
Remove create_new_password parameter in CLI.build_vault_ids ( #82066 )
...
* Remove unused argument in call to build_vault_ids
* Remove obsolete build_vault_ids tests
* Change tests to account for argument removal
* Remove redundant test
12 months ago
Brian Coca
20a54eb236
restore role param precedence ( #82106 )
...
* add test for setfact/param override
12 months ago
Matt Clay
ac3ae94ae1
Ignore coverage on code intended never to execute ( #82128 )
...
* Ignore coverage on code intended never to execute
* Fail collection loader test if wrong code runs
* Update boilerplate test to accommodate nocover
12 months ago
Matt Clay
1df791cd90
Ignore code which coverage can't analyze ( #82125 )
...
* Ignore code which coverage can't analyze
Our own tracing function can't be traced.
* Use `nocover` instead of `no cover` for consistency
12 months ago
Jordan Borean
f8a9fd4758
Remove duplicate winrm test ( #82124 )
12 months ago
Matt Clay
36d6860d80
ansible-test - Remove no-main-display sanity test
12 months ago
Matt Clay
6e15fb0ebf
ansible-test - Removed no-basestring sanity test
12 months ago
Matt Clay
c349b91af3
ansible-test - Removed no-dict-* sanity tests
12 months ago
Matt Clay
9765bb46f9
ansible-test - Remove no-unicode-literals test
12 months ago
Matt Clay
172a010dd7
Remove unused test support plugins
12 months ago
Matt Clay
5b1b0ce762
Remove Python 2 compat (via six) from unit tests
12 months ago
Matt Clay
18e8401edd
Remove Python 2.x compat from unit tests ( #82109 )
12 months ago
Matt Clay
89cda0bcae
pip - Add break_system_packages option ( #82097 )
12 months ago
Jordan Borean
f5a0c0dfc8
Ignore testing data for gitleaks ( #82083 )
1 year ago
Thomas Sjögren
fb8ede22e1
don't warn about using a yescrypt hash as user password ( #82071 )
...
* dont warn about using a yescrypt hash as password
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
* add changelog
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
* add yescrypt test
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
---------
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
1 year ago
Martin Krizek
fe94a99aa2
any_errors_fatal fixes ( #78680 )
...
Fixes #31543
Fixes #36308
Fixes #73246
Fixes #80981
Fixes #81533
ci_complete
1 year ago
Matt Clay
c827dc0dab
Remove obsolete requirements from prepare_http_tests
1 year ago
Brian Coca
99e0d25857
ansible-pull now handles all secret files CLI options ( #82009 )
...
* ansible-pull added missing pasthrough for secrets
Both become and connection password file options were missing.
Also added test
1 year ago
Brian Coca
9ee603d1c5
Clarify some points in config lookup documentation ( #81951 )
...
Also update tests to support the format on modules/plugins
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
1 year ago
Matt Clay
0b7387d46c
Improve filter_encryption test
...
- Update `data2_vaulted_string_with_id` to match the documented plaintext.
- Add a comment explaining how `data2_vaulted_string_with_id` was derived.
- Add assertions for unvaulted values to ensure they match their plaintext.
- Add round-trip tests for vault+unvault when no salt is used.
1 year ago
Matt Clay
2d2211e4e1
Simplify filter_encryption test ( #82062 )
1 year ago
Matt Davis
40263992df
remove args passthru on role runme tests that use grep ( #82060 )
...
* varying verbosity was masking some first-pass test failures
1 year ago
Brian Coca
b4566c18b3
Fix Jinja plugin deduplication ( #82002 )
...
for j2 plugins dedupe on path and not basename
for j2 this is a container file , for other plugins file name == plugin name
1 year ago
Matt Clay
e933d9d8a6
ansible-test - Fix parsing of cgroup entries
1 year ago
Matt Clay
09d943445c
Fix subversion integration test ( #82029 )
...
- Remove dependency on the htpasswd module (and thus passlib)
- Fix setup/teardown of the httpd process
- Fix cleanup of temporary directories
1 year ago
Matt Clay
37cee8bdfc
ansible-test - Remove special cryptography install ( #82008 )
...
Python 3.10 is the minimum version on the controller, and it requires openssl 1.1.1 or later.
As a result, there's no need to check the openssl version any longer.
1 year ago
Jordan Borean
22568305d6
Add ignore invalid options override for mod wrapper ( #81899 )
...
Adds an option that can have an action plugin tell the module to ignore
options that do not fit its arg spec. This is to enable support for core
running modules that exist outside of the collection that may not be new
enough to support some of the options supplied to it.
1 year ago
Matt Clay
4f04df75cc
Fix outdated S3 URLs ( #81964 )
...
We should always use the CloudFront backed endpoint (ci-files) not the direct S3 bucket reference (ansible-ci-files).
1 year ago
Matt Clay
f5c742cdfd
ansible-test - Clean up old Python 2 compat code ( #81962 )
...
* Update generated code __future__ import
* Remove Python 2.x compat from compile sanity test
* Remove __metaclass__ from pylint good names list
* Remove Python 2.x compat from ansible-test injector
* Remove Python 2.x compat from ansible-test importer
* Remove Python 2.x compat from ansible-test units
* Remove Python 2.x compat from validate-modules
* Remove Python 2.x compat from pylint plugins
* Remove more Python 2.x compat from ansible-test
* Remove Python 2.x openssl detection in ansible-test
* Remove obsolete Python 2.x comment
* Remove obsolete ansible-test Python 2.x support
* Remove unused bootstrap script functions
* Keep mypy happy
* Remove unused imports
* Keep pylint happy
1 year ago
Matt Clay
3f607359de
Remove obsolete compat code from integration tests ( #81961 )
...
Also fix up boilerplate for non .py extension files that contain Python code.
1 year ago
Matt Clay
9295bb5b5d
Unit test cleanup ( #81958 )
...
Remove obsolete Python 2.7 and 3.6 support code and fix up existing tests.
1 year ago
Matt Clay
fd0f48e99d
ansible-test - Update base/default containers ( #81957 )
1 year ago
Matt Davis
d8484f0af7
Update default test container Python to 3.12 and support for PyLint 3.0.1 ( #81953 )
...
* temporary PyLint plugin to mask 3.12 finalizer noise
* ansible-test - Default to Python 3.12 for base/default
* ansible-test - Update pylint requirements
* ansible-test - Remove obsoleted changelog entry
* Add changelog fragment for pylint work-around
1 year ago
Sviatoslav Sydorenko
d2ba76c117
Remove Python `< 3.5` `selectors` fallbacks ( #81872 )
1 year ago