Remove Python 2.x compat from unit tests (#82109)

pull/82110/head
Matt Clay 7 months ago committed by GitHub
parent bea459654a
commit 18e8401edd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -674,11 +674,6 @@ class PathMapper:
# Early classification that needs to occur before common classification belongs here.
if path.startswith('test/units/compat/'):
return {
'units': 'test/units/',
}
if dirname == '.azure-pipelines/commands':
test_map = {
'cloud.sh': 'integration:cloud/',

@ -245,7 +245,7 @@ def command_units(args: UnitsConfig) -> None:
#
# NOTE: This only affects use of pytest-mock.
# Collection unit tests may directly import mock, which will be provided by ansible-test when it installs requirements using pip.
# Although mock is available for ansible-core unit tests, they should import units.compat.mock instead.
# Although mock is available for ansible-core unit tests, they should import unittest.mock instead.
if str_to_version(python.version) < (3, 8):
config_name = 'legacy.ini'
else:

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from units.mock.loader import DictDataLoader

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import patch
from ansible.cli.console import ConsoleCLI

@ -40,7 +40,7 @@ from ansible.errors import AnsibleError
from ansible.module_utils.common.text.converters import to_bytes, to_native, to_text
from ansible.utils import context_objects as co
from ansible.utils.display import Display
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from units.mock.loader import DictDataLoader
from ansible import context

@ -21,7 +21,7 @@ from __future__ import annotations
import os
import pytest
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from units.mock.vault_helper import TextVaultSecret

@ -1,22 +0,0 @@
"""
Compatibility shim for mock imports in modules and module_utils.
This can be removed once support for Python 2.7 is dropped.
"""
from __future__ import annotations
try:
from unittest.mock import ( # pylint: disable=unused-import
call,
patch,
mock_open,
MagicMock,
Mock,
)
except ImportError:
from mock import (
call,
patch,
mock_open,
MagicMock,
Mock,
)

@ -1,27 +0,0 @@
# (c) 2014, Toshio Kuratomi <tkuratomi@ansible.com>
#
# This file is part of Ansible
#
# Ansible is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Ansible is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
from __future__ import annotations
# Allow wildcard import because we really do want to import all of
# unittests's symbols into this compat shim
# pylint: disable=wildcard-import,unused-wildcard-import
from unittest import *
if not hasattr(TestCase, 'assertRaisesRegex'):
# added in Python 3.2
TestCase.assertRaisesRegex = TestCase.assertRaisesRegexp

@ -18,7 +18,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import mock_open, patch
from ansible.errors import AnsibleError
from ansible.parsing.yaml.objects import AnsibleBaseYAMLObject

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from ansible.executor.play_iterator import HostState, PlayIterator, IteratingStates, FailedStates

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import MagicMock
from ansible.executor.playbook_executor import PlaybookExecutor

@ -19,7 +19,7 @@ from __future__ import annotations
from unittest import mock
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from ansible.errors import AnsibleError
from ansible.executor.task_executor import TaskExecutor, remove_omit

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import MagicMock
from ansible.executor.task_queue_manager import TaskQueueManager

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from ansible.executor.task_result import TaskResult

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.inventory.group import Group
from ansible.inventory.host import Host

@ -21,7 +21,7 @@ from __future__ import annotations
import pickle
from units.compat import unittest
import unittest
from ansible.inventory.group import Group
from ansible.inventory.host import Host

@ -23,7 +23,7 @@ import json
from contextlib import contextmanager
from io import BytesIO, StringIO
from units.compat import unittest
import unittest
from ansible.module_utils.six import PY3
from ansible.module_utils.common.text.converters import to_bytes

@ -11,7 +11,7 @@ import os
import pytest
from units.compat.mock import MagicMock
from unittest.mock import MagicMock
from ansible.module_utils import basic
from ansible.module_utils.api import basic_auth_argument_spec, rate_limit_argument_spec, retry_argument_spec
from ansible.module_utils.common import warnings

@ -8,7 +8,7 @@ from __future__ import annotations
from units.mock.procenv import ModuleTestCase
from units.compat.mock import patch, MagicMock
from unittest.mock import patch, MagicMock
from ansible.module_utils.six.moves import builtins
realimport = builtins.__import__

@ -8,7 +8,7 @@ from __future__ import annotations
from units.mock.procenv import ModuleTestCase
from units.compat.mock import patch
from unittest.mock import patch
from ansible.module_utils.six.moves import builtins
realimport = builtins.__import__

@ -18,7 +18,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.module_utils.basic import heuristic_log_sanitize

@ -10,7 +10,7 @@ import sys
from units.mock.procenv import ModuleTestCase
from units.compat.mock import patch
from unittest.mock import patch
from ansible.module_utils.six.moves import builtins
realimport = builtins.__import__

@ -5,7 +5,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.module_utils.basic import remove_values
from ansible.module_utils.common.parameters import _return_datastructure_name

@ -8,7 +8,7 @@ from __future__ import annotations
import pytest
from units.compat.mock import patch
from unittest.mock import patch
from ansible.module_utils.six.moves import builtins

@ -10,7 +10,7 @@ import errno
import json
import pytest
from units.compat.mock import mock_open, patch
from unittest.mock import mock_open, patch
from ansible.module_utils import basic
from ansible.module_utils.common.text.converters import to_bytes

@ -8,7 +8,7 @@ import json
import os
import tempfile
from units.compat.mock import patch
from unittest.mock import patch
from ansible.module_utils.common.text.converters import to_bytes
from ansible.module_utils import basic

@ -11,7 +11,7 @@ import tempfile
import pytest
from units.compat.mock import patch, MagicMock
from unittest.mock import patch, MagicMock
from ansible.module_utils.common.text.converters import to_bytes
from ansible.module_utils import basic

@ -4,7 +4,7 @@
from __future__ import annotations
from units.compat.mock import MagicMock
from unittest.mock import MagicMock
from ansible.module_utils.common.locale import get_best_parsable_locale

@ -8,7 +8,7 @@ from __future__ import annotations
import pytest
from units.compat.mock import patch
from unittest.mock import patch
from ansible.module_utils.six.moves import builtins

@ -17,8 +17,8 @@
from __future__ import annotations
from units.compat import unittest
from units.compat.mock import Mock, patch
import unittest
from unittest.mock import Mock, patch
class BaseFactsTest(unittest.TestCase):

@ -17,8 +17,8 @@ from __future__ import annotations
import os
from units.compat import unittest
from units.compat.mock import Mock, patch
import unittest
from unittest.mock import Mock, patch
from ansible.module_utils.facts import timeout

@ -5,7 +5,7 @@
from __future__ import annotations
from ansible.module_utils.facts.network import fc_wwn
from units.compat.mock import Mock
from unittest.mock import Mock
# AIX lsdev

@ -16,8 +16,8 @@
from __future__ import annotations
from units.compat.mock import Mock
from units.compat import unittest
from unittest.mock import Mock
import unittest
from ansible.module_utils.facts.network import generic_bsd

@ -5,7 +5,7 @@
from __future__ import annotations
from ansible.module_utils.facts.network import iscsi
from units.compat.mock import Mock
from unittest.mock import Mock
# AIX # lsattr -E -l iscsi0

@ -18,8 +18,8 @@
from __future__ import annotations
from units.compat.mock import Mock
from units.compat import unittest
from unittest.mock import Mock
import unittest
from ansible.module_utils.facts.network import linux
# ip -4 route show table local

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat.mock import Mock, patch
from unittest.mock import Mock, patch
from .. base import BaseFactsTest

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat.mock import Mock, patch
from unittest.mock import Mock, patch
from .. base import BaseFactsTest

@ -7,7 +7,7 @@ from __future__ import annotations
import pytest
from units.compat.mock import Mock
from unittest.mock import Mock
@pytest.fixture

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat.mock import Mock, patch
from unittest.mock import Mock, patch
from .. base import BaseFactsTest

@ -18,8 +18,8 @@
from __future__ import annotations
# for testing
from units.compat import unittest
from units.compat.mock import Mock, patch
import unittest
from unittest.mock import Mock, patch
from ansible.module_utils.facts import collector
from ansible.module_utils.facts import ansible_collector

@ -22,7 +22,7 @@ from collections import defaultdict
import pprint
# for testing
from units.compat import unittest
import unittest
from ansible.module_utils.facts import collector

@ -19,7 +19,7 @@ from __future__ import annotations
import pytest
from units.compat.mock import Mock, patch
from unittest.mock import Mock, patch
from . base import BaseFactsTest

@ -23,8 +23,8 @@ import os
import pytest
# for testing
from units.compat import unittest
from units.compat.mock import Mock, patch
import unittest
from unittest.mock import Mock, patch
from ansible.module_utils import facts
from ansible.module_utils.facts import hardware

@ -19,8 +19,8 @@
from __future__ import annotations
# for testing
from units.compat import unittest
from units.compat.mock import MagicMock
import unittest
from unittest.mock import MagicMock
from ansible.module_utils.facts.sysctl import get_sysctl

@ -15,8 +15,8 @@
from __future__ import annotations
from units.compat import unittest
from units.compat.mock import patch
import unittest
from unittest.mock import patch
from ansible.module_utils.facts import utils

@ -18,7 +18,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.module_utils.json_utils import _filter_non_json_lines

@ -14,7 +14,7 @@ from ansible.module_utils.urls import (Request, open_url, cookiejar,
from ansible.module_utils.urls import HTTPRedirectHandler
import pytest
from units.compat.mock import call
from unittest.mock import call
import ssl

@ -14,7 +14,7 @@ from http.cookiejar import Cookie
from ansible.module_utils.urls import fetch_url, ConnectionError
import pytest
from units.compat.mock import MagicMock
from unittest.mock import MagicMock
class AnsibleModuleExit(Exception):

@ -2,8 +2,8 @@ from __future__ import annotations
import collections
from units.compat.mock import Mock
from units.compat import unittest
from unittest.mock import Mock
import unittest
from ansible.modules.apt import (
expand_pkgspec_from_fnmatches,

@ -2,8 +2,8 @@ from __future__ import annotations
import os
from units.compat.mock import patch, Mock
from units.compat import unittest
from unittest.mock import patch, Mock
import unittest
from ansible.modules import apt_key

@ -4,7 +4,7 @@ import os
import shutil
import tempfile
from units.compat.mock import patch, MagicMock, mock_open
from unittest.mock import patch, MagicMock, mock_open
from ansible.module_utils.common._utils import get_all_subclasses
from ansible.modules import hostname
from units.modules.utils import ModuleTestCase, set_module_args

@ -1,6 +1,6 @@
from __future__ import annotations
from units.compat.mock import patch
from unittest.mock import patch
from ansible.module_utils import basic
from ansible.modules import iptables
from units.modules.utils import AnsibleExitJson, AnsibleFailJson, ModuleTestCase, set_module_args

@ -4,7 +4,7 @@ import os
import tempfile
from ansible.module_utils import basic
from units.compat import unittest
import unittest
from ansible.module_utils.common.text.converters import to_bytes
from ansible.module_utils.basic import AnsibleModule

@ -4,8 +4,8 @@
from __future__ import annotations
from units.compat import unittest
from units.compat.mock import patch
import unittest
from unittest.mock import patch
from ansible.module_utils import basic
from ansible.modules.service_facts import AIXScanService

@ -1,6 +1,6 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.modules.systemd import parse_systemctl_show

@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.modules.yum import YumModule

@ -2,8 +2,8 @@ from __future__ import annotations
import json
from units.compat import unittest
from units.compat.mock import patch
import unittest
from unittest.mock import patch
from ansible.module_utils import basic
from ansible.module_utils.common.text.converters import to_bytes

@ -19,7 +19,7 @@ from __future__ import annotations
import os
from units.compat import unittest
import unittest
from unittest.mock import patch, mock_open
from ansible.errors import AnsibleParserError, yaml_strings, AnsibleFileNotFound
from ansible.parsing.vault import AnsibleVaultError

@ -18,7 +18,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.parsing.utils.jsonify import jsonify

@ -26,7 +26,7 @@ import tempfile
from binascii import hexlify
import pytest
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from ansible import errors

@ -24,7 +24,7 @@ from io import BytesIO, StringIO
import pytest
from units.compat import unittest
import unittest
from unittest.mock import patch
from ansible import errors

@ -20,7 +20,7 @@ import io
from jinja2.exceptions import UndefinedError
from units.compat import unittest
import unittest
from ansible.parsing import vault
from ansible.parsing.yaml import dumper, objects
from ansible.parsing.yaml.loader import AnsibleLoader

@ -21,7 +21,7 @@ from __future__ import annotations
from collections.abc import Sequence, Set, Mapping
from io import StringIO
from units.compat import unittest
import unittest
from ansible import errors
from ansible.module_utils.six import text_type, binary_type

@ -18,7 +18,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.errors import AnsibleError

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import patch
from ansible.playbook import Play

@ -21,7 +21,7 @@ from collections.abc import Container
import pytest
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from ansible.errors import AnsibleParserError

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.playbook.attribute import Attribute

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.errors import AnsibleParserError, AnsibleAssertionError
from ansible.module_utils.six import string_types

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.playbook.block import Block
from ansible.playbook.task import Task

@ -1,6 +1,6 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from units.mock.loader import DictDataLoader
from unittest.mock import MagicMock

@ -19,7 +19,7 @@ from __future__ import annotations
import os
from units.compat import unittest
import unittest
from unittest.mock import MagicMock
from units.mock.loader import DictDataLoader

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.errors import AnsibleParserError
from ansible.playbook import Playbook
from ansible.vars.manager import VariableManager

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.playbook.taggable import Taggable
from units.mock.loader import DictDataLoader

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import patch
from ansible.playbook.task import Task
from ansible.plugins.loader import init_plugin_loader

@ -23,7 +23,7 @@ import re
from importlib import import_module
from ansible import constants as C
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock, mock_open
from ansible.errors import AnsibleError, AnsibleAuthenticationFailure

@ -17,7 +17,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import MagicMock, patch
from ansible import constants as C

@ -19,7 +19,7 @@ from __future__ import annotations
import os
from units.compat import unittest
import unittest
from unittest.mock import MagicMock, Mock
from ansible.plugins.action.raw import ActionModule
from ansible.playbook.task import Task

@ -23,7 +23,7 @@ import tempfile
from unittest import mock
from units.compat import unittest
import unittest
from ansible.errors import AnsibleError
from ansible.plugins.cache import CachePluginAdjudicator
from ansible.plugins.cache.memory import CacheModule as MemoryCache

@ -22,7 +22,7 @@ import re
import textwrap
import types
from units.compat import unittest
import unittest
from unittest.mock import MagicMock
from ansible.executor.task_result import TaskResult

@ -19,7 +19,7 @@ from __future__ import annotations
from io import StringIO
from units.compat import unittest
import unittest
from ansible.playbook.play_context import PlayContext
from ansible.plugins.connection import ConnectionBase
from ansible.plugins.loader import become_loader

@ -20,7 +20,7 @@ from __future__ import annotations
from io import StringIO
from units.compat import unittest
import unittest
from ansible.plugins.connection import local
from ansible.playbook.play_context import PlayContext

@ -24,7 +24,7 @@ import pytest
from ansible.errors import AnsibleAuthenticationFailure
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock, PropertyMock
from ansible.errors import AnsibleError, AnsibleConnectionFailure, AnsibleFileNotFound
from ansible.module_utils.six.moves import shlex_quote

@ -23,7 +23,7 @@ import textwrap
from unittest import mock
from ansible import constants as C
from units.compat import unittest
import unittest
from ansible.module_utils.six import string_types
from ansible.module_utils.common.text.converters import to_text
from units.mock.path import mock_unfrackpath_noop

@ -25,7 +25,7 @@ from unittest import mock
from ansible import constants as C
from ansible.errors import AnsibleError
from ansible.plugins.loader import PluginLoader
from units.compat import unittest
import unittest
from ansible.module_utils.common.text.converters import to_bytes, to_native

@ -18,7 +18,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible.plugins.lookup.ini import _parse_params

@ -29,7 +29,7 @@ import pytest
from units.mock.loader import DictDataLoader
from units.compat import unittest
import unittest
from unittest.mock import mock_open, patch
from ansible.errors import AnsibleError
from ansible.module_utils.six import text_type

@ -4,7 +4,7 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from ansible.executor.play_iterator import PlayIterator

@ -20,7 +20,7 @@ from __future__ import annotations
import os
from units.compat import unittest
import unittest
from unittest.mock import patch, MagicMock
from ansible.plugins.loader import PluginLoader, PluginPathContext

@ -1,6 +1,6 @@
from __future__ import annotations
from units.compat import unittest
import unittest
from ansible import constants as C

@ -19,7 +19,7 @@ from __future__ import annotations
from jinja2.runtime import Context
from units.compat import unittest
import unittest
from ansible import constants as C
from ansible.errors import AnsibleError, AnsibleUndefinedVariable

@ -18,7 +18,7 @@
from __future__ import annotations
import jinja2
from units.compat import unittest
import unittest
from ansible.template import AnsibleUndefined, _escape_backslashes, _count_newlines_from_end

@ -22,7 +22,7 @@ from collections import defaultdict
from unittest import mock
from units.compat import unittest
import unittest
from ansible.errors import AnsibleError
from ansible.utils.vars import combine_vars, merge_hash
from ansible.vars.manager import VarsWithSources

@ -19,7 +19,7 @@ from __future__ import annotations
import os
from units.compat import unittest
import unittest
from unittest.mock import MagicMock, patch
from ansible.inventory.manager import InventoryManager
from ansible.module_utils.six import iteritems

Loading…
Cancel
Save