Commit Graph

8778 Commits (ae9c0d87a96912e9c9cb7273ec95c0de75d7cd9f)
 

Author SHA1 Message Date
jctanner 19e8742005 Merge pull request #5713 from angstwad/su-fix
Disallow su and sudo params in same play/task
11 years ago
James Tanner 86ba8f4dff Fix git module parameters to conform to code standards 11 years ago
James Tanner 9e52d5a550 Update changelog with new git module information 11 years ago
James Tanner 18050d50ec Fixes #4108 Add sshopts and keyfile parameters to the git module 11 years ago
Craig Tracey 8c6b3baf6f Make default ANSIBLE_REMOTE_PORT None
The ansible remote port should be None, not 22. Having a default value
of 22 means that '-o Port 22' will be appended to the ssh connection
all of the time. This is incorrect as when one would like to use
something like an ssh configuration file (-F) that sets the port to
something other than 22.

Part of this change requires that we check that, in get_config, the
value is not None before trying to cast it into an integer or float.
11 years ago
Caleb Brown 19f7db3065 Fix a bug in "hg" module so that `pull` is not set to a version.
There is a bug in the `hg` module where if a `tag` is used it won't
properly be able to update to it.

This problem is exhibited on repository where a tag is moved from an
older commit to a newer commit.
11 years ago
James Cammarata f2b2354332 Merge pull request #5727 from jimi-c/yum_transaction_check
Adding a check for pending tranasctions to the yum module
11 years ago
James Cammarata 1ca6e4bbb1 Adding a check for pending tranasctions to the yum module
Fixes #4649
11 years ago
Paul Durivage e875089eba Fix bug where self.su was being set by the sudo param in play tasks 11 years ago
Paul Durivage 01d1bd61e7 Disallow su and sudo params in same play/task 11 years ago
James Cammarata ff8eb5f454 Merge pull request #5722 from jeromew/pipelining_default
Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean
11 years ago
jctanner 293d9b490e Merge pull request #5723 from jeromew/ssh_chmod_bug
Bug: chmod should be called only if the tmp dir was created in the first...
11 years ago
jeromew ef69d23715 Bug: chmod should be called only if the tmp dir was created in the first place 11 years ago
jeromew 3f23483022 Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean 11 years ago
Matt Jaynes f3e416f065 Minor documentation fixes.
Fixed double-dash literals. Fixed broken :doc: links. Minor case fixes. Minor wording fixes.
11 years ago
Matthew Nicholas Bradley b7bc427f1b Fix multiple minor typos in a paragraph
Add missing word, remove extraneous word, move misplaced quote,
switch single quotes to be double quotes for consistency in a
single paragraph.
11 years ago
James Tanner 61d283e2ad Fix merge conflicts from #5519 11 years ago
jctanner da136dbe7c Merge pull request #5694 from angstwad/add-su-support-revert
Add su support
11 years ago
jctanner 07b6d6ffd6 Merge pull request #5690 from sivel/rax-regex-fix
rax module: Fix regex match
11 years ago
jctanner 5e886b8ca6 Merge pull request #5699 from jpmens/un1
module unarchive: documentation typos
11 years ago
jctanner 62d96620e1 Merge pull request #5704 from zimbatm/default-grove-service
notify/grove: set the service to "ansible" by default
11 years ago
jctanner a6ab00b918 Merge pull request #5705 from resmo/fix/doc_do
digital_ocean: added requirements in DOCUMENTATION
11 years ago
jctanner 13f5ec3698 Merge pull request #5697 from kormoc/fix_missing_localhost_group
Fix an issue where ansbile-pull fails with AttributeError
11 years ago
Rene Moser a412eae9cd digital_ocean: added requirements in DOCUMENTATION 11 years ago
zimbatm fe4d203b9a notify/grove: set the service to "ansible" by default 11 years ago
Jan-Piet Mens d0912b84ef documentation typos 11 years ago
Rob Smith 761fe8cc04 Fix an issue where git-pull fails with AttributeError
As part of 94f3b9bfab the code was changed to support dynamically adding localhost to the inventory. This change introduced an crash when run via ansible-pull

```
Starting ansible-pull at 2014-01-20 23:09:57
Traceback (most recent call last):
  File "/tmp/ansible/bin/ansible", line 157, in <module>
    (runner, results) = cli.run(options, args)
  File "/tmp/ansible/bin/ansible", line 82, in run
    hosts = inventory_manager.list_hosts(pattern)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 372, in list_hosts
    result = [ h.name for h in self.get_hosts(pattern) ]
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 136, in get_hosts
    subset = self._get_hosts(self._subset)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 177, in _get_hosts
    that = self.__get_hosts(p)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 198, in __get_hosts
    hpat = self._hosts_in_unenumerated_pattern(name)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 275, in _hosts_in_unenumerated_pattern
    ungrouped.add_host(new_host)
AttributeError: 'NoneType' object has no attribute 'add_host'
```

The root cause is there is no group for the host to be added to. I fixed this case by creating the ungrouped group when it doesn't exist and then adding the host to the newly added group. This fixes the regression for me.
11 years ago
jctanner 4b9127f0af Merge pull request #5695 from kormoc/fix_git_check_hostkey_2
Fix case where there is a ~/.ssh/known_hosts file and the host key is only in /etc/ssh/ssh_known_hosts
11 years ago
Rob Smith 953dc6b345 When not finding a host in ~/.ssh/known_hosts, the return value is 0 if the host just is not found. We then never check the system host file in /etc. This fixes the code to check /etc on any failure, not just a bad return code. 11 years ago
Paul Durivage f72f5a20df Revert "Revert "Merge pull request #5325 from angstwad/add-su-support""
This reverts commit c17d0e0357.

Conflicts:
	lib/ansible/runner/connection_plugins/paramiko_ssh.py
11 years ago
Paul Durivage 4c84ba74b0 Resolve su bug in paramiko libs 11 years ago
Jesse Keating 6013f0738e Store the list of hosts to run on in runner object
This reduces the number of times inventory.list_hosts is called, which
can be costly. When coming from a playbook that data is already known.
11 years ago
Jesse Keating e8ad36c8d4 Store hosts for a play as a play attribute
Operate on that play attribute to make things faster for larger
inventories. Instead of making a round trip through inventory.list_hosts
and working through some lengthy list comprehensions over and over
again, calculate the potenital hosts for a play once, then reduce from
it the unavailable hosts when necessary.

Also moves how the %fail is done. The host count is a play level count
of available hosts, which then is compared after each task to the
current number of available hosts for the play. This used to get a new
count every task which was also time expensive.
11 years ago
Michael DeHaan 24f11168d9 Update CHANGELOG.md 11 years ago
Michael DeHaan f420af0676 Update CHANGELOG.md 11 years ago
James Tanner 94f3b9bfab Fixes #3129 Do not require localhost to be in inventory 11 years ago
Matt Martz 89fbc64b60 Fix regex match, the printf match should work with 0 or more numeric padding characters, not 1 or more 11 years ago
James Tanner c17d0e0357 Revert "Merge pull request #5325 from angstwad/add-su-support"
This reverts commit 6f4bfa2cff, reversing
changes made to c91ba3a7c7.
11 years ago
jctanner 6f4bfa2cff Merge pull request #5325 from angstwad/add-su-support
Proposing fix for Issue #4324; adding support for su
11 years ago
Michael DeHaan c91ba3a7c7 Merge pull request #5680 from biolds/devel
Mark stat module as supporting check_mode
11 years ago
Paul Durivage 8cf071f697 Hostvars support for su 11 years ago
Paul Durivage dec9131735 Ensure playbook support for su params 11 years ago
Paul Durivage d21281ff43 Resolve rebase conflicts 11 years ago
Paul Durivage ab6ee1a282 Enable su support in paramkio; disable su support in fireball, local, accelerate, chroot, jail, funcd connection plugins 11 years ago
Paul Durivage c95be4ceaa Make sudo and su command line arguments mutually exclusive 11 years ago
Paul Durivage 4088243deb Proposing fix for Issue #4324; adding support for su in connection plugins ssh, ssh_alt
Fixes for ssh_alt support, adding in references to in_data where appropriate
11 years ago
jctanner 297a28aa79 Merge pull request #5333 from mvermaes/yum_fix
yum module: Attempt #2 to cause yum to fail on invalid url
11 years ago
jctanner 7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
11 years ago
Michael DeHaan 2060ae550a Update changelog 11 years ago
Michael DeHaan 26676ce2e2 update default EC2 exclude regions -- this should be the best configuration for most users, but some may still want to tweak. 11 years ago