Commit Graph

37958 Commits (ad8142fc6d08f9edeb9bc75807eaf04bd558e235)
 

Author SHA1 Message Date
Toshio Kuratomi ad8142fc6d Add changelog for gce_net sort fix
https://github.com/ansible/ansible/pull/41567
6 years ago
saichint 119e6d680b fix nxos_linkagg issue (#41550)
* fix nxos_linkagg issue

* fix shippable
6 years ago
Kevin Breit 674dd3b10d Add docstrings to meraki module utility methods
PR #41369

Co-authored-by: Kevin Breit <kevin.breit@kevinbreit.net>
6 years ago
Tim Rupp 16466f3171
Fixes usage of popen in bigip iapplx package (#41612)
This functionality is superceeded by the run_command method in the
ansible module class.
6 years ago
Toshio Kuratomi 5c614a59a6 Temporarily revert c119d54
There were bugs in this that needed to be resolved.  No time to get the
fix reviewed sufficiently for 2.6.0.

We'll get this into 2.7.0 and try to get this into 2.6.1 as well.

Will need the work done in https://github.com/ansible/ansible/pull/36218
when it does get merged.
6 years ago
Sam Doran 6fa2d9ac6f Update user module docs (#41572)
* Clarify append and groups behavior
* Document return values
6 years ago
Matt Davis b01779ad18
skip winrm unit tests if winrm is not installed (#41596) 6 years ago
Sharp Hall 3935cce394 docker: Allow publishing of ports with the same number but different protocol (#38412)
* Don't deduplicate docker container ports with different protocols

* Test _parse_exposed_ports
6 years ago
Abhijeet Kasurde f21307da91 Add more info related to galaxy sub commands (#41085)
Fixes: #17469

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Abhijeet Kasurde 01cdc22ac6
Add documentation around package dependencies (#41437)
Documented procedure to handle package dependencies required by
packages which are Ansible dependencies.

Fixes: #30732
Fixes: #16571

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Abhijeet Kasurde d65451fa7b
VMware: Add documentation for customValue (#41399)
* VMware: Add documentation for customValue

In order to populate custom values (custom attributes of virtual machine)
inside hostvars, customValue needs to be uncommented under the section
properties in vmware_inventory.ini

* Remove unwanted single quotes from custom_field_group_prefix

Fixes: #41395

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
schp 63f2ad8776 sort the port list properly (.sort() returns None) 6 years ago
Ivica Kolenkaš 0691c9c099 setting LANG, LC_ALL and LC_NUMERIC to C (#41544)
* This forces the fact gathering commands to use C locale, preventing
weird locale issues such as different separator etc
6 years ago
ABond 5d26477b94 DigitalOcean - Fix TypeError when users have tags named the same as droplets (#41368)
* Fix TypeError when users have tags named the same as droplets
* Updated code based on review comments
6 years ago
Abhijeet Kasurde a94ddedfd3 Correct typo from 'Valut' to 'Vault' (#41574)
Correct typo from 'Valut' to 'Vault'

+label: docsite_pr
6 years ago
Felix Yan d352cf514e Fix some typos in config/base.yml (#41363) 6 years ago
David Zager 00b397cfdb Update APB templates (#41559) 6 years ago
James Simpson 8357ae69e7 Fixes #35622 (#41522) 6 years ago
Abhijeet Kasurde eb2b9b3636 Remove extra line in file_attributes.yaml
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Trishna Guha f170298332
fix nxos edit_config for httpapi and have uniform load_config (#41358)
* fix nxos load_config for httpapi and migrate to cliconf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
6 years ago
John Imison 0d885260a5 Adding success_msg to assert (#41048)
* Adding success_msg to assert

* Added missing version_added. Importing and checking string_types.
6 years ago
Nathaniel Case 50e776877d
Check for ConnectionError on change of config or commands (#41504) 6 years ago
Toshio Kuratomi 5814b90835 Add changelog fragment for +/- attribute handling 6 years ago
Andreas Calminder 75e9b76c15 accept + and - modifiers for file attributes (#40061)
* accept + and - modifiers for file attributes
* tests for adding/removing file attributes
6 years ago
Trishna Guha 8ab0d654f3
don't retrieve config in running_config when config is provided for diff (#41400)
* don't retrieve config in running_config when config is provided for diff

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix for eos, nxos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
6 years ago
Jeff Geerling a4f49ed648 Fix typos in blocks documentation examples. (#41508) 6 years ago
Biao Liu d90d8e7f99 Add cli and netconf ability from ansible itself for cloudengine ce modules (#41357)
* for shippable

for shippable

* add cliconf

* add network_cli

* add cliconf and network cli and netconf

* modify bugs of netconf

* add shippable modify

* update shippable

update shippable
6 years ago
saichint 79dd206b3e fix reload smu issue (#41270)
* fix reload smu issue

* review comments
6 years ago
Ben Berry 32c191ee9c expand user before calling abspath (#40196)
* expand user before calling abspath

* omit expanduser code smell check for volumes
6 years ago
Brian Coca 414aae70b1 corrected version 6 years ago
plumbeo 9b0883c70d Add nomask option to the acl module (#39810)
* Add nomask option to the acl module

* acl: allow to choose if and when to recalculate the effective right masks of the files
6 years ago
Adam Miller c4bf168940 service_facts correct meaning of state for systemd service units (#40914)
* service_facts correct meaning of state for systemd service units

Fixes #40809

Previously this module used the commend `systemctl list-unit-files
--type=service` to query state of services but list-unit-files only
shows enabled vs disabled which is not what we want for "state"

Signed-off-by: Adam Miller <admiller@redhat.com>

* make sure to define service_name before referencing it

Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
jaevans 75443b2094 Add support for Tower Smart inventories (#41458)
* Support Smart Inventories

Add kind and host_filter fields and pass through to tower_cli.

* Add documentation for new Smart Inventories options

* Add missing description header for host_filter documentation

* Add version added tags to new options

* Bumped vesion_added to 2.7
6 years ago
Simon Dodsley 8df02ac37e Fix race condifiton where multiple hosts can try and create or delete (#39698)
the same volume, snapshot or hostgroup,
6 years ago
Matt Martz 3832d04611 Ensure we raise the exception caught _post_validate_environment->_parse_env_kv. Fixes #41322 (#41411) 6 years ago
Zim Kalinowski 5b0bb91c72 reappied changes in a new pr (#41228) 6 years ago
Abhijeet Kasurde 063d19048d
plugins: Doc improvement (#41378)
* Typo fixes
* Grammer fixes
* Option fixes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Matt Clay d6ba139713 Disable failing acme_account integration test. 6 years ago
Matt Davis 0c92b11335
allow dev and prerelease at the same time (#41464) 6 years ago
Toshio Kuratomi a5fd86cf6d Tasks that are expected to fail need to begin with a special string 6 years ago
Toshio Kuratomi 5fdd101a3e Add changelog entry for the no_log fix 6 years ago
Brian Coca 336b3762b2 no_log even when task_result doesn't provide key
- now also checks task property
 - added reproducer to tests for unreachable status on item loop
6 years ago
Sloane Hertel 40d2df0ef3 Add AWS boto3 error code exception function is_boto3_error_code (#41202)
* Add aws/core.py function to check for specific AWS error codes

* Use sys.exc_info to get exception object if it isn't passed in

* Allow catching exceptions with is_boto3_error_code

* Replace from_code with is_boto3_error_code

* Return a type that will never be raised to support stricter type comparisons in Python 3+

* Use is_boto3_error_code in aws_eks_cluster

* Add duplicate-except to ignores when using is_boto3_error_code

* Add is_boto3_error_code to module development guideline docs
6 years ago
Roman Dodin 269f404121 fix handling of ># ending prompts for sros (#41382) 6 years ago
Michael Scherer 5bdd91d75f Return changed=True if a new certificate was written (#41445) 6 years ago
Matt Martz ad0827e5c0
When using ANSIBLE_JINJA2_NATIVE bypass our None filtering in _finalze (#41408)
* When using ANSIBLE_JINJA2_NATIVE bypass our None filtering in _finalize. Fixes #41392

* Add tests for _finalize bypass

* Address python3 failures in tests
6 years ago
Sebastien Lacoste-Seris 46ae1a343a vca_vapp: Connecting app network to vApp and VM after vApp creation (#19886)
* Connecting app network to vApp
This fixes connection mechanism for connecting app network to vApp and VM
after vApp creation, returning the IP assigned to the VM as fact 'vm_ip'
* removed duplicate check on task fail for vApp creation. Fixed issue with network_mode value for VCD version > 5.7
* fixed trailing white space

Signed-off-by: Kaneda-fr <sebastien@lacoste-seris.net>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
ABond 4efe53edd5 Digital Ocean Block Storage Bug (#41431) 6 years ago
wiso d43414b82c fix netconf_get documentation section and lock logic (#40357)
* fix netconf_get documentation section and lock logic

* updated lock behavior
6 years ago
saichint 00ce205535 fix get existing vpc issue (#41429) 6 years ago