Commit Graph

2045 Commits (aa0577c2112ceaabdf71d312b679d0fb3f26a263)

Author SHA1 Message Date
Michael Scherer 5e1828a524 add jail module, based on lxc and chroot connexion plugin 11 years ago
Michael DeHaan 1f0eb32846 Update 1.4 specfile -- no need for node fireball package, release dates 11 years ago
James Cammarata 35d138a0d6 When checking conditionals, don't dereference when the variable contains dashes
Fixes #4104
11 years ago
James Cammarata d0236f6ada Check for link in path in utils.path_dwim_relative()
This allows an included path to be relative to a directory, if the
basedir of the original path is a symlink. In that case, the path
is normalized and the file is searched for in the normalized path.

Fixes #3312
11 years ago
Hiroaki Nakamura 2357194b39 Add failed_when module variable.
Implementation note: Ternery operator trick for python prior to 2.5 is used.
(test and [when_true_value] or [when_false_value])[0]
http://stackoverflow.com/questions/394809/ternary-conditional-operator-in-python#comment1466794_394887
11 years ago
Serge van Ginderachter 4f9af7efad subelements lookup plugin 11 years ago
James Cammarata 75a9357e5e Fixing role variable precedence for top-level roles
Fixes #4026
Fixes #3989
11 years ago
James Cammarata 294451d002 Correctly handle variable issues when evaluating jinja2 when statements
Fixes #4025
11 years ago
James Cammarata bcc2a4b513 Minor fix so the any_errors_fatal value is checked properly 11 years ago
James Cammarata 4025695c00 Merge branch 'devel' of https://github.com/kavink/ansible into kavink-devel 11 years ago
Brian Coca d47c48e30a Added remote_user to plays
Still compatible with user: but deprecating it so we can have
a matching remote_user: in tasks, cannot be user: because of the
module of the same name. #3932

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Kavin Kankeshwar c24f6f438b Avoid ugly formatting due to a long if statement 11 years ago
James Cammarata 6e9fa5019f Reverting HostVars change from a mapping back to a dictionary 11 years ago
James Laska 546788a1b6 The required package for selinux is libselinux-python 11 years ago
James Cammarata 4e9dee6093 Use StringIO to feed md5 calculation to prevent unicode issues
Fixes #4014
11 years ago
James Cammarata 2a47f72139 Merge pull request #4049 from mscherer/fix_no_kerberos
Fix no kerberos
11 years ago
Michael Scherer f489702973 Also add back gssapi-keyex
While this is not currently implemented in openssh as far as I know,
there is patch floating around on the web and this may land one day
upstream.
11 years ago
Keiichi Mori 17c39b94a3 support GSSAPIAuth back
GSSAPIAuthentication has not been supported
due to PreferredAuthentications trick ( 2bdba17a85 )
11 years ago
James Cammarata ae9e38daf8 Change hostvars to a mutable mapping to more closely resemble a dict
Fixes #4030
11 years ago
James Cammarata 2cbf28385a Move check for accelerate mode deeper to account for ansible_connection
Fixes #4045
11 years ago
James Cammarata 20b0dc4abd Check for an empty executable passed into the accelerate plugin
This was breaking at least the script module, so it would seem best
to check for it and set it to the default executable value
11 years ago
James Cammarata 4bf506f683 Always run the accelerate module as the user specified in the play
Currently, the accelerate daemon will be run as the sudo_user if
specified, which is incorrect.
11 years ago
Scott Sturdivant 68bffb1233 Don't force accelerate connection for local actions. 11 years ago
James Cammarata f6e1bdabea Ensure ports are set correctly in accelerate module 11 years ago
willthames fe70ed94e3 Expand tilde in paths in file module 11 years ago
guersam 64db327411 Fix: raise correct error in accelerate mode 11 years ago
kavink a075ec9831 Bug fix for a crash, when any_errors_fatal is true
Reported by Rumen:

TASK: [fail FAIL] *************************************************************
skipping: [hostname.com]
failed: [hostname.com] => {"failed": true}
msg: Failed as requested from task
Traceback (most recent call last):
  File "/usr/local/bin/ansible-playbook", line 268, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/bin/ansible-playbook", line 208, in main
    pb.run()
  File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 262, in run
    if not self._run_play(play):
  File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 580, in _run_play
    if (hosts_count - len(host_list)) > int((play.max_fail_pct)/100.0 * hosts_count):
TypeError: object of type 'NoneType' has no len()
11 years ago
Stephen Fromm d704b55860 Support using paramiko to set up accelerate connection
Adds original_transport attribute to Runner to track what the original
transport was before it is changed to 'accelerate'.
If using paramiko in original_transport, uses ParamikoConnection.  If
not, falls back to SSHConnection like before.
11 years ago
James Cammarata fff497a1ae Make sure the accelerated port is set to a sane value 11 years ago
James Cammarata cc21e5c90c Adding hostvars to injected variables in accelerate ssh runner
Also some minor cleanup of some fb* variables and functions, which
were remnants of the old fireball2 name

Fixes #4021
11 years ago
James Cammarata 7b13b1e03e Minor fix to dependency dupe patch 11 years ago
James Cammarata 16258edd7a Merge branch 'devel-duplicates2' of https://github.com/smoothify/ansible into smoothify-devel-duplicates2 11 years ago
James Cammarata a202adcae1 Merge branch 'doublecallback' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-doublecallback 11 years ago
smoothify 5337397abd Second Attempt: Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file. 11 years ago
James Cammarata c0fecf87d1 Increase default socket timeout to 5 minutes 11 years ago
smoothify 0411ea2867 Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file. 11 years ago
James Cammarata 2e49d2003d Fix bug where accelerate keyword was not checked for boolean value
The play was just checking for the presence of the keyword in the
YAML datastructure, and not the value of the field, so doing something
like variable substitution was always causing the play to be accelerated
11 years ago
James Cammarata 2696135b3b Display error during launch of accelerated daemon
* also minor tweak to the # of retries in the connection attempt

Fixes #4012
11 years ago
James Cammarata 7c1c9b3d10 Fix message in utils related to python-keyczar and fireball/acc mode 11 years ago
James Cammarata 53c2f4c1bb Fix race condition on creating the temp directory for ControlPersist
Fixes #3943
11 years ago
James Cammarata d05c61d1f0 Merge branch 'devel' into fireball2
Conflicts:
	lib/ansible/playbook/__init__.py
	lib/ansible/playbook/play.py
11 years ago
James Cammarata 50f54f6bda Making variable names more descriptive for the default variables work 11 years ago
James Cammarata 02b7b79d7e Re-adding capability of tasks to see a unique view of their own defaults 11 years ago
James Cammarata 266d2008d8 Reverting the role default variables change
Loading the default variables in _build_role_dependencies() lead to
a side-effect where those variables were over-riding inventory variables.
11 years ago
James Cammarata 47a89a57fa Fixing bug in playbook use of default variables in roles 11 years ago
James Cammarata e0df5b5888 A couple more tweaks to role default variables/dependencies
* Default variables are now fed directly into roles, just like the
  other variables, so that roles see their unique values rather
  than those set at the global level.

* Role dependency duplicates are now determined by checking the params used
  when specifying them as dependencies rather than just on the name of the
  role. For example, the following would be included twice without having
  to specify "allow_duplicates: true":

  dependencies:
  - { role: foo, x: 1 }
  - { role: foo, x: 2 }
11 years ago
James Cammarata d69d5c294f Renaming fireball2 as 'accelerate' and removing old references 11 years ago
James Cammarata 736c8b19d3 Added ability to limit role dependencies to just one inclusion 11 years ago
James Cammarata 6f6efa268b Merge branch 'smoothify-defaults' into devel 11 years ago
James Cammarata 25e3eed519 Fixing a bug in variable precedence for roles and dependencies 11 years ago
James Cammarata 637d3070dc Allow default variables to be overridden by inventory variables 11 years ago
James Cammarata 9806f89a04 Revert "Construct the multiprocessing manager only once."
This reverts commit 1d13ec2da3.
11 years ago
James Cammarata 7d3ae9fc75 Fixing a few bugs related to fireball2
* ssh port not being picked up, always uses default of 22
* forgot to 'import time' in the fireball2 connection plugin
11 years ago
James Cammarata f66683863e Merge branch 'defaults' of https://github.com/smoothify/ansible into smoothify-defaults 11 years ago
James Cammarata faf82bf841 Fix bug with fetch when using sudo: true
Fixes #3111
11 years ago
James Cammarata af1dd7075f Adding chunked file transfers to fireball2 11 years ago
James Cammarata 959138d00d Added accelerate_port to plays, and made it configurable 11 years ago
James Cammarata 167f185092 Initial support for running gather_facts through fireball2 11 years ago
James Cammarata b45342923c Initial support for sudoable commands over fireball2
Caveats:
* requiretty must be disabled in the sudoers config
* asking for a password doesn't work yet, so any sudoers users must
  be configured with NOPASSWD
* if not starting the daemon as root, the user running the daemon
  must have sudoers entries to allow them to run the command as the
  target sudo_user
11 years ago
James Cammarata 4b552457e7 Bail out correctly if socket.recv gets nothing (indicating a closed socket) 11 years ago
James Cammarata 86f01965cd Fireball2 module will now launch in a proper tmp path 11 years ago
James Cammarata 521e14a3ad Fireball2 mode working! 11 years ago
James Cammarata acc5d09351 Initial commit for the "fireball2" connection plugin
Still needs:
* chunked file transfer/receive
* should probably move all send/recv operations to separate
  functions to reduce code duplication
* initial connection setup over ssh? or do we handle that in runner?
11 years ago
James Cammarata fd2aabaa27 Initial work for the AES cipher class
This is based somewhat loosely on how Keyczar does things. Their
implementation does things in a much more generic way to allow for more
variance in how the cipher is created, but since we're only using one
key type most of our values are hard-coded. They also add a header to
their messages, which I am not doing (don't see the need for it
currently).
11 years ago
Bruce Pennypacker cf6a76c814 changed ignore_md5_mismatch to validate_md5 11 years ago
Bruce Pennypacker 41c474d129 added optional ignore_md5_mismatch parameter 11 years ago
Michael DeHaan cce7f485b8 Merge pull request #3946 from wincent/spelling-fix
Fix minor typo in playbook error message
11 years ago
Wincent Colaiuta fc4307a9c4 Fix minor typo in playbook error message 11 years ago
James Cammarata 88966e6558 Use AnsibleError instead of exit for errors in utils 11 years ago
Jocelyn Jaubert 4cee6a5435 Add option remote_user to task level, to specify the ssh login user 11 years ago
James Cammarata 8262f7bfac Merge branch 'with_items_and_complex_args' of https://github.com/lberruti/ansible into lberruti-with_items_and_complex_args 11 years ago
James Cammarata e11bb0cad4 Merge branch 'plugins-work' of https://github.com/ferringb/ansible into ferringb-plugins-work 11 years ago
James Cammarata 462cd4f728 Merge branch 'pulls/fix-hostvars-inconsistancy' of https://github.com/ferringb/ansible into ferringb-pulls/fix-hostvars-inconsistancy 11 years ago
James Cammarata e6ad3b7792 Merge pull request #3895 from mscherer/fix_option_new_ssh
make sure ssh do not ask password
11 years ago
James Cammarata 157b697a83 Merge branch 'always_run-6' of https://github.com/stoned/ansible into stoned-always_run-6 11 years ago
James Cammarata af4f0bd008 Fix for "argument must be an int, or have a fileno() method" error
The issue was that, when forks == 1, the _executor() function was
being called with None for the value of new_stdin.

Fixes #3841, #3902
11 years ago
James Cammarata 978af89175 Disallow running async tasks with lookup plugins
Fixes #2897
11 years ago
James Cammarata ed3e4aff84 Place retry file in the user's home dir instead of /var/lib/tmp
Addresses CVE-2013-4260: predictable filename used for failed results
in world writable directory.
11 years ago
James Cammarata 6bf5d19506 SSH connection plugin creates ControlPersist socket files in a secure directory
Files were being created in /tmp, but will now be created in $HOME/.ansible/cp/
Addresses CVE-2013-4259: ansible uses a socket with predictable filename in /tmp
11 years ago
Stoned Elipot f0743fc32a Introduce the 'always_run' task clause.
The 'always_run' task clause allows one to execute a task even in
check mode.

While here implement Runner.noop_on_check() to check if a runner
really should execute its task, with respect to check mode option
and 'always_run' clause.

Also add the optional 'jinja2' argument to check_conditional() :
it allows to give this function a jinja2 expression without exposing
the 'jinja2_compare' implementation mechanism.
11 years ago
Michael Scherer 2bdba17a85 make sure ssh do not ask password
For some reason, ssh seems to ask for password even when
PasswordAuthentication is set to no, adding PreferredAuthentications
with the 2 options removed do the trick.
11 years ago
Kavin Kankeshwar 7ac3bbc198 resolved #3609 Change max_fail_pct to max_fail_percentage as recommended 11 years ago
Kavin Kankeshwar 3f247fcbe3 fixes ansible/ansible#3609 Add max_fail_pct to playbook parameter, to complement serial option, So if total number of failures execeed max_fail_pct * total number of hosts, do not go to the next serial batch 11 years ago
smoothify 494043947d Add support for role defaults. These are variables on a per role basis with lowest precedence. 11 years ago
Petr Svoboda e3adfbf5f8 Add tests for undefined variable detection
Tests `test_playbook_undefined_varsX_fail` check if ansible detects
undefined variables when `error_on_undefined_vars` is enabled. These
tests fail without "Improve behavior with error_on_undefined_vars
enabled" patch.

Tests `test_playbook_undefined_varsX_ignore` check if ansible ignores
undefined variables when `error_on_undefined_vars` is disabled.

Also modify PlayBook._run_task_internal() so error_on_undefined_vars is
testable.
11 years ago
Petr Svoboda fff4f1da33 Improve behavior with error_on_undefined_vars enabled
Pass fail_on_undefined flag to recursive calls to `template` function,
so more undefined variables are detected.

Works only for Jinja style variables. Undefined legacy variables are
never detected.
11 years ago
Brian Harring 31061213fa Fix inconsistency in hostvars access.
Previously, hostvars would only expose a keys() list of hosts that had
been seen yet- however you could explicitly access the host if you knew
the name, and get the content that way.  This precludes template code
from being able to safely access information about other hosts if any
limiters/tags were in use.

Additionally, the object was inconsistent for hostvars['myhost'] access
and [x[1] for x in hostvars.items() if x[0] == 'myhost'] access; this is
due to the original derivation from the dict object.  .items() would be
handled by dict.items(), using the passed in setup_cache values without
using the actual lookup content.

This patch rebases the class implementation to a py2.6 dictmixin, fixing
those issues and restoring behaviour to match what the docs claim.
11 years ago
Brian Harring 902183ac0e Enforce alphanumeric ordering for plugins grabbed via glob.
If this isn't done, it's left to directory ordering which can result
in indeterminent behaviour.
11 years ago
James Cammarata 39628d012d Minor fix to ipv6 detection for inventory with -i
For link-local addresses, it is sometimes necessary to append the
interface to use for the ipv6 address. This patch extends the ipv6
regex to allow for '%ifnameX' at the end.

See https://bugzilla.redhat.com/show_bug.cgi?id=136852 for more info
11 years ago
Michael Scherer 3aac187387 fix ssh connection plugin to work with ipv6 address
Due to various inconsistencies of ssh and sftp regarding ipv6 and
ipv4 handling, some special arguments must be passed, and the
ipv6 must be passed in a specific format.
11 years ago
Michael Scherer c9d28e10ad add support for using a ipv6 in -i
testing with a ipv6 :
  ansible -u misc -i  '[2002::c23e]:22,' '*' -m ping

fail due to parsing of ':' as a separator of port/ip with ipv4.
This commit add support for properly parsing 2002::c23 and the
bracket notation [2002::ce]:2222
11 years ago
Matt Saunders 9fd1b174f5 Fixed tiny bug with _meta handling in external inventory scripts 11 years ago
James Cammarata 5847720746 Fixing a small bug with the new role dependency feature
The block that added the original list of roles was indented too far,
and was only being reached if a role had dependencies. This resulted
in roles without dependencies from being added to the list of roles.

Credit goes to looped for reporting and diagnosing the issue.
11 years ago
Michael DeHaan 42648e2f0a Merge branch 'role_dependencies' of git://github.com/jimi1283/ansible into jimi1283-role_dependencies 11 years ago
Michael DeHaan dacd311474 Removing synchronize momentarily as it looks like this won't make 1.3 dates 11 years ago
James Cammarata d8a7a2d1b2 Adding evaluation of role vars as the dep tree is built
This allows variables to be inserted into the role scope specifically
while also being inserted into the global scope.
11 years ago
James Cammarata e12b99dba6 Small cleanup, no need to call _get_role_path a second time 11 years ago
James Cammarata 9a401e73a6 Adding support for role dependencies.
Fixes #3686

Dependencies are enabled by adding a new directory/file named
meta/main.yml to the role. The format of the dependencies are:

dependencies:
- { role: foo, x: 1, y: 2 }
- { role: bar, x: 3, y: 4 }
...

Dependencies inherit variables as they are seen at the time of the
dependency inclusion. For example, if foo(x=1, y=2) has a dependency
on bar(x=3,z=4), then bar will have variables (x=3,y=2,z=4).

Different roles can have dependencies on the same role, and this
variable inheritence allows for the reuse of generic roles quite easily.
For example:

Role 'car' has the following dependencies:
dependencies:
  - { role: wheel, n: 1 }
  - { role: wheel, n: 2 }
  - { role: wheel, n: 3 }
  - { role: wheel, n: 4 }

Role 'wheel' has the following dependencies:
dependencies:
- { role: tire }
- { role: brake }

The role 'car' is then used as follows:
- { role: car, type: honda }

And tasks/main.yml in each role simply contains the following:
- name: {{ type }} whatever {{ n }}
  command: echo ''

TASK: [honda tire 1]
TASK: [honda brake 1]
TASK: [honda wheel 1]
TASK: [honda tire 2]
TASK: [honda brake 2]
TASK: [honda wheel 2]
TASK: [honda tire 3]
TASK: [honda brake 3]
TASK: [honda wheel 3]
TASK: [honda tire 4]
TASK: [honda brake 4]
TASK: [honda wheel 4]
TASK: [I'm a honda]  <- (this is in roles/car/tasks/main.yml)
11 years ago
James Cammarata ad595eadea Enable error_on_undefined_vars by default 11 years ago
Michael Scherer 12bf9a8b69 add a way for callback to disable itself
The idea is that some plugin would not be called in some
specific case, and the callback should decide by itself.

Having a way to globally disable it is much cleaner than
disabling every method one by one on the plugin side.

My use case is for fedora-infrastructure that cannot be run
from git checkout since it try to connect to the message bus,
but another case would be to bootstrap infrastructure, or to
run the code on a test servers without having all the callback
infrastructure setup.
11 years ago
Luca Berruti eee278e02b fix 11 years ago
Luca Berruti 5048218ab5 Fix: with_items and complex_args 11 years ago
Serge van Ginderachter 173586b871 Ensure plugin_loader.all() only loads one instance
by ensuring all basedirs, plugin paths and extra
paths are handled as absolute paths and are checked
to not add any doubles.

This fixes the corner case where e.g. the user has
an additional plugin path configured to a dir
relative to his playbooks or inventory location,
which also matches the  _plugin subdir relative to
one of the basedirs in the play.

For most plugins this doesn't show as an obvious issue
except for callback_plugins, which might fire more
than once. Other plugins (inventory and template
plugins) might unnecessarily be ran twice.

e.g. ansible.cfg has
callback_plugins   = ./plays/callback_plugins
and plays/ contains a playbook file:
.
├── ansible.cfg
├── inventory
└── plays
    ├── callback_plugins
    │   └── timestamp.py
    └── site.yml

modified:   lib/ansible/utils/plugins.py
11 years ago
Michael DeHaan bc02e20503 Merge branch 'rsynctake2' into devel
Conflicts:
	CHANGELOG.md
11 years ago
Michael DeHaan 17aa0d12de Merge pull request #3814 from ftao/inventory_dir_abs
fix inventory.basedir is not absolute path when hostfile is startswith "./"
11 years ago
Abhijit Menon-Sen 1a90d01ba9 Fix some typos discovered during casual reading 11 years ago
ftao 51a180b150 fix inventory.basedir is not absolute path when hostfile is startswith "./" 11 years ago
Michael DeHaan f8c97d6e79 Style/docs cleanup, and also improve an error message. 11 years ago
Michael DeHaan aeb8649da5 Merge branch 'ansible-rsync-take2' of git://github.com/tima/ansible into rsynctake2 11 years ago
Michael DeHaan 4d1f447908 Merge pull request #3650 from bcoca/forking_optimizations
forking least possible
11 years ago
Michael DeHaan baffa8df72 These fields are booleans. 11 years ago
Michael DeHaan 633abca916 Merge branch 'nocolor' of git://github.com/amenonsen/ansible into devel 11 years ago
Michael DeHaan ee11d69697 Merge branch 'better_ini_errors2' of git://github.com/bcoca/ansible into devel 11 years ago
Michael Vogt 89bc43cab0 support i18n on sudo failure 11 years ago
Serge van Ginderachter 9991a530ab fix an encoding bug in copy content = lookup plugin
closes #3518
11 years ago
Michael DeHaan 66b29b6813 Merge branch 'feature/gh-3789-inventory-file' of https://github.com/resmo/ansible into devel 11 years ago
Michael DeHaan 1d13ec2da3 Construct the multiprocessing manager only once. 11 years ago
René Moser e8272e365d
implemented 'inventory_file' variable. Closes GH-3789. 11 years ago
Timothy Appnel 2288a11b6a Implemented setup method in rsync action module. 11 years ago
Timothy Appnel 4a9635e04e Straighten out local-remote-delegate logic in rsync action module. Force set delegate to local if one is not defined. 11 years ago
Timothy Appnel adbca9d251 Fixed identity key logic. 11 years ago
Timothy Appnel 9f170f579a Introduced ansible-rsync to core. 11 years ago
James Cammarata ceff3b6ba3 Minor modification to set_fact with_items patch
Previous patch was reverted due to the fact that there was an issue
with the results not always being a dictionary (they're sometimes
a unicode string, ie. when the with_items is used with yum). This
minor change corrects that by checking for a dict object.
11 years ago
James Cammarata 8be2fc745b Revert "Check for ansible_facts in results for with_ tasks"
This reverts commit 1a4e6e415e.
11 years ago
Serge van Ginderachter 1a4e6e415e Check for ansible_facts in results for with_ tasks
that loop over a lookup plugin. Fixes #3704 and #3735
11 years ago
Serge van Ginderachter 40e60c947d Host specifiers should be sorted
to ensure consistent behavior, hosts should look like this:

    hosts: webservers:&boston:!rack42

So when applying the host selectors, run those without the "&" first,
then the &s, then the !s.

Closes #3500
11 years ago
Abhijit Menon-Sen 0c96d8af6e Add a nocolor setting to ansible.cfg 11 years ago
Brian Coca a937a6a66d now bad ini entries will throw friendlier error
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 4cbfe3be57 Merge pull request #3773 from cchurch/devel
Update callbacks used for async tasks
11 years ago
Michael DeHaan ff44c981e9 Merge pull request #3770 from rishid/devel
Add support for INI comments that begin with '#' or ';'
11 years ago
Michael DeHaan 99775176ff Merge pull request #3623 from ralph-tice/fix_3567_2
changed role path template to read all vars instead of just extra_vars
11 years ago
Chris Church 6ba4331161 Correctly check for failed status from an async task. Use runner_on_async_failed callback (instead of runner_on_failed) when an async task times out. Add runner_on_async_ok callback when a task is started in fire and forget mode. 11 years ago
rishid d18c90ed8f Add support for INI comments that begin with '#' or ';'
Ini file format does not have a standard but ';' is used more often than '#' for comments
11 years ago
Michael Scherer 3fb2da6359 use lgetfilecon_raw instead of lgetfilecon to not depend on local level translation
If SELinux is enabled and mcstrans is running, daemons are restarted on each
run. After further debugging, it turn out that ansible compare the untranslated
level 's0' with the translated level 'SystemLow' due to mcstrans being running,
which trigger a handler since this is considered as a change.
11 years ago
Michael DeHaan 56a00e0667 Remove dead code. 11 years ago
Michael DeHaan 8955ac1eda If the result of a dynamic inventory script contains a "_meta" hash at top level
and the _meta hash contains a "hostvars", don't call --host hostname for any elements
and just serve them directly for performance enhancements with the external inventory
script and a large number of hosts.
11 years ago
Michael DeHaan 1c6b81233c Merge pull request #3692 from tima/action-init
Added support of an optional init method for action modules like rsync that need to alter the connection and other inject data before it's established.
11 years ago
Michael DeHaan dec43f7a2b PEP8 indent fix. 11 years ago
Michael DeHaan 3dbe65def2 PEP8 indent fix 11 years ago
Michael DeHaan 76fd769704 Merge pull request #3685 from mspaulding06/indexed_items
Indexed items lookup plugin
11 years ago
Michael DeHaan c0ab417ef9 Don't iterate across strings in with_nested. 11 years ago
James Cammarata 82c806979b Only use LOG_LOCK in log_flock if a runner is not specified
Fixes issue #3466 - When ansible can't authenticate against a host,
and your answer is no, ansible crash.
11 years ago
James Cammarata ba38d6bc16 Adding support for hashed known_hosts entries
Fixes Issue #3716 - SSH known host checking needs to understand
hashed known hosts
11 years ago
Brian Coca 581a0c9f59 now correctly 'types' value pairs that are passed as options to jinja
override
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 0335d05f43 Check against None around playbook basedir 11 years ago
Michael DeHaan bdef7f1774 Merge pull request #3711 from ashorin/devel
Allow --diff on UTF-8 encoded files and templates
11 years ago
Michael DeHaan 44d060628e Merge pull request #3706 from lorin/sudo_user_breakage
Fix sudo_user copy error
11 years ago
Michael DeHaan daf5ecc7c9 Merge pull request #3684 from stoned/fix-3668
Add extra module path early during playbook parsing.
11 years ago
Michael DeHaan 83481b32cc Merge pull request #3657 from zqad/devel
Fix playbook-local host_vars when running from .
11 years ago
Michael DeHaan 3ebbb56479 Merge pull request #3654 from MaxIV-KitsControls/devel
Fix nested loop for more than 3 elements
11 years ago
Michael DeHaan 7813290969 Merge pull request #3645 from stoned/stringify-conditional-2
stringify conditional before handing it to Jinja2 for evaluation.
11 years ago
Andrey Shorin 664215eb02 Allow --diff on UTF-8 encoded files and templates 11 years ago
Lorin Hochstein a303fca193 Fix sudo_user copy regression
Treat errno 13 (permission denied) as one of the special cases in
atomic_move.

This type of error can occur because of sudo'ing to non-root user.

Fixes #3705
11 years ago
Timothy Appnel 11beb38c66 Added support of an optional setup method for action modules like rsync that need to alter the connection and other inject data before it's established. 11 years ago
Matt Spaulding 5d15515bbf Add indexed_items lookup plugin 11 years ago
Stoned Elipot 841093921b Add extra module path early during playbook parsing.
This should fix issue #3668

Also prevent an extra module path to be added multiple times.
11 years ago
Jonas Eriksson 16efb45735 Fix playbook-local host_vars when running from .
Since ansible 1.2, it became possible to place a host_vars
directory in the same directory as a playbook, making it possible
to keep host_vars local to that playbook there. However, due to
python's os.path.dirname, a action such as:

 $ ansible-playbook pb.yml

..would not pick up the host_vars as os.path.dirname("pb.yml")
returns "", unlike the unix command dirname that would return
".". Substituting "pb.yml" on the command line with "./pb.yml"
would do the trick, but is not always intuitive. This patch
solves the problem until python solves issue18547 [1].

[1] http://bugs.python.org/issue18547
12 years ago
Vincent Hardion 09ef7751e1 Fix nested loop for more than 3 elements
- combine flatten list for each nested level instead once at the end
12 years ago
Brian Coca 576962d335 now if you set fork to 0 or a number higher than the number of hosts, it
will be readjusted to the number of hosts runner is going to deal with.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Stoned Elipot a1503c4d59 stringify conditional before handing it to Jinja2 for evaluation.
This should fix simple conditionals like:

    when: ansible_selinux

While here add tests for ansible.utils.check_conditional() in
"jinja2_compare mode".
12 years ago
WAKAYAMA Shirou 0ce99e391f fix: if a path is symlink and trying to chmod, OSError Exception will be raised. 12 years ago
Michael DeHaan f0eafff1b4 Merge pull request #3621 from sergevanginderachter/rename2flattened
also rename plugin name in error message
12 years ago
Ralph Tice 2383a8205c changed role path template to read all vars instead of just extra_vars 12 years ago
Serge van Ginderachter b40295910d also rename plugin name in error message 12 years ago
Michael DeHaan 2fe25f19dc Fix to group_by module as a result of previous conditional upgrades. 12 years ago
Michael DeHaan e3f213e030 Fixup error reporting. 12 years ago
Michael DeHaan c07dd07767 Add raw copy support (raw=yes), tweak tempfile error message string. 12 years ago
Michael DeHaan 0cf5e5cec3 Merge branch 'devel' of git://github.com/bradleyy/ansible into together 12 years ago
Michael DeHaan 0756aa406a Change conditional operation workflow.
Conflicts:

	lib/ansible/utils/__init__.py
12 years ago
Michael DeHaan 7f462a346a Work in progress on merging changed_when. 12 years ago
Michael DeHaan 88720516a1 Merge branch 'changed_when' of git://github.com/stoned/ansible into changed_when 12 years ago
Michael DeHaan f592340f7f Merge branch 'playbook-skip-tags' of git://github.com/dekked/ansible into skip_tags 12 years ago
Michael DeHaan 3baa55a314 Merge branch 'devel' of git://github.com/sjmudd/ansible into sjmudd_ranges 12 years ago
Michael DeHaan 62b39d3de5 Fix for saving conditionals in variable expressions. 12 years ago
Michael DeHaan bf70dfc1a0 When a role/include has a conditional, add that conditional ahead of any on the task, not behind, so it can short circuit. 12 years ago
Michael DeHaan 419661542b Added some pipes.quote ops to make sure paths with spaces in them are ok. 12 years ago
Michael DeHaan 192d9f8b89 Merge pull request #3607 from stoned/use-AnsibleFilterError
Use AnsibleFilterError exception
12 years ago
Stoned Elipot 667ad2480e Use AnsibleFilterError exception 12 years ago
Stoned Elipot e7a733a6be Quote pathnames of roles' tasks and handlers files so that _load_tasks() can tokenize them properly
With the help of AlejandroTrev's eagle eyes. Thanks !
12 years ago
Michael DeHaan 0f26439234 Remove variable per pyflakes 12 years ago
Michael DeHaan e1167d6977 tweak indentation for 'make pep8' 12 years ago
Michael DeHaan 0f4229f6c4 Merge pull request #3462 from stoned/filtererror
Introduce exception AnsibleFilterError and use it in Jinja filters.  Ign...
12 years ago
Brian Coca dafbcf87d3 changed atomic_move to be more 'optimistic' which helps deal with corner
cases and avoid usless work.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan c10c2cae4e Merge branch 'ansible_sudo_at_role_level' of git://github.com/jeromew/ansible into sudo_role 12 years ago
Michael DeHaan f7dec4f8f4 Rename plugin. 12 years ago
Michael DeHaan 9dec701728 Merge pull request #3559 from sergevanginderachter/flat_list
Introduce flat_list lookup plugin
12 years ago
Michael DeHaan 7d2585caf7 Merge pull request #3577 from Tinche/extra-vars-in-playbook-includes
Enabled the use of extra vars in playbook file paths when including play...
12 years ago
Brian Coca c8d6e5be0b missing self in self method usages
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael Vogt 9caef884e1 fail early on the wrong sudo password instead of waiting until the timeout happens 12 years ago
Michael DeHaan c98b20b2cf Slight style preferences. 12 years ago
Sharif Olorin 5fcbfa984d More informative error message on failure to resolve tmpdir 12 years ago
Sharif Olorin 1a7a779e88 Handle SSH failures when creating remote tmpdir
Bail out if the SSH command fails rather than continuing with an
empty tmp variable.
12 years ago
Michael DeHaan 8a3ea0774a Update error message since user may have specified connection type via non command line or by default. 12 years ago
Michael DeHaan 5eea4b56fa Merge pull request #3591 from cocoy/fix_3567
Allow roles to be interpolated from --extra-vars
12 years ago
Michael DeHaan 7965bc729b Merge pull request #3588 from Atte/devel
Check for existence of isatty on stdout before calling it
12 years ago
Rodney Quillo a4e829c874 Allow roles to be interpolated from --extra-vars 12 years ago
Atte Virtanen 511c7c858d Check for existence of isatty on stdout before calling it 12 years ago
Brian Coca f6c99a69db switched from sestatus to selinuxenabled as per recommendation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca 98cc29f9fd now returns fatal error if operation on selinux enabled target is
attempted w/o selinux python bindings
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
jeromew de0bc96b70 Implement sudo/sudo_user at the include and role levels 12 years ago