Jérémy Lecour
2fb9b46752
Lineinfile must not insert lines multiples times with insertbefore/insertafter ( #49409 )
...
* Change test suite to fit expected behaviour
This reverts some changes from ansible/ansible@723daf3
If a line is found in the file, exactly or via regexp matching, it must
not be added again.
insertafter/insertbefore options are used only when a line is to be
inserted, to specify where it must be added.
* Implement the change in behaviour mentioned in the previous commit
* Fix comment to reflect what the code does
* Set the correct return message.
In these cases, the lines are added, not replaced.
* Add a changelog
6 years ago
Matt Martz
7eb1ab45a7
Allow tags to be templated from a variable ( #49833 )
...
* Allow tags to be templated from a variable. Fixes #49825
* Restore _load_tags to ensure we do csv tag splitting
* Add tests for csv tags and templated tags
* evaluate_tags doesn't need to accept strings, because _load_tags handles this
6 years ago
Matt Martz
a0d71e7735
Fix reverse_inventory order to work on python3 ( #49895 )
6 years ago
Aleksander Kovtunenko
ba562043e1
changed if logic Type to boolean ( #49628 )
...
* changed Type to boolean
* fix after review
* created fragment
6 years ago
Matt Clay
0ccd231afd
Fix MySQL tests when running under Docker. ( #50047 )
6 years ago
Dag Wieers
a8292778f0
Fix GitHub handle, use keachi ( #50043 )
...
* Fix GitHub handle, use keachi
* Add UTF8 name
6 years ago
Toshio Kuratomi
61b1daa65f
Port from plaform.dist to ansible.module_utils.distro.linux_distribution
...
ci_complete
6 years ago
Adrian Likins
be65d9cfe5
Skip sanity tests that don't apply to bundled code
...
* add distro to pep8 skip tests
* Skip no-assert test for distro
* Add bundled distro to the empty-init skip list
6 years ago
Adrian Likins
e872811b8d
WIP: add tests to compare to platform.*dist
...
Can be removed once everything is ported.
6 years ago
Adrian Likins
78a8d09082
Changes to bundled distro to be Python-2.6 compatible
...
* Port bundled distro to use optparse instead of argparse (py2.6)
* Use an absolute import to satisfy the current import testing harness
* Port from subprocess.check_output to subprocess.Popen.communicate() (py2.6)
* Add license location
The changes have been proposed upstream here:
https://github.com/nir0s/distro/pull/232
Upstream is contemplating a branch where everyone wanting python-2.6
support can collaborate without it becoming part of the regularly
supported releases.
6 years ago
Adrian Likins
5e1f8a48f3
Bundle a copy of github.com/nir0s/distro/distro.py
...
Since the 'platform.dist()' and 'platform.linux_distribution()'
methods will be removed from future versions of python, this
provides an alternative to replace ansibles use of those
methods.
lib/ansible/module_utils/distro.py is a copy of
https://github.com/nir0s/distro/blob/master/distro.py
This module is originally from https://github.com/nir0s/distro
and is license under the Apache License, Version 2.0.
6 years ago
Nathaniel Case
61a649ce0f
Don't fail if a remote_addr with a '/' hits ansible_connection ( #49781 )
...
* Fail if a remote_addr with a '/' hist ansible_connection
This is _probably_ a CIDR block, but anything with a slash will fail,
so no need to try to parse to make sure
* Locks are now per-socket_path.
Locks use the same value as socket_path. Locks are also cleaned up in
shutdown like sockets.
6 years ago
Nathaniel Case
bf4ad56479
Move errors from import to connect ( #50034 )
6 years ago
Dag Wieers
d4ee599fe9
Add types to common url parameters ( #50000 )
6 years ago
Dag Wieers
00a83035f2
Meraki: Add types to common parameters ( #49998 )
6 years ago
Dag Wieers
0eb2924380
MSC: Add type to common module parameters ( #49999 )
6 years ago
Dag Wieers
e8885ee4e8
ACI: Add types to modules and doc fragment ( #49997 )
...
* ACI: Add types to module doc fragment
* Add types to ACI modules too
6 years ago
Dag Wieers
b3f062b5ca
Clean up backup doc fragment ( #49995 )
6 years ago
Dag Wieers
3bcc0c0498
Add types to vmware REST client/VCA doc fragments ( #50001 )
6 years ago
Dag Wieers
653c3da500
Fix document references in modules ( #49892 )
...
* Docs: Fixes internal module reference syntax for seealso
* Updates anchors and links
* Updates seealso in the docs for module **win_chocolatey**.
6 years ago
Martin Nečas
651ea5da44
add to ovirt snapshot download and upload disk ( #46696 )
...
* add to ovirt snapshot download and upload disk
* ovirt snapshot update docs
* ovirt snapshot add version_added to docs
* update ovirt snapshot docs
6 years ago
John R Barker
7ddc59b980
Gundalow no net docs updates ( #50031 )
6 years ago
Jeffrey Reeves
1e647db8dc
Redacted IP addresses under SSH_CLIENT & SSH_CONNECTION ( #49991 )
6 years ago
Eric Miller
4d0f2e632c
Docker inventory service/stack groups for docker swarm ( #48021 )
...
* Adding service and stack grouping to docker inventory
* Updating documentation
* Adding changelog fragment for docker.py inventory script
6 years ago
Johannes Brunswicker
87ee59b8d7
Sophos UTM - add module to handle utm ca host key certificate entries ( #48927 )
...
* - add module to handle utm ca host key certificate entries
* - fixed typos in doc
* Apply suggestions from code review
Co-Authored-By: MatrixCrawler <johannes.brunswicker@gmail.com>
6 years ago
Andrey Klychkov
b5ca54eeed
New module - postgresql_idx ( #49684 )
...
* New module - postgresql_idx
* New module postgresql_idx: added returns block
* New module postgresql_idx: fixed documentation, typos and added idxname to fail_json
6 years ago
Dag Wieers
ba573777ba
Add types to docker module fragments ( #50002 )
6 years ago
Deepak Agrawal
0f2f38b044
network_cli - ansible_command_timeout not working as expected ( #49922 )
...
* fix for command_timeout
Signed-off-by: Deepak Agrawal <deepacks@gmail.com>
* fix ci warning
Signed-off-by: Deepak Agrawal <deepacks@gmail.com>
* fix review comments
Signed-off-by: Deepak Agrawal <deepacks@gmail.com>
6 years ago
f-bor
134c1a624e
new network module: edgeswitch_vlan ( #48041 )
...
* initial commit
* better commands generation
6 years ago
anasbadaha
1580afbd62
Fixes #46410 Onyx show facts module does not work for onyx version 3.6.6000 and higher ( #49414 )
...
Signed-off-by: Anas Badaha <anasb@mellanox.com>
6 years ago
anasbadaha
369354547e
Issue: 46475 Fix onyx magp module for supporting new json format ( #49417 )
...
Signed-off-by: Anas Badaha <anasb@mellanox.com>
6 years ago
Zim Kalinowski
de3d188cdd
support lro in azure_rm_resource ( #49919 )
6 years ago
Toshio Kuratomi
e09196f760
Fix validate-modules to not complain about sys.exit in comments
6 years ago
Toshio Kuratomi
175f3b51e5
Ensure that current uses of BaseException are required
...
* In some cases, it appears that Exception should have been used instead
as there's no need to catch sys.exit KeyboardInterrupt and similar.
* In a few cases, it appears that BaseException is used because
a library we depend on calls sys.exit() contrary to good coding
design. Comment those so that we know that those have been audited
and found to be correct and change to use (Exception, SystemExit)
instead.
6 years ago
Toshio Kuratomi
3fba006207
Update bare exceptions to specify Exception.
...
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
6 years ago
Toshio Kuratomi
5147e792d3
Enable the bare-except pylint and pep8 checking
6 years ago
Felix Fontein
65d5f1a4ef
Fix stacktrace when fail_on_error is False and a file cannot be parsed. ( #49987 )
6 years ago
anasbadaha
c0dbc1a441
Issue/38837 ( #49873 )
...
* Fix Issue #38837
Signed-off-by: Anas Badaha <anasb@mellanox.com>
* Fix Issue #38837 2
Signed-off-by: Anas Badaha <anasb@mellanox.com>
* Enhance decumentation
Signed-off-by: Anas Badaha <anasb@mellanox.com>
* Fix Failures in Shippable
Signed-off-by: Anas Badaha <anasb@mellanox.com>
* Fix Version Added
Signed-off-by: Anas Badaha <anasb@mellanox.com>
* Add version_added:2.8 in purge attributes
Signed-off-by: Anas Badaha <anasb@mellanox.com>
6 years ago
Abhijeet Kasurde
1558f77081
AWS: make jittered_backoff API parameter configurable ( #49086 )
...
* AWS: make jittered_backoff API parameter configurable
* Review comments
* minor doc changes
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Abhijeet Kasurde
162d9497ba
Ad-hoc command: fix 'any' call in play_ds ( #49852 )
...
* Ad-hoc command: fix 'any' call in play_ds
* Unit test for ad-hoc cli
* Review comments
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Abhijeet Kasurde
ef3b75afcd
fortimanager: Correct example documentation ( #49925 )
...
Fixes : #49813
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Dag Wieers
26474c6902
Add seealso section to Windows and related modules ( #49845 )
...
* Add seealso section to Windows and related modules
* Fixes after review
6 years ago
Martin Krizek
79947245e2
docs: remove not implemented password_hash feature ( #49945 )
6 years ago
Matt Martz
67ce743cc9
Remove erroneous extra-vars example, and a few really old versionadded indicators. Fixes #38415 ( #49955 )
6 years ago
Adam Miller
16f48bb4be
add changelog for pr #49912 ( #49962 )
...
Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Adam Miller
0eabb8097b
Fix yum/dnf handling of URIs that don't end in .rpm ( #49912 )
...
Fixes #49727
Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Dave Bendit
d62d7176b0
[docker_container] Failing on non-string env values ( #49843 )
...
* [docker_container] Failing on non-string env values
Fixes #49802
* Clarify failure message
Co-Authored-By: DBendit <David@ibendit.com>
* Fixup from review
6 years ago
Dave Bendit
c67f4290e6
[docker_volume] Checking option minimal versions ( #49839 )
...
Fixes #38833
6 years ago
Akshay Gaikwad
1e0363ec7d
Support for cache_from parameter in docker_image module ( #49787 )
...
* Support for cache_from parameter in docker_image module
Fixes #21704
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
* Minimum docker version check for cache_from option
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
* Add changelog fragment
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
* cache_from fix when docker-py is older
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
6 years ago
Chad Anderson
6ff7797eaa
Move verify up so approle and other methods work as intended.
6 years ago