Commit Graph

22685 Commits (a93445c798e06d1828a546807bd610af3fd2e376)
 

Author SHA1 Message Date
Jérémie Astori a93445c798 Remove support for `d[efault]:` in entry permissions
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
8 years ago
Toshio Kuratomi ffbd1efaa7 Remove non-ascii quote char 8 years ago
Rick Mendes 8048c4482a using single device_id and enabling release on disassociation 8 years ago
Marius Gedminas b2fc74337a authorized_key: fix example in documentation
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
8 years ago
Tim Rupp 223cac3f39 Add hostname support for Kali linux 2.0
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error

   hostname module cannot be used on platform Linux (Kali)

Kali is based off of Debian.
8 years ago
Luke aa9b8b8552 removed hyphens in module name in examples 8 years ago
Timothy Appnel 488749500e Clarified and cleaned up grammar of error messages. 8 years ago
Timothy Appnel d811a51744 Fixed call to undefined attribute when RDS module timeouts waiting. 8 years ago
Marius Gedminas f97d00fbad user: don't generate SSH keys in check mode
Fixes https://github.com/ansible/ansible/issues/11768

Test plan:

- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:

    ---
    - hosts: trusty
      tasks:
        - user: name=bob state=present generate_ssh_key=yes

- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
  exist: ansible-playbook --check worked correctly (no errors, reported
  "changed")
8 years ago
Marius Gedminas 270c2e8bbd apt: check for "0 upgraded" to be at the beginning of the line
Fixes #1678.
8 years ago
Till Backhaus e005ef0c36 Delete dead and broken code 8 years ago
Omri Iluz 1c6acc3e8f No need for .keys on volumes list
Since c3f92cca21 changed "volumes" to be a list instead of a dictionary, we don't need (and cannot) .keys when appending to set.
Reported as bug #1957
8 years ago
Simon Li 28c44c554c Don't fail in check_mode if user exists
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
8 years ago
James Cammarata b9ca912ffe Fixing region requirement regarding euca clusters
Fixes ansible/ansible#11023
8 years ago
nitzmahone 51154a6991 added windows facts ansible_lastboot, ansible_uptime_seconds
switched OS object to Get-CimInstance since we need a DateTime object for lastbootuptime
8 years ago
Toshio Kuratomi 1102afed43 Fix for the case where plugins aren't loaded on old RHEL systems 8 years ago
Toshio Kuratomi 77457feda6 Return change results in a dictionary listing the package names.
Fix a parsing problem when package names contain a dot.
8 years ago
Brian Richards c054a058c0 Preventing servers that are deleted and left in the deleted state from being included in the server list 8 years ago
Nithy Renganathan eb3f28effc Handle the changed value 8 years ago
Jason Cowley 2c511a9470 Add support for S3 canned permissions. resolves #1939 8 years ago
Sam Yaple f2c1eeb54c Actually remove the section we are replacing 8 years ago
Sam Yaple 52d364b74c Refix bug 1226 after revert
This patch properly fixes bug 1226 without introducing a breaking
change to idempotency which was introduced in PR #1358

We can properly assign permissions to databases with a '.' in the name
of the database as well as assign priviliges to all databases as
specified with '*'
8 years ago
Jérémie Astori 1b34f1a7ac Fix wrong expectation regarding entry format in acl module 8 years ago
Jérémie Astori 6c298e20c0 Fix wrong processing of lines returned by setfacl in test mode 8 years ago
Jérémie Astori 08e8f732c5 Fix minor whitespace issues 8 years ago
Brian Coca 9ad712018c deal with more failures when apt module fails to instantiate pkg fixes #1499 8 years ago
Mahesh Sawaiker 4b6471d5e7 support creating role only 8 years ago
Ilya Epifanov cbbf284a74 fixed memory_limit for docker api version >= 1.19 8 years ago
David M. Lee 4cd2fcf917 ec2_vol: Added missing "needs 2.0" doc
The ability to find-or-create a volume was added in 2.0. Added note to
the example.
8 years ago
Evan Carter c1526ff87b Adding the ability to associate eips with network interfaces 8 years ago
Shobhit Srivastava 316ccb0e65 checking remote_group_id while comparing os_security_group_rule 8 years ago
Sam Yaple f8bcdffa36 Revert "escapeds changes"
While this change doesn't break the creation, it does break
idempotency. This change will convert '*.*' to '`*`.*' which is
functionally the same, however when the user_mod() function looks up
the current privileges with privileges_get() it will read '*.*'

Since '*.*' != '`*`.*' it will go through the process of updating the
privleges always resulting in a 'changed' result.

This reverts commit db9ab9b262.
8 years ago
Brian Lloyd e6ffb60855 Windows implementation of lineinfile and related documentation 8 years ago
Jason DeTiberus 3619630972 python 2.4 syntax fix 8 years ago
Jason DeTiberus 8bc90c6a62 Add example for changing consumed subscriptions 8 years ago
Adam Ever-Hadani 8fb52e0a8b added support for 'collectstatic clear' in django_manage.py 8 years ago
brannon 8691d56f3c Support creating new VMs by cloning an existing VM. Support setting power state of cloned VMs. 8 years ago
Scot Spinner 0fff871819 one thing missed 8 years ago
Guto Andreollo 81a1579e20 Added the 'hw_interfaces' array, listing the names of all interfaces present on the VM as 'ansible_interfaces' lists the ones seen by the operating system 8 years ago
Andrew Briening bd531f87bc Show the exception messages 8 years ago
Matthias Frey 2ed50d5e5b assemble: add file validation support. 8 years ago
Nikolay Ivanko 33f1da6452 add virtual floppy to VMware guest 8 years ago
Mehul Ved 832f251e90 renamed variables type to cdb_type and version to cdb_version. 8 years ago
HAMSIK Adam 217764ba3c Rebase start/stop instance pull code 8 years ago
Александр Костырев ec8a94f748 Fix documentation of authorized_key.py
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
8 years ago
Brian Coca a1992ad890 updated encoding comment and expanded authors field 8 years ago
Jérémie Astori 288a9d8500 Set version number in recursive option description 8 years ago
Jérémie Astori 17170992c3 Ensure Python 2.4 compatibility and Linux-restricted support
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
8 years ago
Brian Coca c341df2231 updated docs for package 8 years ago
Marius Gedminas 9ab2e9c740 Fix obvious copy-paste error in module docs 8 years ago