Commit Graph

55104 Commits (a49f7a8fe5fa1ad67f34e22ef31f22db183bcd20)
 

Author SHA1 Message Date
Martin Krizek a49f7a8fe5
[stable-2.19] Don't special case implicit meta tasks when filtering on tags (#85805) (#85938)
* Don't special case implicit meta tasks when filtering on tags

Fixes #85475
(cherry picked from commit 313c6f6b4d)
1 month ago
Felix Fontein 81d883687e
Make sure ansible-doc doesn't crash when scanning collections whose path contains ansible_collections twice (#85361) (#85930)
Ref: https://github.com/ansible/ansible/issues/84909#issuecomment-2767335761



(cherry picked from commit c6d8d206af)

Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
1 month ago
sivel / Matt Martz 41ac662dec
Update Ansible release version to v2.19.3.post0. (#85952) 2 months ago
sivel / Matt Martz 81b8229057
New release v2.19.3 (#85949) 2 months ago
Matt Davis 73c439cb75
Update Ansible release version to v2.19.3rc1.post0. (#85925) 2 months ago
Matt Davis cd95e0ff4b
New release v2.19.3rc1 (#85923) 2 months ago
Brian Coca 06900bbbac
script inventory plugin correct error message (#85765) (#85868)
type was reflecting 'converted' type, not 'pre conversion' of the data
now message points at specific data keys
add deprecation tests

(cherry picked from commit c87dc6ed7d)
2 months ago
Sloane Hertel 3f7210d00a
Fix ansible-doc -l/-F/--metadata-dump for relative imports in filter/test plugins (#85801) (#85860)
* Add test for sidecar documentation for filter plugin in a subdirectory

Fix ansible-doc --list/--list_files/--metadata-dump for relative imports in nested filter/test plugin files

(cherry picked from commit 5e8815b823)
2 months ago
Jordan Borean 60fe03290f
Windows async - handle trailing junk output (#85820) (#85829)
Add handling for when a PowerShell module emits more than just the
module result JSON. The behaviour reflects the Python async wrapper
where trailing data after the module result will emit a warning.

(cherry picked from commit aad9fbd4f5)
2 months ago
Abhijeet Kasurde d09ee36b8f
[stable-2.19] fetch_file: add ca_path and cookies parameters (#85187) (#85821)
* Added ca_path and cookies parameter arguments to fetch_file method
  to specify CA path and Cookies to fetch file from URL. These parameters
  are already supported by fetch_url.

Fixes: #85172
(cherry picked from commit 1cd4369)

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2 months ago
🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) 235e6a8cf6
[stable-2.19] 🧪 Pin codecov-cli deptree used in AZP (#85898)
PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With https://github.com/getsentry/prevent-cli/pull/95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* https://github.com/getsentry/prevent-cli/pull/95
* https://github.com/pallets/click/issues/3066

ci_coverage
ci_complete
(cherry picked from commit 1e572ba5cc)
2 months ago
sivel / Matt Martz a7eee1536f
[stable-2.19] Prevent IO capture hang/loss in `basic.run_command` (#85869) (#85891)
* Prevent run_command output truncation or hang

In cases when the selector used to monitor stdout/stderr activates without
data ready to read (a rare but normal condition), a read from a non-blocking
FD can return `None`, which was being conflated with an empty read (EOF)
condition. This caused the selector to be unregistered prematurely,
sometimes resulting in truncated output or hangs. `None` read results
are now excluded from EOF conditions.

* add changelog

---------
(cherry picked from commit 79ddee1)

Co-authored-by: Chris Meyers <chrismeyersfsu@users.noreply.github.com>
Co-authored-by: Matt Davis <nitzmahone@redhat.com>
2 months ago
Matt Clay 423032930b
[stable-2.19] Move display internals into _internal (#85889) (#85896)
(cherry picked from commit 58bad71859)
2 months ago
Matt Davis 7ff2307dee
Update Ansible release version to v2.19.2.post0. (#85826) 3 months ago
Matt Clay ca99cc7e55
New release v2.19.2 (#85822) 3 months ago
Matt Davis cc342f6f2f
Update Ansible release version to v2.19.2rc1.post0. (#85791) 3 months ago
Matt Davis 24c92b2d24
New release v2.19.2rc1 (#85788) 3 months ago
Martin Krizek 764070de69
[stable-2.19] Expose ansible_failed_task in rescue for explicit flush_handlers (#85687) (#85707)
Fixes #85682

(cherry picked from commit c5ddc93767)
3 months ago
Martin Krizek 9aea625f63
[stable-2.19] ternary: evaluate values lazily (#85752) (#85753)
Fixes #85743
(cherry picked from commit 6976e13075)
3 months ago
Matt Clay f2a4eb74ec
[stable-2.19] ansible-test - Update Ansible Core CI auth (#85717) (#85768)
Implement new authentication methods for accessing the Ansible Core CI service.

(cherry picked from commit be9e57366b)
3 months ago
Matt Clay 8203ef0fe0
[stable-2.19] CI - Add missing args to generic.sh (#85737) (#85738)
(cherry picked from commit 7b598f3fc9)
3 months ago
Matt Martz adb3c6fae5
Update Ansible release version to v2.19.1.post0. (#85731) 3 months ago
Matt Martz 43cac0b1d2
New release v2.19.1 (#85730) 3 months ago
Matt Davis 695afe4fe7
Update Ansible release version to v2.19.1rc1.post0. (#85699) 4 months ago
Matt Davis 7fc339e4aa
New release v2.19.1rc1 (#85698) 4 months ago
Matt Davis 875b258977
Include result origin in broken conditional message instead of result (#85695) (#85697)
(cherry picked from commit b1fc98c8ad)

Co-authored-by: Matt Clay <matt@mystile.com>
4 months ago
Abhijeet Kasurde 8849bd776b
[stable-2.19] service_facts: Handle KeyError while processing service name (#85572) (#85647)
* service_facts: Handle KeyError while processing service name

As a part of follow up review,

* Handle KeyError with exception handling
* Warn user about the missing service name in the given service details
(cherry picked from commit 9ed7164)

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
4 months ago
Matt Clay 8d26bbf3f7
[stable-2.19] Fix marker handling in templating (#85690) (#85694)
* allow markers to pass through template lookup
* avoid tripping markers within Jinja generated code

(cherry picked from commit 558676fcdc)

Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
4 months ago
Matt Clay a00261b0ec
[stable-2.19] ensure undefined marker access on Jinja getattr->getitem fallback (#85688) (#85691)
(cherry picked from commit 3518d48146)

Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
4 months ago
Sloane Hertel 6404fdce45
Fix nested import_tasks when the parent import contains a template (#85599) (#85636)
* Test nested import_tasks when the parent import contains a template

* Fix templating the parent_include.args

(cherry picked from commit 9a6420e1d5)
4 months ago
Matt Davis 2dcd35b692
[stable-2.19] Backward-compatible None handling in template concat and argspec str (#85652) (#85663)
* Backward-compatible None handling in template concat and argspec str (#85652)

* templating coerces None to empty string on multi-node result

* avoid simple cases of embedded `None` in multi-node string concatenated template results ala <=2.18
* single-node template results preserve NoneType

* add None->empty str equivalency to argspec validation

* fix integration tests
* remove conversion error message check from apt_repository test
* remove error message check on `None` value for required str argspec in roles_arg_spec test (now logically-equivalent to empty string)

* explanatory comment for None->empty str coalesce

(cherry picked from commit e3c9908679)

* eliminate None template nodes in _flatten_nodes (#85676)

* defers value or concat choice until Nones are gone
* fixes None -> empty string for TemplateModule cases
* add tests

(cherry picked from commit 5345ac9911)
4 months ago
Abhijeet Kasurde e24bc689a3
[stable-2.19] test: Remove redundant Python 3 condition (#85664) (#85675)
(cherry picked from commit 603dd2d)

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
4 months ago
Matt Clay 3c1e46435b
[stable-2.19] Fix slicing of tuples in templating (#85608) (#85661)
* Fix slicing of tuples in templating

* Improve lazy container test coverage
(cherry picked from commit 00fe38215c)
4 months ago
Matt Clay 0718473815
[stable-2.19] Fix filter plugin result processing (#85653) (#85662)
(cherry picked from commit 76748b8478)
4 months ago
Matt Davis db4973572a
Add temporary module result serialization hook (#85609) (#85621)
* Add temporary module result serialization hook

* Sanity test fix

---------


(cherry picked from commit faf86ca2b3)

Co-authored-by: Matt Clay <matt@mystile.com>
4 months ago
Matt Davis 99d701ccf9
default _ansible_tracebacks_for to [] when not specified (#85427) (#85453)
* eases module unit tests that aren't using our fixture

(cherry picked from commit 6b347bfbf7)
4 months ago
Brian Coca ddf2bd773c
meta: clear_host_errors, clarify what this applies to (#85463) (#85465)
* meta: clear_host_errors, clarify what this applies to

It clears host for selection, but does not change state in the current iterator.

* also update example

(cherry picked from commit 319dca2ea8)
4 months ago
Matt Davis 5a20b991d4
Rewrite exception key on failed_when: false (#85516) (#85517)
* Prevents callback handle_exception from displaying the captured exception when the task is not failed.
* Added tests.


(cherry picked from commit 2fbd7c114e)

Co-authored-by: Matt Clay <matt@mystile.com>
4 months ago
Brian Coca 68378c85cb
plugin config options are now correctly fetched with origin (#85488) (#85525)
* also update callbcacks, since they override these functions
due to backwards compat _options being taken for CLI

(cherry picked from commit 19f9c66004)
4 months ago
Abhijeet Kasurde e8272f1038
[stable-2.19] filter: update integration tests (#84990) (#85540)
(cherry picked from commit 181dbdb)

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
4 months ago
Matt Clay d58c99ddd4
[stable-2.19] Add AnsiballZ debugging support with debugpy (#85476) (#85528)
* Add AnsiballZ debugging support with debugpy

Adds support for debugging AnsiballZ modules with debugpy which is used
by VSCode as its Python debugger DAP. Debugging can either be done
through a manual Debugpy listening server through a launch.json
configuration or through the new ansible-test --dev-debug-on-deman
argument.

* Fix up integration test

* Simplify config option and move mypy ignore

* Use new API if available and fix typo

* Guard the import of debugpy

* Fix sanity import issue

* Minor cosmetic adjustments

* Simplify debugger setup

* ansible-test - Refactor debugging interface

* Add ansible-test debug integration tests

* Fix ansible-test shell when in unsupported dir

---------
(cherry picked from commit 3882366585)

Co-authored-by: Jordan Borean <jborean93@gmail.com>
4 months ago
Martin Krizek 28ca9c09fb
[stable-2.19] dnf/dnf5: address issues discovered in 2.16 yum tests (#83659) (#85607)
Fixes #85554
(cherry picked from commit c0256d6)
4 months ago
Matt Clay a5cc030818
[stable-2.19] ansible-test - Limit bootstrap package install retries (#85544) (#85546)
(cherry picked from commit ee297bb7ca)
4 months ago
Matt Clay 85af5cadf3
[stable-2.19] tqm: Use correct warning methods (#85434) (#85550)
* Use display.error_as_warning instead of self.warning
* Use display.error_as_warning instead of display.warning_as_error.

(cherry picked from commit ea238c9eb5)

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
4 months ago
Matt Clay f28faa7fbf
[stable-2.19] ansible-test - Fix coverage config (#85555) (#85559)
(cherry picked from commit 35830cb054)
4 months ago
Matt Clay cf6266cc2d
[stable-2.19] Fix paramiko deprecation unit test (#85573) (#85574)
The unit test previously assumed paramiko was installed, and would fail if it was not.

(cherry picked from commit 43a20c9f68)
4 months ago
Matt Clay 116cc16bc9
[stable-2.19] Update azure-pipelines-test-container (#85578) (#85579)
(cherry picked from commit 62dc40ce1c)
4 months ago
Matt Clay 72c3a20e1a
[stable-2.19] ansible-test - Use OS packages on FreeBSD 13.5 (#85530) (#85531)
(cherry picked from commit cdb7af094b)
4 months ago
Matt Clay fb09e79b2f
[stable-2.19] Fixed string type in tags fieldattribute (#84655) (#85452)
(cherry picked from commit 8207406306)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
4 months ago
Matt Davis fc73880e08
Update Ansible release version to v2.19.0.post0. (#85514) 5 months ago