Commit Graph

32872 Commits (a09a231be7df3200ee1384707aa28175b254a71b)
 

Author SHA1 Message Date
Guillaume Coré a09a231be7 ini_file: add integration test (#24434)
* ini_file: add integration test

Start integration tests for ini_file module.

* ini_file test: add comments for lisibility

* update from review: use var instead of checksum to assert content
7 years ago
aperigault 3622801ad4 Use ansible network env vars to authentication on fortigates (#29499) 7 years ago
rahushen bc6e015a86 Fixes #27138 (#29064) 7 years ago
Trishna Guha 578ae3b238 fix nxos_file_copy and provider getting set to None when transport is cli (#30262)
* nxos_file_copy bug fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* provider gets set to None in module level when transport is cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Ganesh Nalawade d8371cec91 Fix ios_system lookup enable issue (#30263)
Fixes #29974

Add `None` check while comparing module parameter values (want) with the actual
configuration present on device (have).
7 years ago
follower 8489e298ca doc: Typo fix: "accesability" --> "accessibility" (#30251) 7 years ago
Christian Pointner 1fe5171f1a openssl_certificate: make subject-alt-name identifier conistent with openssl_csr (#30151) 7 years ago
Matt Clay 442af3744e Miscellaneous pylint fixes.
The following rules are no longer disabled:

- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
7 years ago
Jordan Borean 77b2aca5a2 fixed become to show the stdout and stderr streams instead of the StreamReader (#30254) 7 years ago
Mike Wiebe cef7ed0310 Fix nxos_mtu nxapi failure (#30153) 7 years ago
Daniel Shepherd 2cdf31d3a2 Update ec2_vpc_subnet_facts to use Boto3 (#25374)
* update ec2_vpc_subnet_facts module to use boto3 and support gathering updated fact items from AWS API

add version_added to new parameter

added return docs and other requested changes

removed errant extra blank line

updates per review

* update per review: fix AWSRetry backoff implementation and fix example that was not correct
7 years ago
Pavel Zagalsky 779e365639 Modified yaml examples (#29039)
Additional fields

Another change

Lint fix

Removed "valid" option from documentation

Checking without cert example

Added fake cert
7 years ago
Jacob McGill 2489eeece0 ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… (#29114)
* ACI EPG TO DOMAIN: Add vm_provider docstring and add support for microsoft and openstack

* Fix typo

* Fix whitespace
7 years ago
Matt Davis 212bb76326 deprecated azure classic module (#30241) 7 years ago
Mike Wiebe f973f93963 Fix nxos_smu error (#30157) 7 years ago
Martin Krizek 59702318e1 yum: fallback to epoch=0 if not available 7 years ago
Michael Price fd8b1e5f34 Refactor E-Series Storage-Pool to use module_utils (#20900)
Refactor the NetApp E-Series module to utlize the common module_utils
and doc_fragments.
7 years ago
Jordan Borean f6858cdd4d windows facts: better way to get machine SID (#29821)
* windows facts: better way to get machine SID

* remove the substring and just get the property that contains the value we need
7 years ago
Michael Price 984af98b1e NetApp E-Series Auth - Resolve issues with validate_certs and error handling (#30167)
* Cleanup password error handling for E-Series auth

The E-Series auth module was using some erronous behavior on handling
the status codes when updating the system password. This patch resolves
some of these issues.

* Fix validate_certs param in E-Series auth module

The auth module was ignoring the validate_certs parameter for making
HTTPS calls to the back-end API. This patch resolves the ignored
parameter.
7 years ago
abirami-n adc533804a module_utils_fix_dellos6 (#28060) 7 years ago
Raja Venkataraman c0000bc722 Handle wait_for_deployment_completion during Azure deployment. (#26079)
Pull the get_poller_result inside the if block so that if the caller has
wait_for_deployment_completion=False, it doesnt block and wait for it to
finish.

Also, since the result contains information about the deployment, provide
None values for it in the output.(Not sure if this needs to be documented)

Fixes #26014
7 years ago
Brian Coca a2b3bb1e49 only eval values if set from defaults 7 years ago
Nicklaus McClendon 6dbc3c63f8 Updated pip module to always return changed if venv is created (#24233)
* Updated pip module to always return changed if venv is created

Fixes #23204

* Add integration test to pip (see #23204)
7 years ago
Matt Davis 1e2ce4c8ab support missing drive letters in PS `path` type (#29884)
* fixes #26623
* Test-Path (and thus `-type path` in Get-AnsibleParam) fail on a nonexistent drive letter, since it can't be mapped to a PSProvider.
* added support and basic smoke tests for
7 years ago
Michael Price 8515db8588 Resolve issues with NetApp E-Series LunMapping module (#28294)
* Refactor E-Series LunMapping module to use module_utils

Refactor the NetApp E-Series module to utlize the common module_utils
and doc_fragments.

* Remove the default LUN number

By providing a default LUN number, it interferes with the ability of the
API to determine the appropriate LUN value.

* Fix ignored validate_certs parameter

The validate_certs parameter was not being provided to the underlying
requests method. This patch resolves the issue by passing the value to
all relevant HTTP requests.
7 years ago
Ganesh Nalawade 530988666a Allow delegate_to if transport is not cli (#29945)
Fixes #29060

Allow delegate_to if transport is either nxapi or eapi.

Persistent connection uses `cli` transport and create
a local socket on control node. Hence delegate_to is not allowed
for `cli` transport.

However as `nxapi` and `eapi` transport does not use persistent connection
it is possible to use delegate_to in this case.
7 years ago
Sloane Hertel b02937f3c3 [cloud] Document requirements for ec2_asg. (#30057) 7 years ago
Anil Kumar Muraleedharan 32f0c9f809 Bug Fixes for Vlan Name not assigned and Switch Error (#29953) 7 years ago
John R Barker 0a5fc3edf9 Add amuraleedhar to Lenovo (#30068) 7 years ago
Ricardo Carrillo Cruz b30cd60829 Fix nxos_user tests (#30048)
On our CI we use SSH port 8022, so parameterized the test passing
-p {{ ansible_ssh_port }}.
Also, force user/pass auth.
7 years ago
Andrea Tosatto 6b6e5665aa make os_security_group_rule idempotent (#23707)
* Fix issue #19610
7 years ago
Will Thames 0566d4672d [cloud] Add documentation around backoff and pagination for AWS module authors (#29883)
We field a lot of PRs that could be improved through use
of built in pagination and retry capabilities.
7 years ago
John R Barker bc2f4365b5 Correctly validate module name for modules with aliases (#29957)
* Correctly validate module name for modules with aliases

If a module has an alias (ie is a symlink) then we need to ensure that
DOCUMENTATION.module is set to the main name, not the aliased name

* formatting
7 years ago
Ricardo Carrillo Cruz 1da7194534 Remove provider lines from iosxr tests (#29956)
We don't use authorize on iosxr nor we use a special transport,
so no need to use iosxr for CLI at all.
7 years ago
Ganesh Nalawade 599fe23ed6 Fix unwanted deprecation message in network module args (#28984)
* Fix unwanted deprecation message in network module argspec

Fixes #25663
Fixes #24537

*  segregate provider spec and top level arg spec
*  add deprecation key in top level arg spec
*  remove action plugin code to load provider and add
   that logic at a common place in network_common.py file

* Fix CI issue

* Minor change
7 years ago
Martin Krizek d52316fcc2 yum cleanup (#28818) 7 years ago
Trishna Guha 5b1c91bf19 nxos_system parse name_servers fix (#29944)
* nxos_system parse name_servers fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_system tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Matt Clay 68aeaa58a8 Fix dangerous default args. (#29839) 7 years ago
Ganesh Nalawade 5caa47feb9 Add port and host check for neighbor args in junos_interface (#29941) 7 years ago
Tim Rupp 74ace093b8 Renames the bigip_configsync_actions module (#29747)
Retains the old name by making a symlink. We can remove it in a later
release.
7 years ago
Toshio Kuratomi cc343a4376 Port ansible doc for plugins to use DOCUMENTATION variables
* Using docstrings conflicts with the standard use of docstrings
* PYTHON_OPTIMIZE=2 will omit docstrings.  Using docstrings makes future
  changes to the plugin and module code subject to the requirement that we
  ensure it won't be run with optimization.
7 years ago
Sloane Hertel 9bc330c89b ec2: fixes #19521, fixes #29456 - create instance-store AMI instances with correct shutdown behavior (#28885)
* Create instance-store AMI instances with 'terminate' as the shutdown behavior since it is required.

* Match on the error code instead of searching for a string in the message.

* Narrow conditional to only fix shutdown behavior if fixing it would help

* Fix pep8.
7 years ago
Brian Coca 2165bac212 module and vault fixes (#29663)
* module and vault fixes

- fix module_path cli option and usage, which fixes #29653
- move --output to be in subset of vault cli, no need for all vault enabled cli to use it
- added debug to loader to see directories added
7 years ago
Dylan Silva 88aa0b7645 Fix bugs with modules_support.rst 7 years ago
ABond 1ec015410d digital_ocean_sshkey doc refinement and removal of unused import (#28960)
Updated doc examples and removed os import that was unused
7 years ago
Matt Clay 79bc49e150 Fix ansible-test unicode and sanity tests. (#29743)
* Show warning when using pylint on Python 2.6.
* Add pylint disable entries for Python 2.
* Fix unicode handling in ansible-test.
* Add missing documentation.
7 years ago
Abhijeet Kasurde b5eca624d0 Refactor easy_install module
* PEP8 fix
* Rectified string check in package install command stdout
* Add abadger's code review changes

Fixes #22245

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Tim Rupp a36ebd979d Adds missing docs and downstream fixes (#29664)
Partition docs are not a documentation fragment, so they need to
be added
7 years ago
Jordan Borean 5623e679b8 win_unzip: added support for Server core by using .net zip functions (#29272)
* win_unzip: added support for Server core by using .net zip functions

* fixed unzip behaviour with folders
7 years ago
Will Thames 5e978b0f2b Use JSON returns values to create RETURN docs
After running hacking/test-module to generate some output,
the JSON output can be fed into the return skeletion generator
to create an excellent starting point for RETURN docs
7 years ago