Commit Graph

4946 Commits (9e1bc434c768dab26468220de4bc57490f5666cd)

Author SHA1 Message Date
Scott Cunningham c4629b72e0 credstash lookup plugin: error out in run function when credstash not installed, not at module scope 9 years ago
Toshio Kuratomi bae7a02be5 Path of group_vars and host_vars were getting the basedir added twice.
Fix inventory so this won't happen and fix DataLoader so that it will
test relative paths relative to self._basedir

Fixes #11789
9 years ago
Toshio Kuratomi e7b5cb8782 Fix synchronize source path with roles and local connection
Fixes #8261
9 years ago
Toshio Kuratomi dd7fa07038 Update submodule refs so synchronize plugin works 9 years ago
Toshio Kuratomi 308bf80055 Cleanups to synchronize including:
* Better comments
* Reorganize code so related settings are close to each other
* Add ::1 to the "localhost" patterns we look for
* Make the dest_port parameter override the ansible_ssh_port setting
* Fix dest_port (wasn't being set)
* more complete detection of delegate_to
* Fix set_remote_user (wasn't being looked for in parameters)
* Instead of removing mode here, have the ansible module accept it
  (better documents the parameters doing it htat way)
9 years ago
James Cammarata 37e38924de Allow field attributes to have priorities
So that roles are loaded ahead of all other play fields, meaning any
plugins contained within the roles are loaded first before tasks.

Fixes #11858
9 years ago
Jon Hawkesworth f69da544f7 add win_basename and win_dirname filters 9 years ago
James Cammarata fad44862a5 Implementing includes in the free strategy 9 years ago
Brian Coca 2b9b3a08a1 make sure you only update pci data if there is a match 9 years ago
Yannig Perré 09d257e637 Porting ini lookup plugin against ansible v2. 9 years ago
Thomas Quinot 5d3cb636ad Minor comment fix 9 years ago
Yannig Perré 47db352725 Merge remote-tracking branch 'ansible/devel' into devel 9 years ago
Yannig Perré 733d40a77c When value does not exist, return default value instead of stopping ansible with an exception. 9 years ago
James Cammarata faf4c3bb6c Merge pull request #11816 from amenonsen/ssh-ipv6
Fix ssh connections to IPv6 addresses
9 years ago
James Cammarata dbd755e0f4 Fix jinja2 template search pathing
Fixes #9933
9 years ago
Scott Cunningham 934ce86d35 update credstash lookup plugin to use Python 2.4-compatible exception catching 9 years ago
James Cammarata 61e76fd707 Allow conditionals on PlaybookInclude statements
Fixes #11852
9 years ago
James Cammarata b6c3e5d797 Validate variable names given in set_fact
Fixes #11851
9 years ago
James Cammarata 5266679964 Use templar all the way down
Fixes bugs related to creating Templar() objects on the fly, where
the shared loader objects (serialized to TaskExecutor) aren't used
so information loaded into plugin loaders after forking is lost.

Fixes #11815
9 years ago
muffl0n 8d6d711a5c move get_available_hash_algorithms() from get_url 9 years ago
James Cammarata c3ce140dd2 Exclude loop_args from post_validation for tasks
This field is templated specially during the TaskExecutor's loop
calculation, so there's no need to post validate it again.

Fixes #11481
9 years ago
Brian Coca 015b922c1f fix quoting for become commands
fixes #11808
9 years ago
Toshio Kuratomi ca941ec632 style cleanup because -ECANNOTUNDERSTAND without it 9 years ago
Toshio Kuratomi f86245dcb0 Add a warning about python3 in the synchronize plugin 9 years ago
Toshio Kuratomi f0431eaea9 Make ansible_python_interpreter work with synchronize
Fixes #11836
9 years ago
James Cammarata 8279557e8f Allow role names to be templated
Fixes #10858
9 years ago
James Cammarata ed603f7030 Fix free strategy only running first play in a multi-play playbook
Fixes #11839
9 years ago
James Cammarata c2435fab7e Inject the play context vars into the variables used for loop item templating 9 years ago
James Cammarata bcbcfc79be Fix relative paths for included files
Also modifies the Play class to not include become* fields in the
post-validation step.

Fixes #11353
9 years ago
James Cammarata 2673eb0afb Add option to fail on undefined variables to listify
And use it in the call to get the loop items for a task.
9 years ago
James Cammarata a586c74967 Merge pull request #11838 from cchurch/stringify_powershell_unquote_value
Fix for PowerShell unquote method when passed None.
9 years ago
James Cammarata f6d1b5e233 Merge pull request #11835 from cchurch/raw_is_not_raw_enough
Raw is not raw enough
9 years ago
James Cammarata 7b9aee7077 Merge pull request #11832 from amenonsen/zeroforks
Disallow --forks 0
9 years ago
Chris Church cafc35fd5b Fix for PowerShell unquote method when passed None. 9 years ago
Abhijit Menon-Sen 7d9689c1c5 Slice ascii_letters directly instead of using 'for x in range()' 9 years ago
Abhijit Menon-Sen bfe708a189 Make host range parsing errors issue better messages
Now we always say "host range must …specific thing…"
9 years ago
Abhijit Menon-Sen 1413496292 Implement step for alphabetic ranges: [a:e:2] => a,c,e 9 years ago
Abhijit Menon-Sen 72715c6add Fix ssh connections to IPv6 addresses
We can unconditionally wrap remote_addr in square brackets for scp and
sftp (both of which require them for IPv6 addresses), but not wrap them
at all for ssh (which doesn't accept them). This way, we don't have to
detect and treat IPv6 addresses specially. This works for hostnames,
IPv4 addresses, and IPv6 addresses.

The earlier code seemed to intend to wrap all IPv6 addresses in square
brackets, which would have broken ssh, but it actually made no attempt
to detect IPv6 addresses at all (so it broke only with IPv6 addresses
for scp and sftp).

Based on a review of PR #11677 by @JuiceBoxSingularity
9 years ago
Chris Church 6969b5ac8b Make sure raw doesn't eat key=value arguments. 9 years ago
Abhijit Menon-Sen 861da614cc Make 'pause: prompt=…' print the prompt
In stable-1.9, the prompt string is passed to raw_input(), which prints
it without an extra \n. Here we're just print()ing it, so the \n would
be doubled.
9 years ago
James Cammarata 9936c5f9f6 Fixing the pause module for devel 9 years ago
Abhijit Menon-Sen 8de70fa657 Disallow --forks 0
Without at least one worker process, things break:

Traceback (most recent call last):
  File "/home/ams/extern/ansible/ansible/lib/ansible/executor/process/result.py", line 103, in run
    result = self._read_worker_result()
  File "/home/ams/extern/ansible/ansible/lib/ansible/executor/process/result.py", line 69, in _read_worker_result
    (worker_prc, main_q, rslt_q) = self._workers[self._cur_worker]
IndexError: list index out of range
9 years ago
Toshio Kuratomi cf35bdbdf9 Merge pull request #11827 from amenonsen/trivial-fixmes
Remove TODO: the play already overrides options
9 years ago
Abhijit Menon-Sen a9b020d6de Remove TODO: the play already overrides options 9 years ago
Abhijit Menon-Sen 1f2adb5e14 Show a better message when ansible.cfg is not found
Earlier we would say «Using  as config file» if we didn't find one.
9 years ago
Abhijit Menon-Sen 2cb7cd8379 Remove outdated FIXME; _compute_delegate is called below 9 years ago
Abhijit Menon-Sen 7b3cb2126c Remove outdated FIXME; ROLE_CACHE is already implemented below 9 years ago
Toshio Kuratomi 91a77b8603 Fix potential bug in parameter passing 9 years ago
James Cammarata 13b8a57d3d Undo previous travis/tox fixes and fix underlying issue 9 years ago
Toshio Kuratomi 0d72be3953 become protection for local connections no longer needed 9 years ago
Toshio Kuratomi d1933accc3 Fixes for synchronize with delegate_to 9 years ago
Toshio Kuratomi 3939348286 Fix HostVars to support containment tests 9 years ago
Chris Church 74df17de29 Add an option for PowerShell modules to indicate support for check mode, skip running module if check mode is not supported. 9 years ago
Chris Church e87cf4a3cc Fixes for WinRM/PowerShell support in v2.
- Add support for inserting module args into PowerShell modules.  Fixes #11661.
- Support Windows paths containing spaces.  Applies changes from #10727 to v2.  Fixes #9999.  Should also fix ansible/ansible-modules-core#944 and ansible/ansible-modules-core#1007.
- Change how execution policy is set for running remote scripts.  Applies changes from #11092 to v2.  Also fixes ansible/ansible-modules-core#1776.
- Use codepage 65001 (UTF-8) for WinRM connection instead of default (CP437), convert command to UTF-8 and results from UTF-8.  Replaces changes from #10024.  Fixes #11198.
- Close WinRM connection when task completes.
- Use win_stat, win_file and win_copy modules instead of stat, file and copy when called from within other action plugins (only when using WinRM+PowerShell).
- Unquote Windows path arguments before passing to win_stat, win_file, win_copy and slurp modules (only when using WinRM/PowerShell).
- Check for win_ping module to determine if core modules are missing (only when using WinRM/PowerShell).
- Add stdout_lines to result from running low level commands (so stdout_lines is available when using raw/script).
- Update copy action plugin to use shell functions for joining paths and checking for trailing slash.
- Update fetch action plugin to unquote source path when using Windows paths.
- Add win_copy and win_template action plugins that inherit from copy and template.
- Support running .bat and .cmd scripts using default system encoding instead of UTF-8.
- Always send PowerShell commands as base64-encoded blobs to allow for running simple PowerShell commands via raw.
- Support running modules on Windows with interpreters other than PowerShell.
- Update integration tests to support above changes and test unicode fixes.
- Add test for win_user error from ansible/ansible-modules-core#1241 (fixed by ansible/ansible-modules-core#1774).
- Add test for additional win_stat output values (implemented by ansible/ansible-modules-core#1473).
- Add test for OS architecture and name from setup.ps1 (implemented by ansible/ansible-modules-core#1100).

All WinRM integration tests pass for me with these changes.
9 years ago
Brian Coca fa8043c0ba corrected typo 9 years ago
Brian Coca f16b745f17 now properly uses default port if defined 9 years ago
Brian Coca 496186f5de makes ssh plugin resilient against invalid entries in hosts file
fixes #10238
9 years ago
Toshio Kuratomi e349004325 Update submodule ref to pull in apt_repo fixes 9 years ago
Jonathan Süssemilch Poulain 02294c52ce Typo 9 years ago
Jonathan Süssemilch Poulain 4614a574ea Allows network network interface facts collection as an unprivileged user and adds more facts 9 years ago
Jonathan Süssemilch Poulain e181bcf62b Allows to fetch machine architecture as an unprivileged user 9 years ago
Brian Coca 9aa4214417 fixed delegate_to ref in syncronize 9 years ago
Brian Coca 8a00dff989 updated submodule refs 9 years ago
Brian Coca 07e5e98cbf removed jinaj2 override restrictions 9 years ago
Brian Coca 113f709eac brought up to date with default 9 years ago
Brian Coca 51de207197 Merge pull request #11805 from amenonsen/trivial-fixmes
A series of trivial FIXMEs for devel
9 years ago
Scott Cunningham 193e857bc4 credstash lookup plugin: raise AnsibleError when credstash library not installed 9 years ago
James Cammarata 222f04e387 Submodule pointer update 9 years ago
Abhijit Menon-Sen 807079ec2f Remove outdated FIXME; HostVars is imported and used below 9 years ago
Brian Coca d05c4b82aa Merge pull request #11803 from amenonsen/prompt_encrypt
Uncomment encrypt handling for vars_prompt
9 years ago
Abhijit Menon-Sen 845784b572 Remove outdated FIXMEs; all use combine_vars already 9 years ago
James Cammarata efcad3aa6d Re-allow vars on tasks, specifically for includes 9 years ago
James Cammarata 0ad52a403f Merge pull request #11804 from amenonsen/fixme
Easy FIXMEs
9 years ago
Abhijit Menon-Sen 1541e331c9 Also fix UTF-8 handling in vars_prompt 9 years ago
James Cammarata 549c204051 Submodule pointer update 9 years ago
Abhijit Menon-Sen 694d2103b1 Remove outdated FIXME code
This is already handled in PlayContext.set_options.
9 years ago
Abhijit Menon-Sen ff2d160fff Correct invalid reference to global display 9 years ago
Abhijit Menon-Sen 10def3aa54 Uncomment encrypt handling for vars_prompt 9 years ago
Brian Coca b2dc66c7ea now check stderr also on become for ssh plugin for the cases where sudo or su do not want to prompt/echo on stdin
fixes #11796
9 years ago
Brian Coca 17f659a143 added some debug to galaxy 9 years ago
Brian Coca 29bc8f51d7 made tags display closer to v1 9 years ago
Brian Coca b37be236d9 Merge pull request #11475 from nibalizer/cfacter_support
Use cfacter instead of facter if possible
9 years ago
Abhijit Menon-Sen 3d581e5306 Don't stat None
Fixes #11794, regression introduced by #11010
9 years ago
Brian Coca 527ae360b0 Merge pull request #10652 from vodik/nspawn
Support querying systemd container information
9 years ago
Brian Coca 4b8e368039 Merge pull request #11010 from sillydong/devel
Add judgment to to fix path0 if ANSIBLE_CONFIG is set to a dir
9 years ago
Brian Coca 0e77871426 fixed non ignore errors path to actually interrupt
fixed cases where missing/inaccessible file gave exception, now you get nice error
9 years ago
Brian Coca 8153c34abf now returns false on bad role_data 9 years ago
Brian Coca e81ec32719 made galaxy more resilient with bad yaml files and comments/spaces in non yaml files
fixes #10641
9 years ago
Joseph Callen 2f5ced8856 Moving VMware Utilites module
Moved `vmware.py` from v1 to `lib/ansible/module_utils/vmware.py`.

No other changes has been made since these two PRs:
https://github.com/ansible/ansible/pull/10812
https://github.com/ansible/ansible/pull/10760
9 years ago
Brian Coca ced93d35ca adjusted list hosts across adhoc and playbook cli 9 years ago
James Cammarata 3a50c08c01 Merge branch 'pluggable_jinja_tests' of https://github.com/quixoten/ansible into quixoten-pluggable_jinja_tests 9 years ago
James Cammarata 782c2f75df Make sure role deps inherit conditionals/tags specified via params
Fixes #7353
9 years ago
Brian Coca bedfe00de8 Merge pull request #11336 from saada/patch-1
Update Vault rekey() in vault.py to validate files passed before input
9 years ago
Toshio Kuratomi 4f1d365a25 Merge pull request #11783 from ansible/synchronize-fix
Synchronize in wasn't running on localhost in the default case which …
9 years ago
Toshio Kuratomi 088682f518 Synchronize in wasn't running on localhost in the default case which meant that rsync was run on the wrong host.
Fixes #11649
9 years ago
Mahmoud Saada ddd46f6599 Update rekey() in vault.py to validate files passed exist before prompting for password 9 years ago
Brian Coca 0784fa1765 removed import q 9 years ago
Brian Coca 96bcf50a94 implemented requirements file in v2
fixes #11179
9 years ago
James Cammarata 71867f9480 Remove vars attribute from base
Fixes #11779
9 years ago
Scott Cunningham 695e456cb0 add credstash lookup plugin 9 years ago
Brian Coca 132c14eb57 indented hosts 9 years ago
Brian Coca c0c094c413 now all --list options are working! 9 years ago
Brian Coca 884435a1aa minor cosmetic changes to list options 9 years ago
Brian Coca 056602c424 rearranged --list- options, now they are consolidated when used toghether, less loops, more concise output
list-hosts works
list-tasks works, but needs better task naming (missing role info)
list-tags only shows play tags
9 years ago
Brian Coca cc85473c1e show role search path when not finding a role
fixes #9770
9 years ago
James Cammarata 42cfacf83b Switch up the task/host overrides for PlayContext to use the compiled vars dict
Fixes #11436
9 years ago
Brian Coca a8b2b5b0c9 avoids printing blank diffs
fixes #10147 fixes #9471
9 years ago
James Cammarata 5cf2781528 A little more cleanup regarding _compute_environment_string 9 years ago
James Cammarata 467432bef5 Fix incorrect module path for AnsibleError in action plugin base 9 years ago
Brian Coca f4a997db49 added back but stderr, which was the original itnention 9 years ago
Brian Coca 3b9282fb90 fixed dupe output in raw/command cases 9 years ago
Brian Coca a78fdde32c better handling for weird doc corner cases (abscense of options, bad text objects, etc)
also updated extras to get some docfixes on the module side
9 years ago
Brian Coca 17103dd4cc update submodule refs 9 years ago
Brian Coca 6cdee94c33 added missing skipped item function to base 9 years ago
Brian Coca 6f93d228f6 made item output closer to v1 9 years ago
Brian Coca 4f9d719b14 removed debug 9 years ago
Brian Coca d78c2fc212 now reports per task item 9 years ago
James Cammarata 2d90cbf78b Properly fail results with rc != 0
Fixes #11769
9 years ago
Brian Coca 787a0c4e04 fixed indent issues 9 years ago
Vilmos Nebehaj 58cccce384 Use PBKDF2HMAC() from cryptography for vault keys.
When stretching the key for vault files, use PBKDF2HMAC() from the
cryptography package instead of pycrypto. This will speed up the opening
of vault files by ~10x.

The problem is here in lib/ansible/utils/vault.py:

    hash_function = SHA256

    # make two keys and one iv
    pbkdf2_prf = lambda p, s: HMAC.new(p, s, hash_function).digest()

    derivedkey = PBKDF2(password, salt, dkLen=(2 * keylength) + ivlength,
                        count=10000, prf=pbkdf2_prf)

`PBKDF2()` calls a Python callback function (`pbkdf2_pr()`) 10000 times.
If one has several vault files, this will cause excessive start times
with `ansible` or `ansible-playbook` (we experience ~15 second startup
times).

Testing the original implementation in 1.9.2 with a vault file:

In [2]: %timeit v.decrypt(encrypted_data)
1 loops, best of 3: 265 ms per loop

Having a recent OpenSSL version and using the vault.py changes in this commit:

In [2]: %timeit v.decrypt(encrypted_data)
10 loops, best of 3: 23.2 ms per loop
9 years ago
Brian Coca 77fc3ce759 removed unused import 9 years ago
Lukas Pirl d9aa14feea fixes remote code execution for su/sudo and strict remote umasks
* temporarily changes umask for creating temporary directories
    * otherwise parent directories may not get chmod'ed and end up
      unreadable
refs #9902
9 years ago
Brian Coca 80ecab5317 Merge pull request #11761 from amenonsen/9843-rebase
Add pciid to LinuxNetwork interface fact
9 years ago
Hugh Saunders f344ec463f Add LVM facts to setup module
This commit adds LinuxHardware.get_device_facts() and calls that from
.populate().

LVM facts are only gathered if the setup module is running as root and
the lvm utilities are available (tested by searching for 'vgs').

If the conditions are met, facts are set for each volume group and
logical volume.

Example:

Test LVM Data:
$ sudo vgs
  VG   #PV #LV #SN Attr   VSize VFree
  test   1   2   0 wz--n- 5.00g 2.00g
$ sudo lvs
  LV      VG   Attr      LSize Pool Origin Data%  Move Log Copy%  Convert
  testlv  test -wi-a---- 1.00g
  testlv2 test -wi-a---- 2.00g

Facts Returned:
$ ansible localhost -i /tmp/inv -m setup -a 'filter=ansible_lvm'
localhost | success >> {
    "ansible_facts": {
        "ansible_lvm": {
            "lvs": {
                "testlv": {
                    "size_g": "1.00",
                    "vg": "test"
                },
                "testlv2": {
                    "size_g": "2.00",
                    "vg": "test"
                }
            },
            "vgs": {
                "test": {
                    "free_g": "2.00",
                    "num_lvs": "2",
                    "num_pvs": "1",
                    "size_g": "5.00"
                }
            }
        }
    },
    "changed": false
}

Test as non-root:
$ ansible localhost -i /tmp/inv-user -m setup -a 'filter=ansible_lvm'
localhost | success >> {
    "ansible_facts": {},
    "changed": false
}

Test without lvm utilities available
$ sudo mv /sbin/vgs{,.bk}
$ ansible localhost -i /tmp/inv -m setup -a 'filter=ansible_lvm'
localhost | success >> {
    "ansible_facts": {},
    "changed": false
}
9 years ago
Brian Coca 5f8db9cd4b changed verbose_override to the new _ansible_verbose_override to keep in line with previous changes
output now defaults back to having indent=4
9 years ago
Trapier Marshall 250620f2ab Add pciid to LinuxNetwork interface fact
This commit adds pciid to the LinuxNetwork fact object.

pciid is gathered if the symlink /sys/class/net/*/device exists.

Example [>>>> emphasis <<<<]:

$ readlink /sys/class/net/eth0/device
../../../0000:01:00.0

$ ansible localhost --ask-pass -i /tmp/hosts -m setup -a "filter=ansible_eth0"
SSH password:
localhost | success >> {
    "ansible_facts": {
        "ansible_eth0": {
            "active": false,
            "device": "eth0",
            "macaddress": "0c:d2:92:5d:6e:8e",
            "module": "alx",
            "mtu": 1500,
       >>>> "pciid": "0000:01:00.0", <<<<
            "promisc": true,
            "type": "ether"
        }
    },
    "changed": false
}
9 years ago
Brian Coca 8746e692c1 changed check to allow for powerpc
fixes #11528
9 years ago
Brian Coca 0c21196633 moved openvz inventory script to new home 9 years ago
Brian Coca 164092a835 optimized module docs 9 years ago
Brian Coca 2575e1540a Merge pull request #11740 from amenonsen/8602-rebase
Encrypt the vault file after editing only if the contents changed
9 years ago
Toshio Kuratomi d2346fd2e2 Python2.4 compat fix 9 years ago
James Cammarata d6cafff2f9 Additional changes to fix fileglob relative path lookups 9 years ago
Toshio Kuratomi 6a68be4e28 Handle quoting of values in dict parameters 9 years ago
James Cammarata cb262449c7 Reworking internal result flags and making sure include_vars hides vault data
Fixes #10194
9 years ago
James Cammarata eebf437d87 Submodule pointer update 9 years ago
Brian Coca b2b19a1dc4 Merge pull request #11751 from amenonsen/playwithoutbook
A better error message for «ansible playbook.yml»
9 years ago
James Cammarata 49a6601856 Further cleanup of internal use of ansible_ssh_host 9 years ago
James Cammarata ee835ff7ad Add a base-level get_basedir method for lookup plugins and fix relative lookups
Fixes #11746
9 years ago
Abhijit Menon-Sen 65d62090c2 A better error message for «ansible playbook.yml»
This is a very conservative change: we add the hint only if we're
definitely going to die already.
9 years ago
James Cammarata 3a4dd523d3 Fix bug where we calculated the relative path of recurisive copies wrong
Fixes #11470
9 years ago
James Cammarata a1a8997e89 Merge pull request #11663 from whereismyjetpack/fix_ansible_ssh_host
only set ansible_ssh_host if not already set
9 years ago
Brian Coca a56ff7ae54 now it really is oneline 9 years ago
Brian Coca 5d1d9f1505 fixed diff output to be as it was in 1.x, copy and template now use the same
functions to do difs.
9 years ago
James Cammarata c56a304ad9 Merge pull request #9195 from reedloden/add-dns-facts
Add several DNS-related facts by parsing /etc/resolv.conf
9 years ago
James Cammarata ccb7fb3b4c Submodule pointer update 9 years ago
James Cammarata 034c766439 Fixing logic in template.py to not assume 'changed' is in the result 9 years ago
James Cammarata a78ed39f93 Merge pull request #11743 from renard/regex_escape-filter
Regex escape filter
9 years ago
James Cammarata db4b3544d7 Fix syntax error in action plugin template.py 9 years ago
Reed Loden eb1fb41576 Add several DNS-related facts by parsing /etc/resolv.conf
Facts include nameservers, domain, search path, sortlist, and options.
9 years ago
Sébastien Gross 36534668f0 Change name from re_escape to regex_escape to fit existing function names. 9 years ago
Sébastien Gross c1e4085251 Add regular expression escaping filter. 9 years ago
Brian Coca 0b6fadaad7 started implementing diff
diff now works with template
also fixed check mode for template and copy
9 years ago
Pablo Figue f8bf2ba1bd Encrypt the vault file after editing only if the contents changed 9 years ago
James Cammarata 73aa5686cc Remove octal escapes from unicode escape handling
Fixes #11673
9 years ago
Brian Coca 5be384bab0 Merge pull request #11733 from amenonsen/csvfile
v2 breakage: lookupfile should lookup the given file=xxx
9 years ago
Brian Coca b19eb0f4dc minor improvements to display 9 years ago
Abhijit Menon-Sen 8737061a8f lookupfile should lookup the given file=xxx
(Earlier it used to lookup the pre-split term.)
9 years ago
James Cammarata eca88d4253 Merge pull request #11732 from amenonsen/9212-rebase
Forbid copy: content="" with a directory destination
9 years ago
Mario de Frutos 4ed664f4d0 Forbid copy: content="" with a directory destination
Fixes #9107, closes PR #9212
9 years ago
Brian Coca b9710b4a34 wrapped new system ssh key lookup in case file does not exist 9 years ago
Patrick Michaud e4df8c3d36 Have paramiko use /etc/ssh_known_hosts
Fixes an issue with a confusing error: "paramiko: The authenticity of host '[host]' can't be established" when ssh on the command line doesn't complain

Closes PR #7730
9 years ago
Brian Coca 0858d97c44 also captures typeerrors for when not getting a proper string in output 9 years ago
Toshio Kuratomi 8ee3b7384d Guard the PROTOCOL setting so that we work on older pythons 9 years ago
Toshio Kuratomi 36382face9 Add a warning about mode being octal 9 years ago
James Cammarata eccfb7e0b5 Adding initial support for includes in handlers
Fixes #11694
9 years ago
Brian Coca 7215470c6f implemented galaxy list in v2 9 years ago
Will Thames 9abd9a8f57 Make ansible-galaxy work with galaxy.ansible.com
Now works with role files that use Ansible Galaxy roles
Still work to do on making this work with internal roles
9 years ago
Brian Coca cff77de917 added todo for future of feature 9 years ago
Brian Coca 0089eb8102 reimplemented logging based on log_path var 9 years ago
James Cammarata ff49c5adac Make sure we're actually looping before looking at 'results' in TaskResult
Fixes #11696
9 years ago
James Cammarata 0fcd53e887 Make sure the command is sudoable before checking for the become password
Fixes #11714
9 years ago
James Cammarata e526743b4f Allowing `args: "{{some_var}}"` for task params again
This is unsafe and we debated re-adding it to the v2/2.0 codebase,
however it is a common-enough feature that we will simply mark it
as deprecated for now and remove it at some point in the future.

Fixes #11718
9 years ago
Brian Coca 681eab1158 fix adhoc that broke with assuming step is always in options 9 years ago
Brian Coca 88e1ef8c9b implemented --step in v2 9 years ago
Brian Coca 3bf1edfd96 Merge pull request #11591 from defionscode/boto3
Connection function for boto3
9 years ago
James Cammarata 7bc789ba64 Properly template task names
Also fixes in the correct way the bug in which the role name was
incorrectly showing up twice in the task name.

Fixes #10347
9 years ago
James Cammarata 698479a623 Add config file info to --version output
Fixes #10348
9 years ago
James Cammarata 37ed756d66 Make sure role names are strings
Fixes #10497
9 years ago
Toshio Kuratomi f8e4aff4c1 Cleanups:
* Don't reference __class__ when we can use the instance itself
* use isdisjoint() as it can stop once a match is found
* Remove a condtional that was taken care of in the conditonal just above
9 years ago
Brian Coca 4e3f5e3be6 Merge pull request #11708 from bcoca/display_me
adding display to plugins and start moving debug to display
9 years ago
Brian Coca 78df37db8a updated submodule refs 9 years ago
Brian Coca a6ba149c49 implemented simplified output for adhoc adn command modules as in v1 9 years ago
James Cammarata 65ae9780fa Merge pull request #11079 from amegianeg/fix_broad_except_in_inventory
Avoid too broad except in Inventory
9 years ago
Toshio Kuratomi e7733a7d3a Update submodule refs 9 years ago
Brian Coca 851ed45bbf adding display to plugins and start moving debug to display 9 years ago
Toshio Kuratomi b06353791c Don't pass mode from synchronize action plugin to the ansible module
Fixes https://github.com/ansible/ansible-modules-core/issues/1783
9 years ago
Brian Coca b678b9828c simplified and normalized lookup search path behaviour 9 years ago
James Cammarata 857f584ebf Merge pull request #11699 from ahamilton55/ah/delegate_variable
v2: Fixing delegate_to when using a variable
9 years ago
Brian Coca b9050ecf18 fixed file lookup pathing in dwim functinos, now does specific paths and priorities and is commented
fixes #11672 as cwd is now not part of thos paths:
if full path is supplied, used that
9 years ago
Andrew Hamilton 7254b22bf4 Fixing delegate_to when using a variable 9 years ago
James Cammarata d412bc72ef Fall back to paramiko if the smart detection fails to run ssh
Fixes #11695
9 years ago
James Cammarata dfcf6a2016 Skip hosts with no state while iterating tasks in the linear strategy
Fixes #11693
9 years ago
James Cammarata 206ef27268 Add flag to template() so data is not converted to a datastructure
Fixes #11641
9 years ago
James Cammarata 7a9916422a Fixing up error handling for fetch_file ops in connection plugins
* enable batch mode (configurable with a config option, on by default)
  for sftp transfers, so we can catch errors more easily
* general cleanup in the local connection plugin and fetch action plugin

Fixes #11612
9 years ago
James Cammarata 4b6525fb58 Fix handler flushing to match how v1 worked
Also adds meta tasks to the list of tasks excluded from tag filtering

Fixes #11574
9 years ago
Toshio Kuratomi d0dcf73716 Update module refs 9 years ago
James Cammarata 135404738e Fix a couple start-at-task issues
* added pattern matching to match v1 functionality
* check the task name, not the task+role name for matches
* make sure the input is unicode

Fixes #11692
9 years ago
James Cammarata 975172c1ef Make sure role name doesn't end up in task name more than once
Fixes #11691
9 years ago
James Cammarata b09f1f8e0b Account for filters in bare variable conversion
Fixes #11530
9 years ago
Jeff Widman 52716c4dc7 Remove mention of 'apache example'
Removed explicit mention of 'apache'
9 years ago
ZviRackover 628925a77d Fix: add missing import 'locale' 9 years ago
James Cammarata 4c733fe4b7 Fix issues with vars_prompt and vars_files
* Prompt had to be moved up, as it needed to be done before the first
  templating of the play occurs, otherwise vars_files won't be templated
  properly
* Fixed a bug related to an earlier fix of vars_files incorporating
  extra vars to do the templating of the file name

Fixes #11404
9 years ago
Toshio Kuratomi 491a4f2a25 Update extras module pointer for docs fix 9 years ago
James Cammarata adf1d4d9b9 Submodule pointer update 9 years ago
James Cammarata 66a8864ae9 Fix environment setting and inheritence
Fixes #11401
9 years ago
James Cammarata 91519d1696 Don't filter include tasks based on tags
Fixes #11320
9 years ago
James Cammarata e64989beb4 Moving ConnectionInformation -> PlayContext
Also making PlayContext a child class of the Playbook Base class,
which gives it access to all of the FieldAttribute code to ensure
field values are correctly typed after post_validation

Fixes #11381
9 years ago
Brian Coca 827b0443c8 now dataloader checkis that you get at least a valid string as a file name 9 years ago
James Cammarata 7124504ccf Incorporate extra vars when templating vars_files
Fixes #11377
9 years ago
James Cammarata b8b206005c Generalize extra variable parsing and loading
Fixes #11352
9 years ago
Dann Bohn 3e79bfa2d6 only set ansible_ssh_host if not already set 9 years ago
James Cammarata 3de6f264dd Fix bug where spaces in the $HOME directory broke things
Fixes #11332
9 years ago
James Cammarata 91a4b866b0 Fix ssh pipelining 9 years ago
Toshio Kuratomi ddec06ccfe Detect the old python-json library
Fixes #11654
9 years ago
James Cammarata 5347db2952 Also check the play basedir for the role
Fixes #11328
9 years ago
James Cammarata dca36c1d16 Reestablishing the use of tags/when for role duplication detection
Not figuring these in can cause problems with "diamond" pattern relationships,
even though this is still not quite optimal.
9 years ago
Toshio Kuratomi a0a6d12b05 Merge pull request #11603 from ansible/get_url-tls-compat
Have openssl autonegotiate tls protocol on python < 2.7.9
9 years ago
Brian Coca 03d7c8d7ca fixed new HPUX networking facts 9 years ago
Brian Coca 80eb7a20ca Merge pull request #11469 from pilou-/local_variable
Fix pyflakes error: use 'msg' variable
9 years ago
Brian Coca 91f2acb029 Merge pull request #10203 from pdelared/devel
Add HP-UX network facts
9 years ago
Pierre-Louis Bonicoli 8c392a94b7 Play.get_name: remove prefix, return name only 9 years ago
Pierre-Louis Bonicoli fda8fa77ab Fix pyflakes error: use 'msg' variable
Error was: local variable 'msg' is assigned to but never used
9 years ago
Brian Coca a09ce4bd87 added callback that skipts 'skipped' 9 years ago
Brian Coca 171c95672e fixed gathering expression as it was triggering when gather_facts was no 9 years ago
Brian Coca f66ba92745 now vault prompts for password if no password file was given, as in 1.x 9 years ago
Brian Coca a8ba9cac3f fixed ansible pull bad options ref, removed print in favor of display 9 years ago
Brian Coca f8905013cd now executes fact search when needed 9 years ago
James Cammarata 2c98b271c8 Make paramiko password detection logic match ssh connection 9 years ago
James Cammarata 3d77723e3d Cleaning up some stuff related to the connection info/become/executable change 9 years ago
James Cammarata 1c185b68be Rearranging some become stuff in relation to action/connection plugins
Moving the make_sudo_cmd() calls back up to the action level so that connection
plugins don't have to know about it at all, and moving some of the become data
(prompt and success_key) into the ConnectionInformation object so they don't
need to be passed around needlessly.
9 years ago
James Cammarata 7a9b5b6fe8 Remove unnecessary make_become_cmd from paramiko exec_command
Fixes #11611
9 years ago
Brian Coca 9dc5607730 Merge pull request #11519 from bcoca/human_readable
new human_readable filter to transform bits and bytes into cake
9 years ago
Brian Coca 115dce028d Merge pull request #11604 from bcoca/faf_deprecated_fixes
fixed first_available_found for template
9 years ago
Brian Coca 4f98fac494 Merge pull request #10914 from bcoca/non_posix_file_copy_fix
hack to prevent tempalte/copy errors on vagrant synced folders
9 years ago
Indrajit Raychaudhuri 4553a41ab5 Add homebrew to package managers' list 9 years ago
James Cammarata 271a7f3281 Cleaning up some of the notify/facts logic added earlier to fix problems 9 years ago
Brian Coca 1aa4155266 generalized warning handling, added it to adhoc also 9 years ago
James Cammarata d4ac73a1bc Adding back capability to display warnings contained in results
Fixes #11255
9 years ago
James Cammarata 5abdd3b821 Handle notifications when coupled with a loop
Fixes #11606
9 years ago
Serge van Ginderachter 8d1549900c fix AnsibleError object name in subelements plugin
fixes #11624
9 years ago
Brian Coca bc5a7fce79 Merge pull request #11616 from halberom/ssh_port
fixes 11607, override ansible_ssh_port in group/host_vars
9 years ago
Gerard Lynch a6c8d30f3e callbacks require a version constant or the v2 code doesn't pass the display param and it gives an error 9 years ago
Brian Coca 6ba706f753 minor doc reformatting
now version_added < 1.3 does not get shown, up from 1.0
option's version_added is also now filterd against this threshold
module version_added is more prominent
exaples now uses pure rst instead of intermingled with html formatting
aliases now shown in description for options
bad version fields now throw warnings instead of exceptions
ansible-doc errors now show traceback in very very verbose mode, for easier debugging
9 years ago
Brian Coca da890f9328 Merge pull request #11622 from amenonsen/gathering
devel breaks «gathering=explicit» setting in ansible.cfg
9 years ago
Brian Coca a09f6236a5 adapated to v2 9 years ago
Brian Coca 10e5c2b46d fixed var scope 9 years ago
Tom Paine 097ed1f17b Add plugin that profiles playbook tasks
Resubmission of https://github.com/ansible/ansible/pull/11270 to
correct v2 file location.

[Description and console output
demonstration](https://github.com/aioue/ansible-plugin-profile/blob/mast
er/README.md#features).

Provides per-task timing, ongoing playbook elapsed time and ordered
list of top 20 longest running tasks at end.
9 years ago
Abhijit Menon-Sen 28e2eae902 Make gathering=explicit work again
There was a confusion between the valid values for defaults.gathering
(explicit/implicit/smart) and a play's gather_facts setting (boolean),
which resulted in gathering=explicit being ignored.
9 years ago
Gerard Lynch d23ab261e1 fixes 11607, allows ansible_ssh_port to be overridden from group or host_vars 9 years ago
Brian Coca 978390693b changed to default 'auto' as it better describes the use= option 9 years ago
James Cammarata 94fa741f96 Make sure files loaded by template action are decoded properly
Fixes #11247
9 years ago
Brian Coca 5ba9fe4748 now supports maintainers and author field for display as MAINTAINERS 9 years ago
Brian Coca c603caca27 removed extra print now that items are getting passed to callback in result 9 years ago
James Cammarata 86a83c16b8 Remove some dead code from the base load_data method
Was causing an odd error which threw off the error detection code
when the datastructure was a string corresponding to a variable.
9 years ago
James Cammarata d977dd507c Merge pull request #11609 from ofpiyush/devel
Fix #11369 A result is skipped when all it's children are skipped. Th…
9 years ago
James Cammarata 052f3c2ece Fixing allow_duplicate and variable resolution bugs
Fixes #11205
9 years ago
Piyush f2bdd9af29 Fix #11369 A result is skipped when all it's children are skipped. This makes it fundamentally different from a result that was changed/failed/unreachable 9 years ago
Brian Coca 5a5b7ff561 fixed first_available_found for template, refactored into common function
added deprecation warning
fixed display.deprecated to make version optional (code already assumed this)
turned warning + 'deprecated' in plugin loader into actual call to deprecated()
9 years ago
Jonathan Davila 6ea772931f Connection function for boto3
Boto3 conn
9 years ago
Toshio Kuratomi 3d3e1c82a2 Have openssl autonegotiate tls protocol on python < 2.7.9
This allows usage of tls-1.1 and tls-1.2 if the underlying openssl
library supports it.  Unfortunately it also allows sslv2 and sslv3 if
the server is only configured to support those.  In this day and age,
that's probably something that the server administrator should fix
anyhow.
9 years ago
James Cammarata ba7243c5f9 Don't set changed for include tasks
Fixes #11197
9 years ago
James Cammarata 291f07242c Properly return Jinja2 Undefined class for bad hostvars lookups
Fixes #11176
9 years ago
James Cammarata 9fe0f21f6a Allow omit to be used on Playbook-level fields
Fixes #11173
9 years ago
James Cammarata 165fff8a1e Fixing module arg parsing splitting when action is a variable
Fixes #11122
9 years ago
Brian Coca b76cb8f655 now that invocation is only async again, no need to sanitize 9 years ago
James Cammarata 2d870b7112 Fix logic where invocation details are added to results 9 years ago
James Cammarata 0b035a4e35 Unicode in result debug statements caused a traceback 9 years ago
Brian Coca ae6d9ebf28 added maintainers (from author field) to ansible-doc 9 years ago
Brian Coca fbec8bfb90 updated ref to add docfixes 9 years ago
Brian Coca 0e1d771a33 updated submodule refs 9 years ago
Toshio Kuratomi 3e293f524a Merge pull request #11589 from ansible/get_url-sni-tls-fix
Add support for SNI and TLS-1.1 and TLS-1.2 to the fetch_url() helper
9 years ago
Toshio Kuratomi 327b1676a8 Add support for SNI and TLS-1.1 and TLS-1.2 to the fetch_url() helper
Fixes #1716
Fixes #1695
9 years ago
James Cammarata 8d887d8dd3 Adding back --start-at-task feature
Also implemented framework for --step, though it's not used yet
9 years ago
Brian Coca 3c7faa8378 fixed missing self in self.action on rekey in vault
fixes #11584
9 years ago
Brian Coca 42e355f9a3 fragments can now be a list 9 years ago
Brian Coca ea159ef9de fixed backup and validate fragments 9 years ago
James Cammarata 4e94bb64d8 Fix group/host var loading relative to playbook basedir 9 years ago
James Cammarata 7dd5600839 Allow empty include files again
Fixes #11582
9 years ago
Brian Coca 8793308c39 made md5 into generic checksum function that uses sha now 9 years ago
James Cammarata 6971e92f39 Fixing up some output stuff 9 years ago
James Cammarata 9a586c3512 Properly catch AnsibleError and not all errors 9 years ago
Brian Coca 2b723c6130 added missing re import 9 years ago
Brian Coca 3102469b94 fixing become success string 9 years ago
Brian Coca a09f44210e now callback errors are not silent but warnings 9 years ago
Brian Coca e0632cb9a4 Merge pull request #11577 from srvg/yaml_file_extensions
Use YAML_FILENAME_EXTENSIONS for vars files.
9 years ago
Brian Coca 5daa540bc0 Merge pull request #11576 from srvg/combine_empty_vars_file
Do not combine group_vars with an empty file
9 years ago
Serge van Ginderachter d5fb11d89c Use YAML_FILENAME_EXTENSIONS for vars files.
The v2 codebase didn't use this previously introduced constant yet.

C.YAML_FILENAME_EXTENSIONS
9 years ago
Serge van Ginderachter 9c8f0da327 Do not combine group_vars with an empty file
This addresses a specific case with multiple vars files
in a group_vars/${groupname}/ directory where one of those files
is empty, which returns None instead of an empty dict.
9 years ago
Brian Coca 24b830bbc8 fixed executable for raw module 9 years ago
Brian Coca c4b6d91275 added skipped to oneline 9 years ago
Brian Coca 8ad52c2e4f readded oneline output feature to adhoc
fixes #11573
9 years ago
Brian Coca 3a768b3b9f removed unused methods, these now live in base class 9 years ago
James Cammarata c18fdd0c18 Re-implement "conditional imports" for vars_files 9 years ago
James Cammarata d977da5b41 Fixing up fact_cache use in VariableManager 9 years ago
James Cammarata 932d1e57f7 Removing stray debugging print 9 years ago
James Cammarata 91c9bb96e3 Moving jsonfile cache plugin over and fixing #10883
Fixes #10883
9 years ago
Brian Coca d8abae71a4 now assemble skips during checkmode
TODO: actually make it check with checkmode
fixes http://github.com/ansible/ansible-modules-core/issues/661
9 years ago
Alejandro Guirao 587a6cb44c Remove v1 code 9 years ago
Alejandro Guirao 6e99023c84 Changed to support Ansible v2 9 years ago
Alejandro Guirao 8efc42d993 Add shelvefile lookup plugin 9 years ago
James Cammarata f40b66d841 Make sure the basedir is unicode
Fixes #10773
9 years ago
Brian Coca ba92965670 fix for when invocation data is missing 9 years ago
James Cammarata c5c1dc2f11 Removing tags/when from role param hash calculation 9 years ago
Brian Coca 4203b699a8 removed dict comprehension as 2.6 does not like 9 years ago
Brian Coca 032690a843 fix read_vault_password_file ref 9 years ago
Brian Coca d993e7000c added cyan back to ignoring message 9 years ago
Brian Coca 064a34689a now actually continues play on ignore errors 9 years ago
Brian Coca fe91f7b506 moved read_vault_file to CLI from utils and renamed to clearer read_vault_password_file 9 years ago
Brian Coca e4097ed279 simplified ansible errors, moved md5 hash import with notes to be more prominent 9 years ago
Brian Coca 1274ce565d added result sanitation to registered var and to callbacks
removed time display as it only is provided by command module
9 years ago
Brian Coca fdea00880b now default shows time taken when -vv or above 9 years ago
Brian Coca 7a1bce1b5d added verbose option to show callback loaded info
also made mail module print nicer without all those 'u'
9 years ago
Brian Coca 4b9a79d42b removed trailing newline
fix from #10973 by @retr0h
9 years ago
teh 4r9h 705018a417 Misspell in mail.py callback.
Looks like little misspell.
9 years ago
Brian Coca e9a3a2912d Merge pull request #9281 from woltage/devel
Enables 'force basic auth' -feature globally
9 years ago
James Cammarata 4608897c27 Submodule update 9 years ago
Carlos E. Garcia 657495d13f minor spelling changes 9 years ago
Brian Coca aaad33ccb6 fixed a couple of bugs 9 years ago
Brian Coca d0c6d2ff1c poreted log_plays, syslog_json and osx_say callbacks to v2
renamed plugins to contrib (they are not really plugins)
rewrote README.md to reflect new usage
added new dir to setup.py so it gets copied with installation, in views
of making using inventory scripts easier in teh future
9 years ago
Brian Coca 50d54b1be7 ported hipchat callback to v2 (needs testing) 9 years ago
Brian Coca e92e15b5f6 moved unused functions to base object 9 years ago
Brian Coca b47d7babe5 removed warning i was using for debug 9 years ago
Brian Coca 834b7a2857 ported context_demo to v2 callbacks 9 years ago
Brian Coca ba0e5323d6 removed connection info to _verbosity, just needed callbacks to call correct display.verbosity
added v2 methods and made them call v1 when possible by tranforming the data
9 years ago
Brian Coca a918a1bd16 now calls correct v2_on_any callback method 9 years ago
Brian Coca f9d817e636 now looks at correct verbosity and removes the need to set a copy of it in _verbosity 9 years ago
James Cammarata cf2a66ef30 Add ansible_version magic variable
Fixes #11545
9 years ago
James Cammarata b0e6baf8c3 Fix bug where options may not have the force_handlers value from the cli 9 years ago
James Cammarata f8ddf2eb04 Move role cache into the play to avoid roles crossing play boundaries 9 years ago
James Cammarata b520d5bc60 Lots of fixes for integration test bugs 9 years ago
Iiro Uusitalo 4e7542af37 Merge upstream changes 9 years ago
Iiro Uusitalo 403f4881ee Enables 'basic auth force' -feature globally 9 years ago
James Cammarata a9712bb0fb Fixing some delegate_to bugs
* Moving connection creation until after the task is post_validated,
  to make sure all fields are properly templated (#11230)
* Fixing problems related to the connection method and remote address
  lookup on the delegated-to host

Fixes #11230
9 years ago
Brian Coca 3ba67dd2d0 added ignore_hidden to assemble 9 years ago
Brian Coca b5f3e84014 now allows for empty vars sections, returns empty dict
fixes #11532
9 years ago
Brian Coca 55366bdc6d ported mail callback plugin to work with v2 9 years ago
Brian Coca 897e098b27 minor fixes to constants 9 years ago
Toshio Kuratomi dd058a1dc2 Fix required_if (needed to pass list to _count_terms) 9 years ago
James Cammarata 27fcf1a4b5 Fix bug in registered variables related to delegate_to changes 9 years ago
James Cammarata 64a1b1e043 Fix first_available_file: support for copy and template actions 9 years ago
Toshio Kuratomi ddac6fa9f3 Update exception handling to be python3 compat 9 years ago
James Cammarata 8f0496d7ce Fix usage of set_host_var when registering a result var
Fixes #11521
9 years ago
James Cammarata 2e5dfd57cc Clear flag indicating role had run before each play is run
Fixes #11514
9 years ago
Brian Coca a02555ad91 Merge pull request #11483 from pilou-/jinja2_header_overrides
implement jinja2 header overrides
9 years ago
James Cammarata f67949e42c Readd logic for ansible_managed to template action plugin
Fixes #11317
9 years ago
James Cammarata da307c8bfd Fix bug in logic introduced in 614c626 9 years ago
James Cammarata 293dd38d05 Correctly handle assigning results to the delegated to host 9 years ago
Brian Coca 688088547b new human_readable filter to transform bits and bytes into cake (not really) 9 years ago
Toshio Kuratomi 49a148056c Ensure that we're dealing with byte str when we print or log messages 9 years ago
James Cammarata 614c626ed0 Fix no hosts remaining logic in linear strategy 9 years ago