Commit Graph

9556 Commits (95755d1859354bf9da5eb0d8a4b4b65e8c5b0431)
 

Author SHA1 Message Date
Toshio Kuratomi 95755d1859 We've changed run_command to return native_strings
on python3, this means that we don't get bytes back by default.  We
probably do want bytes here so modify our call to run_command so we get
bytes instead of text.
8 years ago
Ryan Brown f1c2739163 Handle termination_protection parameter when restarting instances (#5076)
* Restart EC2 instances with multiple network interfaces

A previous bug, #3234, caused instances with multiple ENI's to fail when being
started or stopped because sourceDestCheck is a per-interface attribute, but we
use the boto global access to it (which only works when there's a single ENI).

This patch handles a variant of that bug that only surfaced when restarting an
instance, and catches the same type of exception.

* Default termination_protection to None instead of False

AWS defaults the value of termination_protection to False, so we don't
need to explicitly send `False` when the user hasn't specified a
termination protection level. Before this patch, the below pair of tasks
would:

1. Create an instance (enabling termination_protection)
2. Restart that instance (disabling termination_protection)

Now, the default None value would prevent the restart task from
disabling termination_protection.

```
- name: make an EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    instance_type: t2.micro
    termination_protection: yes
    exact_count: 1
    count_tag:
       Name: TestInstance
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
- name: restart a protected EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    state: restarted
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
```
8 years ago
John R Barker 2779ead45b Add matching quotes (#5133)
Will fix broken syntax highlighting
8 years ago
Chris Houseknecht 90af27f20f Merge pull request #5050 from chouseknecht/devel
Fix intermittent image push error
8 years ago
Matt Davis 6c4d71a7fa fixed windows setup to run in check_mode 8 years ago
Toshio Kuratomi e4c5a13a7a Fix assemble module for python3 8 years ago
Peter Sprygada 857e1d374b adds exception handling for adding an invalid condition (#5125)
This change will now handle a problem adding a condition that raises
an AddConditionError and return a well formed error to the user.
8 years ago
Pradeep 4cb27d914f Typo Fix 8 years ago
Gabriele 423b4a5909 Adding more details on DOCSTRING about how to use the module (#5121) 8 years ago
Peter Sprygada 8afe2402db adds exception handling for AddConditionError (#5124)
AddConditionErrors are now handled by nxos_command and a well formed error
is returned from the module
8 years ago
Peter Sprygada 886757b4dd adds check for AddConditionError when adding conditional statements (#5123)
The Conditional instance will now raise the AddConditionError and this
change instructs eos_command to catch the error and return a nicely formed
error message
8 years ago
Matt Davis 4b3c892284 (re)add post-watchdog-launch sleep to Windows async_wrapper (#5122)
fixed apparent race where subprocess appears to never start
8 years ago
Gabriele d35cd80b7e Improving nxos_igmp_snooping (#5011) 8 years ago
Gabriele d47e38a8f9 Fixing nxos_igmp_interface (#5010) 8 years ago
Gabriele ef85fcb068 Fixing nxos_hsrp (#5009)
* Fixing nxos_hsrp

* Adding space after =
8 years ago
Senthil Kumar Ganesan dad21ce886 Remove the dellosX_template module (#5110) 8 years ago
Matt Davis 18f710fe32 add JSON junk filter to async_wrapper (#5107) 8 years ago
Peter Sprygada 2db006450d roll up of unicode fixes in junos modules (#5113)
* fixes junos_template (fixes #3962)
* fixes junos_config
8 years ago
Gabriele 201d041c4b Add ethernet-link-oam mapping to nxos_feature (#4956)
* Add ethernet-link-oam mapping

* Adding port-secutiry mapping

* Fixing command output format
8 years ago
Gabriele 21078d7462 Fixing nxos_vlan (#5005)
* Fixing nxos_vlan

* Fixing docstring

* Fixing docstring
8 years ago
Gabriele 813a14f046 Fixing nxos_aaa_server (#5002)
* Fixing command output formatting

* Fixing cmds
8 years ago
Gabriele 8da99d4e70 Fixing nxos_acl (#5006)
* Fixing nxos_acl

* Fixing nxos_acl
8 years ago
Gabriele c88404c119 Fixing nxos_acl_interface (#5007) 8 years ago
Gabriele 41d8627376 Fixing nxos_interface (#5012) 8 years ago
Gabriele c977859ae5 Fxing nxos_ip_interface (#5013) 8 years ago
Gabriele 5cc4a7766a Fixing nxos_mtu (#5014) 8 years ago
Gabriele 82828fc1a0 Fixing nxos_ntp (#5015) 8 years ago
Gabriele a6c021219e Fixing nxos_ntp_auth (#5016) 8 years ago
Gabriele 88a2102787 Fixing nxos_ntp_options (#5017) 8 years ago
Gabriele 9f0aec160b Fixing nxos_pim_interface (#5018) 8 years ago
Gabriele c4941285cb Fixing nxos_portchannel (#5019) 8 years ago
Gabriele 33b8a89702 Fixing nxos_smu (#5021) 8 years ago
Gabriele 11f628a124 Fixing nxos_snmp_community (#5022) 8 years ago
Gabriele 099aa0d82d Fixing nxos_snmp_contact (#5023) 8 years ago
Gabriele 26ebb1acb9 Fixing nxos_snmp_host (#5024) 8 years ago
Gabriele 21fe7a1e13 Fixing nxos_snmp_location (#5025) 8 years ago
Gabriele f836de5e4b Fixing nxos_snmp_traps (#5026) 8 years ago
Gabriele d75121b3c1 Fixing nxos_snmp_user (#5027) 8 years ago
Gabriele 0d985071e1 Fixing nxos_udld_interface (#5030) 8 years ago
Gabriele c7e711bd35 Fixing nxos_switchport (#5028) 8 years ago
Gabriele 7e2a87b43f Fixing nxos_udld (#5029) 8 years ago
Gabriele 3b4bbb2497 Fixing nxos_vpc_interface (#5032) 8 years ago
Gabriele 770fd68b42 Fixing nxos_vrf (#5033) 8 years ago
Gabriele db818dddcb Fixing nxos_vpc (#5031) 8 years ago
Gabriele 39cd41f636 Fixing nxos_vrf_interface (#5034) 8 years ago
Gabriele 690bbcb148 Fixing nxos_vtp_domain (#5036) 8 years ago
Gabriele ba3485999a Fixing nxos_vrrp (#5035) 8 years ago
Gabriele 2704b208cc Fixing nxos_vtp_password (#5037) 8 years ago
Gabriele 137d1373d3 Fixing nxos_vtp_version (#5038) 8 years ago
Matt Davis ac42b85225 remove broken ansible_user_uid fact from Windows setup 8 years ago