1a57daf9b0
Add support for multiple IPv6 addresses in nxos_l3_interface module ( #50892 )
...
* Add support for multiple IPv6 addresses in nxos_l3_interface module
Cisco support multiple IPv6 addresses on each interface but only the first
IPv6 is considered by this module. There is no impact on the configuration
but the module is not idempotent.
* Add internal support for IPv6 list
* Fix module idempotency
* Initialize tests for nxos_l3_interface
* Fix IPv4 removal idempotency
* Fix data extraction from nxos config
* Fix silently ignored interfaces in nxos_l3_interface
* Add warning when interface does not exist in nxos config
6 years ago
20fb77c49b
nxos_interfaces_ospf: fix passive-interface states & check_mode ( #54260 )
...
* nxos_interfaces_ospf: fix passive-interface states & check_mode
This fix addresses issues #41704 and #45343 .
The crux of the problem is that `passive-interface` should have been treated as a tri-state value instead of a boolean.
The `no` form of the command disables the passive state on an interface (allows it to form adjacencies and send routing updates). It's essentially an override for `passive-interface default` which enables passive state on all OSPF interfaces.\*
This `no` config will be present in `running-config`.
\**See `router ospf` configuration.*
Since both enable and disable states are explicit configs, the proper way to remove either of these is with the `default` syntax.
Passive-interface config syntax:
```
ip ospf passive-interface # enable (nvgens)
no ip ospf passive-interface # disable (nvgens)
default ip ospf passive-interface # default (removes config, does not nvgen)
```
Code changes:
* `passive_interface` param changed from boolean to string, restricted to `true`,`false`,`default`.
* Several passive-interface specific checks were added because the existing module logic tends to test for true or false and doesn't handle the None case.
* Fixed `check_mode`.
Sanity verified on: N9K,N7K,N3K,N6K
* Fix doc header
* Unit tests for passive-interface
* doc fix #2
* Fix indent for SA
* Remove 'default' keyword, restore bool behavior
* remove changes to sanity
6 years ago
96346938ee
nxos_vlan refactor to support non structured output ( #43805 )
...
* nxos_vlan refactor to support non structured output
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unittest fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* minor fixes
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* use check_rc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove additional return statement
* address Nate's review
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
6 years ago
82dfa542c2
Replace bogus (but routeable) ip addresses with RFC 5737 example addresses ( #40554 )
...
* Remove 1.1.1.1 from *_config tests
* remove from *_smoke and *_system
* Miscellaneous other tests
* Remove from module documentation as well
* Remove from unit tests as well
* Remove accidental duplication from rebase
7 years ago
2fbfce06e7
Fix nxos_interface multiple issues ( #36827 )
...
* fix interface_type
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* speed idempotence and add unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fabric_forwarding_anycast_gateway applicable for svi type intf only
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix speed
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
5e6b2495c0
Convert nxos_vrf to DI module ( #34274 )
...
* Convert nxos_vrf to DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add purge example and improve logic
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert version_added for rd param
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update test to use network_cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
9d2182bcf8
Deprecate nxos_switchport and Add nxos_l2_interface DI module ( #33813 )
...
* Deprecate nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_l2_interface DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* aggregate test for nxos_l2_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert nxos_switchport test change
* gundalow's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
80ba767204
Convert nxos_interface to DI ( #34240 )
...
* Convert nxos_interface to DI
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* commit for ganeshrn's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
60f3649ebd
Convert nxos_vlan to DI module ( #31866 )
...
* Convert nxos_vlan to DI
* fix conflict
* push fix for qalthos's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module ( #33866 )
...
* Deprecate nxos_ip_interface module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_l3_interface DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* Add nxapi cli test
* Improve complexity
* manage layer3 interface
* fix unit test
7 years ago
95a2140f4b
Use show command to support wider platform set for nxos_interface module ( #33037 )
...
* Use show command to support wider platform set
* Fix unit tests
7 years ago
84117e57ba
nxos: 32 bits AS in as-dot format not recognized by regexp asn_regex ( #30569 )
...
* added test for 32 bits AS
* Lint not happy.
7 years ago
e4052c1261
Add mtu option nxos_interface feature idea ( #32680 )
...
* Add mtu option nxos_interface feature idea
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add unit test for mtu feature
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
173c41aefe
Rel240/fix nxos pim interface ( #29885 )
...
* fix nxos_pim_interface
* Add integration test coverage and fix unit test
* Add clarifying comments
* Make ansibot happy
7 years ago
f84ff216b6
Generalize nxos_bgp event-history detection ( #28890 )
...
* More general handling of event-history
* Update unit tests
7 years ago
8bfdbd0f73
nxos_bgp_neighbor: Fix regex &report warnings ( #28888 )
...
* Fix over-detection of log-neighbor-as
* Report nxos warnings
* Update nxos_bgp_neighbor unit tests to test remove-private-as
7 years ago
64dac346c9
Fix nxos_pim_interface dr-priority handling ( #28472 )
...
* Fix nxos_pim_interface dr-priority handling
* Prefer execute_show over `| json`
* Mock get_config
* Fix sparse-mode detection
7 years ago
3d46258cff
Refactor/fix nxos_nxapi to use show run ( #28675 )
...
* Refactor/fix nxos_nxapi to use show run
* Fix unit tests
* Python 3 compatibility
7 years ago
60ce6438e3
fix nxos_overlay_global idempotence ( #28150 )
...
* fix nxos_overlay_global idempotence
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_overlay_global unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
a78f3faa6c
nxos_bgp_neighbor_af does not want required_together ( #26370 )
...
* nxos_bgp_neighbor_af does not want required_together
* fixup tests
* Fix max_prefix_* issues
* Require address-family
* Fix idempotency for next_hop_third_party
* Fix idempotency for allowas_in*
* Fix idempotency for *_in and *_out
* Reorder command generation again
`default` is first, then `max-prefix`, then booleans
7 years ago
85e7e342b0
nxos_bgp_af correct parents ( #26996 )
...
* move config location
* client-to-client is inverse of BOOL_PARAMS
7 years ago
61249995a1
Update nxos_interface_ospf & add test ( #26644 )
...
* Update nxos_interface_ospf & add test
7 years ago
5cfdd5df0f
nxos_pim_interface ( #26367 )
...
* Add unit tests to nxos_pim_interface
* Update tests to match module
* Update nxos_pim_interface
* Address pep8 issues
7 years ago
c5fb4bbcc0
Fix nxos_switchport and unit test ( #26131 )
...
* fix nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_switchport unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* legacy file
* update unit test
* handle exception
7 years ago
5229370364
fix for nxos_acl_interface idempotency ( #26156 )
...
* fix for nxos_acl_interface idempotency
* shippable error fix
* fix issues with python3.x
7 years ago
3102746ebe
nxos_pim_rp_address fixes ( #26119 )
...
* nxos_pim_rp_address tests
* nxos_pim_rp_address changes
* Address issues with idempotence
7 years ago
ad6c4a544e
nxos_pim updates ( #26145 )
...
* nxos_pim tests
* Cleanup nxos_pim
7 years ago
eea18e9875
nxos_vxlan_vtep_vni fixes ( #25913 )
...
* nxos_vxlan_vtep_vni first pass
* nxos_vxlan_vtep_vni tests
7 years ago
3d6d428bbc
Test multiple nxos versions at once ( #25595 )
...
* Extend tests to have multiple device representations
* Move filepath munging to nxos_module
* Device needs to be kwarg so we can leave it off
* Update other nxos tests
* Update tests that fell through
7 years ago
21c7fcf9c0
nxos_vxlan_vtep ( #25971 )
...
* nxos_vxlan_vtep tests
* Fix issues with nxos_vxlan_vtep
7 years ago
3482a6326b
Fixes nxos_vpc_interface ( #25907 )
...
* nxos_vpc_interface fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_vpc_interface unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix state_present
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add state_present unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* make ansibot happy
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* teardown get_config
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
0296c2285b
nxos_vrf fix ( #25812 )
...
* Fixes #25031
* Slight cleanup and add tests
8 years ago
a38e727380
nxos_nxapi fix ( #25306 )
...
* Add nxos_nxapi tests
* Simple changes to nxos_nxapi
* Move validation to check_args
* Don't mark protocol change unless change is requested
* Add different regex to handle HTTP{,S} ports on a different version of nxos
8 years ago
4344132a7d
nxos_vpc updates ( #25452 )
...
* Add nxos_vpc tests
* Split execute-show between get_config and run_commands
8 years ago
343b83041e
nxos_feature fix and unit test ( #25200 )
...
* nxos_feature fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_feature unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove from pep8/legacy-file
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
53837c2ab0
Assorted nxos_bgp_* fixes ( #25080 )
...
* Simplify apply_key_map
* Fix nxapi
* Clean up get_value
* Fix missing non-values
* Add test for existing bgp_af case
* Fix small issues with bgp_neighbor_af
8 years ago
8985f7c930
nxos_static_route updates ( #24992 )
...
* Add static_route tests
* Add VRF tests
8 years ago
6a3ce18e4b
add more testcases for nxos_evpn_vni ( #24996 )
8 years ago
b12beca3ed
Refactos nxos_ip_interface module ( #24885 )
8 years ago
830f19d444
nxos_bgp updates ( #24270 )
...
* Remove invoke from nxos_bgp
* Try to simplify get_existing
* Streamline state_present
* More testing, squash & compact get_value & get_custom_value
* Streamline main
* nxapi has problems reading CustomNetworkConfig directly
8 years ago
c0ebdf144d
nxos_acl_interface fixes ( #23917 )
...
* Update nxos_acl_interface
* Add basic unit tests to nxos_acl_interface
8 years ago
f0914ee3c2
nxos_acl fixes ( #23915 )
...
* Update nxos_acl
* unit tests for nxos_acl
* Remove nxos_acl from pep8-legacy
8 years ago
0b4cebfb8b
nxos_vlan tweaks ( #23194 )
...
* Remove commented code
Remove a lot of unnecessary output
* Tests
* Sort vlan ids _after_ running set operations, so order is not lost
8 years ago
216877c6ca
adds system_mtu argument to nxos_system ( #21970 )
...
* updates argument_spec
* adds unit test case
8 years ago
10b23f3a00
adds unit test cases for nxos_command ( #21959 )
8 years ago
0cb2019293
roll up of bug fixs for nxos_evpn_global ( #21961 )
...
* updates nxos_evpn_global module
* adds integration test cases
* adds unit test cases
8 years ago
21880b9742
adds nxos_config unit test cases ( #21960 )
8 years ago
76c9ad9dfc
new module nxos_system ( #21627 )
...
* provides declarative config support for nxos system attributes
* adds unit test cases for new module
8 years ago
Olivier BLIN