* Fix rollback in junos_config (#31424)
* Fix rollback in junos_config
Fixes#30778
* Call `load_configuration` with rollback id in case
the id is given as input
* Pass rollback id to `get_diff()` to fetch diff from device
* Fix unit test
(cherry picked from commit 88da95bb77)
* Update changelog
* fix paths to actually be config file relative
also allow to unfrack paths for 'not cwd'
only use -i 'localhost,' for adhoc in pull
(cherry picked from commit 3886f80e44)
* Module option metadata are extra arguments rather than S3 object metadata: update ExtraArgs variable.
* Maintain backwards compatibility by guessing at content type rather than always defaulting to binary/octet-stream.
* [rpm_key] Fix to import first key on the system
Fixes: #31483
* [rpm_key] removed unsafe_shell and "throwaway" underscore
* [rpm_key] adding test to add the first key on system
(cherry picked from commit 5ccc1072ea)
* Remove sysctl entry when state=absent
* Cleanup sysctl integration test syntax
* Correct grammar on error message
* Add sysctl integration test for state=absent
(cherry picked from commit 2610b521bc)
* clarified inventory_dir changes for 2.4
added example on how to restore (mostly) old behaviour for add_hosts
fixes#30901
(cherry picked from commit dc69af50dc)
this should allow user to control how they want the playbook dirs inspected
for additional vars, default now reverts to 2.3 behaviour (top).
corrected paths order
minor doc reword
(cherry picked from commit 7d49b27218)
this was abandoned early on the manger side but seems like we left behind on plugin side.
more flexible extensions with yaml plugin
validate data correctly for yaml/constructed
fixed issue with only adding one child to keyed, the group only got the host that forced it's creation
fixes#31382fixes#31365
(cherry picked from commit e4c61ea9a1)
* add codeblock to handle 5K platform for nxos_snmp_host
* fix get_snmp_traps for 5K platform
* Make shippable happy
(cherry picked from commit 48f4643a66)
When keyid is 8 charactes long, drop_key function cuts everything
issuing an error: "package gpg-pubkey- is not installed"
(cherry picked from commit 4337b7a777)
* Improve and link Network Proxy docs
It is possible for proxy issues to cause "unable to open shell", so
detail there.
Having the "how-to" in the debug page makes more sense than on the
porting page, so move it.
Fixed a few formatting issues at the same time.
* Edits
* typo
(cherry picked from commit b79d15e67f)
This breaks output from commands in current playbooks. Since this
change fixed a smaller use case we're going to revert this for 2.4.1 and
revisit a different fix for non /bin/sh shells for 2.5.x
This reverts commit 55135c0825.
* Only get rules if listener has been identified in compare_rules
* Always cast the listener port to an integer.
(cherry picked from commit 7cdaa3089e)