Commit Graph

6946 Commits (849cdd90f2cf69bb61e0152bbd06772147cbc5dc)

Author SHA1 Message Date
Toshio Kuratomi 03d33f0905 Start adding required to docs 10 years ago
jctanner e083fa3d11 Disable sftp batch mode if sshpass (#15829)
Make use of the -oBatchMode=no option to force password prompts from sftp

Addresses #13401
10 years ago
Toshio Kuratomi 119baba6b1 Update submodule refs 10 years ago
Toshio Kuratomi c1cc9f1f23 Merge pull request #15845 from abadger/ziploader-constants
Ship constants to the modules via internal module params rather than a secondary dict
10 years ago
Matt Martz 878b0dca68 Use .code instead of .getcode() as py24 does not have .getcode(). Fixes https://github.com/ansible/ansible-modules-core/issues/3608 10 years ago
James Cammarata d2bade6daf Make sure setting facts with run_once makes copies of the data
When using run_once, there is only one dict of facts so passing that
to the VariableManager results in the fact cache containing the same
dictionary reference for all hosts in inventory. This patch fixes that
by making sure we pass a copy of the facts dict to VariableManager.

Fixes #14279
10 years ago
Toshio Kuratomi 186337db28 Ship constants to the modules via internal module params rather than a secondary dict. 10 years ago
Toshio Kuratomi a404d0ffe2 Update submodule refs 10 years ago
Matt Martz a521b70217 Merge pull request #15306 from sivel/ansible-modules-core/issue/3370
Cascade ssh_*args configurations in synchronize
10 years ago
Matt Martz 196453b9b2 Merge pull request #13771 from sivel/binary-modules
First pass at allowing binary modules
10 years ago
Matt Martz 72b6f8244c Merge pull request #15337 from sivel/ignore-profile-crap
Guard against a shell profile printing extraneous data
10 years ago
James Cammarata ae09648068 Merge pull request #15812 from cThrice/patch-3
Fixes #15745 playbook include: Conditional scoping
10 years ago
Toshio Kuratomi b4e78caf25 Merge pull request #15825 from abadger/fix-squashing-traceback
If we can't squash for any reason, then simply do not optimize the items loop.
10 years ago
Matt Martz ca22783086 modify_module does not need to return module_path, as the calling code already has access to it 10 years ago
Matt Martz 34adb54734 Make _is_binary use already read module_data, move _is_binary check to the top of the stack 10 years ago
Matt Martz 0faddfa168 Move binary module detection into executor/module_common.py 10 years ago
Matt Martz ddf3c3838f Re-implement/move some code lost due to merge conflicts 10 years ago
Matt Martz 35246abb2e Don't register new vars that aren't needed 10 years ago
Matt Martz 1e038e5043 Update for py26 10 years ago
Matt Martz 0a8d016642 Get binary modules working for windows, assuming .exe for windows 10 years ago
Matt Martz d8a243bef0 First pass at allowing binary modules 10 years ago
Toshio Kuratomi 292f0ed0d6 If we can't squash for any reason, then simply do not optimize the items loop.
Also add more squashing testcases

Fixes #15649
10 years ago
Matt Martz 1cee3f35b1 Guard against a shell profile printing extraneous data 10 years ago
Toshio Kuratomi 4d59779e0a Fixed importing the libcloud modules to give a nice error rather than a traceback. 10 years ago
Vic Iglesias dac356466c Update GCE module to use JSON credentials (#13623)
* Update GCE module to use JSON credentials

* Ensure minimum libcloud version when using JSON crednetials for GCE

* Relax langauge around libcloud requirements
10 years ago
James Cammarata d391c53b4f Clear blocked hosts when a role duplicate task is found in free strategy
In the free strategy, we mark a host as blocked when it has work to do
(the PlayIterator returns a task) to prevent multiple tasks from being sent
to the host. However, we check for role duplicates after setting the blocked
flag, but were not clearing that when the task was skipped leading to an
infinite loop. This patch corrects that by clearing the blocked flag when
the task is skipped.

Fixes #15681
10 years ago
James Cammarata 08f6283c3f Merge pull request #15747 from larsks/bug/15744
do not erroneously set gathered_facts=True
10 years ago
James Cammarata 3439bcc744 Merge branch 'refresh-inventory-exit' of https://github.com/zenbot/ansible into zenbot-refresh-inventory-exit 10 years ago
James Cammarata 0d7530e6da Change error about loop variable in use to a warning 10 years ago
Toshio Kuratomi 8a184381af Strip junk after JSON return. (#15822)
Fixes #15601
10 years ago
James Cammarata 9d9a451b34 Simply being in an always block shouldn't mean a host did not fail
Previously the changed code was necessary, however it is now problematic
as we've started using the is_failed() method in other places in the code.
Additional changes at the strategy layer should make this safe to remove
now.

Fixes #15625
10 years ago
Carl fefd87c61a Fixes #15745 playbook include: Conditional scoping
Fixes #15745
Applies conditional forwarding to all tasks/roles within the included playbook.
The existing line only applies forwarded conditionals to the main Task block, and misses pre_, post_, and roles.

Typo ::

Made a selection mistake when I copied over the one line change
10 years ago
James Cammarata 33de7707c9 Do not include params when getting role vars in certain situations
In VariableManager, we fetch the params specifically in the next step,
so including them in the prior step is unnecessary and could lead to things
being overridden in an improper order.

In Block, we should not be getting the params for the role as they are
included earlier via the VariableManager.

Fixes #14411
10 years ago
Toshio Kuratomi 9096901c1f Update submodule refs 10 years ago
Toshio Kuratomi 99e3880181 small python3 fix so that ping will run on python3 10 years ago
Brian Coca 4561be00af simplified inventory error messaging 10 years ago
Tim Rupp a685fa5543 Add port argument for bigsuds (#15434)
This patch adds the port argument as a valid parameter to the f5_spec.

This argument is supported in bigsuds version 1.0.4 and greater, so
this patch uses the __version__ variable of the bigsuds module to
determine when the port value should be honored by the module.
10 years ago
Brian Coca f576082949 restore old jsonfile behaviour on key expiration
fixes #14456, now it won't expire keys in middle of a play when they
were 'valid' at 'gather time'.
10 years ago
Brian Coca 47d05e9b58 fix bad assignment, method modifies by ref already
fixes #15694
10 years ago
Matthew Stoltenberg ddd9f92255 add repr for hostvars (#15793)
* allows passing full hostvars to a module
10 years ago
Toshio Kuratomi 9e88fa21f5 Update submodule refs 10 years ago
Kamjar Gerami 724e692f54 fixes-#15685-tools-that-paginate-show-spurious-less-output: less --version outputs to standard out not to standard error so this changes the redirect from 2> to > (#15720)
fixes-#15685-tools-that-paginate-show-spurious-less-output: Updated redirect to include stderr as well as stdout to not show any errors on screen
10 years ago
jctanner 781de83762 When walking through module directories, always follow symlinks. (#15784)
Fixes #15783
10 years ago
Toshio Kuratomi 409bfe4d0f Strip leading and trailing whitespace for json arg types 10 years ago
Robin Roth 30e5999812 Fix distribution_facts missing on BSD (#15780)
The previous fix in #15773 only solved MacOSX, but left other BSDs broken

fixes #15768
10 years ago
Pomin Wu 78808fc4cc Fixed `ansible_os_family` variable on OS X (#15768) (#15773)
Fixed `ansible_os_family` variable on OS X
10 years ago
nitzmahone fca5ba153e bump extras submodule ref 10 years ago
Toshio Kuratomi 0a5831e654 Update submodule refs 10 years ago
Jiri Tyr 589f6d25bb Updating VCA module documentation (#14368) 10 years ago
James Cammarata 09c90f7f2f Fixing bugs in strategies
* Don't filter hosts remaining based on their failed state. Instead rely
  on the PlayIterator to return None/ITERATING_COMPLETE when the host is
  failed.
* In the free strategy, make sure we wait outside the host loop for all
  pending results to be processed.
* Use the internal _set_failed_state() instead of manually setting things
  when a failed child state is hit

Fixes #15623
10 years ago