Commit Graph

9029 Commits (848e9de95015092da289ddcdbdd28a9a09e833ef)

Author SHA1 Message Date
Carlo Mandelli 1f93a052d6 Added HP-UX subclass 8 years ago
James Cammarata 7fd7cffb61 Updating version added fields for new alias parameters in route53 8 years ago
Monty Taylor 3e3486b813 One more OpenStack deprecation notice
Fixes #858
8 years ago
Oleg A. Mamontov 845b6d78be On FreeBSD apply 'login_class' only if there is real change. 8 years ago
James Cammarata 657d9d1f25 Add private_zone parameter for route53
Fixes #473
8 years ago
Monty Taylor 411c7e22b6 Add deprecation notices for old OpenStack modules 8 years ago
Brian Coca fb61d5e795 fixed add_host docs indentation 8 years ago
Monty Taylor 7c9a36a999 Deprecate old OpenStack modules
There are a completely new set of modules that do all of the things like
keystone v3 and auth_plugins and the like correctly. Structurally
upgrading these would have been massively disruptive and there is no
real good way to do so without breaking people.

These modules should be kept around for several releases - they still
work for people - and they should get bug fixes. But they should not
take new features. New features should go to the os_ modules.
8 years ago
Brian Coca d6305bc938 fixed file module to use realpath when following links, readlink could be relative and fail in corner cases as per #852 8 years ago
Edward Larkey d17726bae9 Fix typo in authorized key module documentation.
Added opening double quote
8 years ago
Toshio Kuratomi b9984b1dfe Fix documentation to have correct param name 8 years ago
Dann Bohn 2cbaf16bcd rhn_channel using depriciated methods. swapped out with their replacements 8 years ago
Brian Coca 5c90040626 undeprecated docker_image until replacement actually arives 8 years ago
blxd 35c414c271 Added check mode support to the ini_file module 8 years ago
Gerard Lynch 1fcc1a7374 wait_for: updated docs, must be resolvable hostname, updated example 8 years ago
Brian Coca 1ca1a2ed98 fixed typo on isgid 8 years ago
Brian Coca 49c10e4359 now captures connection exceptions and returns in 'nicer' module failure 8 years ago
Brian Coca 6e08dea567 fixed issues with stats return docs as per feedback 8 years ago
Brian Coca 47f84190a0 removed always for success, as data wont show on fail 8 years ago
Brian Coca 4124f8c381 now module fails gracefully instead of stacktrace when trying to install missing deb file 8 years ago
Brian Coca 8f197aed48 added missing docs on connection_timeout for wait_for 8 years ago
Brian Coca d07d41b914 added note to add_hosts about loop bypass 8 years ago
Brian Coca bcd6a6a3d5 draft for documenting module returns 8 years ago
Coderah 0fbe26273d add alias support to route53 module 8 years ago
Coderah 40c41ed4ec add hosted_zone information to ec2_elb_lb return 8 years ago
Capi Etheriel 103caa2853 add ec2 instance tags and groups info 8 years ago
Joel Thompson 646657e325 Fixes issue 697 -- only purge the grants that need to be purged 8 years ago
Stefan J. Betz aca24caa19 Create SSH Keys always after creating $HOME 8 years ago
Jorge-Rodriguez ad9379ad7d Added optional parameter scheduler_hints. 8 years ago
Bret Martin ed3f1a133b ec2: make group only match group names in this VPC 8 years ago
Edward bad5aafd30 Fixes #816 Backups not enabled on new droplets.
Convert backups_enabled string to lowercase. Similar to fix for private
networking.
8 years ago
Brian Coca 2278a69f7b fix for mount w/o opts (bug introduced when fixing bind mounts) 8 years ago
Brian Coca 70856d5228 fix instance=None documentation 8 years ago
Brian Coca cd7f498755 Revert "Revert "Don't use 'tenancy' in ec2 spot requests"" 8 years ago
Brian Coca 6e55a0324b Revert "Don't use 'tenancy' in ec2 spot requests" 8 years ago
Dan Rue d3c686d632 Do not mark "skipped" when changed is false
When using the "creates" option with the uri module, set changed
to False if the file already exists. This behavior is consistent with
other modules which use "creates", such as command and shell.
8 years ago
Matt Martz 8e4755728e DRY up duplicate code 8 years ago
mrsheepuk 31421374c0 Doc change - make clearer usage for existing remote file
Having read the doc for this module several times and completely missing that it can be used for existing remote archives, I propose this update to the wording to make clear from the top the two ways in which this module can be used.
8 years ago
Gauvain Pocentek 6c7b202a63 fetch: fix the flat parameter description
ansible-doc expects the value of the description field to be a list,
otherwise the output is not correct. This patch updates the flat
description to be a list.
8 years ago
Matt Martz cf50526cb5 Don't hardcode minimum for boot_volume_size 8 years ago
Sergey Zhukov d013652dc7 Fixed broken volumes_from for client API >= 1.10 8 years ago
Marek Chodor 35ab6d15df Fixes docker.errors.DockerException: 'dns' parameter has no effect on create_container(). It has been moved to start() 8 years ago
Matt Martz 724ae97898 Fix order of logic to determine required args 8 years ago
Richard Lander a0dad8e683 password required 8 years ago
Richard Lander f5532b7904 set network_config.public_ips attribute 8 years ago
Matt Martz 1f51a5effd Add boot from volume functionality to rax and rax_cbs modules 8 years ago
Toshio Kuratomi 3aba0d5272 Fix for recursion traceback in copy with relative paths
This is a further fix for: https://github.com/ansible/ansible/issues/9092

when the relative path contains a subdirectory.  Like:

ansible localhost -m copy -a 'src=/etc/group dest=foo/bar/'
8 years ago
Matt Martz cce6cb8d7f Don't hardcode a minimum size of a volume 8 years ago
mcameron f799180a58 More general output. 8 years ago
Toshio Kuratomi af6c625cc2 When recursing subdirectories, honor the follow parameter for setting file attributes.
One half of the fix for
https://github.com/ansible/ansible-modules-core/issues/778
The other half is in basic.py
8 years ago
mcameron 751e268f0d Useful log output. 8 years ago
Rahul Mehrotra fe08f52d92 Fixed Documentation issue concerning file mode when specified using numberical value 8 years ago
David Hummel 63e9de3170 Fix issue #793: mysql_db: for state={absent,present} connections to database mysql fail for users other than root 8 years ago
Robert Marsa 4737b41f26 Added the ability to set an instance to forward ip. 8 years ago
Jon Hadfield 90f5a23f34 use is-enabled to check systemd service status. 8 years ago
Matt Martz a078a99fae Support accounts with more than 100 load balancers 8 years ago
Brendan Jurd fdc52b8277 Add word boundary in apache2_module regexp
Add a word boundary \b to the regexp for checking the output of a2{en,dis}mod,
to avoid a false positive for a module that ends with the same text as the
module we're working on.

For example, the previous regexp r'.*spam already enabled' would also match
against 'eggs_spam already enabled'.

Also, get rid of the redundant '.*' from the end of the regexp.
8 years ago
Graham Hay 15fcbcb0ee Use insserv where available 8 years ago
Henry Finucane 464c502f95 dpkg does not take a --force-yes option 8 years ago
Doug Ellwanger cc6cc6e302 Pull SSL certificate IDs from existing ELBs 8 years ago
Petros Moisiadis f5961f9ecf synchronize: use a single -F instead of -FF
This small change corrects behavior when one uses an .rsync-filter file to exclude some paths from both being transferred and being deleted, so that these excluded paths can be handled separately with different tasks (e.g. in order to deploy the excluded paths independently from the rest paths and notify handlers appropriately). The problem with the double -FF option is that it excludes the .rsync-filter file from being transferred to the receiver. However, deletions are done on the side of the receiver, so it is absolutely necessary the .rsync-filter file to be transferred to the receiver, so that the receiver knows what files to delete and what not to delete.
8 years ago
Sébastien Gross 164d518370 Add basic support for OSX groups. 8 years ago
Sébastien Gross 624be0e239 Add basic support for OS X (Darwin) user management. 8 years ago
Robert Marsa bf3cb32c1b Added target_tags to gce_module. 8 years ago
Dagobert Michelsen 9991e8d8f1 Solaris SMF is already supported and should be mentioned in the docs, 8 years ago
Brian Coca 132c43a84f added note that url src is only avaialable from 1.9 on 8 years ago
Toshio Kuratomi 691f4cc049 Tabs to spaces 8 years ago
Tomer Paz 76ee9a6a04 resolve issue 764
https://github.com/ansible/ansible-modules-core/issues/764
added 'domainname' attribute in addition to existing 'hostname'.
That's the most elegant way to delegate domain name to docker-py...
8 years ago
Paul Geraghty 5f24584010 Correct grammar of comment relating to example 8 years ago
giovtorres 1f034a6573 Added pip example installing from local tarball 8 years ago
moussa taifi 742c10a1a0 Adds the currently available instance types for azure to the available dict(choices..... 8 years ago
Luc Bourlier ae97d76a12 Don't use 'tenancy' in ec2 spot requests
The problem was introduced in commit f5789e8e. 'tenancy' is a parameter of
ec2.run_instances, but not in ec2.request_spot_instances. So it was breaking
the support for spot requests.
8 years ago
Jesse Keating 6f4273a3ff Add exclusive option to authorized_keys
This option allows the module to ensure that ONLY the specified keys
exist in the authorized_keys file. All others will be removed. This is
quite useful when rotating keys and ensuring no other key will be
accepted.
8 years ago
Philippe ALEXANDRE 5b48ecc80a Add Linuxmint support in hostname module 8 years ago
Jeff Gonzalez 7ea6650d6c Refactored code to use module utility fetch_url function. 8 years ago
Jeff Gonzalez 04fb952d49 Added documentation for using url as key source 8 years ago
Brian Coca b6a1927f13 now allows for case in which someone removed the K* links and is trying to reenable a service 8 years ago
Brian Coca 03273e06c7 simplified update-rc.d enable/disable handling, removed forced defaults creation as that breaks local customizations 8 years ago
Jean-Baptiste Barth c0b2960892 Improve formatting after previous commit 8 years ago
Jean-Baptiste Barth 58ff9bece2 EC2: move logic about terminated instances up (#423)
As stated in #423, the commit 7f11c3d broke ec2 spot instance launching
after 1.7.2. This is because it acts on the 'res' variable which have 2
different types in the method, and in case we request spot instances,
the resulting object is not a result of ec2.run_instances() but
ec2.request_spot_instances(). Actually this fix doesn't seem to be
relevant in the spot instances case, because by construction we won't
retrieve 'terminated' instances in the end.
8 years ago
Toshio Kuratomi 52d769d36c Reverse the force parameter for the hg module 8 years ago
Peter Mooshammer d741b57b91 adding disk_type option to choose from pd-ssd or pd-standard 8 years ago
Toshio Kuratomi 49f5b28fbd Change the git force parameter to default to no as a safety change.
Fixes #306
8 years ago
Toshio Kuratomi 245dce0e30 Make documentation list when force changed defaults 8 years ago
Toshio Kuratomi 36a483dacd Update force documentation to reflect default=no 8 years ago
Brian Coca b853ad6c90 corrected version added for latest features 8 years ago
Brian Coca 83e0516478 minor fixes on new rds refactor 8 years ago
AlejandroF 2e40773034 Example added
How to define specific version of the package we need...
8 years ago
Brian Coca 884471a6b5 implemented account expiration as flag and not state, removed from unsupported platforms 8 years ago
Toshio Kuratomi 84f27cfa68 Remove str.format() usage for python2.4 compat.
Fixes #10036
8 years ago
Conrado Buhrer 09082e6e7f fixed: namespace clash #710 8 years ago
Conrado Buhrer abde33c615 fixed: erroneous logic 8 years ago
Conrado Buhrer a6315043ef fixed: missing check for upgrade flag 8 years ago
Conrado Buhrer 807b168590 fixed: removed build-deb from required_one_of 8 years ago
Toshio Kuratomi e4a3e5fdd7 Prefer gtar to tar
Fixes #702
8 years ago
Conrado Buhrer 3165b39d21 changed: state=build-dep; refactored into install() 8 years ago
Conrado Buhrer 442663a13a added: build-dep to apt module #349
Original code provided by @nathanhruby
8 years ago
Johannes Steger 1a440d6a06 Fix function identifier quoting 8 years ago
sysadmin75 2990358cd5 Fix #10059 - replace module does not obey follow=yes 8 years ago
Toshio Kuratomi dd79a27e73 Spelling and grammar fix 8 years ago
Matt Martz ff90273021 Remove unnecessary logic, return the database on delete 8 years ago
Toshio Kuratomi a73bd8dcbc More information about distutils on Solaris in case we run into this again 8 years ago
Toshio Kuratomi 52bcf4a195 Don't fial if virtualenv is not installed and we do not need to initialize the virtualenv
Fixes #688
8 years ago
Brian Coca f90da6b2ba ec2 fix docs format 8 years ago
Brian Coca ed0f5045eb moved defaulting to module constant to after when it is defined 8 years ago
Toshio Kuratomi 547c90554a Standardize class names on Archive suffix.
This also removes the collision between the stdlib ZipFile class and the
module's ZipFile class

Fixes #681
8 years ago
Brian Coca 1f1ebf248f updated tenancy version added 8 years ago
Ryan Rawson e318ef2d70 Fixes #581 - digitalocean module cannot create private_networking=true droplets 8 years ago
Ben Konrath 96a20de9ff Add support for SL7 to hostname module. 8 years ago
Brian Coca 8405edd5a2 now handles non string values for sysctl 8 years ago
Alex Clifford 4097cbf317 ttl should always be used during a delete 8 years ago
Matt Martz 8b60fb7181 Remove unnecessary required arg logic, and remove 'absent' as a valid choice since it isn't implemented 8 years ago
Matt Martz 5ae50eb8cf Small fix-ups to convert objects to dicts, update volume details at the appropriate time, and remove unnecessary required argument logic 8 years ago
Matt Martz 19d99e0da6 Remove some broken and unnecessary required args logic 8 years ago
Matt Martz 63e5d5dcc4 Use rax_to_dict and make sure to return the volume details after deletion 8 years ago
Brian Coca 02a1cb62df corrected release when this feature was added 8 years ago
Patrik Lundin 88fe45d7e7 Update OpenBSD rcctl handling to use new syntax.
See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2
8 years ago
Matt Martz 3a46c79451 Clean up some required argument logic 8 years ago
Matt Martz db5f2bf3df Just use built in required functionality for arguments 8 years ago
Matt Martz 617048b717 It is not correct that you need at least 1 primary node 8 years ago
Tim G b2e39265e1 Load distutils on all platforms EXCEPT Solaris.
Solaris doesn't ship distutils with with the default Python package.  This patch fixes "service" on Solaris since 30d6713.
8 years ago
Toshio Kuratomi 1728f9bba7 Add detection of uid,gid,mode changes when deciding whether an archive needs to be unarchived again. 8 years ago
Brian Coca 65d3b167e6 now captures cache fetch failures 8 years ago
Toshio Kuratomi f9a6ec95b0 Implement user,group,mode,selinux settings for unarchive.
This is a partial fix for #234.  Still have to figure out how to
make change reporting work as we can no longer rely on tar's --compare
option
8 years ago
Toshio Kuratomi 44354e31e4 Better error messages if a2enmod/a2dismod are not found 8 years ago
Toshio Kuratomi f3d41cdb06 Potential fix for 640 8 years ago
Tim G ea77ac076b distutils is not available on some non-Linux OS's 8 years ago
Alex Clifford d4c4dd31d8 Fix slight typo in doco 8 years ago
Toshio Kuratomi e11ea4b402 Also catch mysql errors so we can give the error message back through json rather than tracebacking 8 years ago
Michael Scherer 0a745de765 Do not use echo shell builtin for password
Using \t in a password may result in a different password
being set :

    $ echo 'a\ta'
    a   a

Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
8 years ago
Michael Scherer b154bf967e Remove unused code
There is no call to yum_base using 'cachedir' argument, so
while it work fine from a cursory look, that's useless code,
and so should be removed to clarify the code.
8 years ago
Michael Scherer 2dfc7122af Use the rpm python module rather than execing rpm
Using the rpm module prevent a uneeded fork, and permit
to skip the signature checking which slow down a bit the
operation, and which would be done by yum on installation
anyway.
8 years ago
Bruce Pennypacker 605a5a5b53 requested changes 8 years ago
Bruce Pennypacker 9cbe3eb8ae Added support for 'REQUIRE SSL' grant option 8 years ago
Brian Coca a3de4db57d fix for allowing permissions on hard links and soft links + follow=yes 8 years ago
Toshio Kuratomi e75dc7e5a6 Clarify documented behaviour of user module's ssh_key_file parameter
Fixes #9873
8 years ago
Brian Coca c5dfc66cb1 added version added for new template options 8 years ago
Vasyl Kaigorodov d41ec7027f gce_net - creating firewall rule, src_range value seems to get lost or set to empty string -- fixes #252 8 years ago
James Martin 07dbc333b2 vpc_zone_identifier must be a csv string when an asg is updated. 8 years ago
Brian Coca 9eb77bdb4f fix for when state=directory, follow=yes and target is symlink to directory 8 years ago
Philip Misiowiec f3abfa0f19 Adds tenancy state to returning json 8 years ago
Johnny Robeson 6fc04862a4 rename FedoraStratgy to SystemdStrategy 8 years ago
Michael J. Schultz 588d03db8d Build the db connection on `"postgres"` instead of `"template1"`
According to the postgresql docs[1], you should not have a connection with
`"template1"` when copying multiple databases.

[1]: http://www.postgresql.org/docs/9.1/static/manage-ag-templatedbs.html
8 years ago
Jeff Gonzalez 30822706dd Added ability to use url as key source 8 years ago
Michael Scherer d357f309b5 Fix #370, by allowing to export over a existing repository
This requires to use force=True
8 years ago
Michael Scherer e1194116b2 Make force parameter work for export operation
The default is changed from 'yes' to 'no' to follow
subversion behavior (ie, requiring explicit confirmation
to erase a existing repository). Since that was not working before
cf #370 and since the option was ignored before and unused, this
should be safe to change.
8 years ago
Patrik Lundin 9803938663 Handle string returned by 'default' correctly.
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
8 years ago
Jesse Buchanan 06a58dcad7 Files module: Allow touch on hardlinks 8 years ago
Patrik Lundin d88080007a Fix typo: Replace "N0" with "NO". 8 years ago
anatoly techtonik 59a700ad17 acl: Fix X support in ACL permissions
If you try to set rwX permissions, ACL fails to set them at all.

Expected:

    $ sudo setfacl -m 'group::rwX' www
    ...
    drwxrwxr-x  2 root root  4096 Nov 10 17:09 www

With Ansible:

    acl: name=/var/www permissions=rwX etype=group state=present
    ...
    drwxrw-r-x  2 root root  4096 Nov 10 17:30 www

x for group is erased. =/
8 years ago
Patrik Lundin 6594a1458d Multiple fixes for OpenBSD rcctl handling.
* Use the newly added 'default' argument to know if the default flags are set
  or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.

Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
8 years ago
Ricky Cook 522c644bf1 Fix regex string format 8 years ago
Ricky Cook a6a9e2c247 Get warn option same as other args 8 years ago
Ricky Cook 095400c45e Add comment to command options dict 8 years ago
Ricky Cook 5e21c81ca4 Simplify command module option parsing 8 years ago
Luís Guilherme F. Pereira b347875de0 Allow ec2_lc to create EC2-Classic Launch Configs
Removes default value from ec2_lc so it can create launch configurations valid on a EC2-Classic environment. AWS API will not accept a assign_public_ip when creating an ASG outside of VPC.
8 years ago
Nate Coraor 771fdfb1f8 Fix a few bugs and misbehavior in the hg module: 1. Don't pull when `dest` is already at the desired changeset. 2. Don't change the working copy when cleaning or pulling and a revision was specified. 3. Change the default for the `revision` param to match the behavior of hg. 8 years ago
Jonathan Mainguy aef138107c Fixes bind mounts
Fixed tab's and spaces, or so I think I did

Fixed tabs and spaces for real this time
8 years ago
Jonathan Mainguy 6be46cb2e3 Fixes --enable-repo for Oracle Linux 8 years ago
Jonathan Mainguy 13990e9479 adds error message if socket does not exist 8 years ago
Philip Misiowiec c57c1ea419 added version 8 years ago
billwanjohi b019076dd3 user: add expired state
ported from
https://github.com/ansible/ansible/pull/6303

It's very useful and routine to disable a *nix user.
I implemented expired instead of locked because this prevents any use of
the account, safer than just preventing password-based authentication.

I have tests [1], but since none of the suite came along with the core
modules, I'm unsure how to submit them.

[1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml
8 years ago
kustodian 447c625cb3 Set selinux state to 'permissive' for state=disabled 8 years ago
Michael Scherer 36c653f54a Add hostname to generated user SSH key comment
The default is not very useful to sort between different
keys and user. Adding the hostname in the comment permit to later
sort them if you start to reuse the key and set them in different
servers. See https://github.com/ansible/ansible/pull/7420
for the rational.
8 years ago
Phillip Holmes 0d3b144eb2 Route53 fix - forcing zone_in, record_in to lower case
Fixed the .tolower to .lower() for correct syntax (copied change from older notes).
8 years ago
Philip Misiowiec 23668e41b0 Support for EC2 dedicated tenancy option 8 years ago
Philip Misiowiec d30881a461 Ability to detach an EBS volume from an EC2 instance 8 years ago
fabios 3c53b3b268 mark as upgradable and let apt-get install deal with it 8 years ago
fabios 043242df2c improve fail message and use itertools chain 8 years ago
fabios 21bfa80203 older python-apt compatibility 8 years ago
fabios 301c8b8e09 handle list of list for python-apt < 0.7.9 compatibility 8 years ago
Lorin Hochstein 88d5f15025 docker: fix volume[s]_from typo
Code makes reference to volume_from instead of volumes_from. If volumes_from is
passed as an argument, generates a KeyError.
8 years ago
Toshio Kuratomi 1dc2ae0aef Cleanup the old apt compatibility changes 8 years ago
fabios 0ad355585a use low-level apt_pkg.Package 8 years ago
Jan Weitz 8146b45203 Fixes invalid dictionary access. 8 years ago
FabioBatSilva a748229f3a fix compatibility issues with python-apt < 0.7.9 8 years ago
Mark Phillips 786aceb43b vsphere_guest fix for KeyError: folder message 8 years ago
Jan Weitz 1b9d0c5987 Fixes version check for docker-py 8 years ago
Toshio Kuratomi 1be539d870 git fetch --tags overwrites normal fetching with git < 1.8.x so do a normal fetch followed by using the refspec format for fetching tags 8 years ago
Toshio Kuratomi 73b7d6ea7b Fix typo in git refspec code. Change lists to tuples 8 years ago
Brian Coca 945909bf67 update to use connect_to_region to avoid errors with china 8 years ago
Brian Coca abdb1afa0a Revert "Merge pull request #384 from jhawkesworth/win_copy_file_template_ansible_modules_core_1" I missed some discussion in devel, these need more work before inclusion
This reverts commit 58bfebb047, reversing
changes made to 27dee77ca0.
8 years ago
Peter Oliver 432a6286db Fix appending to a user's group on Solaris
Without this change, you get:
    AttributeError: 'set' object has no attribute 'extend'

Tested on a Solaris 11.2 client with the included Python 2.6.8.
8 years ago
Toshio Kuratomi 5c090207ff Make documentation clear about update=no vs clone=no 8 years ago
Chris Church 9d0830a181 Change version added in win_user docs to 1.9 for updates that didn't make it into 1.8. 8 years ago
Rohan McGovern b607ffb7c6 git: add 'refspec' argument
This argument may be used to fetch additional refs beyond the default
refs/heads/* and refs/tags/*.  Checking out GitHub pull requests or Gerrit
patch sets are two examples where this is useful.

Without this, specifying version=<sha1> with a SHA1 unreachable from any
tag or branch can't work.
8 years ago
Rohan McGovern 06ff34f364 git: clean up "fetch" method
De-duplicate repetitive code checking the exit code.

Include the stdout/stderr of the failed process in all cases.

Remove the returned values because no caller uses them.

Combine git commands where possible.  There is no need to fetch branches
and tags as two separate operations.
8 years ago
Toshio Kuratomi d28cd02ab7 Newstyle class 8 years ago
Toshio Kuratomi 4aaba45e29 Make insecure_registry feature version check against the client API 8 years ago
Maksim Losev 807d964a48 Add insecure_registry to docker-py pull method
Starting from docker-py>=0.5.0 it is impossible to work with private registries based on HTTP.
So we need additional parameter to allow pull from insecure registry
Related to ansible/ansible#9111
8 years ago
Toshio Kuratomi 7b74e451d9 Make docker ver checks issue failures rather than silently ignoring
Also:
* make client version checks robust for two digit version pieces and
  alpha versions
* consolidate version checking code
8 years ago
Will Thames 834c8d2f59 Added better region handling and enabled eu-central-1
Make use of improved connect_to_aws that throws an exception
if a region can't be connected to (e.g. eu-central-1 requires
boto 2.34 onwards)

Add eu-central-1 to the two modules that hardcode their regions
Add us-gov-west-1 to ec2_ami_search to match documentation!
This pull request makes use of the changes in ansible/ansible#9419
8 years ago
Ingo Gottwald f88107bc9b Add support for new docker restart policies 8 years ago
Toshio Kuratomi 8af70de1fc Probably would make clone a 1.9 feature rather than 1.8.3 8 years ago
Toshio Kuratomi a7ff6c4cba Make git's update parameter revert to its old behaviour and add new clone parameter to take its place.
Fixes #426
Fixes https://github.com/ansible/ansible/issues/8630
8 years ago
Kale Franz 7c8f0b99af #531 correction
correct list comprehension for older versions of python (back to python 2.4)
8 years ago
Kale Franz eac743dc39 fixes #529 ec2_group module bug 8 years ago
Toshio Kuratomi 104b2d684c Add text/json as a mimetype to try deserializing
Fixes #503
8 years ago
Jonathan Mainguy 8c05023be3 Fixed hostname for rhel5 python 2.4.3 8 years ago
zitterbacke 1d4808780f re-enable AIX password setting
the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7).

besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.
8 years ago
Toshio Kuratomi 123c99f879 Add error message from git to message returned from ansible
Fixes #81
8 years ago
Jeff Gonzalez 8eedd915cd Fixed formatting in documentation
The example was using mixed shorthand and long form yaml (region: "us-east-1 disable_rollback=true"

I modified the entire example to be long form.
8 years ago
Jeff Bradberry 60ed80f99a Fix breakage in lineinfile check mode when target file does not exist.
Similarly to https://github.com/ansible/ansible/issues/6182, checking of the file attributes should be avoided in check mode when the file didn't originally exist.

Also, avoid creating parent directories in check mode.

Fixes https://github.com/ansible/ansible/issues/9546
8 years ago
Michael Scherer 104f91ed3b Revert commit cbc417c, as the code is broken, see #438
LooseVersion expect a string, so filtering to return a int
is incorrect. Thanks to Jeremy Brown for the analysis.
8 years ago
sysadmin75 7fbb422ae7 Fixes #9518 - "file state=directory" silently skips if it's currently a file 8 years ago
kustodian 8621f9a7cd Fixed postgresql_db failing on Python 2.4 with --check
This reverts commit 81cbdb6c8c and adds ignoring of the SystemExit exception because of Python 2.4.
8 years ago
Toshio Kuratomi e359f7cfcf Don't traceback if a gid is specified instead of a group name
Fixes https://github.com/ansible/ansible/issues/9796
8 years ago
Mike Putnam d2d0ffd83a Type fix on delete_snapshot docs. 8 years ago
Toshio Kuratomi 37f237ecfc Fixup the directory name at a higher level so it can be used by both conditional branches
Fixes #500
8 years ago
Jon Hawkesworth 44cc1a75ba Switched to SHA1 checksum instead of MD5 8 years ago
Harald Skoglund 1a8b9b8935 add support for stack policies in cloudformation 8 years ago
Jon Hawkesworth 67def35795 Adding first pass at win_copy, win_file and win_template modules (include new files). 8 years ago
Harri Hämäläinen 299d28f7e5 Fixed typo in comment 8 years ago
Brian Coca 6d56767454 fixed hostname for gentoo 8 years ago
Matt Martz 411e4cfae8 Make a few enhancements to the rax_scaling_group module
* Cast loadbalancer id and port to integers
* Do not attempt to base64 encode NoneType values
8 years ago
Petros Moisiadis 63b18ae618 mysql_user: Added missing privileges
Added missing privileges 'CREATE TABLESPACE' and 'PROXY' (see: http://dev.mysql.com/doc/refman/5.5/en/privileges-provided.html).
8 years ago
PikachuEXE fbba80d72e ~ Add missing documentation for option `email` 8 years ago
Andrew Shults 2390184084 Strip white space to support multiline permissions in YAML 8 years ago
Toshio Kuratomi 88ccfc219a Change git update param documentation to match reality 8 years ago
Toshio Kuratomi 8b586ad055 Before pulling submodules from repos add ssh hostkeys for those submodules
Fixes #9655
8 years ago
Mike Putnam 1de5248a0a Clarify possible variable value in the docs. 8 years ago
Toshio Kuratomi 6f3f0904eb Fix git mod so that we switch to the desired version even if it was previously downloaded 8 years ago
Toshio Kuratomi 59066f6138 Some cleanups to the git module 8 years ago
Toshio Kuratomi fc15177e6e Revert git module doc update because it appears ssh:// works and bare ssh repo does not
This reverts commit e715909831.
8 years ago
Marcus Ahle a71b1b7385 Preventing Nonetype is not iterable error when no tags are passed in for a newly created ASG 8 years ago
Ben Whaley 6609ebde27 vpc_zone_identifier should be a list as per the docs 8 years ago
Brian Coca 77ec45e3d1 vastly simplified systemd detection, made enable/disable errors clearer both of which allows us to remove 'service name detection' as if systemd is init we still use it to handle initscripts. 8 years ago
Brian Coca 8b9772565e now actually adds usable name for systemd when service only has init script 8 years ago
Peter Bwire 20eb900065 Update django_manage to add database option for migrate
Allow passing the database option to the django_manage module for migrations. This is usefull in situations where multiple databases are used by a django application.
8 years ago
Dale Bewley 65d8fbd9ab use state parameter in examples 8 years ago
follower b15a633103 Note that `rsync` must be installed on both local & remote machine
In particular, if `rsync` is not installed on the remote machine the following error message will be encountered:

    "rsync error: remote command not found"
8 years ago
Toshio Kuratomi 9fde3c2dc5 Add USAGE as a valid privilege 8 years ago
Scott Miller c49a20b0e5 fix documentation
AWS does not recognize the subnet if it is presented in a comma delimited format with spaces. you must remove the space for Amazon to recognize the second subnet.
8 years ago
Toshio Kuratomi cd7cc07e85 Gixes to doc formatting 8 years ago
Francois Deppierraz 181c3aa25f Fix auto_floating_ip documentation
The default value is 'no' instead of the currently documented 'yes'.

See cloud/openstack/nova_compute.py line 543:

        auto_floating_ip                = dict(default=False, type='bool'),
8 years ago
Toshio Kuratomi 307116b838 Fix typo so docs will build 8 years ago
Toshio Kuratomi 7ff9b3990a Update cron example for setting to run twice a day
Fixes #415
8 years ago
Tomasz Kontusz 103b5954c7 supervisorctl: Don't try to start a starting program
Starting a "STARTING" program throws ERROR (already started),
so don't do that.
8 years ago
Steve Fox 7af1c96623 retry_interval needs to be a float before passing to time.sleep 8 years ago
Lorin Hochstein 0cf3cfbf5a git doc: don't prepend ssh:// for ssh repo
The github ssh example has ssh:// at the beginning of the url. However, this doesn't
work. It does work if the ssh:// is removed.
8 years ago
Chris Church ff193241b1 Minor win_user fixes based on feedback. 8 years ago
Brian Coca ab96ff8b6d service cleanup 8 years ago
Stewart Rutledge 0f1bf6c8c1 Fixed a typo on power options 8 years ago
Jérémie Astori c52bfe3e35 Fix #91: Expand user home folder for the key_file path of the git module 8 years ago
Chris Church 262624ca12 Update win_feature module to work on server 2008 and fail with error message on non-server windows, fix output messages and error handling. 8 years ago
Chris Church c81c192dcb Update win_user module to support more user options and group membership changes. 8 years ago
sterutkb 944ce9c7c3 Added support for deploying virtual machine from a virtual template 8 years ago
Michael Scherer 4e4e0cca17 Fix old ticket #9092 where a playbook can enter in recursion
This can be tested with this command :

    ansible -c local -m copy -a 'src=/etc/group dest=foo/' all

This is a corner case of the algorithm used to find how we should
copy recursively a folder, and this commit detect it and avoid it.

Check https://github.com/ansible/ansible/issues/9092 for the story
8 years ago
Philip Misiowiec 3f4d412bff Ability to specify new SSD EBS option 8 years ago
Patrik Lundin 8a6a4a7757 Simplify self.arguments logic.
Strange logic pointed out by @jarmani, thanks!
8 years ago
Patrik Lundin 2b18e544f5 Depend more on rcctl if it is present.
* Make the module support enable/disable of special services like pf via rcctl.
  Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
  match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
  is available.
8 years ago
Will Thames 63656e5ef7 Fixed tagging 8 years ago
Denver Janke 61cfccff1c Fix few bugs around renaming db instances. 8 years ago
Will Thames daac0e3a3e Improved error handling
More tests, particular for failure testing
8 years ago
Patrik Lundin 25c3c03a11 Tweak error checking for "enabled" code.
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
  trying to handle the different meanings of rc after running "status",
  just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
  turn up on stderr.
8 years ago
Patrik Lundin 32cb025b85 Fail if "rcctl status" writes to stderr. 8 years ago
Patrik Lundin 03d4b76b14 Check rc and print error message if any.
It is probably good to use stdout before printing a generic error
message as well.
8 years ago
Patrik Lundin 38d8db473f Make "enabled" code aware of --check mode. 8 years ago
Jonathan Armani d1433eca14 Add enable / disable of services for OpenBSD if rcctl is present 8 years ago
Will Thames 22a3b3f811 RDS rewrite to use boto.rds and boto.rds2
Using rds2 allows tags and the control over whether or not DBs are
publicly accessible.
Move RDS towards a pair of interfaces implementing the details of rds
and rds2
Added tests to ensure that all operations work correctly as well as
requirements files that allow virtualenvs to test either boto.rds or
boto.rds2
8 years ago
Antti Salminen 75e15e2ae9 Find the actual commit annotated tags refer to instead of the tag object. 8 years ago
willthames ef88ff6dd8 Added the ability to remove snapshots
Added state option, and accompanying snapshot_id option for
when state=absent.
8 years ago
Michael DeHaan f875cc5197 Remove potentially out of date or specific product references. 8 years ago
Michael DeHaan 76efaa6cfb More EC2 doc tweaks 8 years ago
Michael DeHaan 590d20db24 Misc EC2 doc tweaks. 8 years ago
Toshio Kuratomi ddc81c7b93 Escape % in db+table names before adding to a format string being passed into db.execute()
Fixes #416
8 years ago
Dan fe787f1bc9 Adds a login_unix_socket option to the postgresql_privs module. 8 years ago
Dan ee65c55fb0 Adds a unix_socket/login_unix_socket option to the postgresql_user module. 8 years ago
Dan 789ee410f1 Adds a login_unix_socket option to the postgresql_db module. 8 years ago
René Moser ceeeea84cd yum: add update_cache option
Yum does not always update to latest package version unless metadata cache has expired. By runing yum makecache, we ensure the metadata cache has been updated.

Signed-off-by: René Moser <mail@renemoser.net>
8 years ago
Toshio Kuratomi 5734838cd1 Fix module traceback instead of returning an error 8 years ago
Eric 11bd0fed9d Fix lineinfile documentation typo 8 years ago
Achilleas Pipinellis 872f6aa559 Clarify supported init systems. 8 years ago
follower 4889701874 Fix typo of "rules_egress"
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.

Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
8 years ago
Pascal Borreli 187b07e6c0 Fixed typo 8 years ago
Fabrice Bernhard 3d437b068e Typo in comments
Credit goes to @kbsali
@pborreli : you did not see that one? :-)
8 years ago
Toshio Kuratomi e8081baca9 Fix for single role_attr 8 years ago
Toshio Kuratomi 47b009b001 Add a bare grant to the list of allowed privileges 8 years ago
Toshio Kuratomi b00e6464e9 Fix cornercase tracebaxk when detecting whether submodules changed 8 years ago
Devin Christensen b2829cf6b9 Fix user_alter in postgresql_user 8 years ago
Devin Christensen ff7a9eb625 Fix user_add in postgresql_user 8 years ago
Toshio Kuratomi bed60553ca Escape mysql identifiers 8 years ago
Toshio Kuratomi 87b2afc272 Correct new function name 8 years ago
Toshio Kuratomi 3e9771f544 Normalize privs and flags to uppercase so comparisons against allowed names will work 8 years ago
Toshio Kuratomi e0ac340f59 Make sure we quote or confirm good all user provided identifiers 8 years ago
Toshio Kuratomi d3787840a4 Audit escaping of identifiers in the postgresql_user module 8 years ago
Toshio Kuratomi 32aaa07325 More robust quoting of database identifiers
Note: These aren't database values, those are already using the
appropriate Pyhton DB API method for quoting.
8 years ago
Toshio Kuratomi f7fafa8c16 Cannot readlink() on a hard link 8 years ago
Toshio Kuratomi 3e09de7aef Fix git module checking out correct version after initial clone
Fixes #313
8 years ago
Toshio Kuratomi 1af6a85492 Correct variable name 8 years ago
Brian Coca 78fb3217d6 service now detects systemd is actually running, not just installed 8 years ago
Jonathan Mainguy a71ce0615a fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N 8 years ago
Henry Finucane 2363074dd8 If force=true, ignore python-apt's advice
This lets you downgrade packages, for instance.
8 years ago
IndyMichaelB 07d4ddfeff docfix for vsphere_guest.py
Corrected parameter name from user to username in documentation
8 years ago
Sam Kottler bb9c7acc2f Remove trailing whitespace in digital_ocean_domain 8 years ago
Nejc Zupan 442c8a5457 digital ocean: Remove unsupported states 8 years ago
Toshio Kuratomi 81978cbacb Fix retrieval of package version in apt module 8 years ago
Toshio Kuratomi 83e43415da Documentation update for apt version wildcards from bryanlarsen 8 years ago
Toshio Kuratomi 9472a27345 Clean up the docker module just a little so that we can unittest the get_split_image_tag function 8 years ago
Toshio Kuratomi f45e70fdbc Moving unittests to the main ansible repo for now 8 years ago
Toshio Kuratomi 615b954cd8 Update package_status and install to account for wildcarded versions. 8 years ago
Toshio Kuratomi 1ca1b80fe8 Decide to allow pkgname and version wildcards so that things like libxml2*=2.9* would work 8 years ago
Toshio Kuratomi 37fa22eb93 Cache pkg name list so we don't recreate the list for every package 8 years ago
Toshio Kuratomi 6b776da7bc Just make things a little more readable 8 years ago
Toshio Kuratomi f2c1d49de7 Correct trivial spelling. 8 years ago
Toshio Kuratomi 945447e392 if __name__ does work with ansible modules 8 years ago
Michael Vogt e360582c4a add apt unittest 8 years ago
Michael Vogt 80d520dde8 Allow foo=1.0* like expressions in apt 8 years ago
Robert Estelle 4e2d05b1f3 Remove incorrect executable permissions. 8 years ago
Adam Miller c707107e1b fix gce_net add firewall rule example 8 years ago
John Batty dd78dde449 Fix get_flavor_id() when flavor_ram is specified
Without this fix, _get_flavor_id() fails to find a matching flavor if
both:
* the flavor_ram parameter is specified
* the first flavor in the list does not match.

The bug is simply that the module.fail_json() call lies within the loop
iterating through the flavors.  This call should only be made if the
loop completes and no matching flavors have been found.
8 years ago
Brian Coca 5d16410518 corrected comparisson which had accidentally chaned in previous fixes 8 years ago
Brian Coca 9de01b8e10 better handling of deprecated aliases 8 years ago
Brian Coca f91859c817 make sure 'present' is fully equivalente of 'installed' and remove installed from feedback in favoer of 'present' 8 years ago
James Martin dd46f7275f asg will now be terminated if state=absent.
adds mutually exclusive options
8 years ago
James Cammarata e9fbb5f1b6 Serialize tag attributes to ASG properties in ec2_asg
Fixes #108
8 years ago
James Martin f59a1348ad Removes orphaned code. 8 years ago
James Martin 17cd9d18b0 fixes #240, #274, #108 8 years ago
Brian Coca ba040784b8 let implied type do the spliting 8 years ago
Brian Coca 7d577e4447 minor fixes to wait_for to avoid tracebacks as per ansible core issue #9244 8 years ago
Jeff Geerling 5d103793ee Add mention of fetch module to the copy module docs. 8 years ago
Brian Coca c071d6a85c switched to iterator as per comments 8 years ago
James Cammarata a32a50568e Use new prompt detection in run_command to detect aptitude prompts
Also adds flags to aptitude command when force=yes is used, in order
to bypass the prompts given for untrusted packages.

Fixes #31
8 years ago
Martijn P. Rijkeboer fcf527557d Fix whitespace around '=' in sysctl.conf. 8 years ago
José Moreira 82450c6811 Fixed small typo on ec2 task name 8 years ago
Francois Deppierraz 9620346c36 Fix a typo in nova_compute documentation string
Without this patch, ansible-doc was failing this way:

$ ansible-doc nova_compute
Traceback (most recent call last):
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 324, in <module>
    main()
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 316, in main
    text += get_man_text(doc)
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 112, in get_man_text
    desc = " ".join(opt['description'])
KeyError: 'description'
8 years ago
Brian Coca a91b5fc170 made hostname work with python 2.4 8 years ago
Fwiffo 64e07acb19 typo in comments: of -> or 8 years ago
Toshio Kuratomi 34d65647bf Move from md5 to sha1 to work on FIPS-140 enabled systems 8 years ago
Michael DeHaan 98fdc389d0 Deprecate docker_image, use the docker module to deploy docker images, or shell out to docker to call docker build if you want from a playbook. 8 years ago
Brian Coca a091d8c59a added missing init.py for utilities modules 8 years ago
Brian Coca 5a467bc72c added __init__.py to new cloud subcategories so builds work again 8 years ago
Michael DeHaan d31ac79269 Move internal category to utilities to remove one more category from the left hand menu, keeping it concise. 8 years ago
Michael DeHaan 677ed39cb4 Renames. 8 years ago
Michael DeHaan 5d814d9fb2 Some more module categorization. 8 years ago
Brian Coca 32e85c0944 made subcategories for cloud modules for better organization 8 years ago
James Cammarata bb9433f198 Fail in ec2 if exact_count is specified without using count_tag
Fixes ansible/ansible#9431
8 years ago
Toshio Kuratomi dfd4433fba Fix git module handling of the recursive flag
Fixes: #169
8 years ago
Toshio Kuratomi 5fc463eee7 Update desctiprion, parameter name, and default value as discussed in #55 8 years ago
Lorin Hochstein 5c06bb6dca ec2_snapshot: document wait, wait_timeout params
Document the wait and wait_timeout params for ec2_snapshot.

This is important because snapshots can take a long time to complete,
and the module defaults to wait=yes.
8 years ago
Ashish Ranjan 57ce7b1ea1 fields in /proc/net/tcp* are not always delimited by single space 8 years ago
Adam Chainz dddc5ffd2c Update syntax for cloudformation example 8 years ago
Jaanus Torp 7be83dc844 Fixed really annoying omission in the example without the task would complete without errors or warnings but delete all egress rules 8 years ago
Toshio Kuratomi 1429507489 Fix for systemd service scripts with newlines
Fixes #127
8 years ago
CptLausebaer a572f85d43 correct requirement of parameter dest
The parameter "dest:" is required, but it is documented as "required: false".
8 years ago
Toshio Kuratomi bcc058249c Use original_basename to set the dest path even if src is not set 8 years ago
Tim Gerla 26698246c3 Fix a typo of a function call 8 years ago
Richard Glew dac24deeb4 Fixed bug #193 where parameter name was set incorrectly 8 years ago
Jorge Bastida d82bfcb75f Initialize create_changed and replace_changed 8 years ago
Sapan Bhatia d492544714 Added user, tenant and password to module parameters declaration -- these parameters are already handled by the implementation 8 years ago
Ted Timmons 6e900744f2 fix spelling 8 years ago
James Cammarata dd2807ef3c Strip newlines off k=v pairs in command/shell argument parsing
Fixes ansible/ansible#9272
8 years ago
Lorin Hochstein 06218fe7d2 apt_key: add keyserver example to docs 8 years ago
Jon Hadfield f63ad7894e Remove redundant check for creates argument. 8 years ago
Tadej Janež 9a845a03f4 Simplified condition in a stat module example testing if path is a directory. 8 years ago
James Cammarata 429ab56e14 Adding file doc fragment to those modules in files/ missing it 8 years ago
Joe Adams 6eda3cbee7 Added note to files/synchronize module about synchronizing two directories on the same host 8 years ago
Tongliang Liu 59477d2e9a Added support of returning owner's group name in stat module 8 years ago
anatoly techtonik 90091b1277 files.stat: Expose path in returned result
This is needed to apply subsequent operation on tested path
8 years ago
Matt Martz cce5b600c0 Don't count DELETED servers when adding new servers 8 years ago
Matt Martz 6a6faeb506 Fix determination if a few configurations change in the launch config 8 years ago
Matt Martz e905162571 Ensure that files is the right type, and that we send the formatted personality var 8 years ago
Matt Martz 591ba934c3 Support config_drive and user_data in rax_scaling_group 8 years ago
Eric Hanchrow e4ac716663 Tweak docs to mention `replace` 8 years ago
Major Hayden e3449b6691 Updating SELinux example doc in lininefile module
Encouraging users to use this Ansible module to enable SELinux seems
like a better idea. It also warms Dan Walsh's heart.

Signed-off-by: Major Hayden <major@mhtx.net>
8 years ago
Chad Nelson 20706f5f4d Chnge option name to track_submodule_branches.
Update documentation to reflect what the actual effect of the option.
8 years ago
Chad Nelson 5f30157a05 Give option on how git tracks submodules.
Allows user to decide if git submodule should track branches/tags or track commit hashes defined in the superproject.

Add track_branches parameter to the git module.

Defaults to track branches behavior.
8 years ago
Michael DeHaan 11b0ce5c32 Update README.md 8 years ago
Michael DeHaan c7e9139a1b Fix filename error. 8 years ago
Michael DeHaan ef2a2b9093 package files 8 years ago
Michael DeHaan 213e518165 file extensions! 8 years ago
Michael DeHaan c7eec45b73 Restructuring. 8 years ago
Michael DeHaan 87a9034751 Core/extras split WIP. 8 years ago
Michael DeHaan e5b3cb3b02 Core/Extras splitting WIP. 8 years ago
Michael DeHaan b2bf4b9bf7 Not core. 8 years ago
Michael DeHaan 42ab1eab36 Fix typo in README filename 8 years ago
James Cammarata cd42f73662 Moving snapshot of modules back from core 8 years ago
James Cammarata 9c67f6dcdc removed core and extras submodules 8 years ago
James Cammarata 1a4484be61 Submodule ref update 8 years ago
Toshio Kuratomi 36f29148a3 Update submodule refs 8 years ago
Matt Clay 6611845716 Update submodule refs. 8 years ago
Peter Sprygada dc23667cc2 add back reverted change to network_cli (#18761)
This adds back the change to the network_cli plugin.  Ths change adds
the ensure_connect decorator to the open_shell() method to make sure
the connection is valid before trying to open a shell.

The issue was due to the addition of the decorator that will call
_connect() when there is no connection.  The _connect() method should
have been mocked in the test case.  This commit fixes the test
case as well

Change was originally reverted in c414ded69a
8 years ago
Toshio Kuratomi 117b88cd38 smart quotes, die die die. 8 years ago
Toshio Kuratomi 9f94414095 Fix indentation 8 years ago
Toshio Kuratomi 32ffa87732 Add docstring explaining whatw Attribute does 8 years ago
Toshio Kuratomi 868b20d982 Document the get_config function 8 years ago
Ondra Machacek f1812b0f15 module_utils: ovirt: Add support to fetch nested object's attributes (#18666)
* module_utils: ovirt: Add support to fetch nested object's attributes

This patch fixes issue #3555

* Update documentation
8 years ago
Toshio Kuratomi c414ded69a Revert "minor updates to network_cli connection plugin (#18742)"
This reverts commit 8e375913b0.

This breaks testing as the PlayContext is not mocked out for the test.
Temporarily reverting.
8 years ago
Toshio Kuratomi 5f5ea06ca4 make hash_params more robust in the face of many corner cases (#18701)
* make hash_params more robust in the face of many corner cases

Fixes #18680
Alternative fix to #18681

* add test case for role.hash_params

* Add role.hash_params test for more types

A set, a generator/iterable, and a Container that
is not Iterable.
8 years ago
Peter Sprygada 8e375913b0 minor updates to network_cli connection plugin (#18742)
* removes superfluous timeout kwargs from open_shell()
* cleans up play_context become check
* adds check for ssh session and calls _connect() if needed
8 years ago
Ruslan Tumarkin 9d8fc7afce Fux bug 18584 (#18718) 8 years ago
Matthew Krupcale cb4153c285 FreeIPA module polymorphic restructuring, Python 3 support, and small fixes. (#18542)
* Moved JSON-RPC client IPAClient class to ansible.module_utils.ipa, which is extended by all ipa modules
* IPAClient: Changed to 2-clause BSD license
* IPAClient (lines 37-39): Added some additional imports for use with Python 3
* IPAClient (line 41): Explicitly extend Python base object
* IPAClient (line 57): Properly URL quoted the username/password form data as per https://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.1
* IPAClient (line 62): Data should be bytes or bytearray in Python 3 (still str in Python 2)
* IPAClient (line 65): Print error message, not returned body
* IPAClient (line 70): getheader() is not present in Python 3 version of HTTPMessage; get() is present in both Python 2/3
* IPAClient (line 88): Convert form data to bytes for Python 3 again
* IPAClient (line 91): Print error message, not returned body
* IPAClient (line 96-104): json.loads() requires a string; HTTPResponse.read() returns bytes in Python 3 and str in Python 2, so decode the bytes/string using the HTTPResponse returned charset (default to 'latin-1')
* Add author/copyright notice
8 years ago
Peter Sprygada 8e562018ed adds py3 compat changes to network_cli plugin (#18735)
now calculates StringIO receive buffer and if received data is less than
buffer size, resets offset to 0
8 years ago
Dag Wieers b52159163b Add RHEV host detection support (#17177)
* Add RHEV host detection support

This adds RHEV host detection support based on a running 'vdsm' process and the existence of _/rhev/_ (which are both part of the vdsm RPM package in a RHEV installation). Without this change, a RHEV host would be reported as a kvm host (which is also true, but often not specific enough).

This closes #17058

* Only scan the process list when we determined /rhev/ exists

Small performance improvement, so we do not have to scan the process list if /rhev/ does not exist.
8 years ago
gl0bus d5eff47fcc Extend OpenStack related hypervisor detection (#15166)
* fixed detection of ansible_virtualization_(role|path) facts for VM's running in
OpenStack Instances

* NOTE: this will break detection of ansible_virtualization_(role|path) facts
        if you are using Openstack Instaces with nested virtualization

* fixed detection of ansible_virtualization_(role|path) facts for VM's running in
OpenStack Instances

Fixes #15165

* NOTE: this will break detection of ansible_virtualization_(role|path) facts
        if you are using Openstack Instaces with nested virtualization
8 years ago
Michael Scherer 435dfc2b9c Add a bit more information for network facts on BSD
This was tested on FreeBSD 11, NetBSD 7 and OpenBSD 6.0
This currently detect ether, loopback and tunnel.
8 years ago
Yann Autissier c048198567 fix setup module on Fedora Core 5 (#17175)
setup module fails with AttributeError: 'module' object has no attribute
'selinux_getpolicytype' in get_selinux_facts on Fedora Core 5
8 years ago
Jesse Keating 8e38f7475f Do not set docker use to None. (#18706)
The user variable defaults to None, and was being passed in as a user
named None. This was breaking rsync unless a specific user was set.

Fixes 16306
8 years ago
Chris Houseknecht 599e016315 For container enabled role, display warning only when not ANSIBLE_CONTAINER (#18717) 8 years ago
Toshio Kuratomi 8c03fec67a Remove method that isn't used here. (#18713)
We have two copies of this function and only the one in cli is used.
8 years ago
Toshio Kuratomi 74a10d7ca2 Transform vault_pass into text when we read it in from the user or a file. (#18699)
Fixes #18684
8 years ago
Toshio Kuratomi 0d9afa84d5 ssh-keyscan can fail to find keys for a host.
When it does, we need to fail otherwise other code will fail later.

Fixes #18676
8 years ago
Benoît Allard 56dcf2cc04 with_sequence: pass AnsibleError through
The parsing methods try as hard as possible to generate meaningful error messages that are all ignored and immediately overwritten by a new AnsibleError instance. Better use the original one instead.
8 years ago
Benoît Allard 7db4ed02ee with_sequence: Fix indentation
This doesn't need to run for every parameters. Once is enough.
8 years ago
Alberto Murillo 7542dae26b Fix fetching files with scp (#18673)
Commit ec2521f intended to fix the scp command to fetch files
from a remote machine but it has src and dest swapped.

This change correctly treats src as the location in the remote machine
and dest as the location in the local machine.

Signed-off-by: Alberto Murillo Silva <alberto.murillo.silva@intel.com>
8 years ago
Peter Sprygada 8137c7207d adds feature to try to auto determine network_os (#18674)
This updates the network_cli connection plugin to attempt to automatically
determine the remote device os.  The device network os discovery can
be overridden by setting the ansible_network_os value.
8 years ago
Peter Sprygada 6fe9a5e40c functional updates to ansible-connection (#18574)
* sends the serialized play_context into an already established connection
* hooks the alarm_handler() method in the connection plugin if it exists
* added configuration options for connect interval and retries
* adds syslog logging to Server() instance

This update will send the updated play_context back into an already
established connection in case privilege escalation / descalation activities
need to be performed.  This change will also hook the alarm_handler() method
in the connection instance (if available) and call it in case of a
sigalarm raised.

This update adds two new configuration options

* PERSISTENT_CONNECT_INTERVAL - time to wait in between connection attempts
* PERSISTENT_CONNECT_RETRIES - max number of retries
8 years ago
Yannig 900b3ffcba Implement docker support for synchronize module. (#18145)
* Implement docker support for synchronize module.

Note : you need rsync installation on your docker container.
Have a look at https://github.com/ansible/ansible/issues/16306 for more details.
Support Ansible options for remote access.

* Give user name to docker command.
8 years ago
Matt Davis d95eac16eb bump submodule refs 8 years ago
Brian Coca 461dcf8ce3 log on target based on nolog, not verbosity (#18570)
* log on target based on nolog, not verbosity

fies #18569

* initialize module name

removing verbosity exposed missing name at certain stages, initialize to file name
and update later once module args are parsed
8 years ago
Virgil Dupras bf48383610 Fix regression in jinja2 include search path (#18617)
* Fix regression in jinja2 include search path

Since commit 3c39bb5, the 'ansible_search_path' variable is used to set
jinja2's search path for {% include %} directives. However, this path is
the the proper one because our templates live in 'templates' subdirs in
our search path.

This is a regression because previously, our include search path would
include the dirname of the currently interpreted file, which worked most
of the time.

fixes #18526

* Fix template lookup search path

Improve fix in commit c96c853 so that the search path contain both
template-suffixed paths as well as original paths.

ref PR #18617

* Add integration test for template lookups

Tests regression at #18526

This test fails on current devel branch and succeeds on PR #18617
8 years ago
James Cammarata 786ac0ea3d Submodule update 8 years ago
Brian Coca ca1514cf2a unified boolean function
optimized boolean function
fixes #17815
8 years ago
Adrian Likins 83676e9b40 Fix 'cancled' misspelling in --step debug 8 years ago
Toshio Kuratomi 3c6d71522e Fix for AnsiballZ when the remote clock is behind (#18660)
Some machines have system clocks which can fall behind (for instance,
a host without a CMOS battery like Raspberry Pi).  When managing those
machines we have to workaround the fact that the zip format does not
handle file timestamps before 1980.  The workaround is to substitute in
the timestamp from the controller instead of from the managed machine.

Fixes #18640
8 years ago
Daniel Miranda 57f4a9885e Make sure include_role inherit variables from parent role (#18627)
* Make sure include_role inherit variables from parent role

Setting the parent of task blocks generated by include_role after they
have been produced is not sufficient - it means the tasks don't have the
correct dependency chain set afterwards, and therefore, don't properly
inherit variables from outer roles.

In addition to manually setting the parents, pass the dep_chain when
compiling the role, such that variables are correctly imported.

Fixes #18540.

* Add tests for include_role

* Fix include_role variable inheritance for multiple parent levels
8 years ago
Matt Clay 00f8945159 Update submodule refs. 8 years ago
Adrian Likins dbbd2d79ff Fix traceback in atomic_move (#18649)
Commit 8b08a28c89 removed a
call to get_exception() that was needed. Without it, the fail_json
references an undefined variable ('exception') and throws an exception.

Add the get_exception() back in where needed and update references.

Now the proper module failure is returned.

Fixes #18628
8 years ago
Matt Clay 6169d2d49f Update submodule refs. 8 years ago
John R Barker 02842767c6 Remove duplicated 'timeout' doc (#18657) 8 years ago
Peter Sprygada 9aa8547016 adds two new plugins that use ansible-connection for persistence (#18572)
* adds new connection plugin `network_cli` which builds on paramiko
* adds new plugin `terminal` used for manipulating network_cli terminals
* adds new field to play_context `network_os` settable as ansible_network_os

This commit adds the plugins necesary to establish a persistent cli connection
to network devices of ssh.  It builds on the paramiko connection plugin
to create a shell environment that will persistent through ansible-connection.
The `newtork_cli` plugin then uses the network_os in the instance of
PlayContext to load the appropriate network OS environment plugin for
handling opening and closing of shells as well as privilege escalation.
8 years ago
Peter Sprygada 7df5a0abd0 adds config option to auto add keys when using paramiko (#18598)
* updates paramiko_ssh to auto add keys
* updates constants with new config options

This commit adds a new feature that will allow paramiko to automatically
accept and save a host ssh key.  This feature is controlled by the
`host_key_auto_add` config setting in the paramiko section.  The default
is False to maintain current functionality.  It also includes a new
setting `look_for_keys` with the default to False for maintaining current the
current setting.
8 years ago
Peter Sprygada a87d30f72f fixes exception raised when extracting timeout value from ModuleStub in eapi (#18651) 8 years ago
Peter Sprygada 9cb0e771d2 expose timeout param to socket (#18632)
The timeout param was exposed to the socket connection but was not
enforced for commands.  This update will now cause a command to timeout
based on the module parameter.
8 years ago
Peter Sprygada 69fb310878 updates the network shared docs to include the timeout parameter (#18635)
The network shared doc fragment was missing the timeout parameter from
the docstring.  This commit adds the timeout parameter back to the
doc fragment
8 years ago
Peter Sprygada a757a77159 fixes timeout param in netconf provider for junos (#18634)
This change will now cause the netconf provider to honor the module
timeout value when making calls to pyez.
8 years ago
Peter Sprygada eec6980f3e pass module timeout value to fetch_url in eapi connection (#18633)
This change causes the eapi connection to honor the module timeout
value when calling fetch_url
8 years ago
Alberto Murillo ec2521f6af Fix ssh plugin to correctly fetch files when using scp (#18614)
Fetch module uses fetch_file() from plugin/connection/ssh.py to
retrieve files from the remote hosts which in turns uses
_file_transport_command(self, in_path, out_path, sftp_action) being
sftp_action = 'get'

When using scp rather than sftp, sftp_action variable is not used
and the scp command is formed in a way that the file is always
sent to the remote machine

This patch fixes _file_transport_command() to correctly form the scp
swaping src and dest if sftp_action is 'get'

Bug introduced at 8e47b9b
Fixes #18603

Signed-off-by: Alberto Murillo Silva <alberto.murillo.silva@intel.com>
8 years ago
Matt Clay 43714f859a Update submodule refs. 8 years ago
Ondra Machacek b606078d69 Add param method to oVirt helper module (#18605)
This patch add new param method to fetch parameters
from the Ansible module, so modules don't have to use
the long name `self._module.params.get()`.
8 years ago
Brian Coca fbe5878919 only access match if we actually match fact
fixes #18601
8 years ago
Brian Coca 778c983ef9 ansible_playbook_python (#18530)
* ansible_playbook_python

fixes #18471

* fix tests

* removed dupe
8 years ago
James Cammarata 4859e0a419 Look for _get_parent_attribute method in both src and dst dict
When determining which getter style to use for the object in question,
the BaseMeta class should look at both dict's to try and locate the method.

Fixes #18522
8 years ago
Brian Coca 4a325b5ea2 fixed issue with when/with error deferment
now it issues correct error (loop) when conditional depends on loop
compliment fixes #16222
8 years ago
Eric Chou 9d0b8c8545 modified POST body in axapi_authenticate_v3() and axapi_call_v3() (#18104) 8 years ago
Toshio Kuratomi 03dd186c63 Update submodule refs 8 years ago
Matt Clay d61b2ed0a3 Support script interpreters for async_wrapper. (#18592) 8 years ago
Matt Clay 387fca28ab Update submodule refs. 8 years ago
Brian Coca a715d03a83 dont fail on missing service during check mode 8 years ago
Toshio Kuratomi 255a5b5d75 Fix the Solaris POSIX acl fix
For setfacl on Solaris we need to specify permissions like r-x.
For chmod, we need to specify them as rx (r-x means to make the file
readable and *not* executable)
8 years ago
fallencliff d5910ebdae update facts.py for solaris and hp-ux
for solaris,  add get_dmi_facts to get product_name fact, and update memtotal_mb to integer for consistency.

for hp-ux,  user machinfo to get product_serial fact
8 years ago
Toshio Kuratomi bacdbc5f27 Update submodule refs 8 years ago
koralsky 4e194d71bd import reduce from six label:python3 (#18561)
* import 'reduce' from six
* import reduce in facts fix
8 years ago
Michael Noseworthy bb5d8fb476 Fix unicode handling in fixup_perms2 errorhandling (#18565)
The _fixup_perms2 method checks to see if the user that is being sudo'd
is an unprivileged user or root. If it is an unprivileged user, some
checks are done to see if becoming this user would lock the ssh user out
of temp files, among other things. If this check fails, an error prints
telling the user to check the documentation for becoming an unprivileged
user.

On some systems, the stderr prints out the unprivileged user the ssh
user was trying to become contained in smartquotes. These quotes aren't
in the ASCII range, and so when we're trying to call `str.format()` to
combine the stderr message with the error text we get a
UnicodeEncodeError as python can't coerce the smartquotes using the
system default encoding. By calling `to_native()` on the error message
we can ensure that the error message is a native string for the
`Exception` handling, as `Exception` messages need to be native strings
to avoid errors (byte strings in python2, and text strings in python3)

Fixes: #18444
8 years ago
Nathaniel Case 8d0418f7c1 net_template doesn't need BOOLEANS
Note #17815
8 years ago
Nathaniel Case 3f4ac0b9f7 Fix for whitespace padding on JSON responses
Fixes #17825, closes #17829
8 years ago
James Cammarata 81aa12eb1b Rework how the Conditional class deals with undefined vars
Previously, the Conditional class did a simple check when an
AnsibleUndefinedVariable error was raised to see if certain strings were
present. This patch tries to be smarter by evaluating the variable contained
in the error string and compared to the defined/not defined conditionals in
the conditional string.

This also modifies the UndefinedError message from HostVars slightly to
match the format returned jinja2 in general, making it easier to match the
error message in the Conditional code.

Fixes #18514
8 years ago
Toshio Kuratomi d90638ad40 Fix setfacl for Solaris with POSIX acl support.
Tested on Linux and freebsd.

Fixes #17919
8 years ago
James Cammarata 7e2305f953 Cache dynamically included blocks for later lookup via uuid
Fixes #18357
8 years ago
James Cammarata 26ec2ecfce Adding a persistent connection utility 8 years ago
Toshio Kuratomi 0b96d61162 Convert playbook basedir into unicode at the borders 8 years ago
James Cammarata 8ee3ef587a Check for negative defined logic in conditionals 8 years ago
James Cammarata 0df3767d4d When iterating over hostvars yield the hostname not the host object
Also fixes HostVars to raise the correct jinja2 error type.

Fixes #16836
8 years ago
Peter Sprygada 69649358b1 fixes issue with setting the terminal length (pager) in vyos (#18546)
`set terminal length 0` actually sets `VYATTA_PAGER=cat`
`set terminal length [some number]` actually sets `stty length [some number]`
8 years ago
Brian Coca 6dece90a57 change to ~ instead of $HOME to avoid undefined (#18551)
fixes #16032
8 years ago
Andrea Tartaglia 62697ad77f Replaced iterkeys with 'for key in dict' for #18507 (#18538) 8 years ago
John R Barker d27e007fb1 Network docs fragments: fix copy paste errors (#18564) 8 years ago
René Moser 72f75fd9e0 cloudstack: add helpers to distinguish VMs not in VPC (#18560)
VMs in VPC and not in VPC can have an identical name. As a result VMs in a VPC must be sorted out if no VPC is given.
Due the API limitation, the only way is to check if the network of the VM is in a VPC.
8 years ago
Toshio Kuratomi 783a185f1c Update submodule ref for mount fixes 8 years ago
René Moser ff7051bab4 cloudstack: fix distinguish VPC and other networks (#18515) 8 years ago
James Cammarata a83b00bbc0 Properly sort groups by name as well as depth when getting vars
Fixes #17243
8 years ago
James Cammarata f36926f8d3 With role params also keep special params in the ds as well as params
With 2.0, we decided to create a special list of param names which were
taken out of the role data structure and stored as params instead (connection,
port, and remote_user). This causes problems with inheritance of these params,
so we are now deprecating that while also keeping those keys in the ds so they
are brought in as attributes on the Role correctly.

Fixes #17395
8 years ago
Toshio Kuratomi 5984e3ee9b Update submodule refs 8 years ago
Ben Cordero a9a2f12adb openstack: iterate through nova addresses with six (#18408) 8 years ago
jamessewell b91d4d884d Moved the _inventory.clear_group_dict_cache() from creating a group w… (#17766)
* Moved the _inventory.clear_group_dict_cache() from creating a group which doesn't exist, to adding members to the group.

* Update __init__.py

Update to use changed: block to catch all changes for cache clear as suggested
8 years ago
Matt Davis d78ec1e760 bump submodule refs 8 years ago
Andrew Haines 200d6bdb23 Default include_role results to empty list in linear strategy plugin
Fixes #18544.

When a loop is over an empty list, the result is set to

    {'skipped_reason': u'No items in the list', 'skipped': True, 'changed': False}

which means that accessing `hr._result['results']` throws a `KeyError`.
8 years ago
Brian Coca aff5d9160a disable 'dense' callback in py26 8 years ago
James Cammarata 937d872f4b Return failed instead of raising an error when an include_vars file is missing
Fixes #18508
8 years ago
Dag Wieers b7425b59ee Adapt callback functions to changes in 13f3cbaf3b 8 years ago
Dag Wieers 0036108c59 Implement destructor to ensure newline and terminal attributes
Also fixed a typo
8 years ago
Dag Wieers 2a8914e496 Reset VT100 attributes in case we get unexpected output 8 years ago
Dag Wieers cd6f577d91 Rename ansi to the more correct name vt100 8 years ago
Dag Wieers 893dc81b5e Implement our own detailed task output
Also:
- Streamline ANSI calls
- Implement v2_playbook_on_include
8 years ago
Dag Wieers 221a4e7014 Ensure we end with a newline in normal mode 8 years ago
Dag Wieers 7148023f59 Small fix so diff output starts on a new line 8 years ago
Dag Wieers 9a507b1f07 Don't try to be smart with cmd output ! 8 years ago
Dag Wieers 84e0420389 Make everything work magically !
- Support item-loops correctly
- Support notification handlers
8 years ago
Dag Wieers 589953c79b Assorted improvements
- Better switch between *dense* and *default*
- Reimplement C.COLOR* out of necessity (help!)
- Make verbose output more dense (clean up result)
- Implement our own dumper
- Improve delegation support
8 years ago
Dag Wieers 223c0011e0 Assorted fixes
- Implement delegate support
- Implement preliminary handler support
- Implement our own recap/summary (still fails)
8 years ago
Dag Wieers 1bf7e22756 Implement support for itemized tasks 8 years ago
Dag Wieers 14cfb2b230 Preliminary support for items, WIP 8 years ago
Dag Wieers 67c57a9b6b Improve readability 8 years ago
Dag Wieers 326bb24a89 Various improvements, now supports different verbosity levels 8 years ago
Dag Wieers fe6e4f8286 New "dense" callback plugin
The goal for the "dense" output is to only show changes and failures on-screen (the Unix-way).
However, since we still want to have a sense of progress, we use terminal capabilities to display progress.

 - On screen there should only be relevant stuff
    - How far are we ? (during run, last line)
    - What issues occured
    - What changes occured
    - Diff output

 - If verbosity increases, act as default output
   So that users can easily switch to default for troubleshooting

 - Leave previous task output on screen
   - If we would clear the line at the start of a task, there would often
     be no information at all
   - We use the cursor to indicate where in the task we are.
     Output after the prompt is the output of the previous task
   - Use the same color-conventions of Ansible

This is still a work in progress.
It was released to give a glimpse of what would be possible.

The Ansible callback mechanism currently does not have all the functionality we need to do this efficiently.
8 years ago
Brano Zarnovican 96ddd29c7e random filter: added optional 'seed' parameter
implements #15621
8 years ago
Toshio Kuratomi ed00741a01 Mcsalgado's change to use shlex.quote instead of pipes.quote (#18534)
* Replace pipes.quote for shlex_quote

* More migration of pipes.quote to shlex_quote

Note that we cannot yet move module code over.  Modules have six-1.4
bundled which does not have shlex_quote.  This shouldn't be a problem as
the function is still importable from pipes.quote.  It's just that this
has become an implementation detail that makes us want to import from
shlex instead.

Once we get rid of the python2.4 dependency we can update to a newer
version of bundled six module-side and then we're free to use
shlex_quote everywhere.
8 years ago
Brian Coca 5d043b65d3 fix for filter fix 8 years ago
Brian Coca 7c960d440f remove rsync path from returned facts 8 years ago
James Cammarata f7fe6dc19c Don't fail on missing vars files for delegated hosts
Fixes #17965
8 years ago
Dag Wieers 1ca4add91c Performance improvement using in-operator on dicts
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
8 years ago
Brian Coca bb41a005b3 updated to add tailing msg to missing error 8 years ago
Brian Coca 5129e2fe16 added fail_if_missing shared service function 8 years ago
Adrian Likins c09060e8ff Fix 'ansible-vault edit' crash on changed nonascii
ansible-vault edit was attempting to decode the file contents
and failing.

Fixes #18428
8 years ago
James Cammarata ca5b361ad8 Reworking iterator logic regarding failed states during always
Previous changes addressed a corner case, which unfortunately introduced
another bug. This patch adds a new flag to the host state (did_rescue) which
is set to true when the rescue portion of a block completes. This flag is
then checked in _check_failed_state() when the fail_state != FAILED_NONE.

This lead to the discovery of another bug - current strategies are not advancing
hosts to ITERATING_COMPLETE after doing a peek at the next task, leaving the
host state in the run_state of the final task. To address this, before gathering
the list of failed hosts in StrategyBase.run(), a final pass through the iterator
for all hosts is done to ensure each host is in its final state. This way, no
strategy derived from StrategyBase has to worry about it and it's handled.

Fixes #17983
8 years ago
Brian Coca afaec3da82 corrected service filtered option to singular 8 years ago
Gael Pasgrimaud f94100aa87 make default strategy configurable (#18394) 8 years ago
Brian Coca bd70397e24 always template when called from template (#18490)
* Have template action plugin call do_template

Avoids all the magic done for 'inline templating' for ansible plays.
renamed _do_template to do_template in templar to make externally accessible.
fixes #18192

* added backwards compat as per feedback
8 years ago
James Cammarata fcb033b9e4 Add `name` field for Blocks
Fixes #18420
8 years ago
James Cammarata 57cf5e431c Catch loop eval errors and only raise them again if the task is not skipped
This should help on issues like #16222.
8 years ago
Matt Clay 4981feee99 Update submodule refs. 8 years ago
Brian Coca c005ae3cd9 removed package from squash actions
fixes https://github.com/ansible/ansible-modules-core/issues/5595
8 years ago
James Cammarata 435ca620b2 Add option to prepend inherited attributes when extending values
Fixes #18483
8 years ago
Brian Coca 11465134fa added alias to argumetns 'args' to blacklist (#18485)
this should fix https://github.com/ansible/ansible-modules-core/issues/5584
8 years ago
Brian Coca f4391d34e4 added alias to argumetns 'args' to blacklist
this should fix https://github.com/ansible/ansible-modules-core/issues/5584
8 years ago
Adrian Likins 0690a67926 Include missing _text.to_text import
Fixes "global name 'to_text' is not defined" error on
openbsd clients.

Fixes #18473
8 years ago
René Moser b08ef44da0 cloudstack: extend support for VPC (#18434) 8 years ago
Chris Church 534bd12ae9 Increment changed stat for a failed task if changed. (#18014) 8 years ago
James Cammarata 4f06a86161 Alternately track listening handlers by uuid if no name is set
Fixes #17846
8 years ago
Trond Hindenes 8874c1dc39 Improved Get-PendingRebootStatus 8 years ago
Matt Davis 39dcafe23f bump submodule refs 8 years ago
Brian Coca 3fd03b764b removed core import template 8 years ago
James Cammarata 5b87951d6c Don't copy the parent block of TaskIncludes when loading statically
When loading an include statically, we previously were simply doing a
copy() of the TaskInclude object, which recurses up the parents creating
a new lineage of objects. This caused problems when used inside load_list_of_blocks
as the new parent Block of the new TaskInclude was not actually in the list
of blocks being operated on. In most circumstances, this did not cause a
problem as the new parent block was a proper copy, however when used in
combination with PlaybookInclude (which copies conditionals to the list of
blocks loaded) this untracked parent was not being properly updated, leading
to tasks being run improperly.

Fixes #18206
8 years ago
René Moser 80af461178 cloudstack: add additional CLOUDSTACK_VPC env var (#18467) 8 years ago
Brian Coca c880c1a78d added sysv functions 8 years ago
Matt Clay 2ab2e709b0 Update submodule refs. 8 years ago
Adrian Likins 51e3ef89a9 Add error info if tabs are found in the yaml (#18343)
If a yaml file fails to load because of tabs being used
for formatting, detect that and show a error message
with more details.
8 years ago
Ievgen Khmelenko 619f2fd210 ansible-logstash-callback (#18282)
* ansible-logstash-callback

* GPL v3 license preamble, ImportError

* Update logstash.py
8 years ago
James Tanner 20fb74b1b1 ini lookup: add 'default' to the list of parsed keys
Fixes #18369
8 years ago
Brian Coca 5dd195b52f restore play_hosts variables to not show removed
Also adds ansible_play_hosts_all with original list of hosts the play targeted
8 years ago
James Cammarata 4794b5da45 Merge class dict with parent dict when creating meta attributes
In some situations, where the Base class defines an Attribute, the
BaseMeta class doesn't properly see the _get_parent_attribute or
_get_attr_<whatever> methods because of multiple layers of subclasses
(ie. Handler, which subclasses Task). This addresses that by merging
the __dict__ of the parent with the current classes __dict__ meaning
all future iterations see available special methods.

Fixes #18378
8 years ago
Matt Clay 8c270ac75f Add empty-init code-smell script. (#18406)
Also removed boilerplate from otherwise empty __init__.py files
which should not contain any code (checked by empty-init script).
8 years ago
Toshio Kuratomi 6a3893c518 Remove direct calls to print and cleanup imports
All display of information should go through display instead of through print.
8 years ago
Brian Coca a0f27d552c File attributes (#18213)
* added attributes to base file params

* dont change attributes when none

* fixed test to deal with new attributes
8 years ago
Brian Coca 7a33c14782 added 'friendly' name to fact gathering
fixes #18198
8 years ago
Michael Scherer 37de9031c6 Detect virtualisation on netbsd (#18381)
* Refactor OpenBSD sysctl based detection in a separate class

The idea is later to reuse this code for NetBSD and FreeBSD, who
use a different sysctl key for vendor and product.

* Add detection of virtualisation on NetBSD

* Add support to detect running as a Xen guest

tested on NetBSD 7 on Rackspace.
8 years ago
Michael Scherer ccecbdd78d Add DMI facts on NetBSD and refactor code (#18388)
* Add support for OpenBSD dmi fact gathering

* Refactor get_sysctl in the Hardware class

Due to difference between Darwin/NetBSD and OpenBSD, we
have to change the regexp used split the key/value

* Add support for dmi facts on NetBSD
8 years ago
Toshio Kuratomi ee14e0cc2a Text's .translate() is easier to use than bytes
Text strings and byte strings both have a translate method but the byte
string version is harder to use.  It requires a mapping of all 256 bytes
to a translation value.  Text strings only require a mapping from the
characters that are changing to the new string.  Switching to text
strings on both py2 and py3 allows us to state what we're getting rid of
simply without having to rely on the maketrans() helper function.
8 years ago
Michael Scherer fd44917561 Remove duplicate declaration of human_to_bytes
This is already declared in basic.py, in a more complete way.
8 years ago
Michael Scherer 150ea49d8a Add tunnel linux (#18118)
* Refactor the type selection of network device under linux

* Add the tunnel type to the type of net interface under Linux
8 years ago
Michael Scherer df145df962 Make facts detection work on OpenBSD with Python3
The traceback is the following:

    Traceback (most recent call last):
      File \"/tmp/ansible_8s0bj604/ansible_module_setup.py\", line 134, in <module>
        main()
      File \"/tmp/ansible_8s0bj604/ansible_module_setup.py\", line 126, in main
        data = get_all_facts(module)
      File \"/tmp/ansible_8s0bj604/ansible_modlib.zip/ansible/module_utils/facts.py\", line 3641, in get_all_facts
      File \"/tmp/ansible_8s0bj604/ansible_modlib.zip/ansible/module_utils/facts.py\", line 3584, in ansible_facts
      File \"/tmp/ansible_8s0bj604/ansible_modlib.zip/ansible/module_utils/facts.py\", line 1600, in populate
      File \"/tmp/ansible_8s0bj604/ansible_modlib.zip/ansible/module_utils/facts.py\", line 1649, in get_memory_facts
    TypeError: translate() takes exactly one argument (2 given)

And the swapctl output is this:

    # /sbin/swapctl -sk
    total: 83090 1K-blocks allocated, 0 used, 83090 available

The only use of the code is to remove prefix in case they are present, so just
replacing them with empty space is sufficient.
8 years ago
Michael Scherer bd6ac784bb Add support for KVM in the Solaris virt detection
smbios -i 256 return:

    # smbios -i 256
    ID    SIZE TYPE
    256   77   SMB_TYPE_SYSTEM (system information)

      Manufacturer: Red Hat
      Product: KVM
      Version: RHEL 6.4.0 PC

      UUID: 8a3b8b1a-ba59-1a4b-5f85-ab53a5a885a9
      Wake-Up Event: 0x6 (power switch)
      SKU Number:
      Family: Red Hat Enterprise Linux
8 years ago
Michael Scherer 12354869b9 Add xen guest detection on FreeBSD 8 years ago
Michael Scherer bc6c1afb1e Fix media_type detection on NetBSD
On NetBSD 7.0.1, ifconfig return this:
    $ ifconfig
    ne0: flags=8863<UP,BROADCAST,NOTRAILERS,RUNNING,SIMPLEX,MULTICAST> mtu 1500
            ec_capabilities=1<VLAN_MTU>
            ec_enabled=0
            address: 00:20:91:45:00:78
            media: Ethernet 10baseT full-duplex
            inet 192.168.156.29 netmask 0xffffff00 broadcast 192.168.156.255

Which result into setup returning this:
    "media_type": "ull-duplex",

So we have to specialise that method, since FreeBSD ifconfig return
something like this:

    ue0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=80009<RXCSUM,VLAN_MTU,LINKSTATE>
        ether 00:20:91:a7:48:45
        inet 192.168.156.11 netmask 0xffffff00 broadcast 192.168.156.255
        media: Ethernet autoselect (100baseTX <full-duplex>)
        status: active
        nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
8 years ago
Michael Scherer d393409fed Fix type detection on OpenSolaris for loopback interface
Extract of ifconfig output:

    # ifconfig  -a
    lo0: flags=2001000849<UP,LOOPBACK,RUNNING,MULTICAST,IPv4,VIRTUAL> mtu 8232 index 1
            inet 127.0.0.1 netmask ff000000
    rtls0: flags=1004843<UP,BROADCAST,RUNNING,MULTICAST,DHCP,IPv4> mtu 1500 index 3
            inet 192.168.125.125 netmask ffffff00 broadcast 192.168.125.255
            ether 0:20:91:83:45:82
8 years ago
Adrian Likins dd0189839e Fix bug (#18355) where encrypted inventories fail 18355 (#18373)
* Fix bug (#18355) where encrypted inventories fail

This is first part of fix for #18355
* Make DataLoader._get_file_contents return bytes

The issue #18355 is caused by a change to inventory to
stop using _get_file_contents so that it can handle text
encoding itself to better protect against harmless text
encoding errors in ini files (invalid unicode text in
comment fields).

So this makes _get_file_contents return bytes so it and other
callers can handle the to_text().

The data returned by _get_file_contents() is now a bytes object
instead of a text object. The callers of _get_file_contents() have
been updated to call to_text() themselves on the results.

Previously, the ini parser attempted to work around
ini files that potentially include non-vailid unicode
in comment lines. To do this, it stopped using
DataLoader._get_file_contents() which does the decryption of
files if vault encrypted. It didn't use that because _get_file_contents
previously did to_text() on the read data itself.

_get_file_contents() returns a bytestring now, so ini.py
can call it and still special case ini file comments when
converting to_text(). That also means encrypted inventory files
are decrypted first.

Fixes #18355
8 years ago
Michael Scherer 5aaf1d1a15 On python 3.5, sys.subversion have been removed
So to get the type of the python interpreter, we need to look at
sys.implementation.name which do not return 'cpython', instead of 'CPython',
but that's upstream breakage, so not much we can do.
8 years ago
Brian Coca bec9ebbf30 added docs for new arg 8 years ago
Brian Coca 8217c1c39c resolve inventory path on init
This allows meta refresh_inventory to work with relative paths
Added option to unfrackpath to not resolv symlinks
fixes #16857
8 years ago
Toshio Kuratomi ed134d81f1 Limit how much of the file we read to test if it's an encrypted vault file
Fixes memory errors reported in #16391
8 years ago
Michael Scherer 57b8acccec Add support for network alias on NetBSD
While testing on netbsd 6.0, ansible setup failed with:

    Traceback (most recent call last):
      File \"/tmp/ansible_m2ieeq/ansible_module_setup.py\", line 134, in <module>
        main()
      File \"/tmp/ansible_m2ieeq/ansible_module_setup.py\", line 126, in main
        data = get_all_facts(module)
      File \"/tmp/ansible_m2ieeq/ansible_modlib.zip/ansible/module_utils/facts.py\", line 3609, in get_all_facts
      File \"/tmp/ansible_m2ieeq/ansible_modlib.zip/ansible/module_utils/facts.py\", line 3552, in ansible_facts
      File \"/tmp/ansible_m2ieeq/ansible_modlib.zip/ansible/module_utils/facts.py\", line 2500, in populate
      File \"/tmp/ansible_m2ieeq/ansible_modlib.zip/ansible/module_utils/facts.py\", line 2584, in get_interfaces_info
      File \"/tmp/ansible_m2ieeq/ansible_modlib.zip/ansible/module_utils/facts.py\", line 2644, in parse_inet_line
    socket.error: illegal IP address string passed to inet_aton

The cause is having aliases on lo like this:

     lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> mtu 33184
         inet 127.0.0.1 netmask 0xff000000
         inet alias 127.1.1.1 netmask 0xff000000

So if the address is 'alias', we have to skip it.
8 years ago
Jasper Lievisse Adriaanse c17dad0def Rework how OpenBSD processor facts are resolved 8 years ago
James Tanner 2d43b20eb9 Update submodule refs 8 years ago
Matt Clay 88dbb5a630 Python 3 fixes for ansible-doc. 8 years ago
Andrea Tartaglia b18263cf36 ANSIBLE_SSH_CONTROL_PATH_DIR option added (#18342)
* ANSIBLE_SSH_CONTROL_PATH_DIR option added

This removes the hardcoded value ( $HOME/.ansible/cp ) from ssh.py.
User is able to change the ControlPath directory ( the one that replaces %(directory)s ).

 Fixes #18325

* Added config option in ansible.cfg
8 years ago
Jasper Lievisse Adriaanse 9547d6b422 Detect vmm virtualization for OpenBSD, both host and guest. 8 years ago
Matt Clay 66a0b1475f Update submodule refs. 8 years ago
Robin Roth 6ca6a9a291 Exclude floppy disks from lsblk call for uuids
Fixes #18326
8 years ago
James Cammarata 7ff9942ec6 Correctly reassign implicit block parents when an include is involved 8 years ago
Brian Coca 32a7b4ce71 only validate extensions when using dir loading
fixes #18223
8 years ago