9239 Commits (819fe45864bfa317d219beb6ca900498c436bbf4)

 

All Branches   

Search

Author	SHA1	Message	Date
Ryan Brown	819fe45864	Fix failure when powering on/off EC2 instances by tag only. (#4767) ... If you apply `wait=yes` and use `instance_tags` as your filter for stopping/starting EC2 instances, this stack trace happens: ``` An exception occurred during task execution. The full traceback is: │~ Traceback (most recent call last): │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module> │~ main() │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main │~ (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags) │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances │~ if len(matched_instances) < len(instance_ids): │~ TypeError: object of type 'NoneType' has no len() │~ │~ fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~ ack (most recent call last):\n File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n main()\n File \"/tmp/│~ ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n (changed, instance_dict_array, new_instance_ids) = startstop_instances│~ (module, ec2, instance_ids, state, instance_tags)\n File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~ nces\n if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~ MODULE FAILURE", "parsed": false} ``` That's because the `instance_ids` variable is None if not supplied in the task. That means the instances that result from the instance_tags query aren't going to be included in the wait loop. To fix this, a list needs to be kept of instances with matching tags and that list needs to be added to `instance_ids` before the wait loop.	8 years ago
Dag Wieers	1cda0b1819	Ensure unicode characters in zip-compressed filenames work correctly (#4702) ... * Ensure unicode characters in zip-compressed filenames work correctly Another corner-case we are fixing hoping it doesn't break anything else. This fixes: - The correct encoding of unicode paths internally (so the filenames we scrape from the output and is returned by zipfile match) - Disable LANG=C for the unzip command (because it breaks the unicode output, unlike on gtar) * Fix for python3 and other suggestions from @abadger	8 years ago
Peter Sprygada	477c71d985	minor updates to junos_package module for 2.2 (#4761) ... * replaces get_module() with NetworkModule() * removes old call to package_version()	8 years ago
Peter Sprygada	4277b88de5	update junos_facts module to remove get_module() factory function (#4760) ... Replaces get_module() with NetworkModule instance	8 years ago
Peter Sprygada	7b46245ecb	Merge pull request #4758 from privateip/iosxr_config ... adds path kwarg when difference() is called from iosxr_config	8 years ago
Peter Sprygada	3d365c5cf8	adds path kwarg when difference() is called from iosxr_config ... Adds the path kwarg to handle use cases with exact and strict matching	8 years ago
Peter Sprygada	684c6897e2	Merge pull request #4701 from GGabriele/nxos_vrrp ... nxos_vrrp update	8 years ago
Peter Sprygada	c113a3ef8e	Merge pull request #4686 from GGabriele/nxos_igmp_interface ... Adding nxos_igmp_interface	8 years ago
Peter Sprygada	24b68d73e8	Merge pull request #4684 from GGabriele/nxos_vrf_interface ... nxos_vrf_interface support for 2.1 and 2.2	8 years ago
Peter Sprygada	fd2a0da5b1	Merge pull request #4682 from GGabriele/nxos_vlan ... nxos_vlan support 2.1 and 2.2	8 years ago
Peter Sprygada	fda1771276	Merge pull request #4685 from GGabriele/nxos_igmp ... Adding nxos_igmp	8 years ago
Peter Sprygada	412a44317c	Merge pull request #4683 from GGabriele/nxos_vrf ... Updating nxos_vrf	8 years ago
Peter Sprygada	550001372e	Merge pull request #4681 from GGabriele/nxos_ping ... nxos_ping support for 2.1 and 2.2	8 years ago
Peter Sprygada	e6bbc5a828	Merge pull request #4680 from GGabriele/nxos_ip_interface ... nxos_ip_interface support for 2.1 and 2.2	8 years ago
Peter Sprygada	49cb49f8b9	Merge pull request #4677 from GGabriele/nxos_reboot ... Adding nxos_reboot	8 years ago
Peter Sprygada	1a0e3003a0	Merge pull request #4676 from GGabriele/nxos_feature ... nxos_feature 2.1 and 2.2 support	8 years ago
Peter Sprygada	a71a36cee2	Merge pull request #4675 from GGabriele/nxos_rollback ... Adding nxos_rollback	8 years ago
Peter Sprygada	9377666fc4	Merge pull request #4672 from GGabriele/nxos_vrf_af ... Adding nxos_vrf_af	8 years ago
Peter Sprygada	6d02dc4f2c	Merge pull request #4670 from GGabriele/nxos_vpc_interface ... Adding nxos_vpc_interface	8 years ago
Peter Sprygada	30c8c8e17e	Merge pull request #4669 from GGabriele/nxos_vpc ... Adding nxos_vpc	8 years ago
Peter Sprygada	944aa8644b	Merge pull request #4673 from GGabriele/nxos_vxlan_vtep ... Adding nxos_vxlan_vtep	8 years ago
Peter Sprygada	0bcad5a71d	Merge pull request #4667 from GGabriele/nxos_static_route ... Adding nxos_static_route	8 years ago
Peter Sprygada	fce047f2f4	Merge pull request #4666 from GGabriele/nxos_smu ... Adding nxos_smu	8 years ago
Peter Sprygada	54ae1e9787	Merge pull request #4665 from GGabriele/nxos_portchannel ... Adding nxos_portchannel	8 years ago
Peter Sprygada	9def666f3d	Merge pull request #4664 from GGabriele/nxos_pim_rp_address ... Adding nxos_pim_rp_address	8 years ago
Peter Sprygada	dd0bec4b85	Merge pull request #4663 from GGabriele/nxos_pim ... Adding nxos_pim module	8 years ago
Peter Sprygada	3ad8cbe5fc	Merge pull request #4662 from GGabriele/nxos_overlay_global ... Nxos overlay global	8 years ago
Peter Sprygada	f961e57db1	Merge pull request #4656 from GGabriele/nxos_interface_ospf ... Adding nxos_interface_ospf	8 years ago
Peter Sprygada	b603774e55	Merge pull request #4655 from GGabriele/nxos_hsrp ... Adding nxos_hsrp	8 years ago
Peter Sprygada	1b281cb7cc	Merge pull request #4654 from GGabriele/nxos_file_copy ... Adding nxos_file_copy	8 years ago
Peter Sprygada	3370df7e87	Merge pull request #4625 from GGabriele/nxos_ospf_vrf ... Adding nxos_ospf_vrf module	8 years ago
Peter Sprygada	cdda76df8a	Merge pull request #4653 from GGabriele/nxos_evpn_vni ... Adding nxos_evpn_vni	8 years ago
Peter Sprygada	4234add9e9	Merge pull request #4652 from GGabriele/nxos_bgp_neighbor_af ... Adding nxos_bgp_neighbor_af module	8 years ago
Peter Sprygada	94db615d22	Merge pull request #4651 from GGabriele/nxos_bgp_neighbor ... Adding nxos_bgp_neighbor module	8 years ago
Peter Sprygada	95d495b50b	Merge pull request #4650 from GGabriele/nxos_bgp_af ... Adding nxos_bgp_af module	8 years ago
Peter Sprygada	b0d50b42dd	Merge pull request #4624 from GGabriele/nxos_ospf ... Adding nxos_ospf module	8 years ago
Peter Sprygada	a1badcf6f6	Merge pull request #4622 from GGabriele/nxos_evpn_global ... Adding nxos_evpn_global module	8 years ago
Peter Sprygada	1f6f430819	Merge pull request #4621 from GGabriele/nxos_acl_interface ... Adding nxos_acl_interface_module	8 years ago
Peter Sprygada	ea37837ac8	Merge pull request #4618 from GGabriele/nxos_acl ... Adding nxos_acl module	8 years ago
Peter Sprygada	65fed11424	Merge pull request #4602 from GGabriele/nxos_bgp ... Adding nxos_bgp.py	8 years ago
Matt Clay	bf5b3de83e	Python 3 fixes for apt_* modules. (#4754)	8 years ago
Peter Sprygada	99ddf08e2b	Merge pull request #4751 from privateip/ios_config ... minor bug fix to pass path to difference() in ios_config	8 years ago
Peter Sprygada	c716744f3c	minor bug fix to pass path to difference() in ios_config ... The ios_config module needs to pass the path kwarg to difference when specifying match=exact or strict.	8 years ago
Peter Sprygada	db5cb54b23	Merge pull request #4749 from privateip/nxos_config ... fixes bug where nxos_config wasn't handling checkpoints correctly	8 years ago
afunix	ab7fe884d7	Updated get_url module to process FTP results correctly [#3661] (#4601)	8 years ago
Peter Sprygada	ec9f6594ca	fixes bug where nxos_config wasn't handling checkpoints correctly	8 years ago
Abhijit Menon-Sen	55d51b3946	Fix spot instance creation by ignoring instance_initiated_shutdown_behavior (#4741) ... Before this, all spot instance requests would fail because the code _always_ called module.fail_json when the parameter was set (which it always was, because the module parameter's default was set to 'stop'). As the comment said, this parameter doesn't make sense for spot instances at all, so the error message was also misleading.	8 years ago
Florian Dambrine	aac55fcc62	Fix ec2 module source_dest_check when running on non VPC instances (EC2 Classic) (#3243)	8 years ago
Peter Sprygada	81aa3a760c	Merge pull request #4730 from privateip/ios_template ... fix bug in ios_template when include_defaults is set to true	8 years ago
Peter Sprygada	0a03d34916	Merge pull request #4729 from privateip/ios_config ... adds path kwarg when performing config diff checks in ios_config	8 years ago