Commit Graph

8181 Commits (804a8e637874ffe404b12b3a05305d147168f605)
 

Author SHA1 Message Date
jctanner 804a8e6378 Fix status check on get_url with file schemas and update the examples. (#3512)
Addresses #3511
9 years ago
Brian Coca 3c009bd04f corrected return docs sample 9 years ago
vaupelt 67de0675c3 exclude_hosts does not work as expected with state=drained
There are established connections for a service. The service is bound to a ipv4-mapped ipv6 address. Wait_for wrongly waits for clients listed in exclude_hosts.
9 years ago
Toshio Kuratomi 3cbca32e73 Merge pull request #3507 from resmo/fix/git-porcelain-status
git: fix status to use porcelain, ignore user configuration
9 years ago
Michael Scherer 0300b2add1 Remove old test on SELinux (#3510)
since all is done in modules_utils/basic.py, no need to make
the same test here, especially since that's unused later
9 years ago
Robin Roth 2256ae0793 fix git switch branches in combination with depth on old git versions (#3492)
* fix git switch branches in combination with depth

* the old implementation is correct, but relies on git working correctly
  (as only newer versions do)
* with some older git version (e.g. 1.8.3), git fetch remote branch does
  not work, if the branch does not yet exist locally
* this patch works around that without explicitly checking the git version
* future refactoring is needed to reduce the number of fetches to a
  minimum; but this patch makes the code "correct"

* add git version requirements to doc

* replace set-branches with git 1.7.1 compatible version
9 years ago
ThomasSteinbach 8dc0276533 docker: fix type issue (#3491)
* fix type issue

* fix type issue for 'volumes-from'
9 years ago
Rene Moser 1f92e77650 git: fix status to use porcelain, ignore user configuration
From the git status doc:

    --porcelain

        Give the output in an easy-to-parse format for scripts. This is similar to the short output, but will remain stable across Git versions and regardless of user configuration. See below for details.

User configuration can break the git module from working as expected.
9 years ago
Matt Davis c6f5475afe Merge pull request #3501 from dreamcat4/fix/win-modules-strict-mode-fixes
Fix/win modules strict mode fixes
9 years ago
Dreamcat4 b3584c5ffe fix: win_get_url - fixes for strict-mode 9 years ago
Dreamcat4 bb229c8fa2 fix: win_stat - fixes for strict-mode 9 years ago
Adrian Likins d83c269b82 improve redhat_subscription documentation (#3348)
* add subscription-manager's --type, --consumerid, --name option support

* redhat_subscription: More docs on consumerid
9 years ago
Michael Scherer a144663953 Fix error reporting for fetch_key (#2662)
Since fetch_url already take care of the exception, the try/except
clause is no longer working, so replace it with proper status
checking, thus permitting to remove urlib2 from the import list.
9 years ago
Constantin b3bcd5a433 Added improvements and documented return structure (#2320) 9 years ago
jjshoe bfa0a94c27 Fix an issue where by a call to ec2.get_image wasn't wrapped in a try/except, and would occasionally throw an exception in the wild. Also greatly simplifies two of the ugliest known loops to man down into a single loop. (#2554) 9 years ago
Brian Coca c64b7a71fb removed usless default doc 9 years ago
Justin Kennedy 7a2b00b625 Updating examples to include required fields (#3242)
Updated examples to include required fields (host, username).  Also updated src option to be listed as required.
9 years ago
Brian Coca 53c4827da5 added missing version_added 9 years ago
Pål Nilsen eb6192c050 Add optional force parameter for apache2_module (#3251)
* Add optional force parameter for apache2_module

Fixes #2499

* Add documentation for the force parameter

* Clarify in description that -f(orce) is a Debian parameter
9 years ago
Jan Hutař 9ab4780b25 Add support for Satellite/Spacewalk which have slightly different API to Hosted (#3289) 9 years ago
Michael Scherer b5ef21ef89 Suggest using uri if curl is detected
Some people use the command module to run curl not to
download file, but to interact with remote HTTP api, and the
get_url suggestion is not suitable. So adding uri in the warning
would give a more meaningful warning.

Suggested by Tahvok on #ansible irc channel.
9 years ago
Dennis Conrad c1787da7ff Fix UnboundLocalError if 'access_key_ids' not supplied
'key_ids' is referenced before it is assigned, causing the module to fail with a UnboundLocalError instead of failing gracefully with a helpful error message.  This very small patch moves the assignment of 'key_ids' to before the variable is referenced.
9 years ago
Toshio Kuratomi 98322a777f Merge pull request #3466 from robinro/git-full-clone-with-hash
git: fall back to full clone if version is hash
9 years ago
Toshio Kuratomi f39e2343c4 Fix apt module needing another format character 9 years ago
Toshio Kuratomi 609d4cf84b Merge pull request #3464 from robinro/fix-pull-git-branch-#3456
git: with depth only fetch actual version, don't use refs/heads/*
9 years ago
Robin Roth b67d15f385 fall back to full clone if version is hash
if version is not a branch or tag (i.e. a hash), we need a full checkout to be able to switch to it
9 years ago
Robin Roth c398eb5399 with depth only fetch actual version
* don't use refs/heads/branchname for branches
* for tags it's needed thou
* fixes #3456
9 years ago
Jeroen Geusebroek 766671f1e1 Allow an empty password when adding a new MySQL user. (#3445) 9 years ago
Kyle Dyroff 2b003a2773 Log git error stdout/stderr to fail_json (#3022) 9 years ago
Dag Wieers 983cdd00bc Making unarchive idempotent (#3307)
* WIP: Making unarchive idempotent

Currently unarchive is not idempotent and has many rough edges and bugs.
The current release is a workable improvement on many fronts:

- zip support is now idempotent (but gtar lacks check-mode)
- New option `exclude` to exclude specific paths/files
- New option `keep_newer` to exclude newer files on target
- New option `extra_opts` to influence unzip/gtar (like synchronize module)

The following items are still ongoing:

- Implement CRC32 support for .zip files
- Re-implement the zip support using native zipfile module
- Re-implement the gtar support using native tarfile/gzip/bz2 modules (lzma external)
- Implement check-mode (works in gzip, but fails using gtar)
- Implement diff-mode (discuss an appropriate output model, like synchronize module)

The re-implementation of unzip/gtar support using native python modules will not only simplify the codebase, additional functionality can be implemented correctly and identically, which is currently not possible. (Other archives could be implemented using native modules equally, incl. options)

* Assorted fixes to zip support (during quality checks)

- Support both rw---- and rwx--- permstr
- Better file type support (more qa needed)
- Symlink support
- Include fix from #3229

* Implement zip diff-mode (itemized change) and avoid changes permissions every time (!)

This commit implements:
- rsync-compatible itemized-change output in diff-mode (using zip)
- no longer changing permissions unconditionally (when idempotent)

* Small fixes to itemized change output

* Fixes to user/group ownership changes

- The implementation of user/group ownership is a bit more complex for idempotency
- We report when a ZIP file incorrectly tags a directory as a file/link
- We only offer diff output when there is a change

* Fix the handling of includes and excludes for unzip

* Remove test output from output (confuses easily)

* Logic and performance improvements to ownership handling, and umask fix

* Handle special files (type '?')

* Make exceptions compatible with python 2.4

* Implement CRC32 support

* Revert some unintended/unknown changes ?

* Taking over maintenance as offered by current maintainer

* Fix support for white-spaces in filenames

* Remove/rename incorrect regex

* Ensure that fat executables end up with execute permission

* Remove check_result from output when unchanged

* When unarchiving as a user, or when owner/group/mode is supplied --diff is insufficient

Only way to be sure is to check request with what is on disk (as we do for zip).
Leave this up to set_fs_attributes_if_different() instead of inducing a (false) change

* By default, don't send confusing check_results in verbose output

This fixes #74.
9 years ago
NielsH ab699a0953 Resolve idempotency issue with virtual apt package (#3449)
Virtual packages were always marked as upgradable which caused the changed-state even though nothing changed.
9 years ago
Tobias Wolf dba53b5543 Add diff to apt.py (#2944)
for install, remove, deb_install, and upgrade.

Since apt has very commonly familiar output, just use the normal output
from apt-get or aptitude -- trimmed to the interesting parts -- to show
to the user if she specified --diff on the CLI.

Uses the recent support for the `diff['prepared]` key.

Fixes ansible/ansible#10239
9 years ago
Oleg Senin 377e94f77f Correct misspell (#3454) 9 years ago
Kei Nohguchi 795b3c25cd ops_template.py: Taking care of the JSON src variable (#3313)
* ops_template.py: Taking care of the JSON src variable

* ops_template.py: Specify type='str' for src argument to be explicit
9 years ago
Marcin 5312627091 rebase for #2477, ready_for_review (#2581) 9 years ago
Michael Fenn 09f14731f2 Support altering the virtual cdrom when state == reconfigured (#2394)
This allows a user to modify the state of the virtual cdrom in a VM
by using the state == reconfigured action.  This is useful for
provisioning VMs from templates which do not have ISO images connected.
9 years ago
Alexey Wasilyev 1c3071af61 docker: support polling image by digest (#2932) 9 years ago
Joel Thompson a39d11e8f5 Add exponential backoff retries to ec2_elb_lb (#3379)
ec2_elb_lb doesn't react well to AWS API throttling errors. This
implements an exponential backoff operation around some of the AWS API
calls (with random jitter, in line with AWS recommendations) to make
this more resilient.
9 years ago
Patrick Ogenstad 5409ed1b28 Fix documentation example, missing ")" 9 years ago
Donovan Jones 7c52ea58f1 Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
* Make remote_group handle name and id

* fix regression breaking os_security_group_rule with no remote_group
9 years ago
Robin Roth f1bacc1d3f make git updates respect depth (#3254)
* make git updates respect depth

until now `fetch` gets all tags and heads at full depth, this change
* uses `depth` argument for `fetch`
* only get the specified `version` in `fetch`

* fixes #14954

* treat combination of refspec and depth correctly

* be more conservative for non-depth fetch
9 years ago
jjshoe ea199ecac0 Give encoding examples (#3436) 9 years ago
David Shrewsbury 25e75e66eb Merge pull request #3236 from rcarrillocruz/network_by_project
Add project parameter to os_network
9 years ago
Ricardo Carrillo Cruz 3e93204598 Add project parameter to os_network
A cloud/domain admin should be able to create a network on any project
it is granted to.
This changes adds the possibility to pass either a project ID or
project name.
9 years ago
David Shrewsbury cea5ceb644 Merge pull request #3237 from rcarrillocruz/os_subnet_by_project
Create subnet by project
9 years ago
yarick123 bf2f09e37c ini_file: added option 'noextraspaces' to turn off inserting extra spaces around '=' symbol
* ini_file: added option 'noextraspaces' to turn off inserting extra spaces around '=' symbol

* ini_file: noextraspaces, python 2.4 compatibility

* ini_file: noextraspaces - yes/no => true/false

* ini_file: noextraspaces - added 'version_added' option

* ini_file: noextraspaces => no_extra_spaces
9 years ago
Sandra Wills 086735e255 Merge pull request #3400 from gaomd/patch-1
Improve doc accuracy of template module
9 years ago
hyperized 48fa3a5243 Set --quick to True by default and make it selectable (#3418)
As indicated by @jmainguy in eb1cb94380 (commitcomment-17077470), this will allow the user to set the option quick, which is True by default (as it was before).

This is in reference to: https://github.com/ansible/ansible-modules-core/pull/3402
9 years ago
James Cammarata 79ff959635 Merge pull request #3417 from jkugler/fix_mount_passno
Fix mount's handling of passno
9 years ago
Mengdi Gao 4ff5218903 Improve doc accuracy of template module 9 years ago