Commit Graph

29013 Commits (7c3957cc0cc3e12e7a7cfefb89a413280bc4e873)
 

Author SHA1 Message Date
Peter Sprygada 7c3957cc0c fixes nxos_template integration test case (#21953)
* test case implemented invalid argument: match
* changed argument to force: yes
8 years ago
Peter Sprygada 1f9b503e89 fixes issue with config parents on eos modules (#21923)
eos_config module wasn't respecting config block path (parents).  This
patch fixes that problem.  Also fixes a number of integration tests
cases

fixes #21903
8 years ago
Peter Sprygada 14c05d9e2b roll up of fixes for nxos_config (#21949)
* fixes provider to not log entries
* fixes nxapi send_request with config statements
* fixes nxapi get_config()
* updates nxos_config integration tests
8 years ago
Peter Sprygada f9b108e319 fixes issue that caused eapi transport setting to get lost (#21919)
The eos action didn't properly set provider transport argument for the
module.  This patch fixes that problem
8 years ago
Peter Sprygada 01ac1bc6e5 roll up of fixes from nxos integration tests (#21948)
* now fails nxos_nxapi if the transport=nxapi
* fixes typos in nxos_nxapi integration tests cases
8 years ago
René Moser d26c57f938 exoscale: pep8 and python3 fixes (#21821)
* exoscale: pep8 fixes

* exo_dns_record: remove from pep8 test legacy

* exoscale: fix python3 support
8 years ago
Barry Peddycord III 2ca5719168 Deprecating old cumulus modules (#21726)
* deprecating old nclu modules

* adding deprecated cl_ moduels to changelog

* renaming deprecated modules
8 years ago
Dag Wieers 98934939af win_copy: Add force parameter and check-mode support (#20405)
* win_copy: Add force parameter and check-mode support

The rationale behind this is that if you're working with +3GB files,
creating the checksum takes a lot of time, which we can avoid by simply
testing if the file exists.

I also took the liberty to put the various parameters together. It
probably takes a (neglible) performance hit but makes the code a bit
easier to inspect/work with, as its closer to all other windows modules.

On a normal run, the action plugin does a local checksum of the source
and a remote checksum of the destination. And afterwards, the module
will do another remote checksum of the copied source, a remote checksum
of the original destination, and another remote checksum of the copied
destination.

On a very huge file (think 4GB) that means 5x reading the complete file
(if you have a large cache you may get away with it, otherwise you're
doomed !).

This patch will ensure with `force: no` that not checksums are being
performed.

* Moving presence check before remote checksum

* Adapted to wishes

* Even more performance improvements
8 years ago
Brian Coca ce08b4165d ansible-doc more flexible to metadata changes 8 years ago
Matt Clay 2804d2e848 Split up unit tests on Shippable. (#21931)
* Add more verbose output to coverage combine.
* Run unit tests on CI separately by version.
8 years ago
Matt Clay 0d455037a2 Disable broken tests. 8 years ago
Matt Martz 305c88700d PEP8 E712 fixes (#21916) 8 years ago
Wouter 5d39056379 Correct link in documentation (#21894)
Fixes #20692
8 years ago
Matt Clay c448a418fd Treat deprecated modules as old during validation. 8 years ago
Matt Clay 4e0f82e0e9 Fix PEP 8 issue. 8 years ago
John R Barker 1d2349872a RETURN block is broken, so delete it 8 years ago
John R Barker fdd03916a3 Document ANSIBLE_METADATA (#21250)
* Document ANSIBLE_METADATA

* Formatting

* Reive feedback - WIP

* notes about Declarative

* fix headings

* Use field lists

* typo

* review feedback

* Imports

* typo

* Toshio's feedback
8 years ago
Toshio Kuratomi 49db03c384 Fix for traceback when we encounter non-utf8 characters in diff
We can diff non-utf8 files (as part of copy, for instance) but when we
try to turn the bytes into text for display, the characters cause
a traceback.  Since diff output is only informational, we can replace
those problematic bytes with replacement characters.  We do not want to
do this to other fields because those fields may be used inside of the
playbook (for templating another variable or matching in a conditional).

Fixes #21803
Fixes #21804
8 years ago
Brian Coca b714f1fc4b made module notes render nicer on docsite 8 years ago
Brian Coca 9ac697a155 simplified persistent connection quandry 8 years ago
Brian Coca 2a6145ca1c prep for role passthrough instead of detection
(cherry picked from commit 2125a23f2ab0903065a13f9ee68ae43ed348d6fb)
8 years ago
Matt Davis 7798297317 temp disable Windows batch test 8 years ago
Peter Sprygada c85d794d83 fix argument name in nxos shared lib (#21912)
fixes #21895
8 years ago
Matt Martz 97e12b0898 Check for imports to be between last doc line and first callable (#21863)
* Check for imports to be between last doc line and first callable

* Small readme update
8 years ago
Adrian Likins 6c6b647182 Fix 'ansible-vault edit /some/symlink' (#20417)
Since vault edit attempts to unlink
edited files before creating a new file
with the same name and writing to it, if
the file was a symlink, the symlink would
be replaced with a regular file.

VaultEditor file ops now check if files
it is changing are symlinks and instead
works directly on the target, so that
os.rename() and shutils do the right thing.

Add unit tests cases for this case and
assorted VaultEditor test cases.

Fixes #20264
8 years ago
Adrian Likins 8830cde28d Fix 'task name is not templated in retry callback' (add task_name property to TaskResult) (#21214)
Fix 'task name is not templated in retry callback'

Add a task_name property to TaskResult that knows to
check in TaskResult._task_fields.

Add integration test for v2_retry_runner callback

Fixes #18236
8 years ago
Adrian Likins 78c4f03e50 Fix firewalld get_masquerade_enabled_permanent error (#21693)
get_masquerade_* functions only take one arg. The action_handler
wrapper function expected a tuple, but was being passed (zone)
instead of (zone,) making for an ambiquous tuple. The
(zone) arg was being treated as a tuple/list of six chars
(the zone name) instead of a tuple of one string.

This would cause errors like:

        get_masquerade_enabled_permanent() takes exactly 1 argument (6 given)

Fixes #21632
8 years ago
Ricardo Carrillo Cruz e6a78b38d3 Remove check_args import (#21905)
It is defined in the file, thus no point in importing it.
8 years ago
Gaurav Rastogi 436095f576 New module for setting up Avi Pool (#21241)
* New module for setting up Avi Pool

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
8 years ago
Gaurav Rastogi 055f2c29a5 New module to setup Avi VirtualService (#21170)
* Added new module to setup Avi VirtualService

* Fixed the documentation error where [] brackets where used making it incompatible with yaml

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for check mode
8 years ago
Gaurav Rastogi de841a6429 New module for setting up Avi SSL Key and Certificates for Virtual Se… (#21242)
* New module for setting up Avi SSL Key and Certificates for Virtual Services

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
8 years ago
Gaurav Rastogi 39a93eb357 New module for setting up Avi Pool Group settings. (#21243)
* New module for setting up Avi Pool Group settings.

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
8 years ago
Gaurav Rastogi 51718fd32b New module for setting up Avi Pool Health Monitors (#21240)
* New module for setting up Avi Pool Health Monitors

* Fixed inconsistency between argspec and documentation regarding defaults and required attributes

* Added support for module_check
8 years ago
Pavel Malyshev 7063db64c2 redhat_subcription module accepts id in the pool argument [#3898] 8 years ago
Adrian Likins a2907c4d5c Add smoke/intg tests for vault cli (#21679)
Add smoke/intg tests for vault cli
8 years ago
Dhivyap e3dc202a3c Fixes #18663 Bad Handling of existing config in OS6 module (#21661)
Fix bad handling of existing config in OS6 module

Fixes #18663
8 years ago
jhawkesworth d0278d1d1e [WIP] documentation: Remove assemble from list of windows modules, plus tweaks (#21859)
* Remove assemble from list of windows modules, but advise you can delegate appropriate modules to localhost.  Try to fix list of usable on windows modules to appear as a list instead of on one line.

* Update intro_windows.rst

Minor edit
8 years ago
Simon Li ef7dd0cb2c Set os_server metadata on existing instances (#19318)
* Update metadata on existing openstack instances

This adds or updates existing keys, but doesn't remove them
Fixes #5500

* Set meta to {} if None

* Move common metadata parsing into a method
8 years ago
Dag Wieers 581bf7bb97 win_environment: Clean up, check-mode and diff support (#21356)
* win_environment: Clean up, check-mode and diff support

Changes include:

- Remove trailing semi-colons
- Replaced PSObjects into normal hashes
- Make use of Get-AnsibleParam and types
- Added check-mode support
- Added diff support

* Improve diff-support by using standard naming

I started to use the variable $diff_support for the boolean that takes
care of diff output support.
8 years ago
Dag Wieers b1f6344ecb win_chocolatey: Clean up parameter handling (#21533)
Changes include:

- Use Get-AnsibleParam with -type/-validateset
- Replace $result PSObject with normal hash
- Deprecate 'upgrade' parameter by using state=latest
8 years ago
Dag Wieers 78c300412d win_user: Clean up parameter handling and $result hash (#21375)
* win_user: Clean up parameter handling and $result hash

Changes include:
- Use of Get-AnsibleParam and parameter types/validateset
- Removed parameter validation
- Replace $result PSObject with normal hash

* Revert to original formatting

* Parameter "groups" is a list
8 years ago
Matt Martz 36e6c7973d pep8 fixes for module_docs_fragments (#21876) 8 years ago
Dag Wieers cfb1f72d1c Improve winrm import error message (#20267)
The requests python module is needed, however it is not a dependency of
the python-winrm package. The python-winrm package does require
python-requests_ntlm, which does not seem to pull python-requests.

So for the time being (until Red Hat fixes their package) give a more
informative error message.
8 years ago
Dag Wieers 70336c63c9 win_uri: Replace -type "string" with -type "str" (#21373)
Type "string" does not exist.
8 years ago
Dag Wieers 582557bc09 win_file_version: Clean up and check-mode support (#21379)
* win_file_version: Clean up parameter handling and $result hash

Changes include:
- Replacing $result PSObject with hash
- Use Gt-AnsibleParam using -type

* Revert to original formatting
8 years ago
Dag Wieers 69ac88176d win_group: Clean up and check-mode support (#21384)
* win_group: Clean up and check-mode support

Changes include:
- Use Get-AnsibleParam with -type/-validateset support
- Replace $result PSObject with normal hash
- Add check-mode support

* Revert to original formatting
8 years ago
Dag Wieers 928880c639 win_owner: Clean up and check-mode support (#21385)
* win_owner: Clean up and check-mode support

Changes include:
- Use Get-AnsibleParam with -type/-validateset
- Replace $result PSObject with normal hash
- Add check-mode support

* Implemented -WhatIf:$check_mode support

* Revert to original formatting
8 years ago
Dag Wieers 313a9d3845 win_share: Clean up parameter handling (#21386)
* win_share: Clean up parameter handling

Changes include:
- Use Get-AnsibleParam with -type/-validateset
- Replace $result PSObject with normal hash

* Revert to original formatting
8 years ago
Dag Wieers cb78262c18 win_lineinfile: Clean up and check-mode support (#21503)
* win_lineinfile: Clean up and check-mode and diff support

Changes include:
- Use Get-AnsibleParam with -type support
- Replace $result PSObject with normal hash
- Remove trailing semi-colons
- Fix indentation (majority is tabs, few lines using spaces)
- Add check-mode support
- Support `r and `n for CR and LF
- Add diff support

* Implement -WhatIf:$check_mode support

* Keep original formatting as requested
8 years ago
Dag Wieers d239adb5e5 Improve diff-support and use Add-Warning() (#21519)
I started to use the variable $diff_support for the boolean that takes
care of diff output support.
8 years ago