Commit Graph

24546 Commits (7609a8cdd622311f6bc8441af36004d6a4cd62dd)

Author SHA1 Message Date
anasbadaha 7fcd55f3ec Fix Issue:#47076 onyx_l2_interface parameter trunk_allowed_vlans tries to remove all existing vlans on a port (#49418)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
6 years ago
Felix Fontein b0c7efcc6b ACME: add diff to acme_account, account_public_key to acme_account_facts, and general refactoring (#49410)
* Only one exit point.

* Refactoring account handling.

* Add diff support for acme_account.

* Insert public_account_key into acme_account_facts result and into acme_account diff.

* Add changelog.
6 years ago
Chris Archibald 62dd1fe29e New options of na_ontap_aggregate (#48906)
* add new options for na_ontap_aggregate

* add gpl line

* remove dup option

* Put files in wrong directory

* change unit test to match the request from PR 48941

* Changed for review comments

* pep8
6 years ago
Felix Fontein 34c57b4c42 ACME: fix bug introduced in #49266, work around problem with Pebble (#49407) 6 years ago
Ruben Tsirunyan d62492e656 zabbix: New zabbix_action module (#49189) 6 years ago
Brian Coca fc71cde7d3
Yaml inventory more tolerant (#48883)
* make yaml inv more tolerant to comments
* add tests for bad inventory processing

fixes #47254
6 years ago
Bob Vincent 2557373cc8 Do not document buggy behavior. (#49325)
In the pip module, umask should be specified as an octal *string*, not an octal (or decimal) *integer*.
6 years ago
Brian Coca 8c43ce491e unsafe cleanup 6 years ago
Alicia Cozine 031e961c58
removes talk of hardcoded loading from plugin docs (#49383) 6 years ago
Gregor Wegberg 4096d74245 Specify key to use while sorting permissions (#49126)
Without specifying the dictionary key to use while sorting it will fail
in Python 3 environments due to simplifying Python's rules for ordering
comparisons: https://docs.python.org/3.0/whatsnew/3.0.html#ordering-comparisons
6 years ago
Ken Partridge 19035dbcb2 CPM plugcontrol for WTI Power Devices (#47683)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Added the new module cpm_plugcontrol to control the plugs on WTI Power devices
6 years ago
Ken Partridge 837818018d CPM plug configuration for WTI Power Devices (#47989)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* added the module cpm_plugconfig
6 years ago
Adam Miller 378cc9668c dnf module load/init dnf pkg mgr plugins properly (#49278)
* dnf module load/init dnf pkg mgr plugins properly

Fixes #45940

Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Jorgen 8ff13db17c Add Windows example of raw command (#47153)
* Add Windows example of raw command

Perform shutdown of Windows OS using Microsoft.PowerShell.Management module

* Capitalized cmdlet, remove quotes and improve description

This commit also cleans up some of the description sections.

* Use another example as suggested by jborean93

I was happy to merge this before I noticed jborean93 objected to the example :-/

* Fix whitespace issue
6 years ago
Martin Krizek c78c8d389f
Last loaded handler with the same name wins (#49249)
* Last loaded handler with the same name wins

* Add comment explaining reversed
6 years ago
James Cote aee9209375 Update set_fact doc to reflect updated caching options (#46565)
* Update set_fact doc to reflect updated caching options

* add note about change in precedence caused by caching
6 years ago
Peter Sprygada 2a4be2748f fixes an issue with dict_merge in network utils (#41107)
This change address a problem where the dict_merge function would fail
due to the value being a nested dict.  This will now recursively pass
the value back through the dict_merge function.
6 years ago
Youhua Li c1a30c743e enable ONE auth file authentication (#49331) 6 years ago
Lars Kellogg-Stedman b2e5c75131 server.security_groups is a list of dicts (#48798)
os_server was trying to access `[sg.name for sg in
server.security_groups]`, but the items in `server.security_groups`
are dictionaries, so that should be `sg['name']`.
6 years ago
Giovanni Sciortino 95718f7e12 fix archive module can not compress a single file in a tar file (#45117)
fixes #44968
6 years ago
Martin Surovcak 87a9ada188 fix module argument to be boolean (#47134) 6 years ago
Lex Rivera aa484c0835 Fix GCE and scaleway VM detection (#47193)
* Fix Google cloud engine & Scaleway VM detection
6 years ago
maxstack 0dbac3f3b8 add default nolog param for VPN PreSharedKey (#47788) 6 years ago
Alan Rominger d536be6530 Avoid duplicated recursive calls in inventory CLI (#48598) 6 years ago
ftntcorecse b4ce4e1571 Fortinet FortiManager Device Group Module (#46086)
* fmgr_device_group PR candidate

* fgmr_device_group PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Authors

* Removed State Parameter and replaced with Mode, per request of justjais
6 years ago
bverschueren 5cd31578cc comparing StorageConnection.password breaks idempotency (#48933) 6 years ago
Christian Kotte 68cafbda2b Improve vmware_dvswitch module (#48720) 6 years ago
Matthew Krupcale 93fd323457 Add support for newer FreeIPA SHA256 SSH public key hashes (#40803)
* lib/ansible/modules/identity/ipa/ipa_user.py:
    - Check any existing `ipa_user` SSH public key fingerprints for the hash algorithm to use
    - Generate `module_user` SSH public key fingerprint based on detected or default algorithm
6 years ago
Felix Fontein 2bd8e47247 add acme_inspect module (#48444) 6 years ago
rajaspachipulusu17 fe147289b7 Pluribus Networks pn access list module (#49176)
* Pluribus Networks pn access list module
* Added shlex import which was missing and added correct author
* Added an extra space which is according to pep8
6 years ago
Sofiane Medjkoune ec73af1d78 Removed the unused argument description from lxd_container module (#31440) 6 years ago
Abhijeet Kasurde 3141fda6b4
Misc typos in ce action plugin (#49348)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Yunge Zhu be28794dfc
fix keyvault key secret not support cloud environment (#49182) 6 years ago
Monty Taylor 824c72da5f Set play context on stdout callback plugin (#35910)
The loop on self._callback_plugins does not include the stdout callback,
so the stdout_callback never has set_play_context called.
6 years ago
Gaël Lambert ad7798c26a Add the ability to download a specific version of an S3 object (#47867)
Add the ability to download a specific version of a S3 Object

Fixes: #47864
6 years ago
Florian Pracht eb410a9987 Run patch command with --check option instead of --dry-run to support older BSDs (#42168) 6 years ago
Dag Wieers bc481c2500 PSRP: Improve default logging to ansible.log (#47645) 6 years ago
Dag Wieers 01d66d4431 WinRM: Improve default logging to ansible.log (#49308) 6 years ago
Tomáš Pospíšek 434c421675 improve usage example of tempfile module (#47933)
* Show in example how to use file created by tempfile module
6 years ago
Chris Archibald 73348ae32d Fixes for na_ontap_cluster_peer (#48329)
* Fixes for na_ontap_cluster_peer, incorporating review comments, version, etc.
6 years ago
Laurent G 655b27f571 VMware: Add a pointer on how to get possible values. (#48658)
* Add a pointer on how to get possible values for VMware host config manager
6 years ago
Felix Fontein 3726d467ec Code style adjustment. (#49329) 6 years ago
martinwangjian d1816d4908 grafana_datasource: Add CloudWatch as grafana datasource type (#48174) 6 years ago
Matt Martz 77befcf5d7
Do not allow addressing an import from handlers via notify. Fixes #48936 (#49317) 6 years ago
Dusan Matejka a9aa1053a8 zabbix_template: fixed idempotency issues (#49188) 6 years ago
Paul Neumann a914f494a8 ios_facts: Gather CDP neighbor data (#49129)
* ios_facts: Gather CDP neighbor data

* ios_facts: Create tests for ansible_net_neighbors
6 years ago
Ryan Brown a51eca364f New module: AWS EC2 Launch Template (#46972)
* Add launch template integration tests
6 years ago
Isakov Anton 5a7f2b6b08 Update elb_application_lb_facts.py (#48983)
<!--- Added example how to see the facts about specific ALB -->
6 years ago
Brian Coca 24e4d26b72 added missing github id 6 years ago
Amy Buck 392a12589e Update dellos10_command.py (#48167)
<!--- Your description here -->

Updated Dell OS10 to Dell EMC OS10
6 years ago
spike77453 bd35069495 Non-existent RR returns empty string (#40680) 6 years ago
Pilou 62c05033d6 templar: ensure that exceptions are handled, fix 'AttributeError' (#48792)
* templar: ensure that exceptions are handled

* Fix AttributeError: object has no attribute 'message'

'message' attribute is deprecated since Python 2.6 and not available
with Python 3.

Simple reproducer:

    - hosts: localhost
      vars:
        not_json: "{{ 'test str' | from_json }}"
      tasks:
        - command: "echo {{ not_json }}"
6 years ago
jpdasma 37f66ee15b Fix reboot plugin not working in Illumos/Solaris (#48986) 6 years ago
Sam Doran 8f9ced4005 Improve log message (#49004)
This is the only connection plugin that doesn't state explicitly what it is in the log.
6 years ago
Douglas Fraser d6d16fa619 Extend DMI form factors list to match SMBIOS standard 3.2.0 (2018-04-26) (#42239)
Signed-off-by: Douglas Fraser <doug+git@idmf.net>
6 years ago
fdeschamps faed1bbd96 ignore empty lines in rabbitmqctl output (#43722)
* ignore empty lines in rabbitmqctl output

this fixes a bug with rabbitmq 3.7.5
rabbitmqctl can return empty lines, breaking the rabbitmq_parameter module
especially in a new vhost, the command rabbitmqctl list_parameters -q -p <vhost> will return an empty line

* Strip empty line in rabbitmqctl output
6 years ago
Ryan Brown af6427bf40 VPC peer module unhandled exception on bad peering ID (#45306)
* Improve error handling for VPC peer module when a bad peering-id is specified

* changelog
6 years ago
Ryan Brown 7f7c059a04 ec2_asg: Retry Autoscaling Group delete calls when scaling activity is in progress (#46124)
* Retry delete calls when scaling activity is in progress

* changelog
6 years ago
joaocpinto bbab4c1b49 Cast int for expire field to avoid call failure to sensu API (#33239) 6 years ago
Corey Wanless 6cd321ed8e sets admin_password to no_log (#46604) 6 years ago
John Nelson 571749f3ed ec2_vpc_nacl: Don't default name into Name unless able (#48889)
This fixes ansible/ansible#issues/48832
6 years ago
Felix Fontein 1e0ab16247 Add basic unit tests for module_utils/acme.py. (#49103) 6 years ago
Alan Rominger 729c3a6767 Fix error where pod has error and no containers (#49154)
k8s: Fix error where pod has error and no containers
6 years ago
Dusan Matejka 7190c73d50 zabbix_hostmacro: Fixed support for LLD type user macros and added missing validate_certs attribute (#48730) 6 years ago
Felix Fontein b842b1b97e ACME: improve error handling (#49266)
* Improve error handling: when parse_json_result is False, still return the error message.

* Remove content body from info dict.

* Add changelog.
6 years ago
Ganesh Nalawade 829fc0feda
Fix iosxr netconf plugin response namespace (#49238)
* Fix iosxr netconf plugin response namespace

*  iosxr netconf plugin removes namespace by default
   for all the responses as parsing of xml is easier
   without namepsace in iosxr module. However to validate
   the response received from device against yang model requires
   namespace to be present in resposne.
*  Add a parameter in iosxr netconf plugin to control if namespace
   should be removed from response or not.

* Fix CI issues

* Fix review comment
6 years ago
Olivier BLIN c51407c806 Fix nxos modules idempotence issue (#46437)
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution
6 years ago
Mike Wiebe af1e6878e9 Fix n3k power supply facts (#49150) 6 years ago
Yunge Zhu ecd995496c new module: azure_rm_rediscache (#47914)
* add new redis cache module

* fix version

* fix lint
6 years ago
Sandra McCann 13a6b4a856 Gather subset fix (#49264)
*  reword subset description for ios_facts
6 years ago
vmpr 46a3c0cf2e changed documented default value for url (#49097)
the Default Value for url is 3000, so there was a mistake in the documentation
6 years ago
Chris Archibald 6dc6538eef Bug fixes for na_ontap_fcp (#48583) 6 years ago
Selivanov Pavel 0b380b09bf ec2_instance_facts.py: documentation: add example (#49010)
Add an example of using multiple states for instance-state-name in filters. Not obvious how it works until you try.
6 years ago
Pierre Allix 965dec6a9a Clarify volume unit in the ec2_vol module (#49242)
"GiB" is more appropriate than "GB" since the volume size in AWS is
expressed in gibibytes.
6 years ago
Adam Miller 81540bd754 require git when trying to use it in ansible-galaxy cli (#49212)
* require git when trying to use it in ansible-galaxy cli

Previously we weren't setting `required=True` when calling
`get_bin_path` and the path would return `None`, this would cause
a traceback when attempting to ' '.join() to create a string
representation of the failed command for error output

Fixes #49200

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Anil Kumar Muraleedharan 7a81d859c5 Refactoring cnos_vlan in line with ios, eos etc. (#48924)
* Refactoring cnos_vlan in line with ios, eos etc.
6 years ago
Michael Brennan ca918def18 fixed parsing issue with openstacksdk and idempotent checking issues (#44928)
* fixed parsing issue with openstacksdk and idempotent checking issues

* fixed whitespace found in pylint
6 years ago
Abhijeet Kasurde bc3e7bbeba
E325 Removal - Part II (#49196)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Sumit Jaiswal 991a9dfa12
PR to support commit check to confirm commits with JunOS (#49054)
* commit check support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed review comments

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed review comments

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
6 years ago
Matt Clay 8987a647e3 Remove commented out author to attempt bot fix. 6 years ago
Matt Clay aaf1e459e7 Fix author in azure_rm_virtualnetworkpeering. 6 years ago
Abhijeet Kasurde 7ac47bd600
Fix author GitHub id (#49228)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Mike Wiebe 374ca783bb nxos_logging message fix (#49205)
* nxos_logging message fix

* Remove rescue in block
6 years ago
Yunge Zhu dc871bd493
add module azure_rm_virtualnetworkpeering (#47045) 6 years ago
Jordan Borean 098b18e846
win basic - fix issue when serializing PSObjects in result (#48860) 6 years ago
Yunge Zhu e0af9b2ce0 new module cdnendpoint (#46796)
* new module cdnendpoint
6 years ago
jokurz 6404c6484c Fix fact ansible_distribution_version for AIX (#48570)
* Fix fact ansible_distribution_version for AIX

* aix_facts: Check oslevel output
6 years ago
Brian Coca ae2467ddbc Merge pull request #49080 from bcoca/better_invp_skip
more precise pluing skip msg and now in higher verbosity level
6 years ago
tomasg2012 07895538b5 Changes to redfish-based parameters (#48717)
* Changes to redfish-based parameters

Corrected (potentially) small scope variable to 'id'

Review to see if this is problematic

* Updated doc information with "version_added"

* Corrected 'username' in redfish_config file
6 years ago
Vinay Dandekar ff9b86f560 Revert back to getting the AWS role name from the URI with a small change (#49113)
- The role name and instance profile name _can_ be different
- Change the delimiter to `:` for keys that are discovered through the JSON parsing (which is not a valid delimiter for AWS IAM role names), this delimiter is still converted to underscore
- Now checks for the existence of that delimiter to remove the cases where the JSON keys are appended to the role name to find the role name
6 years ago
Adilio 3cbb66dd53 Updated example in include_role.py
<!--- Updated example text from with_items to loop -->

+label: docsite_pr
6 years ago
Sam Doran 5eb7f5781e
Reboot - Fix errors when using Paramiko connection (#49002)
Different connection plugins return different data when throwing exceptions. The Paramiko connection plugin does not return a text sting, which caused an exception.

The ssh connection plugin returns multi-line errors, which makes the debug logs harder to read. Only return the last line in that case in order to make the logs more readable.

When experiencing a connection failure, reset the connection.

Add reset() to paramiko_ssh

Indicate thet conection state is False when running close(). This is needed by the ensure_connected() decorator to work properly.


Co-authored-by: Matt Martz <matt@sivel.net>
6 years ago
Martin Krizek d4568d97d4 Fix using vault encrypted data with jinja2_native (#49025)
Fixes #48950
6 years ago
Lars Kellogg-Stedman bafc1f8a41 fix constructed functionality in openstack inventory plugin (#48833)
* test for openstack inventory constructed functionality

this adds unit tests for the compose, groups, and keyed_var features
of the openstack inventory plugin

* fix constructed functionality in openstack inventory plugin

The compose, groups, and keyed_groups functionality of the openstack
inventory plugin was broken:

- the plugin was not passing the correct variables to the
  Constructable methods for compose and groups
- the plugin was simply never calling the appropriate method for
  implementing keyed_groups

This commit fixes both issues.
6 years ago
Martin Krizek abdf46803b
Warn about falling back to jinja2_native=false (#49063) 6 years ago
Bob Vincent 67a70a1205 Improve docs for umask option of pip module. (#49146)
* Improve docs for umask option of pip module; umask should be specified as an octal *string*, not an octal (or decimal) *integer*.
6 years ago
Abhijeet Kasurde 9b732df436
E325 removal - Part I (#49136)
Remove E325 from Amazon modules

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
tchernomax d14dee9ceb pacman: if 'upgrade' is used, 'name' isn't apply (#48854)
fix #31713
6 years ago
AlexZolotarenko 91b7bee3da -'templateLinkage' set to match Zabbix web interface defaults (#45229) 6 years ago
seag-rvc 3acc71225a Update tower_host.py (#49186)
<!--- Your description here -->
Current example does not show how to declare variables
+label: docsite_pr
6 years ago
Tim Rupp 0b5b5e69d8
Adds hasattr checks for rpc calls used in network_cli plugins (#49173)
Network platforms that don't have cliconf plugin will fail when
sending rpc calls for the reset_history and disable_response_logging
functions because those are defined in cliconf exclusively at this
time.

This patch adds checks for those attributes before making the call
6 years ago
Trishna Guha 8796085569
nxos_facts fix NameError (#48981)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
6 years ago
Jonathan Hanson 12a573a7db Fix type in ansible-galaxy info output (#49096)
Changed from 'intalled_version' to 'installed_version'
6 years ago
Matt Davis 8c1f701e6e
split PS wrapper and payload (CVE-2018-16859) (#49142)
* prevent scriptblock logging from logging payload contents
* added tests to verify no payload contents in PS Operational event log
* fix script action to send split-aware wrapper
* fix CLIXML error parser (return to -EncodedCommand exposed problems with it)
6 years ago
ivovangeel e7104a445b Fix incorrect 'installed' status setting in dnf.py (#48931) 6 years ago
Brian Coca 89b7e10436 updated var docs (#48957)
* updates var docs, fixes #48949

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
6 years ago
Bernardo Vieira da Silva 26a677c2a9 Update git example (#49098)
* Update git example

* set correct url format for ssh
6 years ago
Alicia Cozine e42fb44995 adds hint about simplestreams protocol (#48959) 6 years ago
ikanobori 7740778d85 correct message to have consistent pluralisation (#36897) 6 years ago
Gregor Riepl 02893520a9 Cloudstack: Add password reset module (#47931) 6 years ago
Martin Krizek 48ffd8789f
Properly handle FieldAttribute.default if callable (#48992)
* Properly handle FieldAttribute.default if callable

Fixes #48673

* Add changelog...

* Add integration test

* Add aliases file
6 years ago
Zhikang Zhang 93c5781f61 pip: Fix the mistake replacement from 'distribute' to 'setuptools' (#47403)
* Fix the mistake replace from distribute to setuptools

* Add a testcase for this bug
6 years ago
Felix Fontein 3a9eadb22f Updating argument_spec for type='list' options by elements value. (#48485) 6 years ago
Christian Kotte 1ed9e72dc3 Improve vmware_portgroup_facts module (#47357) 6 years ago
Felix Fontein be55abafe1 Mention docker[tls]. (#49095) 6 years ago
Felix Fontein 9caaf7b109 docker_container: fix init option idempotency with old docker-py versions (#49078)
* Don't check options for idempotency which are not supported.

This check should be superfluous if every option would adhere to
the convention that options not specified should have value None.
Unfortunately, some options (such as init) which correspond to
container properties have an explicit default set.
6 years ago
Felix Fontein 35049a148a Don't jsonify after and before on diff return. (#49092) 6 years ago
Abhijeet Kasurde 70f992c618
wait_for: Add note about path and port (#48930)
Path and Port are mutually exclusive parameters but not documented.
This fix documents this requirement.

Fixes: #15732

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Hideki Saito 731bf1b11d Fix issue #39412 (#39483)
* postgresql_db dump does not fail on FATAL error when using compression
6 years ago
Varun Chopra 90c3337316 Add win_partition (#46292)
* Added win_partition module

* Fixes sanity tests

* Requested changes minus changes in partition_size

* Removed trailing whitespace and fixed docstring

* Changes to parititon_size to allow variable units

* Stricter regex for partition_size
6 years ago
Jens Stark 8f449eec64 Updated help to list all features (#48875)
* Updated help to list all features

just to avoid searching powershell syntax Get-WindowsFeature

+label: docsite_pr

* added Linebreak

added Linebreak

* removed trailing whitespace

removed trailing whitespace

* slight modification of text
6 years ago
John R Barker ba3f512d8a updated version_added 6 years ago
Derek Ditch 29041f89e2 Removed choices for boolean options, as requested 6 years ago
Derek Ditch 48c5930836 Adds support for proxy authentication and repoview enablement. 6 years ago
Julian Kornberger 859b6a6526 Fix virt role detection for Hetzner cloud servers (#42023)
See also https://wiki.hetzner.de/index.php/CloudServer/en
6 years ago
Romain Acciari 4b1b0bcbb6 Add filters to os_router and os_subnet Fixes #37921 (#47220) 6 years ago
Tad Merchant 4b2356ff55 Ecs service force new deployment (#47983)
* Support UpdateService forceNewDeployment in ecs_service module

* Force update to be called if force_new_deployment set

* Fixes for review

* Add force_new_deployment option to ecs_service.py

cherrypicks changes from via/ansible
Adds tests for pull request #42518
fixes backwards compatability with boto<1.8.4

* change version_added to 2.8 for force_new_deployment

* remove extra lines from test

* remove more unnecessary whitespace
6 years ago
kcd83 3143abc8dc ec2_metadata_facts: Handle missing identity_document_region (#49040)
* Handle missing identity_document_region

* Fix indentation size to match standard
6 years ago
Michael Rose 1eed8900ed influxdb_user: Fixed default password behavior (#47040) 6 years ago
Josue David Hernandez 8880c72682 Adding support for clearlinux showing release nuber (#47101)
Signed-off-by: Josue David Hernandez <josue.d.hernandez.gutierrez@intel.com>
6 years ago
Arnaud Venturi ad1180b22f Replace some likely forgotten `yum` by `dnf` (#48988)
I'm not 100% certain this change is relevant for the filename, but it would make sense, so I'll let you confirm.

+label: docsite_pr
6 years ago
Christopher Brown 7f7062580e Update docs with rhsm note (#48928)
* Update docs with rhsm note

redhat_subscription is the module for handling registration of modern Red Hat systems. This commit adds a note indicating that unless people are using RHEL 5 etc, they probably want that module instead.

+label: docsite_pr

* Make redhat_subscription a link to the module docs
6 years ago
René Moser 3554c59c9f cs_instance: fix typos in defaults for ip/ip6_ipaddress (#49064) 6 years ago
Zeng Jie a9c2bc955c Fix dictionary iteration exception reported in #48096 (#48836) 6 years ago
Felix Fontein de1c9c53c3 update value in acme_certificate route53 example
fixes #49032

Co-Authored-By: endorama <endorama@users.noreply.github.com>
6 years ago
Edoardo T b30d2ce9e5 add state parameter to route53 module
<!--- Your description here -->

route53 module state parameter is required (https://docs.ansible.com/ansible/latest/modules/route53_module.html#parameters), so the example is not working out of the box in ansible.

Required state parameters has been introduced in commit 698fa37a44 (698fa37a44)

+label: docsite_pr
6 years ago
Stefan Horning c3b059d61c Ecs service module health check settings (#47217)
* Added feature health_check_grace_period_seconds to ecs_service, this time with a botocore version check and some initial testing

* Only set health_check_grace_period_seconds when loadbalancers are defined

* Removed leftover commas and fix in test

* Removed blank line

* Minor improvements for ecs_service module

* Removed default (30) for health_check_grace_period_seconds param

* Changed botocore version allowed to 1.8.20 for health check param.

* Fix empty healthcheck failure
6 years ago
Paul Neumann 2019f0e430 nxos_facts: Do not gather redundant neighbor data (#49024)
* nxos_facts: Remove dead code

The commit e51964e made this redundant as the structured case is handled
elsewhere.

* nxos_facts: Do not gather neighbors redundantly

LLDP reports the neighbor using the abbreviated interface name, whereas
CDP reports the neighbor using the full interface name. Normalize the
local interface name in the LLDP case, so there is no redundant
information. Due to the order of the gathering, CDP neighbors are saved
in case both LLDP and CDP data is available on a certain interface.
6 years ago
Yunge Zhu 729d094a72 use explict conversion instead of as_dict (#49046)
* use explict conversion instead of as_dict

* fix typo
6 years ago
Yunge Zhu 438bd35729 fix keyvault doc (#49045) 6 years ago
Will Thames 31ccb3c29d Diff mode returns yaml diffs in yaml callback plugin (#48794)
* Diff mode returns yaml diffs in yaml callback plugin

* Add changelog for yaml diff mode
6 years ago
Benoît Knecht e39fbb9db4 modules: github_release: support anonymous access (#47817)
Releases can be listed without logging in for public projects, so allow
`github_release` to be called without `token` or `password`.

Signed-off-by: Benoît Knecht <benoit.knecht@fsfe.org>
6 years ago
Abhijeet Kasurde 69191b10c1 Remove unused import (#48639)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Adam Chalkley 685ea357f9 counter_enabled.py - Fix minor typos (#49014) 6 years ago
Devyani Kota 363ec65062 Fixes #38174: Add remove-brick operation for gluster_volume (#38269)
* Fixes #38174: Add remove-brick operation for gluster_volume

Existing gluster_volume module does not support removal of bricks
from a gluster volume. Also, operation remove-brick needs to be
followed by a commit operation.

Signed-off-by: Devyani Kota <dkota@redhat.com>

* Updates #38174: Add documentation for remove-brick operation

Signed-off-by: Devyani Kota <dkota@redhat.com>

* Updates #38174: Add support to reduce cluster configuration.

An exceptional scenario exists where the user might want to
reduce the gluster cluster configuration for replicated
volumes from replica 3 to replica 2 that need to be handled
in a different manner than the generic gluster commands,
where the user is expected to mention the replica count
of the new configuration in order to remove the bricks.

Signed-off-by: Devyani Kota <dkota@redhat.com>

* Updates #38174: Add checks for self-heal status prior remove operation.

While reducing the cluster configuration from replica 3
to 2, it needs to be checked for status of self-heal
prior remove-brick operation is executed.

Signed-off-by: Devyani Kota <dkota@redhat.com>
6 years ago
Will Thames 960ebd981f k8s append_hash (#48830)
* Add append_hash functionality to k8s module

append_hash adds a hash based on the contents of a ConfigMap
or Secret to the name - this enables immutable ConfigMaps and
Secrets.

* Provide k8s_config_resource_name plugin

The k8s_config_resource_name filter plugin provides a means of determining
the name of ConfigMaps and Secrets created with append_hash

* Add changelog fragment

* fix failing tests

* Update openshift version needed for append_hash
6 years ago
Jordan Borean c3770bf6f2
win_mapped_drive: removed docs around a system wide mount (#49017) 6 years ago
nesanton 14612db43f Ovirt: fixes #41592, #34559 (#41622)
* autostart cannot be used with command=define

autostart cannot be used with command=define. If it's used with state, it'll be silently ignored.
https://github.com/ansible/ansible/issues/41592

* guest name should not be used with xml

When both ```name``` and ```xml``` are specified, there might be a mismatch of domain names in
```name``` and inside ```xml```.

* Improved error handling and param deps for autostart-only tasks.
Standalone autostart tasks depend on ```name``` and need the domain to be present.

* Added handling of errors thrown by libvirt

* Updates to documentstion and examples

* Removed required flag from name. Added description on some option combinations.
Added a few examples.

* lint issues

* docs: note that name is optional

* Removing required from documentation of name parameter

* extra text to make clearer when name is required

* When defining a domain with xml, its name is taken directly from the xml definition.

This reverts commit 4ac14a622b.
6 years ago
Jordan Borean a568bbed3c
win_mapped_drive - refactor module and docs (#48642)
* win_mapped_drive - refactor module and docs

* Updated code to work with become and split tokens

* use win_credential_manager instead of cmdkey

* updated credential manager module name

* harden the system token impersonation process
6 years ago
Jordan Borean 8e92cca139
win_credential: new module to manage credentials (#48840)
* win_credential_manager: new module to manage credentials

* fix sanity issues and removed CredSSP references

* renamed module to win_credential

* fix typo on test variable

* fix sanity ignore line
6 years ago
Michael Cassaniti 10af3874b5 win_snmp: Initial commit (#45710)
* win_snmp: Initial commit

* win_snmp: Better handling of lists

* win_snmp: Documentation fixes

* win_snmp: Updated documentation to match parameters

* win_snmp: Added integration tests

* win_snmp: Fixed typo in test

* win_snmp: Adjusted parameter checks to match documentation

* win_snmp: Updated option descriptions to be full sentences

* win_snmp: Better type checking and output suppression

* win_snmp: Fixed unset managers and communities

* win_snmp: Fixed skipping default registry keys

* win_snmp: Migrated to using add/set/remove action from replace

* win_snmp: Fixed check mode

* win_snmp: Fixed setting action and documentation. Expanded tests.

* win_snmp: Efficiency changes and documentation cleanup
  * Added example of explicitly setting an empty set of managers to
documentation
  * Made sure set will only remove items if there is a list of items
provided. This list can be of length 0
  * Improved efficiency in selecting next index for SNMP manager
  * Updated tests

* win_snmp: Added output of permitted managers and community strings

* win_snmp: Documentation fix
6 years ago
John R Barker 75407d3e43
Validate DOCUMENTATION.author (#48993)
* Validate DOCUMENTATION.author

Ensure that author line includes a GitHub account
6 years ago
Diane Wang 9b44109ba3 Fix pr44962 add check before hot add cpu or memory (#48289) 6 years ago
John R Barker 8f41270a01
Bulk fix DOCUMENTATION.author (Part 3) (#48990) 6 years ago
Rémy Léone 959395f4b4 Fix getheaders regression with open_url in Scaleway dynamic inventory (#48671)
* Fix regression

* Improve changelog fragment
6 years ago
abarbare 70fff13a6e feat: meaningful error message scaleway image not found (#48829) 6 years ago
John R Barker 97e2fa4953
Bulk module author 2 (#48955)
* Bulk fix DOCUMENTATION.author (Part 2)
6 years ago
Christian Kotte 3f6878ac84 VMware: New module vmware_dvswitch_lacp (#48555) 6 years ago
ftntcorecse fb7b6f9521 Fortinet FortiManager Device Add Module (#45954)
* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_fwobj_address PR candidate

* Grammar

* grammar changes

* pylint changes

* Fixing Authors
6 years ago
ftntcorecse 050a2c51dd Fortinet FortiManager Device Config Module (#46080)
* fmgr_device_config PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* Resolving Edits

* Resolving Edits

* Fixing Authors
6 years ago
ftntcorecse 1da3c5c302 Fortinet FortiManager Firewall Objects - Addresses (#46084)
* fmgr_fwobj_address PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* PR candidate

* Adding requested changes by @samccann

* minor issue...

* minor pylint issue

* More changes from @samccann

* more grammar

* Author Mention Change

* Fixing Authors
6 years ago
ftntcorecse 86222fd4c4 Fortinet FortiManager HA Configuration Module (#46085)
* fmgr_ha PR candidate

* PR candidate

* PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Edits.

* Fixing Edits.

* Fixing Authors
6 years ago
Tim Rupp 212b48b6fd
Adds module to configure ldap device auth on a bigip (#48974) 6 years ago
ftntcorecse 44b20fbf96 Fortinet Firewall Object - Virtual IPs (#47637)
* PR Candidate

* PR Candidate - pylint fix

* PR Candidate minor pylint fix v2

* Fixed Odd type annotation -- needed double comments

* Missed one of the # type: comments in fixture...

* Fixing Edits. Nixing Stale CI Flag

* Fixing Edits.

* Fixed Authors -- Fixed Changes.

* Fixing pep8...

* Fixing a description
6 years ago
ftntcorecse 4862a4aeb4 FortiManager security profile group module (#46220)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
6 years ago
ftntcorecse 64c4881d58 FortiManager DNS security profile (#46239)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Initial commit for FMG DNS security profile

* Fixing pep8 line too long in unit test

* Removing excess modules and unit tests

* Fixing trailing white space for dns module

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
6 years ago
ftntcorecse 37e932c4ee Fortinet FortiManager IPv4 Policy Module (#47638)
* Needs unit test fix -- the "delete" calls a GET command and another function to get policy ID of a firewall policy before deleting it. Nested functions like this, where a GET occurs to determine a new call, breaks the unitTestGen output. Need to figure out what's going on, and adjust the generator.

* PR Candidate

* PR Candidate (fixes)

* Reverting

* Fixing Edits.

* Fixing Authors - Fixing Requested Changes
6 years ago
ftntcorecse 1f1c1a0a16 Fortinet FortiManager Query Module (#46716)
* PR Candidate

* Fixing Edits. nixing Stale CI flag.

* Update lib/ansible/modules/network/fortimanager/fmgr_query.py

Co-Authored-By: ftntcorecse <43451990+ftntcorecse@users.noreply.github.com>

* Fixing Edits. Nixing Stale CI Tags

* Fixing Edits.

* Fixing Authors
6 years ago
ftntcorecse d7e1e6429c FortiManager Web Application Firewall Security Profile (#46967)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
6 years ago
ftntcorecse a171b80a0c FortiManager Web Filter Security Profile (#47150)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Initial commit for fmgr web filter security profile

* Fixing pep8 syntax issues

* Fixing documentation yaml syntax errors with choices on new lines

* Fixing documentation yaml syntax errors, removing Todo comments

* Fixing choices additional tab

* Fixing choices on multiple lines

* Fixing choices on multiple lines

* Adding yaml block scalar for multiline choices

* Changing YAML syntax for multiline to YAML sequence for choices

* Fixing all sanity test errors

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
6 years ago
ftntcorecse 199cd1bc77 FortiManager SSL SSH Security Profiles (#47152)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Initial commit for fmgr web filter security profile

* Initial commit for SSL and SSH security profiles in FMG

* Fixing pep8 syntax issues

* Adding better playbook example

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
6 years ago
Tim Rupp cd02b3637c
Removes remaining nose usage from f5 unit tests (#48973) 6 years ago
Matt Martz 9773a1f289
Add a Singleton metaclass, use it with Display (#48935)
* Add a Singleton class, use it with Display

* update six import

* Move remaining failes to display singleton

* Fix rebase issues

* Singleton improvements

* Add code-smell for 'from __main__ import display'. ci_complete

* s/self/cls/g

* Add docs for no-main-display

* Address linting issues

* Add changelog fragment. ci_complete

* Implement reentrant lock for class instantiation in Singleton

* Add Display singleton porting guide
6 years ago
Sloane Hertel 54a2f21f93 Fix comparison of determining which rules to purge by ignoring descriptions (#48443)
AWS uses rule type, protocol, port range, and source as an idempotent identifier.
There can only be one rule with that unique combination. Rules that differ only by description are allowed but overwritten by AWS.
Add a test

Co-authored-by: Will Thames <will@thames.id.au>
6 years ago
Matt Martz 64bb54dab4 Catch per loop label templating exceptions. Fixes #48879 (#48896) 6 years ago
Lukas Grossar ba8a05daab fix typo in constants.py (#48877)
* CONTROLER_LANG => CONTROLLER_LANG
6 years ago
jpdasma a4ad59fdf6 user: Modify RBAC attributes for Illumos/Solaris based system (#48409) 6 years ago
Tim Rupp fb782fa3e9
Adds the bigip_password_policy module (#48951)
This module can be used to manage password policy settings on a BIG-IP
6 years ago
John R Barker 3fcc564bbb
Bulk fix DOCUMENTATION.author (Part 1) (#48934)
* Bulk fix DOCUMENTATION.author
6 years ago
Björn 9c71f176f3 Make wait_for return matched groups defined in search_regex. Closes #… (#47690)
* Make wait_for return matched groups defined in search_regex. Closes #25020.

* Fix formatting issues.

* Fix issues raised in review.

- Use output_dir instead of hardcoded /tmp for temp files
- Sleep for only 3s instead of 10s
- Revert indent change
6 years ago
Michael Rose 0886c20d19 influxdb_user - Allows updates to user privileges (#46667)
* influxdb_user - Allows updates to user privileges

* influxdb_user - Updated documentation for admin roles
6 years ago
Abhijeet Kasurde 08c3e0a248 route53_facts: Handle exception gracefully (#48801)
Handle exception in while querying hostzone details, for example
'NoSuchHostedZone' is raised when host zone id does not exists.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Abhijeet Kasurde a6fde8aef9 Add timeout information into async failure message
Add some extra information to an async failure message to reflect the
actually timeout value of the failure.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
6 years ago
David Soper 9f1b75db0e Ucs disk group policy (#43578)
* ucs_disk_group_policy module and integration tests

* Additional refactor based on review in other modules.

* Fix issue with automatic config and add virtual_drive config.
Integration tests added for automatic config and virtual_drive config.

* Code review updates (documentation items)

* update version added to 2.8
6 years ago
Abhijeet Kasurde 789b0ef0c9 Pass string command in run_command (#48805)
When there are spaces in command args passed as a list,
then run_command and underlying subprocess fails.
This can be overcome by passing command as string rather than list.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Mike Wiebe a721572206 Fix issues with nxos_os_install module (#48811)
* Use expect module to copy files

* Remove old and redundant upgrade files

* Return error message instead of code

* Cleanup copy command code

* Fix force issue in nxos_install_os

* new nxos_install_os integration tests

* Uncomment transport tests

* Revert negative test change

* Remove combined option that is no longer required

* Make shippable happy

* Add n5k test files
6 years ago
Tim Rupp 10095a397c
Adds the bigip_monitor_gateway_icmp module (#48915) 6 years ago
Tim Rupp fdbc0e5798
Adds the bigip_dns_cache_resolver module (#48914) 6 years ago
Jordan Borean e62edfc796
Ansible.Basic - fix deprecate return value (#48908) 6 years ago
Tim Rupp 8e6c3b06b8
Adds the ip_intelligence_policy parameter to vs module (#48903) 6 years ago
Tim Rupp 7546ebf08e
Make use of the bytes function that supports both py2 and 3 (#48904) 6 years ago
Jordan Borean 9b0dd5224b
win_security_policy - add warning when using this module ot edit rights (#48850) 6 years ago
Tim Rupp fdb5b124fd
Changes argspec to no longer enforce strict int (#48901)
The route domain parent can be a string instead of an int. this patch
chanes the argspec to allow this.
6 years ago
Tim Rupp 8d2beea1cf
Removes commented out code (#48902) 6 years ago
Tim Rupp e6d586f703
Change port to allow strings too (#48899)
The port technically supports an asterisk, but the argument spec was
requiring integers only.
6 years ago
Tim Rupp 03f448f329
Adds documentation to make note of tower/awx restrictions (#48900)
When using modules that download files, you need to be aware of tower/awx
restrictions to use those modules correctly.
6 years ago
Brian Coca 68301f890a fix cache 'update' method to be 'mapping' compatible
- also simplify the update functions
 - fix methods and allwow backwards compat with plugins overriding 'update'
6 years ago
Scott Barvick 0f0e976183 updated .decode('utf-8') to to_text() 6 years ago
Scott Barvick 1ff7b258f4 make compatible with both python 2 and 3 by setting the encoding 6 years ago
Adam Miller 41176b5e0f fix group-missing/invalid-group detection
Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Adam Miller 23b60035a1 fix up sanity tests and with_modules conditional
Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Adam Miller 4a06e95671 dnf to support modularity module appstream specs
Fixes #48743

Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Abhijeet Kasurde a32902427c linode_v4: correct usage of module.fail_json (#48882)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Brian Coca 652da82558 fix bug in config mgr
- use function that creates config slots as needed
6 years ago
Brian Coca 87e44a7ed1
better handling of bad type in config (#48821)
* better handling of bad type in config

 fixes #22468, fixes #22476
6 years ago
dionben a796299651 Added support for L2 external domain association (l2dom). (#48670)
* Added support for L2 external domain association (l2dom).

Added support for L2 external domain association (l2dom).

* Update lib/ansible/modules/network/aci/aci_epg_to_domain.py

* Fix a few small items, restore earlier changes

Performed the necessary updates to fix this PR.

* Fix spaces

* One more miss
6 years ago
Abhijeet Kasurde 2faddfc1fe Misc typo in msc_* modules (#48716)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
tchernomax 943edb3319 apt: add policy_rc_d option (#47191) 6 years ago
Chris Archibald 50808ffa8f Add common files for ONTAP and SOLIDFIRE unit tests (#48739)
* And unit test files

* Changes to netapp.py

* Matt's changed, and pep8 change for test_netapp.py
6 years ago
Maciej Delmanowski c7e2226035 Do not require TTY for 'apt-key' operations (#48580)
The 'gpg' command supports the '--no-tty' option, which disables any use
of a TTY during its execution. This parameter is sometimes required for
non-interactive operation to avoid any questions for the user.

The 'apt-key adv' command can pass additional parameters to the
underlying 'gpg' command. This patch adds the '--no-tty' option to avoid
issues with APT key imports when Ansible pipelining active, which
disables the use of a dedicated TTY.
6 years ago
duritong 475d69da69 Make puppet module useable on puppet 6 (#46044)
The unused ignorecache setting has been removed and so you
can't run puppet through this module anymore.

See PUP-8533 / https://tickets.puppetlabs.com/browse/PUP-8533
6 years ago
Pilou 7f98a8db12 BOTMETA.yml and module metadata: fix case authors (#46051)
* botmeta: fix GitHub ID case

* module authors: fix GitHub ID case

* replace CloudEngine-Ansible by submitter GitHub ID
6 years ago
Pit Kyzn c79a9e2287 add example for flusing [tables] chains (#48858)
<!--- Your description here -->
add examples for:
- iptables flush filter
- iptables flush nat
+label: docsite_pr
6 years ago
Felix Fontein 3bb41ccb8e docker_* tests: check API version (#48620)
* Check minimal API and docker-py versions for all docker_* tests.

* Improve docker_swarm creation/destruction for tests.

* Fail when conditions aren't met.

* Don't hardcode address for advertise_addr.
6 years ago
Felix Fontein 891687284f docker_* modules: improve diff (#48546)
* Add difference tracking tool

* Improve --diff mode for docker_container.

* Improve diffs of sets by ordering the sets.

* Rewrite imports, get rid of HAS_DOCKER_PY_x variables and use docker_version instead.

* Rename container -> active (more generic).

* Add --diff for docker_volume. Change old diff output.

* Add --diff for docker_network. Change old diff output.

* Add --diff for docker_swarm_service.

* Add changelog.

* Add entry for porting guide on docker_network and docker_volume.
6 years ago
Miguel Angel Muñoz González a67e9f89e7 Initial commit for fortios_firewall_policy (#48815) 6 years ago
Miguel Angel Muñoz González f775d3b3ea Initial commit for fortios_webfilter_ips_urlfilter_setting (#48806) 6 years ago
Miguel Angel Muñoz González 66ceea910a Initial commit for fortios_webfilter_ips_urlfilter_setting6 (#48807) 6 years ago
Miguel Angel Muñoz González 5c2ef75424 Initial commit for fortios_webfilter_ips_urlfilter_cache_setting (#48799) 6 years ago
Miguel Angel Muñoz González 6d0c770c8c Initial commit for fortios_webfilter_override (#48295) 6 years ago
Miguel Angel Muñoz González d25becb64e Initial commit for fortios_webfilter_ftgd_local_rating (#48293) 6 years ago
Miguel Angel Muñoz González bad16ed641 Initial commit for fortios_webfilter_ftgd_local_cat (#48181) 6 years ago
Miguel Angel Muñoz González f421212810 Initial commit for fortios_webfilter_profile (#48177) 6 years ago
Eric P 6800559d61 Fix a part of the example (#48851)
<!--- Your description here -->

+label: docsite_pr
6 years ago
Bojan Vitnik b0cc240665 New module: xenserver_guest - manages XenServer VMs (#41041)
* XenServer related modules - initial commit

 - New module_util: xenserver. Contains common module arguments, functions
   and classes useful for future XenServer related modules.
 - New module_docs_fragment: xenserver. Describes common module arguments.
 - New module: xenserver_guest. Supports VM deployment, reconfiguration,
   removal, detection of changes, state management, fact gathering and
   Ansible check mode. Module is fully documented.
 - Updated: developing_module_utilities.rst.
 - Module params, workflow and some functions are based on or taken from
   vmware_guest module.

* Implemented support for configuring custom VM params in xenserver_guest module

* Compatibility fixes and documentation update

 - xenserver module_util: implemented support for XenAPI.py version older
   than 7.2.
 - xenserver module_util: PEP8 fixes.
 - xenserver module_util: Added missing imports.
 - xenserver module_util: Copyright notice fixes.
 - xenserver_guest module: updated module documentation with notes regarding
   module requirements and compatibility.
 - xenserver_guest module: bumped version_added to 2.7.
 - xenserver_guest module: minor fixes.

* VM power state management refactoring, subargument specs in xenserver_guest module, other fixes

 - VM power state management code moved from xenserver_guest module to xenserver
   module_util (set_vm_power_state function).
 - Code for waiting for VM IP address moved from xenserver_guest module to
   xenserver module_util (wait_for_vm_ip_address function).
 - xenserver module_util: implemented get_object_ref function to clean up
   a lot of repeated code in xenserver_guest module.
 - xenserver module_util: added additional aliases 'host' and 'pool' for
   'hostname' common module argument. They are more in line with what
   XenServer users are familiar with.
 - xenserver module_util: minor fixes.
 - xenserver_guest module: removed VM state management other than 'present',
   'absent' and 'poweredon'. Other states are to be managed by separate module.
 - xenserver_guest module: added subargument specs and cleaned up custom code
   for subargument validation.
 - xenserver_guest module: reorganized code for disk and network reconfiguation
   to minimize code duplication.
 - xenserver_guest module: renamed 'cdrom.iso' module argument to
   'cdrom.iso_name', avoids cryptic error message when parameter is
   missing.
 - xenserver_guest module: documentation update.
 - xenserver_guest module: changes in error messages.
 - xenserver_guest module: minor fixes.

* Implemented guest OS network parameter configuration and other

 - xenserver module_util: moved code for validating MAC addresses from
   xenserver_guest module and implemented a range of functions for validating
   IP addresses and related entities and converting prefixes to netmasks and
   vice versa.
 - xenserver module_util: updated fact gathering code to support guest OS
   network parameters.
 - xenserver module_util: added docstrings.
 - xenserver module_util: minor changes.
 - xenserver_guest module: implemented support for guest OS network parameter
   configuration.
 - xenserver_guest module: changed CD-ROM handling code.
 - xenserver_guest module: changed so that user friendly version of changes
   list is always returned in module result.
 - xenserver_guest module: error message changes.
 - xenserver_guest module: added docstrings.
 - xenserver_guest module: documentation update.
 - xenserver_guest module: minor changes and fixes.

* Various fixes and code cleanup

 - xenserver module_util: implemented get_xenserver_version function.
 - xenserver module_util: moved customization agent detection code to
   gather_vm_params function. customization_agent variable is now part of
   vm_params. An exception in customization agent detection code that prevented
   deployment of new VMs is also fixed.
 - xenserver module_util: added support for alternative VM state names with
   dash and underscore in set_power_state function.
 - xenserver_guest module: removed customization agent detection code
   as it is now implemented in xenserver module_util.
 - xenserver_guest module: fixed a bug in xenserver_data update code that
   occured when "networks.mac" was not specified in module params and
   other fixes.
 - xenserver_guest module: some code cleanup.
 - xenserver_guest module: bumped version_added to 2.8.
6 years ago
Dag Wieers 5f6a350b3a Fix a possible issue with comparing values with $null (#37763)
This PR includes:
- Fix $null comparison.
- Simplify Get-AnsibleParam in the same effort
6 years ago
Dag Wieers f69e3e1cec win_get_url: Rewrite using AnsibleModule (#48390)
* win_get_url: Rewrite using AnsibleModule

* Fix sanity issue

* Implemented review suggestions

* Try something else

* fix circular dependency issues
6 years ago
jhawkesworth 361acd3547 win_say: Port to use CSharpUtil AnsibleBasic (#48361)
* port win-say to use CSharpUtil AnsibleBasic and add warning when requested voice not found

* win_say: fixes following code review: use C# style properties consistently; prefix changelog fragments

* fix invalid yaml in change log fragment

* win_say: fixes following code review: use generic module parameter validation where possible

* remove redundant setting of Result.changed to false, simplified some logic for readability.

* fix serialisation issue when message text is drawn from a file; allows tests to be run not in check mode and fix up some test descriptions
6 years ago
Anton Alekseyev 7eebec59b3 zabbix_map: Add module to create Zabbix maps based on data written in DOT language (#23026)
* Add zabbix_map module

* Fix PEP8 complainments

* Fix dict comprehension incompatible with python 2.6

* Support Zabbix 3.4 API changes

* Fix documentation

* Minor fixes

* Move zabbix_map to zabbix namespace

* Fix compatibility issue with Zabbix >= 3.4

* Support maps and triggers as map elements
6 years ago
Jordan Borean fd4b282f6f
Ansible.Basic.cs - fix check mode run with nested spec (#48838) 6 years ago
Susant Sahani 88dcb11695 nmcli: Introduce IPIP Tunnel (#45933)
This work enables to add ipip tunnel via nmcli module

```
  - nmcli:
       state: present
       type: ipip
       conn_name: ipip_test1
       autoconnect: yes
       ip_tunnel_dev: enp0s8
       ip_tunnel_local: 192.168.1.2
       ip_tunnel_remote: 192.168.1.5
```

version2: Added tests
Signed-off-by: Susant Sahani <susant@redhat.com>

Rebase
6 years ago
Tim Rupp a4921cd5d9
Removes more f5-sdk references from f5 modules (#48771) 6 years ago
Dag Wieers 9436ce5d85
win_wait_for_process: Rewrite using AnsibleModule (#48388)
* win_wait_for_process: Rewrite using AnsibleModule

* Add mutually_exclusive and required_one_of
6 years ago
Matthew Hellmer 854e607535 Update win_wait_for_process.py (#48816)
<!--- Your description here -->
Corrected pattern example.
+label: docsite_pr
6 years ago
Tim Rupp 9af5724bd4
Remove the f5-sdk from bigip_remote_syslog (#48539) 6 years ago
Pilou 5271f771f0 YAML inventory doc: add info about 'all' group, remove unused option (#25408)
* YAML inventory: add note about 'all' group, update
6 years ago
Tim Rupp dd2629ff0b
Adds new module for gtm topology records (#48817) 6 years ago
tchernomax bf2ef364b7 pacman: add & deprecate options (#30482)
Add:

 * extra_args
 * update_cache_extra_args
 * upgrade_extra_args

which add flexibility.

Deprecate `recurse` which is redundant with extra_args.

`force` is also redundant but is kept for module ergonomics.
6 years ago
Tim Rupp 0e1dca6e8f
Adds the bigip_imish_config module. (#48779)
This can be used to manage bgp configuration on a BIG-IP.
6 years ago
Martin Krizek 86be056633 inventory: fix hostname check (#48789) 6 years ago
David Soper 62b165c8d3 UCS managed objects module for direct control of any object (#44470)
* UCS managed objects module for direct control of any object and properties.

* Avoid checks for parent info or passwords in property compares

* Planned for 2.8

* try except for imports
6 years ago
Will Thames aaf29c785f Provide Kubernetes resource validation to k8s module (#43352)
* Provide Kubernetes resource validation to k8s module

Use kubernetes-validate to validate Kubernetes resource
definitions against the published schema

* Additional tests for kubernetes-validate

* Improve k8s error messages on exceptions

Parse the response body for the message rather than returning
a JSON blob

If we've validated and there are warnings, return those too - they
can be more helpful

```
"msg": "Failed to patch object: {\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},
       \"status\":\"Failure\",\"message\":\"[pos 334]: json: decNum: got first char 'h'\",\"code\":500}\n",
```
vs
```
"msg": "Failed to patch object: [pos 334]: json: decNum: got first char 'h'\nresource
        validation error at spec.replicas: 'hello' is not of type u'integer'",
```

* Update versions used

In particular openshift/origin:3.9.0

* Add changelog for k8s validate change
6 years ago
lwm ae0054a79e Add new linode_v4 module. (#46151)
Refs:
  * https://github.com/ansible/ansible/issues/36348
  * https://github.com/ansible/ansible/pull/41875
6 years ago
Anton Nikulin 9770ac70f9 FTD modules: upsert functionality and bug fixes (#47747)
* FTD modules: bug fixes and upsert functionality

* Fix sanity checks

* Fix unit tests for Python 2.6

* Log status code for login/logout

* Use string formatting in logging
6 years ago
Felix Fontein ce3a9cfae5 Only pass ipam parameter to create_network() if needed. (#48735) 6 years ago
Tim Rupp f8f2746efc
Adds a series of new parameters to bigip_virtual_server (#48777) 6 years ago
Tim Rupp 04520361ac
Fixes the changing of the root password so it is no longer logged (#48774) 6 years ago
Tim Rupp 2cd4224fb3
Fixes ipv6 and defaults errors (#48776) 6 years ago
Dan 01b06dd5f2 Added track option for nxos_static_route module (#48710) 6 years ago
Tim Rupp 4f80c45c51
Adds revoke functionality to device license (#48772) 6 years ago