Commit Graph

45322 Commits (73b2199fa28fa68bcf3c514f3b30da579af7c14b)
 

Author SHA1 Message Date
Matt Clay 73b2199fa2
[stable-2.8] [stable-2.9] [stable-2.10] Fix ansible-test handling of user-defined docker networks. (#72256) (#72310)
* Fix ansible-test docker container detection.

* Attach test containers to the correct network.

* Do not assume `localhost` for accesing Docker.

* Look for containers on current network.

* Always map /var/run/docker.sock into containers.

This fixes issues when using a remote Docker host.

* Support container IP lookup from networks list.

* Fix container network attachment.

* Remove redundant container detection messages.

* Limit DOCKER_HOST parsing to TCP.

* Restore docker socket existence check.

The check is skipped if the docker hostname is not localhost.

* Correct changelog entry..
(cherry picked from commit 3c2e8b99be)

Co-authored-by: Matt Clay <mclay@redhat.com>.
(cherry picked from commit 6362232c30)

Co-authored-by: Matt Clay <mclay@redhat.com>.
(cherry picked from commit 7c83f1f045)

Co-authored-by: Matt Clay <mclay@redhat.com>
5 years ago
Matt Clay d86d4285e1
CI stability updates. (#72307)
* Avoid issues with user-defined docker networks.
* Increase CI timeout.
* Increase unit test timeout.
5 years ago
Matt Clay 785fa40dc5 [stable-2.8] Fix ansible-test Azure Pipelines container auth.
(cherry picked from commit 2ef4b7e07e)

Co-authored-by: Matt Clay <matt@mystile.com>
5 years ago
Abhijeet Kasurde 2faf48f5f9
[2.8] kubectl: Follow up fix in connection plugin (#72131)
PR #71535 broke, _build_exec_cmd API in kubectl connection
plugin.

Fixes: #72171

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Rick Elrod 527dfa368a Update Ansible release version to v2.8.16.post0. 5 years ago
Rick Elrod 4b9308bd29 New release v2.8.16 5 years ago
Rick Elrod f66f05f4bb
[tests] Try re-enabling hcloud (#72034)
Change:
- See if they have fixed their issues yet.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Rick Elrod b926f73309
[tests] --no-use-pep517 in kubevirt_conformance (#72016)
Change:
- This enables the inventory_kubevirt_conformance test to pass again on
  freebsd.
- This was due to a google-auth version bump. The dep chain looks like
  this: openshift -> kubernetes -> google-auth -> aiohttp -> multidict

Test Plan:
- ansible-test integration inventory_kubevirt_conformance --remote
  freebsd/12.0

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Matt Clay aac6ed13e6 [stable-2.8] Disabled inconsistent pylint checks..
(cherry picked from commit 8152d8bc1a)

Co-authored-by: Matt Clay <matt@mystile.com>
5 years ago
Rick Elrod 1781285ceb Update Ansible release version to v2.8.16rc1.post0. 5 years ago
Rick Elrod d2f85078b1 New release v2.8.16rc1 5 years ago
Rick Elrod ed4db892d3
add CVE ref to kubectl changelog fragment (#71985)
Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Matt Clay b8f6c2d4b9
[stable-2.8] CI provider fixes for ansible-test. (#71929) (#71934)
* Make Azure Pipelines resource_prefix lowercase.

* Make classification of CI files consistent.

* Update package-data sanity test for AZP..
(cherry picked from commit 92b66e3e31)

Co-authored-by: Matt Clay <mclay@redhat.com>
5 years ago
Rick Elrod 15fe8c0239
[2.9] kubectl: redacted token and password from console log (#71971)
** SECURITY_FIX ** for CVE-2020-1753

kubectl connection plugin now redact kubectl_token and
kubectl_password from console log.

Fixes: ansible-collections/community.kubernetes#65

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Rick Elrod f3d3c43c00 [tests] disable hcloud for now
Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Rick Elrod 97c4064b87 [2.8] [tests] uninstall docker stuff for podman
Change:
- This isn't a direct backport of #71949 because in stable-2.8,
  setup_docker doesn't use handlers like more modern branches to clean
  up after itself.
- Instead, here we just make sure the docker packages are gone before
  the podman test runs.

Test Plan:
- CI
- ci_complete

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Sandra McCann 2953544616
[backport][2.8] remove github link from plugins (#70951) (#71915)
* remove github link from plugins (#70951)

(cherry picked from commit e28b20d729)

* remove cli section
5 years ago
Felix Fontein 67cd27400a
[2.9] Redirect inventory script links (#71732) (#71862)
(cherry picked from commit ef5f2c35ee)
5 years ago
Rick Elrod 4616b3bbac
[incidental_setup_docker] changes to upstream repo (#71897) (#71901)
Change:
- The docker-ce.repo file for centos does not work on RHEL since it uses
  $releasever and on RHEL that is, e.g., "7Server".
- Instead, set up the repo manually.
- Additionally, the docker centos8 repo no longer has old versions, so
  we use the (only) version in the repo instead.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 31ddca4c0d)
(cherry picked from commit 651c0a2d03)
5 years ago
Sandra McCann 8ceb36098d
update version switcher for 2.10 release (#71869)
(cherry picked from commit bf4e102d97)
5 years ago
Matt Clay e35aafa81c [stable-2.8] Fix attribute testing in file integration test. (#71843)
The file test will no longer attempt to test attributes if `lsattr -vd` does not work on the system under test.
(cherry picked from commit 17765cd4e8)

Co-authored-by: Matt Clay <mclay@redhat.com>
5 years ago
Sam Doran caf82158d0 [stable-2.8] openssl_privatekey test - Add pause for macOS
The stat time granularity on macOS is one second. We recently upgraded
to faster macOS hosts, so some tests that run closely together to see if
something changed will have the same timestamp intermittently.
5 years ago
Sam Doran 81f660f606 [stable-2.8] incidental_setup_openssl - Pin version of Python packages
A recent update to cffi that was yanked is still being installed on our
Mac OS X 10.11 test image since the version of pip there is very old and
does not ignore yanked packages.

Pin the version of pyOpenSSL and its dependencies to fix this and avoid
future spontaneous failures..
(cherry picked from commit 65cdb86c8a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
5 years ago
Timothy Visser 9a5999aa7e
Backport documentation correction (#71633)
* Remove "mode: preserve" option from documentation #71486

(cherry picked from commit 7127d37466)
5 years ago
Matt Clay 909ac41247
[stable-2.8] Backport ansible-test CI provider support. (#71625)
* Add types.py from devel to support backport.

* [stable-2.9] Backport ansible-test CI provider support. (#71614)

* Add encoding.py from devel to support backports.

* Add io.py from devel to support backports.

* Update ansible-test support for CI providers. (#69522)

Refactored CI provider code to simplify multiple provider support and addition of new providers.

(cherry picked from commit d8e0aadc0d)

* Add Shippable request signing to ansible-test. (#69526)

(cherry picked from commit e7c2eb519b)

* ansible-test local change detection: use --base-branch if specified (#69508)

(cherry picked from commit 43acd61901)

* Add Azure Pipelines support to ansible-test.

(cherry picked from commit 8ffaed00f8)

* Update ansible-test remote endpoint handling. (#71413)

* Request ansible-core-ci resources by provider.
* Remove obsolete us-east-2 CI endpoint.
* Add new --remote-endpoint option.
* Add warning for --remote-aws-region option.
* Update service endpoints.
* Allow non-standard remote stages.
* Add changelog fragment.

(cherry picked from commit d099591964)

* Fix ansible-test coverage traceback. (#71446)

* Add integration test for ansible-test coverage.

* Fix ansible-test coverage traceback.

* Fix coverage reporting on Python 2.6.

(cherry picked from commit f5b6df14ab)

* Use new endpoint for Parallels based instances.

(cherry picked from commit 98febab975)

* Add pause to avoid same mtime in test.

(cherry picked from commit 3d769f3a76)

Co-authored-by: Felix Fontein <felix@fontein.de>

(cherry picked from commit 417e408f59)
5 years ago
Rick Elrod 04ff489698 Update Ansible release version to v2.8.15.post0. 5 years ago
Rick Elrod 01d9ef008b New release v2.8.15 5 years ago
Rick Elrod 83eda14330
[tests] fix fallout from dnf gpg fix (#71550)
Change:
- Missed needed gpg ignores

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Rick Elrod 69827e0894
Re-add changelogs and add docs for CVE-2020-1736 reverts [2.8] (#71516)
Signed-off-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Sam Doran <sdoran@redhat.com>
5 years ago
Sam Doran a0ddefde38
Fix inventory_kubevirt_conformance test (#71545) 5 years ago
Rick Elrod 1fa2d5fd6b
[dnf] ensure packages are gpg-verified (#71541)
Change:
- By default the dnf API does not gpg-verify packages. This is a feature
  that is executed in its CLI code. It never made it into Ansible's
  usage of the API, so packages were previously not verified.
- This fixes CVE-2020-14365.

Test Plan:
- New integration tests

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Sandra McCann 53be4cc03d
point all older release pages to devel (#71428) (#71471)
(cherry picked from commit 3be597419d)
5 years ago
Rick Elrod 555b1fdd7a
tests: Use `hg serve` instead of bitbucket for hg (#71403)
Change:
- Uses `hg serve` instead of a bitbucket repo for hg tests
- bitbucket no longer serves hg

Backport of #71398

Test Plan:
- CI, fixed integration tests

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Matt Clay eddb0920e4 Revert "[stable-2.8] Cap pytest version to avoid relative import issue."
This reverts commit 9c5663699f.
6 years ago
Sam Doran c6eff6bdb2
Revert "[stable-2.8] Change default file permissions so they are not world readable (#70221) (#70827)" (#71233)
This reverts commit 11738aed97.
6 years ago
Rick Elrod 8ba8a41b95 Update Ansible release version to v2.8.14.post0. 6 years ago
Rick Elrod c404bd75ff New release v2.8.14 6 years ago
Rick Elrod eb1114a1b1
[tests] pin docker to <4.3.0 (#71193)
Change:
- New python docker lib wants a newer docker than we have in CI.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
6 years ago
David Shrewsbury f35e825440
[2.8] Sanitize URI module keys with no_log values (#70762) (#70822)
* Sanitize URI module keys with no_log values (#70762)

* Add sanitize_keys() to module_utils.

* More robust tests

* Revert 69653 change

* Allow list or dict

* fix pep8

* Sanitize lists within dict values

* words

* First pass at uri module

* Fix insane sanity tests

* fix integration tests

* Add changelog

* Remove unit test introduced in 69653

* Add ignore_keys param

* Sanitize all-the-things

* Ignore '_ansible*' keys

* cleanup

* Use module.no_log_values

* Avoid deep recursion issues by using deferred removal structure.

* Nit cleanups

* Add doc blurb

* spelling

* ci_complete

(cherry picked from commit bf98f031f3)

* update changelog for security_fixes

* Update 70762-sanitize-uri-keys.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
6 years ago
Rick Elrod d73793fac7
Update integration tests to support rpmfluff-0.6 (#71155) (#71161)
Co-authored-by: Matt Martz <matt@sivel.net>
6 years ago
Sloane Hertel 291f94934c
copy - redact 'content' from invocation in check mode (#71033) (#71069)
* sanitize copy module invocation secrets in check mode

(cherry picked from commit 991714b9d1)
6 years ago
Sam Doran 11738aed97
[stable-2.8] Change default file permissions so they are not world readable (#70221) (#70827)
* [stable-2.8] Change default file permissions so they are not world readable (#70221)

* Change default file permissions so they are not world readable

CVE-2020-1736

Set the default permissions for files we create with atomic_move() to 0o0660. Track
which files we create that did not exist and warn if the module supports 'mode'
and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults.

A code audit is needed to find all instances of modules that call atomic_move()
but do not call set_mode_if_different(). The findings need to be documented in
a changelog since we are not warning. Warning in those instances would be frustrating
to the user since they have no way to change the module code.

- use a set for storing list of created files
- just check the argument spac and params rather than using another property
- improve the warning message to include the default permissions.
(cherry picked from commit 5260527c4a)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Fix service test

* Fix lamdba_policy test

* Fix aws_lamdba test

* Fix warning for new default permissions when mode is not specified (#70976)

Follow up to #70221
Related to #67794
CVE-2020-1736

When set_mode_if_different() is called with mode of 'None', ensure we issue
a warning about the change in default permissions.

Add integration tests to ensure the warning works properly.

* Fix tests
- actually use custom module 🤦‍♂️
- verify file permission on created files
- use remote_tmp_dir so we're ready for split controller
- improve test module so we can skip the call to set_fs_attributes_if_different()
- fix tests for CentOS 6

(cherry picked from commit dc79528cc6)

* Use new category in changelog fragments
6 years ago
Sam Doran b95e520602
[stable-2.8] Drop "rhui-" prefix from RHEL repositories in AMI (#71130) (#71133)
The repository names seem to have changed and no longer have the "rhui-" prefix.
(cherry picked from commit 6ac4439a6a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago
Abhijeet Kasurde 7b8a66f284
[2.8] debconf: add a note about no_log usage (#70755)
debconf module exposes sensitive information to logs, console.
Add a note to user about using no_log=True to hide such
information from console.

Fixes: #32386

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 84b4387702)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 9b9bc112d5)
6 years ago
Rick Elrod f6d5d548b7
Add ansible-releases@redhat.com to announce template (#70815)
Signed-off-by: Rick Elrod <rick@elrod.me>
6 years ago
Alicia Cozine d1b2f66e16
backport of PRs 64763 and 70849 (#71098)
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
6 years ago
Alicia Cozine 8ec313a107
use security_fix category in changelogs (#71072)
(cherry picked from commit 3d5217b6d5)

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
6 years ago
Matt Clay 9c5663699f [stable-2.8] Cap pytest version to avoid relative import issue.
(cherry picked from commit 3a8ac62596)

Co-authored-by: Matt Clay <matt@mystile.com>
6 years ago
Sam Doran eb7597c5cb
[stable-2.8] Pin psutil version in pids test (#70716) 6 years ago
Sam Doran 9d7594c627
[stable-2.8] ansible_runner test - Add constraints (#70667) (#70671)
A recent updated to psutil, which is a dependency of ansible-runner, fails
to install on older versions of pip.

Commit with the breaking change:

  135628639b
(cherry picked from commit 9d27d7c8b1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago