Commit Graph

15337 Commits (72715c6adde78e9d497e3f535eae7a97e8f34006)
 

Author SHA1 Message Date
Abhijit Menon-Sen 72715c6add Fix ssh connections to IPv6 addresses
We can unconditionally wrap remote_addr in square brackets for scp and
sftp (both of which require them for IPv6 addresses), but not wrap them
at all for ssh (which doesn't accept them). This way, we don't have to
detect and treat IPv6 addresses specially. This works for hostnames,
IPv4 addresses, and IPv6 addresses.

The earlier code seemed to intend to wrap all IPv6 addresses in square
brackets, which would have broken ssh, but it actually made no attempt
to detect IPv6 addresses at all (so it broke only with IPv6 addresses
for scp and sftp).

Based on a review of PR #11677 by @JuiceBoxSingularity
9 years ago
James Cammarata 6d514e18b7 Merge pull request #11834 from amenonsen/pauseprompt
Make 'pause: prompt=…' print the prompt
9 years ago
Abhijit Menon-Sen 861da614cc Make 'pause: prompt=…' print the prompt
In stable-1.9, the prompt string is passed to raw_input(), which prints
it without an extra \n. Here we're just print()ing it, so the \n would
be doubled.
9 years ago
James Cammarata 9936c5f9f6 Fixing the pause module for devel 9 years ago
Toshio Kuratomi cf35bdbdf9 Merge pull request #11827 from amenonsen/trivial-fixmes
Remove TODO: the play already overrides options
9 years ago
Abhijit Menon-Sen a9b020d6de Remove TODO: the play already overrides options 9 years ago
Toshio Kuratomi 686b07603d Merge pull request #11828 from amenonsen/configmsg
Show a better message when ansible.cfg is not found
9 years ago
Abhijit Menon-Sen 1f2adb5e14 Show a better message when ansible.cfg is not found
Earlier we would say «Using  as config file» if we didn't find one.
9 years ago
Toshio Kuratomi dd65b55cc4 Merge pull request #11825 from ansible/tox-py24
Split py24 testing into its own tox section
9 years ago
Toshio Kuratomi 87cb7f8147 Push python2.4 check into travis 9 years ago
James Cammarata 0137c10e0e Merge pull request #11826 from amenonsen/trivial-fixmes
Another small batch of trivial FIXME removals
9 years ago
Abhijit Menon-Sen 2cb7cd8379 Remove outdated FIXME; _compute_delegate is called below 9 years ago
Abhijit Menon-Sen 7b3cb2126c Remove outdated FIXME; ROLE_CACHE is already implemented below 9 years ago
Toshio Kuratomi 53ae326603 Port some things in test-module to v2.
In particular, fix arg parsing

Fixes #11820
9 years ago
Toshio Kuratomi 91a77b8603 Fix potential bug in parameter passing 9 years ago
James Cammarata 13b8a57d3d Undo previous travis/tox fixes and fix underlying issue 9 years ago
James Cammarata 7c332b63dc Updating tox script too 9 years ago
James Cammarata e7009a14b4 Removing python 2.4 from travis install 9 years ago
James Cammarata 00daf43aed Merge pull request #11822 from ansible/synchronize-fix2
Fixes for synchronize with delegate_to
9 years ago
Toshio Kuratomi 0d72be3953 become protection for local connections no longer needed 9 years ago
Toshio Kuratomi d1933accc3 Fixes for synchronize with delegate_to 9 years ago
Chris Church 2154212491 Merge pull request #11094 from cchurch/test_win_feature_has_servermanager
Only run win_feature tests when the host has the ServerManager module.
9 years ago
Toshio Kuratomi 3939348286 Fix HostVars to support containment tests 9 years ago
James Cammarata 8e164eb46b Merge branch 'cchurch-winrm_v2_fixes' into devel 9 years ago
Chris Church 74df17de29 Add an option for PowerShell modules to indicate support for check mode, skip running module if check mode is not supported. 9 years ago
James Cammarata 8f549e11ab Merge branch 'winrm_v2_fixes' of https://github.com/cchurch/ansible into cchurch-winrm_v2_fixes 9 years ago
Chris Church e87cf4a3cc Fixes for WinRM/PowerShell support in v2.
- Add support for inserting module args into PowerShell modules.  Fixes #11661.
- Support Windows paths containing spaces.  Applies changes from #10727 to v2.  Fixes #9999.  Should also fix ansible/ansible-modules-core#944 and ansible/ansible-modules-core#1007.
- Change how execution policy is set for running remote scripts.  Applies changes from #11092 to v2.  Also fixes ansible/ansible-modules-core#1776.
- Use codepage 65001 (UTF-8) for WinRM connection instead of default (CP437), convert command to UTF-8 and results from UTF-8.  Replaces changes from #10024.  Fixes #11198.
- Close WinRM connection when task completes.
- Use win_stat, win_file and win_copy modules instead of stat, file and copy when called from within other action plugins (only when using WinRM+PowerShell).
- Unquote Windows path arguments before passing to win_stat, win_file, win_copy and slurp modules (only when using WinRM/PowerShell).
- Check for win_ping module to determine if core modules are missing (only when using WinRM/PowerShell).
- Add stdout_lines to result from running low level commands (so stdout_lines is available when using raw/script).
- Update copy action plugin to use shell functions for joining paths and checking for trailing slash.
- Update fetch action plugin to unquote source path when using Windows paths.
- Add win_copy and win_template action plugins that inherit from copy and template.
- Support running .bat and .cmd scripts using default system encoding instead of UTF-8.
- Always send PowerShell commands as base64-encoded blobs to allow for running simple PowerShell commands via raw.
- Support running modules on Windows with interpreters other than PowerShell.
- Update integration tests to support above changes and test unicode fixes.
- Add test for win_user error from ansible/ansible-modules-core#1241 (fixed by ansible/ansible-modules-core#1774).
- Add test for additional win_stat output values (implemented by ansible/ansible-modules-core#1473).
- Add test for OS architecture and name from setup.ps1 (implemented by ansible/ansible-modules-core#1100).

All WinRM integration tests pass for me with these changes.
9 years ago
Brian Coca fa8043c0ba corrected typo 9 years ago
Brian Coca f16b745f17 now properly uses default port if defined 9 years ago
Brian Coca 496186f5de makes ssh plugin resilient against invalid entries in hosts file
fixes #10238
9 years ago
Toshio Kuratomi e349004325 Update submodule ref to pull in apt_repo fixes 9 years ago
Brian Coca 9aa4214417 fixed delegate_to ref in syncronize 9 years ago
Brian Coca 8a00dff989 updated submodule refs 9 years ago
Brian Coca c2d8ca4bf7 fixed test to expected output 9 years ago
Brian Coca 07e5e98cbf removed jinaj2 override restrictions 9 years ago
Brian Coca 113f709eac brought up to date with default 9 years ago
Brian Coca 51de207197 Merge pull request #11805 from amenonsen/trivial-fixmes
A series of trivial FIXMEs for devel
9 years ago
Chris Church b07f8e7a7e Add an option for PowerShell modules to indicate support for check mode, skip running module if check mode is not supported. 9 years ago
James Cammarata 222f04e387 Submodule pointer update 9 years ago
Brian Coca 2ed5d29951 Merge pull request #11040 from resmo/patch-1
doc: we need GPLv3 license headers
9 years ago
Abhijit Menon-Sen 807079ec2f Remove outdated FIXME; HostVars is imported and used below 9 years ago
Brian Coca d05c4b82aa Merge pull request #11803 from amenonsen/prompt_encrypt
Uncomment encrypt handling for vars_prompt
9 years ago
Abhijit Menon-Sen 845784b572 Remove outdated FIXMEs; all use combine_vars already 9 years ago
James Cammarata efcad3aa6d Re-allow vars on tasks, specifically for includes 9 years ago
James Cammarata 0ad52a403f Merge pull request #11804 from amenonsen/fixme
Easy FIXMEs
9 years ago
Abhijit Menon-Sen 1541e331c9 Also fix UTF-8 handling in vars_prompt 9 years ago
James Cammarata 549c204051 Submodule pointer update 9 years ago
Abhijit Menon-Sen 694d2103b1 Remove outdated FIXME code
This is already handled in PlayContext.set_options.
9 years ago
James Cammarata 2a93559fc8 Merge branch 'winrm_v2_fixes' of https://github.com/cchurch/ansible into cchurch-winrm_v2_fixes 9 years ago
Abhijit Menon-Sen ff2d160fff Correct invalid reference to global display 9 years ago