When we introduced an include parameter to the unarchive module, we
inadvertenly flipped the exclusion logic. This flip meant that the
unarchive module started rejecting files that should be extracted.
This commit flips the bad logic and adds some tests that will make
sure things do not go bad again.
(cherry picked from commit f92830d16e)
* Disable the _distutils_hack in newer setuptools. Doesn't fix the underlying issue of the venv finding the _distutils_hack of a setuptools that is not its own.
ci_complete
* re-throw blanket
(cherry picked from commit fa617fcd7b)
* set host_key_checking check to False, rather than if not (which captures False and None)
* add host_key_checking default to ssh.py / update documentation
(cherry picked from commit d527be8a52)
Co-authored-by: James Spurin <james@spurin.com>
* Skip recursive suboption validation if sub_parameters is not a dictionary
* Ensure sub parameter elements is a sequence to prevent iterating over string characters and causing duplicate error messages for the same param
(cherry picked from commit b5ed41edb3)
* Have tests use shortname in action_groups to uncover an issue
* Alias shortname from action_groups to FQCR of owning collection
* Add clog frag
* Don't overwrite
- Use `fallible==0.0.1a2` instead of `black==19.10b`
- Test on both Python 2 and 3.
(cherry picked from commit b6725ec6c9)
Co-authored-by: Matt Clay <matt@mystile.com>
* hostname: Change "strategy" to "use" (#74815)
Fixed typo: 'strategy' to 'use'
(cherry picked from commit 63701b1b6b)
* Add changelog fragment for backport of #74815
Co-authored-by: bdouxx <bdouxx-git@yahoo.fr>
Switch to a different repo that isn't giving 503 errors since GitHub hasn't fixed the issue yet..
(cherry picked from commit 319b50f04c)
Co-authored-by: Matt Clay <matt@mystile.com>
* Handle netconf plugin ncclient import error when running in FIPS mode
* While running in FIPS mode importing ncclient result in
InternalError raised by cryptography
* Refer https://github.com/ansible/ansible/pull/65477
(cherry picked from commit d8bf4206e4)
Co-authored-by: Ganesh Nalawade <ganesh634@gmail.com>
* Fix role with empty argument_specs.yml
* Use try/except and add changelog fragment
* Always return a dict
* Add test for empty argument_specs key
(cherry picked from commit 3e7a622204)
Co-authored-by: devon-mar <devon-mar@users.noreply.github.com>
* If an exception occurs when getting a collection's metadata, continue to the next in the server list.
* Warn for unknown exceptions when finding versions of a collection
* Test that an invalid server is no longer fatal if a subsequent server has the collection
* Fix server for verify tests - compare checksums against the server from which it was installed
* Add tests for verify and fix that code path to mirror install/download behavior for server errors
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 469b559ebe)
* various fixes to command
- Updated splitter to allow for all expected args in ad-hoc
- Ensure we always return the returns we promissed to always return (i.e stderr/stdout)
- Updated docs to clarify creates/removes precdence in checking
- Removed abspath from chdir to allow reporting to handle symlinks correctly
- Corrected tests to new output messages
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b3b1dde648)
* setup module, dont truncate hpux interfaces
fixes#70533
no hpux to test so relying on man page and users that reported successful testing
(cherry picked from commit 03083c3139)
* avoid getting delegated vars w/o inventory host
fixes#75512
In the case of imports, we don't have a host, so getting host vars for
the delegated host makes no sense and should be avoided.
* also avoid error on vars_files with per host vars
* test
* testing given case
* oops
(cherry picked from commit 91319c5cfc)
* Make individual dirs that should exist instead of using shutil.copytree
* Test build_ignore when installing collections in git repos
* changelog
* Fix assertion
Fix git directory
* Fix nested content while building the collection dir
Test installing a collection from a git repo and artifact have the same result
Refactor to use variables
(cherry picked from commit f38a97cece)
* Improve ansible-galaxy error for InconsistentCandidate exception (#75235)
* Improve error for InconsistentCandidate exceptions
* Add test case for installing a collection with an inconsistent version
* Add test case for installing a collection that has a dependency with an inconsistent version
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
(cherry picked from commit e24eb59de5)
* Handle extra stderr for Python 2.7
* ignore attributes in output
* ignore 'attributes' for json dump
* actually add file
* clog
* sometimtes its not a dict
* always ignore
* also allow validation to work on newer modules
* remove attributes doc
let existing overrides display, wont be full info but still pertinent info
though user will have to check newer versions
Tadej Borovšak