Commit Graph

2184 Commits (6b54417bd5477fbc3148d1d756c173c049a145b4)

Author SHA1 Message Date
James Cammarata 521e14a3ad Fireball2 mode working! 11 years ago
James Cammarata acc5d09351 Initial commit for the "fireball2" connection plugin
Still needs:
* chunked file transfer/receive
* should probably move all send/recv operations to separate
  functions to reduce code duplication
* initial connection setup over ssh? or do we handle that in runner?
11 years ago
James Cammarata fd2aabaa27 Initial work for the AES cipher class
This is based somewhat loosely on how Keyczar does things. Their
implementation does things in a much more generic way to allow for more
variance in how the cipher is created, but since we're only using one
key type most of our values are hard-coded. They also add a header to
their messages, which I am not doing (don't see the need for it
currently).
11 years ago
Bruce Pennypacker cf6a76c814 changed ignore_md5_mismatch to validate_md5 11 years ago
Bruce Pennypacker 41c474d129 added optional ignore_md5_mismatch parameter 11 years ago
Michael DeHaan cce7f485b8 Merge pull request #3946 from wincent/spelling-fix
Fix minor typo in playbook error message
11 years ago
Wincent Colaiuta fc4307a9c4 Fix minor typo in playbook error message 11 years ago
James Cammarata 88966e6558 Use AnsibleError instead of exit for errors in utils 11 years ago
Jocelyn Jaubert 4cee6a5435 Add option remote_user to task level, to specify the ssh login user 11 years ago
James Cammarata 8262f7bfac Merge branch 'with_items_and_complex_args' of https://github.com/lberruti/ansible into lberruti-with_items_and_complex_args 11 years ago
James Cammarata e11bb0cad4 Merge branch 'plugins-work' of https://github.com/ferringb/ansible into ferringb-plugins-work 11 years ago
James Cammarata 462cd4f728 Merge branch 'pulls/fix-hostvars-inconsistancy' of https://github.com/ferringb/ansible into ferringb-pulls/fix-hostvars-inconsistancy 11 years ago
James Cammarata e6ad3b7792 Merge pull request #3895 from mscherer/fix_option_new_ssh
make sure ssh do not ask password
11 years ago
James Cammarata 157b697a83 Merge branch 'always_run-6' of https://github.com/stoned/ansible into stoned-always_run-6 11 years ago
James Cammarata af4f0bd008 Fix for "argument must be an int, or have a fileno() method" error
The issue was that, when forks == 1, the _executor() function was
being called with None for the value of new_stdin.

Fixes #3841, #3902
11 years ago
James Cammarata 978af89175 Disallow running async tasks with lookup plugins
Fixes #2897
11 years ago
James Cammarata ed3e4aff84 Place retry file in the user's home dir instead of /var/lib/tmp
Addresses CVE-2013-4260: predictable filename used for failed results
in world writable directory.
11 years ago
James Cammarata 6bf5d19506 SSH connection plugin creates ControlPersist socket files in a secure directory
Files were being created in /tmp, but will now be created in $HOME/.ansible/cp/
Addresses CVE-2013-4259: ansible uses a socket with predictable filename in /tmp
11 years ago
Stoned Elipot f0743fc32a Introduce the 'always_run' task clause.
The 'always_run' task clause allows one to execute a task even in
check mode.

While here implement Runner.noop_on_check() to check if a runner
really should execute its task, with respect to check mode option
and 'always_run' clause.

Also add the optional 'jinja2' argument to check_conditional() :
it allows to give this function a jinja2 expression without exposing
the 'jinja2_compare' implementation mechanism.
11 years ago
Michael Scherer 2bdba17a85 make sure ssh do not ask password
For some reason, ssh seems to ask for password even when
PasswordAuthentication is set to no, adding PreferredAuthentications
with the 2 options removed do the trick.
11 years ago
Kavin Kankeshwar 7ac3bbc198 resolved #3609 Change max_fail_pct to max_fail_percentage as recommended 11 years ago
Kavin Kankeshwar 3f247fcbe3 fixes ansible/ansible#3609 Add max_fail_pct to playbook parameter, to complement serial option, So if total number of failures execeed max_fail_pct * total number of hosts, do not go to the next serial batch 11 years ago
smoothify 494043947d Add support for role defaults. These are variables on a per role basis with lowest precedence. 11 years ago
Petr Svoboda e3adfbf5f8 Add tests for undefined variable detection
Tests `test_playbook_undefined_varsX_fail` check if ansible detects
undefined variables when `error_on_undefined_vars` is enabled. These
tests fail without "Improve behavior with error_on_undefined_vars
enabled" patch.

Tests `test_playbook_undefined_varsX_ignore` check if ansible ignores
undefined variables when `error_on_undefined_vars` is disabled.

Also modify PlayBook._run_task_internal() so error_on_undefined_vars is
testable.
11 years ago
Petr Svoboda fff4f1da33 Improve behavior with error_on_undefined_vars enabled
Pass fail_on_undefined flag to recursive calls to `template` function,
so more undefined variables are detected.

Works only for Jinja style variables. Undefined legacy variables are
never detected.
11 years ago
Brian Harring 31061213fa Fix inconsistency in hostvars access.
Previously, hostvars would only expose a keys() list of hosts that had
been seen yet- however you could explicitly access the host if you knew
the name, and get the content that way.  This precludes template code
from being able to safely access information about other hosts if any
limiters/tags were in use.

Additionally, the object was inconsistent for hostvars['myhost'] access
and [x[1] for x in hostvars.items() if x[0] == 'myhost'] access; this is
due to the original derivation from the dict object.  .items() would be
handled by dict.items(), using the passed in setup_cache values without
using the actual lookup content.

This patch rebases the class implementation to a py2.6 dictmixin, fixing
those issues and restoring behaviour to match what the docs claim.
11 years ago
Brian Harring 902183ac0e Enforce alphanumeric ordering for plugins grabbed via glob.
If this isn't done, it's left to directory ordering which can result
in indeterminent behaviour.
11 years ago
James Cammarata 39628d012d Minor fix to ipv6 detection for inventory with -i
For link-local addresses, it is sometimes necessary to append the
interface to use for the ipv6 address. This patch extends the ipv6
regex to allow for '%ifnameX' at the end.

See https://bugzilla.redhat.com/show_bug.cgi?id=136852 for more info
11 years ago
Michael Scherer 3aac187387 fix ssh connection plugin to work with ipv6 address
Due to various inconsistencies of ssh and sftp regarding ipv6 and
ipv4 handling, some special arguments must be passed, and the
ipv6 must be passed in a specific format.
11 years ago
Michael Scherer c9d28e10ad add support for using a ipv6 in -i
testing with a ipv6 :
  ansible -u misc -i  '[2002::c23e]:22,' '*' -m ping

fail due to parsing of ':' as a separator of port/ip with ipv4.
This commit add support for properly parsing 2002::c23 and the
bracket notation [2002::ce]:2222
11 years ago
Matt Saunders 9fd1b174f5 Fixed tiny bug with _meta handling in external inventory scripts 11 years ago
James Cammarata 5847720746 Fixing a small bug with the new role dependency feature
The block that added the original list of roles was indented too far,
and was only being reached if a role had dependencies. This resulted
in roles without dependencies from being added to the list of roles.

Credit goes to looped for reporting and diagnosing the issue.
11 years ago
Michael DeHaan 42648e2f0a Merge branch 'role_dependencies' of git://github.com/jimi1283/ansible into jimi1283-role_dependencies 11 years ago
Michael DeHaan dacd311474 Removing synchronize momentarily as it looks like this won't make 1.3 dates 11 years ago
James Cammarata d8a7a2d1b2 Adding evaluation of role vars as the dep tree is built
This allows variables to be inserted into the role scope specifically
while also being inserted into the global scope.
11 years ago
James Cammarata e12b99dba6 Small cleanup, no need to call _get_role_path a second time 11 years ago
James Cammarata 9a401e73a6 Adding support for role dependencies.
Fixes #3686

Dependencies are enabled by adding a new directory/file named
meta/main.yml to the role. The format of the dependencies are:

dependencies:
- { role: foo, x: 1, y: 2 }
- { role: bar, x: 3, y: 4 }
...

Dependencies inherit variables as they are seen at the time of the
dependency inclusion. For example, if foo(x=1, y=2) has a dependency
on bar(x=3,z=4), then bar will have variables (x=3,y=2,z=4).

Different roles can have dependencies on the same role, and this
variable inheritence allows for the reuse of generic roles quite easily.
For example:

Role 'car' has the following dependencies:
dependencies:
  - { role: wheel, n: 1 }
  - { role: wheel, n: 2 }
  - { role: wheel, n: 3 }
  - { role: wheel, n: 4 }

Role 'wheel' has the following dependencies:
dependencies:
- { role: tire }
- { role: brake }

The role 'car' is then used as follows:
- { role: car, type: honda }

And tasks/main.yml in each role simply contains the following:
- name: {{ type }} whatever {{ n }}
  command: echo ''

TASK: [honda tire 1]
TASK: [honda brake 1]
TASK: [honda wheel 1]
TASK: [honda tire 2]
TASK: [honda brake 2]
TASK: [honda wheel 2]
TASK: [honda tire 3]
TASK: [honda brake 3]
TASK: [honda wheel 3]
TASK: [honda tire 4]
TASK: [honda brake 4]
TASK: [honda wheel 4]
TASK: [I'm a honda]  <- (this is in roles/car/tasks/main.yml)
11 years ago
James Cammarata ad595eadea Enable error_on_undefined_vars by default 11 years ago
Michael Scherer 12bf9a8b69 add a way for callback to disable itself
The idea is that some plugin would not be called in some
specific case, and the callback should decide by itself.

Having a way to globally disable it is much cleaner than
disabling every method one by one on the plugin side.

My use case is for fedora-infrastructure that cannot be run
from git checkout since it try to connect to the message bus,
but another case would be to bootstrap infrastructure, or to
run the code on a test servers without having all the callback
infrastructure setup.
11 years ago
Luca Berruti eee278e02b fix 11 years ago
Luca Berruti 5048218ab5 Fix: with_items and complex_args 11 years ago
Serge van Ginderachter 173586b871 Ensure plugin_loader.all() only loads one instance
by ensuring all basedirs, plugin paths and extra
paths are handled as absolute paths and are checked
to not add any doubles.

This fixes the corner case where e.g. the user has
an additional plugin path configured to a dir
relative to his playbooks or inventory location,
which also matches the  _plugin subdir relative to
one of the basedirs in the play.

For most plugins this doesn't show as an obvious issue
except for callback_plugins, which might fire more
than once. Other plugins (inventory and template
plugins) might unnecessarily be ran twice.

e.g. ansible.cfg has
callback_plugins   = ./plays/callback_plugins
and plays/ contains a playbook file:
.
├── ansible.cfg
├── inventory
└── plays
    ├── callback_plugins
    │   └── timestamp.py
    └── site.yml

modified:   lib/ansible/utils/plugins.py
11 years ago
Michael DeHaan bc02e20503 Merge branch 'rsynctake2' into devel
Conflicts:
	CHANGELOG.md
11 years ago
Michael DeHaan 17aa0d12de Merge pull request #3814 from ftao/inventory_dir_abs
fix inventory.basedir is not absolute path when hostfile is startswith "./"
11 years ago
Abhijit Menon-Sen 1a90d01ba9 Fix some typos discovered during casual reading 11 years ago
ftao 51a180b150 fix inventory.basedir is not absolute path when hostfile is startswith "./" 11 years ago
Michael DeHaan f8c97d6e79 Style/docs cleanup, and also improve an error message. 11 years ago
Michael DeHaan aeb8649da5 Merge branch 'ansible-rsync-take2' of git://github.com/tima/ansible into rsynctake2 11 years ago
Michael DeHaan 4d1f447908 Merge pull request #3650 from bcoca/forking_optimizations
forking least possible
11 years ago
Michael DeHaan baffa8df72 These fields are booleans. 11 years ago
Michael DeHaan 633abca916 Merge branch 'nocolor' of git://github.com/amenonsen/ansible into devel 11 years ago
Michael DeHaan ee11d69697 Merge branch 'better_ini_errors2' of git://github.com/bcoca/ansible into devel 11 years ago
Michael Vogt 89bc43cab0 support i18n on sudo failure 11 years ago
Serge van Ginderachter 9991a530ab fix an encoding bug in copy content = lookup plugin
closes #3518
11 years ago
Michael DeHaan 66b29b6813 Merge branch 'feature/gh-3789-inventory-file' of https://github.com/resmo/ansible into devel 11 years ago
Michael DeHaan 1d13ec2da3 Construct the multiprocessing manager only once. 11 years ago
René Moser e8272e365d
implemented 'inventory_file' variable. Closes GH-3789. 11 years ago
Timothy Appnel 2288a11b6a Implemented setup method in rsync action module. 11 years ago
Timothy Appnel 4a9635e04e Straighten out local-remote-delegate logic in rsync action module. Force set delegate to local if one is not defined. 11 years ago
Timothy Appnel adbca9d251 Fixed identity key logic. 11 years ago
Timothy Appnel 9f170f579a Introduced ansible-rsync to core. 11 years ago
James Cammarata ceff3b6ba3 Minor modification to set_fact with_items patch
Previous patch was reverted due to the fact that there was an issue
with the results not always being a dictionary (they're sometimes
a unicode string, ie. when the with_items is used with yum). This
minor change corrects that by checking for a dict object.
11 years ago
James Cammarata 8be2fc745b Revert "Check for ansible_facts in results for with_ tasks"
This reverts commit 1a4e6e415e.
11 years ago
Serge van Ginderachter 1a4e6e415e Check for ansible_facts in results for with_ tasks
that loop over a lookup plugin. Fixes #3704 and #3735
11 years ago
Serge van Ginderachter 40e60c947d Host specifiers should be sorted
to ensure consistent behavior, hosts should look like this:

    hosts: webservers:&boston:!rack42

So when applying the host selectors, run those without the "&" first,
then the &s, then the !s.

Closes #3500
11 years ago
Abhijit Menon-Sen 0c96d8af6e Add a nocolor setting to ansible.cfg 11 years ago
Brian Coca a937a6a66d now bad ini entries will throw friendlier error
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 4cbfe3be57 Merge pull request #3773 from cchurch/devel
Update callbacks used for async tasks
11 years ago
Michael DeHaan ff44c981e9 Merge pull request #3770 from rishid/devel
Add support for INI comments that begin with '#' or ';'
11 years ago
Michael DeHaan 99775176ff Merge pull request #3623 from ralph-tice/fix_3567_2
changed role path template to read all vars instead of just extra_vars
11 years ago
Chris Church 6ba4331161 Correctly check for failed status from an async task. Use runner_on_async_failed callback (instead of runner_on_failed) when an async task times out. Add runner_on_async_ok callback when a task is started in fire and forget mode. 11 years ago
rishid d18c90ed8f Add support for INI comments that begin with '#' or ';'
Ini file format does not have a standard but ';' is used more often than '#' for comments
11 years ago
Michael Scherer 3fb2da6359 use lgetfilecon_raw instead of lgetfilecon to not depend on local level translation
If SELinux is enabled and mcstrans is running, daemons are restarted on each
run. After further debugging, it turn out that ansible compare the untranslated
level 's0' with the translated level 'SystemLow' due to mcstrans being running,
which trigger a handler since this is considered as a change.
11 years ago
Michael DeHaan 56a00e0667 Remove dead code. 11 years ago
Michael DeHaan 8955ac1eda If the result of a dynamic inventory script contains a "_meta" hash at top level
and the _meta hash contains a "hostvars", don't call --host hostname for any elements
and just serve them directly for performance enhancements with the external inventory
script and a large number of hosts.
11 years ago
Michael DeHaan 1c6b81233c Merge pull request #3692 from tima/action-init
Added support of an optional init method for action modules like rsync that need to alter the connection and other inject data before it's established.
11 years ago
Michael DeHaan dec43f7a2b PEP8 indent fix. 11 years ago
Michael DeHaan 3dbe65def2 PEP8 indent fix 11 years ago
Michael DeHaan 76fd769704 Merge pull request #3685 from mspaulding06/indexed_items
Indexed items lookup plugin
11 years ago
Michael DeHaan c0ab417ef9 Don't iterate across strings in with_nested. 11 years ago
James Cammarata 82c806979b Only use LOG_LOCK in log_flock if a runner is not specified
Fixes issue #3466 - When ansible can't authenticate against a host,
and your answer is no, ansible crash.
11 years ago
James Cammarata ba38d6bc16 Adding support for hashed known_hosts entries
Fixes Issue #3716 - SSH known host checking needs to understand
hashed known hosts
11 years ago
Brian Coca 581a0c9f59 now correctly 'types' value pairs that are passed as options to jinja
override
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 0335d05f43 Check against None around playbook basedir 11 years ago
Michael DeHaan bdef7f1774 Merge pull request #3711 from ashorin/devel
Allow --diff on UTF-8 encoded files and templates
11 years ago
Michael DeHaan 44d060628e Merge pull request #3706 from lorin/sudo_user_breakage
Fix sudo_user copy error
11 years ago
Michael DeHaan daf5ecc7c9 Merge pull request #3684 from stoned/fix-3668
Add extra module path early during playbook parsing.
11 years ago
Michael DeHaan 83481b32cc Merge pull request #3657 from zqad/devel
Fix playbook-local host_vars when running from .
11 years ago
Michael DeHaan 3ebbb56479 Merge pull request #3654 from MaxIV-KitsControls/devel
Fix nested loop for more than 3 elements
11 years ago
Michael DeHaan 7813290969 Merge pull request #3645 from stoned/stringify-conditional-2
stringify conditional before handing it to Jinja2 for evaluation.
11 years ago
Andrey Shorin 664215eb02 Allow --diff on UTF-8 encoded files and templates 11 years ago
Lorin Hochstein a303fca193 Fix sudo_user copy regression
Treat errno 13 (permission denied) as one of the special cases in
atomic_move.

This type of error can occur because of sudo'ing to non-root user.

Fixes #3705
11 years ago
Timothy Appnel 11beb38c66 Added support of an optional setup method for action modules like rsync that need to alter the connection and other inject data before it's established. 11 years ago
Matt Spaulding 5d15515bbf Add indexed_items lookup plugin 11 years ago
Stoned Elipot 841093921b Add extra module path early during playbook parsing.
This should fix issue #3668

Also prevent an extra module path to be added multiple times.
12 years ago
Jonas Eriksson 16efb45735 Fix playbook-local host_vars when running from .
Since ansible 1.2, it became possible to place a host_vars
directory in the same directory as a playbook, making it possible
to keep host_vars local to that playbook there. However, due to
python's os.path.dirname, a action such as:

 $ ansible-playbook pb.yml

..would not pick up the host_vars as os.path.dirname("pb.yml")
returns "", unlike the unix command dirname that would return
".". Substituting "pb.yml" on the command line with "./pb.yml"
would do the trick, but is not always intuitive. This patch
solves the problem until python solves issue18547 [1].

[1] http://bugs.python.org/issue18547
12 years ago
Vincent Hardion 09ef7751e1 Fix nested loop for more than 3 elements
- combine flatten list for each nested level instead once at the end
12 years ago
Brian Coca 576962d335 now if you set fork to 0 or a number higher than the number of hosts, it
will be readjusted to the number of hosts runner is going to deal with.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Stoned Elipot a1503c4d59 stringify conditional before handing it to Jinja2 for evaluation.
This should fix simple conditionals like:

    when: ansible_selinux

While here add tests for ansible.utils.check_conditional() in
"jinja2_compare mode".
12 years ago
WAKAYAMA Shirou 0ce99e391f fix: if a path is symlink and trying to chmod, OSError Exception will be raised. 12 years ago
Michael DeHaan f0eafff1b4 Merge pull request #3621 from sergevanginderachter/rename2flattened
also rename plugin name in error message
12 years ago
Ralph Tice 2383a8205c changed role path template to read all vars instead of just extra_vars 12 years ago
Serge van Ginderachter b40295910d also rename plugin name in error message 12 years ago
Michael DeHaan 2fe25f19dc Fix to group_by module as a result of previous conditional upgrades. 12 years ago
Michael DeHaan e3f213e030 Fixup error reporting. 12 years ago
Michael DeHaan c07dd07767 Add raw copy support (raw=yes), tweak tempfile error message string. 12 years ago
Michael DeHaan 0cf5e5cec3 Merge branch 'devel' of git://github.com/bradleyy/ansible into together 12 years ago
Michael DeHaan 0756aa406a Change conditional operation workflow.
Conflicts:

	lib/ansible/utils/__init__.py
12 years ago
Michael DeHaan 7f462a346a Work in progress on merging changed_when. 12 years ago
Michael DeHaan 88720516a1 Merge branch 'changed_when' of git://github.com/stoned/ansible into changed_when 12 years ago
Michael DeHaan f592340f7f Merge branch 'playbook-skip-tags' of git://github.com/dekked/ansible into skip_tags 12 years ago
Michael DeHaan 3baa55a314 Merge branch 'devel' of git://github.com/sjmudd/ansible into sjmudd_ranges 12 years ago
Michael DeHaan 62b39d3de5 Fix for saving conditionals in variable expressions. 12 years ago
Michael DeHaan bf70dfc1a0 When a role/include has a conditional, add that conditional ahead of any on the task, not behind, so it can short circuit. 12 years ago
Michael DeHaan 419661542b Added some pipes.quote ops to make sure paths with spaces in them are ok. 12 years ago
Michael DeHaan 192d9f8b89 Merge pull request #3607 from stoned/use-AnsibleFilterError
Use AnsibleFilterError exception
12 years ago
Stoned Elipot 667ad2480e Use AnsibleFilterError exception 12 years ago
Stoned Elipot e7a733a6be Quote pathnames of roles' tasks and handlers files so that _load_tasks() can tokenize them properly
With the help of AlejandroTrev's eagle eyes. Thanks !
12 years ago
Michael DeHaan 0f26439234 Remove variable per pyflakes 12 years ago
Michael DeHaan e1167d6977 tweak indentation for 'make pep8' 12 years ago
Michael DeHaan 0f4229f6c4 Merge pull request #3462 from stoned/filtererror
Introduce exception AnsibleFilterError and use it in Jinja filters.  Ign...
12 years ago
Brian Coca dafbcf87d3 changed atomic_move to be more 'optimistic' which helps deal with corner
cases and avoid usless work.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan c10c2cae4e Merge branch 'ansible_sudo_at_role_level' of git://github.com/jeromew/ansible into sudo_role 12 years ago
Michael DeHaan f7dec4f8f4 Rename plugin. 12 years ago
Michael DeHaan 9dec701728 Merge pull request #3559 from sergevanginderachter/flat_list
Introduce flat_list lookup plugin
12 years ago
Michael DeHaan 7d2585caf7 Merge pull request #3577 from Tinche/extra-vars-in-playbook-includes
Enabled the use of extra vars in playbook file paths when including play...
12 years ago
Brian Coca c8d6e5be0b missing self in self method usages
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael Vogt 9caef884e1 fail early on the wrong sudo password instead of waiting until the timeout happens 12 years ago
Michael DeHaan c98b20b2cf Slight style preferences. 12 years ago
Sharif Olorin 5fcbfa984d More informative error message on failure to resolve tmpdir 12 years ago
Sharif Olorin 1a7a779e88 Handle SSH failures when creating remote tmpdir
Bail out if the SSH command fails rather than continuing with an
empty tmp variable.
12 years ago
Michael DeHaan 8a3ea0774a Update error message since user may have specified connection type via non command line or by default. 12 years ago
Michael DeHaan 5eea4b56fa Merge pull request #3591 from cocoy/fix_3567
Allow roles to be interpolated from --extra-vars
12 years ago
Michael DeHaan 7965bc729b Merge pull request #3588 from Atte/devel
Check for existence of isatty on stdout before calling it
12 years ago
Rodney Quillo a4e829c874 Allow roles to be interpolated from --extra-vars 12 years ago
Atte Virtanen 511c7c858d Check for existence of isatty on stdout before calling it 12 years ago
Brian Coca f6c99a69db switched from sestatus to selinuxenabled as per recommendation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca 98cc29f9fd now returns fatal error if operation on selinux enabled target is
attempted w/o selinux python bindings
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
jeromew de0bc96b70 Implement sudo/sudo_user at the include and role levels 12 years ago
Tin Tvrtkovic 4a732c1e9f Enabled the use of extra vars in playbook file paths when including playbooks from other playbooks. 12 years ago
Serge van Ginderachter 730b368259 Introduce flat_list lookup plugin
- hosts: localhost
    gather_facts: False
    tasks:
    - debug: msg="{{item}}"
      with_flat_list:
      - a
      - - b
        - c
        - d
        - - e
        - f
        - - g
          - h
      - i
      - j
      - - k
        - l

  # note: main list or list (sub)items can also be set as a variable

  TASK: [debug msg="{{item}}"] **************************************************
  ok: [localhost] => (item=a) => {"item": "a", "msg": "a"}
  ok: [localhost] => (item=b) => {"item": "b", "msg": "b"}
  ok: [localhost] => (item=c) => {"item": "c", "msg": "c"}
  ok: [localhost] => (item=d) => {"item": "d", "msg": "d"}
  ok: [localhost] => (item=e) => {"item": "e", "msg": "e"}
  ok: [localhost] => (item=f) => {"item": "f", "msg": "f"}
  ok: [localhost] => (item=g) => {"item": "g", "msg": "g"}
  ok: [localhost] => (item=h) => {"item": "h", "msg": "h"}
  ok: [localhost] => (item=i) => {"item": "i", "msg": "i"}
  ok: [localhost] => (item=j) => {"item": "j", "msg": "j"}
  ok: [localhost] => (item=k) => {"item": "k", "msg": "k"}
  ok: [localhost] => (item=l) => {"item": "l", "msg": "l"}
12 years ago
Alan Descoins 04349ec362 Added --skip-tags option to ansible-playbook. 12 years ago
Antti Rasinen b12cc909a9 Fix pretty_bytes for exa- and zettabytes 12 years ago
Brian Coca 18cb155bd5 now ANSIBLE_KEEP_REMOTE_FILE acts as boolean
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Bradley Young 23557b6e5a change the name from transpose to "together". Change to use itertools.izip_longest() rather than method cribbed from nested.py 12 years ago
Stoned Elipot eb45f07ae3 Introduce 'changed_when' keyword to override a task's changed status with the evaluation of a Jinja2 expression 12 years ago
Bradley Young ea93a36b10 Adding transpose lookup method. This will matrix transpose arrays that are passed in, and then work like items over the resulting list of lists. e.g.:
Transpose a list of arrays:
    [1, 2, 3], [4, 5, 6] -> [1, 4], [2, 5], [3, 6]
    Replace any empty spots in 2nd array with "":
    [1, 2], [3] -> [1, 3], [2, ""]
12 years ago
Michael DeHaan fba1f7ef42 Revert "expand vars like $HOME used in config values too" -- breaks remote_tmp if set.
This reverts commit e5ff35bbdb.
12 years ago
Michael DeHaan afcd869487 Merge pull request #3451 from sergevanginderachter/template_ansible_ssh_host
allow ansible_ssh_host to be templated
12 years ago
Michael DeHaan 90dfc115d6 Merge pull request #3463 from stoned/filterskipped
Add Jinja2 filter 'skipped' to test for a registered variable from a ski...
12 years ago
Michael DeHaan 279247dfac Merge pull request #3464 from stoned/filterquote
Add Jinja2 filter 'quote' to quote string for shell usage
12 years ago
Andreas Piesk e5ff35bbdb expand vars like $HOME used in config values too 12 years ago
Lasse Borchard 8c8b4d56fc Fixed indention of vv() output 12 years ago
Stoned Elipot 247322bb16 Add Jinja2 filter 'quote' to quote string for shell usage 12 years ago
Stoned Elipot 906746b1f0 Add Jinja2 filter 'skipped' to test for a registered variable from a skipped task 12 years ago
Stoned Elipot 2d88c70cd5 Introduce exception AnsibleFilterError and use it in Jinja filters. Ignore this exception when trying to find the name of a task for display (callback) purpose. 12 years ago
Michael DeHaan cf6e1f8db9 Make it possible to tell paramiko to not record new host keys, which can be slow with a large number of hosts.
-c ssh is preferred in most cases if you have ControlPersist available, otherwise if you are comfortable you
can turn off recording while leaving host key checking on, etc.
12 years ago
Michael DeHaan 14818af446 Merge pull request #3450 from tonk/sudo
Repair issue #3447
12 years ago
Michael DeHaan aa9385411d Merge pull request #3443 from ajsalminen/arg_unicode_fix
Use .encode() instead of str() to support unicode arguments.
12 years ago
Ton Kersten 37ee361be1 Repair issue #3447 12 years ago
Serge van Ginderachter 129c7522d9 allow ansible_ssh_host to be templated
Use case: e.g. dual homed hosts on production en management network

The inventory_hostname is the regular host name and matches the
dns name on the production network; ansible connects to the host
through a management network; the dns name on the management network
is standardized and equals ${inventory_hostname}-mgt.mynetwork.com

Now this can be configured as the default in group_vars/all:

   ansible_ssh_host: {{ inventory_hostname + '-mgt.mynetwork.com' }}
12 years ago
Michael DeHaan 2cb7c30834 Improve interlaced output prevention when asking for host key approval. 12 years ago
Michael DeHaan c55adc9ac9 Default to 'smart' transport, which will use OpenSSH if it can support ControlPersist. 12 years ago
Antti Salminen d7c6cf10c2 Use .encode() instead of str() to support unicode arguments.
str() throws an UnicodeEncodeError for code points that cannot be
represented in 7-bit ASCII. This makes it impossible to use any
non-ASCII characters in module arguments. Using encode('utf-8')
gives the desired result.
12 years ago
Michael DeHaan 1683d44d2e Lock around SSH connectivity to new hosts in host checking mode such that prompts for host approval
messages do not get interlaced.
12 years ago
Michael DeHaan cb26945d54 Close the named temporary file. 12 years ago
Michael DeHaan 3b1aa092f8 Closing stdin too early. 12 years ago
Michael DeHaan ffadbc520a Enable paramiko to ask whether to add keys to known hosts. 12 years ago
Michael DeHaan 9db4f7a9a6 Makes host key checking the default behavior but can be disabled in ansible.cfg or by environment variable. 12 years ago
Stoned Elipot 0b3483cf03 Add Jinja2 filter |bool : return boolean interpretation of the value
'yes', 'on', '1', 'true', insensitively, and 1 are true,
 everything else is false
12 years ago
Michael DeHaan 6ba72854ee Merge pull request #3296 from ninetythirty/devel
Added flexible filename handling for main files
12 years ago
Michael DeHaan c2988dfdb0 Merge branch 'option-updates' of git://github.com/jlund/ansible into devel
Conflicts:
	bin/ansible-pull
12 years ago
Michael DeHaan 2bbad5dae3 Merge pull request #3275 from madduck/implicit-negations
Enable negated patterns
12 years ago
Michael DeHaan f2fc185651 Styling: indentation 12 years ago
Michael DeHaan c265c761d0 Slight message tweak. 12 years ago
Michael DeHaan e6adc2f066 Merge branch 'devel' of git://github.com/arturaz/ansible into devel 12 years ago
Michael DeHaan 146455fd0a Merge pull request #3375 from jhoekx/mandatory-filter
Add a mandatory jinja2 filter for use in templates.
12 years ago
Michael DeHaan 98e7eaf07a Merge pull request #3316 from dsedivec/devel
expanduser on each component of plug-in paths
12 years ago
Stoned Elipot b7f89837bb Remove redundant call to _get_path() in PluginLoader.find_plugin() 12 years ago
Jeroen Hoekx a37f55d32e Add a mandatory jinja2 filter for use in templates. 12 years ago
Joshua Lund dc984d94ac Updates to Ansible command options
* Moved the --list-hosts option that is common to both `ansible` and
  `ansible-playbook` into utils/__init__.py (corrects a FIXME)
* Wrote new help text for the --list-hosts option that makes sense
  for both of the commands that it applies to
* Changed the usage argument in `ansible-playbook` so that it is
  setup in the base_parser method the same way that it is in
  the `ansible` executable
* Updated the help text for several options to correct typos,
  clarify meaning, improve readability, or fix grammatical errors.
  In the case of `ansible-pull`, I changed the help text so that
  it adheres to the same standards as the other executables.
12 years ago
Jesse Keating e1dd83f2b6 add_host should not be a changed action
The action doesn't actually change anything on a system, so setting
the status to changed is wrong. add_host is much like set_fact in that
regard.

Since changed is False by default, there is no need to explicity set
it, so just create an empty dict for result and add to it from there.
12 years ago
Arturas Slajus 9be93d6ac7 Better error for fireball + sudo mode. 12 years ago
Dale Sedivec b32131c867 expanduser on each component of plug-in paths
ansible.constants was calling expanduser (by way of shell_expand_path)
on the entire configured value for the library and *_plugins
configuration values, but these values have always been interpreted as
multiple directories separated by os.pathsep.  Thus, if you supplied
multiple directories for one of these values, typically only the first
(at least on *nix) would have e.g. "~" expanded to HOME.

Now PluginLoader does expansion on each individual path in each of
these variables.
12 years ago
Ninety Thirty 7b1e87b62d Added flexible filename handling for main files
tasks, handlers, and vars main files can now be any of main, main.yml, or main.yaml
12 years ago
martin f. krafft fd02443d42 Enable negated patterns
A host pattern of the form '!foo' by itself does not work, but
'all:!foo' does. If the first pattern is a negation, this commit
automatically prepends 'all'.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
Michael DeHaan 010440dc47 Merge pull request #3114 from laggyluke/roles_combine_vars
Added basic support for hash_behaviour=merge in roles
12 years ago
Michael DeHaan fc45470162 Merge branch 'with_inventory_hostnames' of git://github.com/sdossett/ansible into inv_hostnames 12 years ago
Michael DeHaan 0ce7996bb6 Merge pull request #3266 from trbs/20130619_first_found
enable use of multiple terms in first_found
12 years ago
Michael DeHaan d2721526de Small tweak, don't merge conditionals, just evaluate each in turn. 12 years ago
Michael DeHaan d9c0a5c37d Revert "now modules can implement with_items list globbing w/o updating"
This reverts commit 4942a06bc2.

Conflicts:

	lib/ansible/runner/__init__.py
12 years ago
trbs 87c7fa9138 enable use of multiple terms in first_found 12 years ago
George Miroshnykov c642ba77ae Added basic support for hash_behaviour=merge in roles
Dict vars passed to roles are now properly merged
instead of simply overriding dict vars that are
coming from vars_files.
12 years ago
Jesse Keating 1074896105 make name the parameter, with hostname as alias
name is used throughout Ansible, it's the "standard". This change
applies that standard to the add_host routine and updates the docs to
reflect that. Related to https://github.com/ansible/ansible/pull/3254
12 years ago
Michael DeHaan fc2d25eb82 Merge pull request #3127 from bennojoy/devel
bug fix for #3077, environment settings for script
12 years ago
Michael DeHaan 132c89e681 Merge branch 'callbackinit' of git://github.com/sergevanginderachter/ansible into devel 12 years ago
Michael DeHaan 7193ff5fbf Merge pull request #3250 from gildegoma/more_magical_ansible_ssh_user
Make 'ansible_ssh_user' available in templates
12 years ago
Michael DeHaan 2123507315 Merge branch 'sha256' of git://github.com/jlund/ansible into devel
Conflicts:
	library/network/get_url
12 years ago
Michael DeHaan 92754065bf Remove debug statement. 12 years ago
Michael DeHaan 5a504e3a3b Tweak error messages for undefined variables feature. 12 years ago
Michael DeHaan 637983cf31 cleanup example config file + Squashed commit of the following:
commit c36b66dc952dfff91043ecbca56cf3f1f8f00703
Merge: 240d7bf f4cf934
Author: Michael DeHaan <michael@ansibleworks.com>
Date:   Tue Jun 18 13:04:51 2013 -0400

    Merge branch 'unevaluated-vars' of git://github.com/lorin/ansible into lorin_undefined

    Conflicts:
    	lib/ansible/runner/__init__.py

commit f4cf934367
Merge: 2531440 07a1365
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Thu Jun 6 11:07:41 2013 -0400

    Merge branch 'devel' into unevaluated-vars

commit 253144045c
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Thu Jun 6 11:06:37 2013 -0400

    Fail template from file on undefined vars

    If config option is set, raise an exception if templating from a
    file and a variable is undefined.

commit aecb71d8b7
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Wed Jun 5 17:12:12 2013 -0400

    Add fail_on_undefined flag

    Add a fail_on_undefined flag to the template and template_from_string methods.

    If this flag is true, then re-raise the ninja2.excpetions.UndefinedError instead of
    swallowing it.

commit cbb1808f05
Merge: d4bbf49 41425fb
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Wed Jun 5 16:14:12 2013 -0400

    Merge branch 'devel' into unevaluated-vars

commit d4bbf492b0
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Mon Jun 3 19:46:13 2013 -0400

    template: Raise UndefinedError exception

    In template_from_string, raise an undefined error if it occurs.

    Have the caller catch it and throw an AnsibleUndefinedVariable

commit c947802805
Merge: 8d919d6 be33bcf
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Mon Jun 3 10:09:43 2013 -0400

    Merge branch 'devel' into unevaluated-vars

commit 8d919d6c97
Merge: 0f68ad8 b8630d2
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Thu May 30 16:27:48 2013 -0400

    Merge branch 'devel' into unevaluated-vars

commit 0f68ad8193
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date:   Thu May 30 14:32:03 2013 -0400

    Optionally fail task on undefined variables

    This patch introduces a new configuration option called
    error_on_undefined_vars, which defaults to false.

    If this option is set to true, then a task which has unevaluated
    variables in its arguments will fail instead of running. Output looks
    like this:

        TASK: [set rabbitmq password] *************************************************
        fatal: [10.20.0.7] => Undefined variables: rabbitmq_user, rabbitmq_password
12 years ago
Gilles Cornu 48fe7ac19d Enlarge scope of 'ansible_ssh_user' magic variable
Allow to use ansible_ssh_user variable in `sudo_user` or `when` clauses
12 years ago
Scott Sturdivant b10b676158 Print the default value if one is provided. 12 years ago
Michael DeHaan e128e8b563 Merge pull request #3162 from strawlab/apt-key-binary-fix
allow apt-key module to work with binary key
12 years ago
Michael DeHaan aa340c1508 Merge pull request #3169 from Debilski/fix-duplicate-host-reads
Allow inventory to be read from a pipe
12 years ago
Michael DeHaan 70a9be27f6 Merge pull request #3217 from dagolden/topic/late-sudo_user
Expand sudo_user after variable merging
12 years ago
Michael DeHaan d9f91be34a Merge pull request #3227 from bcoca/modules_wantlist
implementing with_items list globbing made easier for modules
12 years ago
trbs a4223e119d fixed x-bits in git 12 years ago
Brian Coca 4942a06bc2 now modules can implement with_items list globbing w/o updating
hardcoded lists in ansible code, just add WITH_ITEMS_USES_LIST in a
comment anywhere, and of course, support recieving params as list.

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
David Golden d65f45f0b2 Expand sudo_user after variable merging
Previous commit c3659741 expanded sudo_user during task construction,
but this is too early as it does not pick up variables set during
the play.

This commit moves sudo_user expansion to the runner after variables
have been merged.
12 years ago
Serge van Ginderachter 2a7f9df109 add support for callback_plugins/ relative to playbook 12 years ago
Michael DeHaan 404b082d82 Version bump and assorted things to start new development version. 12 years ago
Michael DeHaan 3d21dab705 Small fix so template plugins can see inject variables. 12 years ago
Rike-Benjamin Schuppner 71afb9e432 Use with guard for file reads. 12 years ago
Rike-Benjamin Schuppner deaf499ba1 Remove duplicate host file reads by removing a legacy check.
This allows using a form such as

    ansible -i <( arbitrary command ) all -m ping
12 years ago
Andrew Straw 94e66ef558 allow apt-key module to work with binary key 12 years ago
Chris Church d1de7839d7 Renamed on_no_hosts_matched/on_no_hosts_remaining to correct names in noop callback, added methods to callback plugin examples. 12 years ago
Chris Church 3f17a39238 Set current play/task to None for callback context when finished running the current play/task. 12 years ago
Simon J Mudd 25822330a2 Add support for multiple ranges in a host
e.g.  db[01:10:3]node-[01:10]

- to do this we split off at the first [...] set, getting the list
  of hosts and then repeat until none left.
- also add an optional third parameter which contains the step. (Default: 1)
  so range can be [01:10:2] -> 01 03 05 07 09
12 years ago
bennojoy 017e7f24ed bug fix for #3077, environment settings for script 12 years ago
Joshua Lund 2ce7f136b2 * Added a sha256 method to module_common
* Added a sha256sum parameter to the get_url module to enable
cryptographic verification of downloaded files
* Fixed a few typos in the documentation
12 years ago
Chris Jacobs 588d4080df don't want to ignore explicit cwd 12 years ago
Chris Jacobs 69db160e2f Skip dotfile in hosts dirs 12 years ago
Serge van Ginderachter f1cf81b086 optimization when adding child groups 12 years ago
Peter Hudec e8ff3c43ad fixed first_available_file and roles support
for copy and template action
12 years ago
Steven Dossett e0a15d0c50 Updated to support inventory options from command line 12 years ago
Michael DeHaan c52abd40b0 Fix for the directory inventory source where depth information on the group was being discarded
due to initial copy.  New model will reuse the first object and copy attributes on the second.
12 years ago
Michael DeHaan be33bcf16f Merge pull request #3105 from shirou/devel
fix utf-8 named task failed with --step.
12 years ago
Michael DeHaan 3783dc42d4 normalize path 12 years ago
WAKAYAMA Shirou 66247042a5 fix utf-8 named task failed with --step. 12 years ago
Darryl Stoflet c0baf10845 Support for all:vars in script inventories 12 years ago
Michael DeHaan 3b77d17a26 Spelling fix. 12 years ago
Michael DeHaan 1f7c197a9d os.path.dirname returns '' not None in some cases, handle this so inventory can be specified with ./ 12 years ago
Michael DeHaan 4a93c247bd Another lookup plugin relative path tweak. 12 years ago
Michael DeHaan b8a66ce5bb Lookup plugins in included files now look in paths relative to their files, allowing role usage. 12 years ago
Michael DeHaan c4a125e6d9 Add ability to use |success and |failed as Jinja2 filters.
Example:

when: registered_variable|failed
12 years ago
Michael DeHaan 4840e59b90 Allow cowsay to be removed mid playbook run. 12 years ago
Steven Dossett 1ff93e6b08 Plugin with_inventory_hostnames - loops generated from groups or
hosts in inventory
12 years ago
Michael DeHaan 6cd3ba5b06 Allow the group_vars and host_vars directories to be stored alongside the playbook as well as inventory. 12 years ago
node a58baae2c4 Make the actual user used for executing play available as 'ansible_ssh_user' variable 12 years ago
Pol Llovet 4432c01ceb Handle '#' in var strings by splitting on ' #'
If someone has a " #" in a quoted var string, it
will interpret that as a comment and refuse to
load the inventory file due to an unbalanced
quote. Noisy failure > unexpected behavior.
12 years ago
Pol Llovet ba78360c52 Remove inline comments from inventory tokenizing. 12 years ago
Michael DeHaan fd77804bff Merge pull request #3017 from sergevanginderachter/roles-script
Add roles support for the script module
12 years ago
Michael DeHaan 44e32cc45e Some formatting fixes so docs will build, etc. 12 years ago
Michael DeHaan a9fcea5893 Merge branch 'escape' of git://github.com/ngrilly/ansible into repr 12 years ago
Jeremiah Heller 7de718cd51 Fix copy when force=no and update _remote_md5 docs.
Previously setting force=no caused copy to subversively
fail when target did not exist on remote host.

Caused by Runner._remote_md5 returning 1
when files don't exist, rather than 0.
12 years ago
Kavin Kankeshwar 8217e0706f Avoid crash in module_common when the file cannot be moved/copy 12 years ago
Serge van Ginderachter 0c0d6c0b4e performance optimization in inventory.groups_list()
don't calculate all hosts for every parent group of every group
when that parent group was already in the cache
12 years ago
Serge van Ginderachter dd9919342b hide magic variables used bin/ansible output
'verbose_override' and 'verbose_always'
12 years ago
Serge van Ginderachter 5859af7285 script support for roles: use the files/ directory
instead of an additional scripts/ directory
12 years ago
Michael DeHaan 3a635d2d26 Lots of formatting fixes 12 years ago
Michael DeHaan 11792a9daa Merge pull request #2987 from kentfrazier/sudo_user
Fix bug with include-level vars and sudo_user.
12 years ago
Michael DeHaan 84623441e1 Merge pull request #2945 from jsmartin/new_fetch
Fetch destination path can now be overriden.
12 years ago
Michael DeHaan 4fc6be8579 Merge pull request #2993 from SirScott/pkgng
Make pkgng and with_items result in a single module call.
12 years ago
Michael DeHaan 4b988dbd43 Merge pull request #2978 from bryanlarsen/basename
add basename and dirname to the core jinja2 filters
12 years ago
Michael DeHaan 27236cf598 Merge pull request #2998 from SirScott/runner-permissions
Ensure the tmp_path is sufficiently open.
12 years ago
Michael DeHaan 159ba7d68a Merge pull request #2956 from akerl/unicodefix
ignore unicode errors in stdout
12 years ago
Michael DeHaan 98a4331107 Merge pull request #2999 from ngrilly/python
Python
12 years ago
Michael DeHaan 5fdca267ac Merge pull request #3018 from dsedivec/devel
Plug-ins loaded from top-level plug-in directory
12 years ago
Serge van Ginderachter 94028852d9 Make debug module always verbose in playbooks
Created a new flag 'verbose_always' handled by
on_ok callback, similar to the 'verbose_override'
flag used by the setup module.
12 years ago
Dale Sedivec 611d56dc4c Plug-ins loaded from top-level plug-in directory
PluginLoader._get_paths, as of 391fb98e, was only finding plug-ins that
were in a subdirectory of one of the basedirs (i.e. in a category
directory).  For example, action_plugins/foo.py would never be loaded,
but action_plugins/bar/foo.py would work.

This makes it so that "uncategorized" plug-ins in the top level of a
directory such as action_plugins will be loaded, though plug-ins in a
"category" subdirectory will still be preferred.  For example,
action_plugins/bar/foo.py would be preferred over action_plugins/foo.py.
12 years ago
Serge van Ginderachter 4c9ebe8522 Add roles support for the script module
allows to put scripts directly in a dir within the
role:

 roles/<role>/scripts/..

Same as the copy and template module.

As requested in and closes #2969
12 years ago
Nicolas Grilly 75ceb80572 Escape args injected in new style modules 12 years ago
Scott Sturdivant 5516ece859 Ensure the tmp_path is sufficiently open. 12 years ago
Nicolas Grilly 7aee588918 Idiomatic Python: use in operator instead of method find 12 years ago
Nicolas Grilly 7babd30cf7 Idiomatic Python: use isinstance instead of type 12 years ago
James Martin 3c131dbd2b Initial Commit. 12 years ago
Scott Sturdivant d91bc1692e Make pkgng and with_items result in a single module call. 12 years ago
Kent Frazier 4c6583bd00 Fix bug with include-level vars and sudo_user.
If a variable was provided for an include, in either of these ways:

    ---
    - hosts: all
      tasks:
      - include: included.yml param=www-data
      - include: included.yml
        vars:
          param: www-data

and then that param was used as the value of sudo_user in the included
tasks:

    ---
    - name: do something as a parameterized sudo_user
      command: whoami
      sudo: yes
      sudo_user: $param

you would receive a "failed to parse: usage: sudo" error back and the
command would not execute.

This seemed to be due to a missing call to template.template somewhere,
because the final value being passed through ssh was still `$param`.
After some digging, the issue seems to instead have been a problem with
providing the wrong context to the template for expansion. Inside the
`Task` logic, it was passing `play.vars` as the context, where
`module_vars` seemed more appropriate. After replacing it, my test case
above ran without issue. There was a comment above suggesting that the
template call might be unnecessary, but removing it made the original
error return, since it is not getting escaped later down the line. I
removed the comment since it was inaccurate.

I tried to actually incorporate my test case above into the test suite
as a regression test, but was unable to figure out how to structure it.
The existing test infrastructure seemed to only be testing for correct
number of counts in things (ok vs. changed, etc.), without regard for
whether the content generated by the command is correct. If there is an
example of a test similar to this one (where I would want to check the
JSON generated to make sure sudo_user had been converted), please let me
know and I will be happy to submit an additional patch.
12 years ago
Bryan Larsen f629baef11 add basename and dirname to the core jinja2 filters 12 years ago
Michael DeHaan 753ebea186 Prefer categorized modules to uncategorized, such that if someone does an install on top of old content
the categorized modules will win over the 1.1 uncategorized modules, as the packages may not automatically
clean up the old content.
12 years ago
Michael DeHaan cd57d59913 If ansible is configured to use a log file but cannot write to it, exit, but don't traceback. 12 years ago
Michael DeHaan 496f06c3c9 Pass variables to lookup function for those that want to use them. 12 years ago
Michael DeHaan 16709ecd76 Replace tab with spaces. 12 years ago
Dimos Alevizos e96bc981ce Set paramiko's logging level
Excplicity set paramiko's logging level to WARNING.
By default it inherits ansible's DEBUG logging level (set in
callbacks.py) and fills the log file with useless debug messages.
Obviously it only applies if log_path is set in ansible.cfg
12 years ago
Les Aker 1179d1bbd8 corrected indentation 12 years ago
Les Aker 2adc335481 ignore unicode errors in stdout 12 years ago
Maykel Moya 60f24bb077 Remove unused modules 12 years ago
Maykel Moya f52e3dee70 Don't hardcode chroot executable path 12 years ago
Ben Ritcey 0938d4d89a Allow the remote MD5 checks to be run via sudo 12 years ago
Michael DeHaan 8475a92dec Merge pull request #2939 from mmoya/lookup-crypted-passwds
Add support for crypted passwords to password lookup
12 years ago
Stoned Elipot 94ba0f740a Fix for issue #2916 : for each host promote the host variables as globally scoped variables for the sake of the groups determination 12 years ago
Maykel Moya 45f5447f9f Fix name in copyright 12 years ago
Maykel Moya 96afc3f462 Add support for crypted passwords to password lookup
Added new parameter 'encrypt' with same semantics from that of
vars_prompt. When encryption is requested a random salt will be
generated and stored along the password in the form:
'<password> salt=<salt>'.

Also store passwords with an ending '\n' for easier looking at files
with console tools. File content was being already rstripped so this
is harmless.
12 years ago
Brian Coca 8dd72d2828 changed lockfile to be opened in write mode (solaris for one doesn't like
exclusive locks on read)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan f2a8c0d612 Fix listification inside of with_items so it runs more intelligently. 12 years ago
Michael DeHaan 161f3e3670 Merge pull request #2899 from sergevanginderachter/host-group-vars-no-subdirs
don't parse subdirs in host/group_vars
12 years ago
Michael DeHaan ff3625b0c9 Merge pull request #2902 from timhabermaas/fix-grammatical-error
Fix grammatical error in error message
12 years ago
Serge van Ginderachter 7eeab168bc bug fix in first_found search path assembly 12 years ago
Tim Habermaas 4d24faeeb1 Fix grammatical error in error message 12 years ago
Serge van Ginderachter a6b827ca07 don't parse subdirs in host/group_vars
as those are not supported in
core vars_plugins/group_vars.py
but might be used by other vars_plugins
12 years ago
Michael DeHaan 2a091a3505 Remove duplicate import. 12 years ago
Michael DeHaan a78edbb45c More pep8 12 years ago
Michael DeHaan 50586928b2 No need for trailing semicolon. 12 years ago
Michael DeHaan ea8302e68d Indentation. 12 years ago
Michael DeHaan 9f47d13306 Misc identation. 12 years ago
Michael DeHaan 0a1657080b Indentation fix 12 years ago
Michael DeHaan 3fdf15fa8a template code fixes for 'make pep8' 12 years ago
Michael DeHaan 3afa8b373e Improve check mode reporting for directories and file modes. 12 years ago
Michael DeHaan 05a4513a03 Merge branch 'group-by-global' of git://github.com/stoned/ansible into devel
Conflicts:
	lib/ansible/runner/action_plugins/group_by.py
12 years ago
Michael DeHaan 11176c0711 Merge pull request #2878 from DavidMikeSimon/devel
Dealing with invalid symlinks and symlink permissions
12 years ago
Michael DeHaan e4e6616169 Merge pull request #2872 from tima/fuzzy-match-localhost-127
Adds fuzzy matching of localhost to 127.0.0.1 host entries and vice versa
12 years ago
Michael DeHaan 344a30938c Merge pull request #2871 from tima/inv-host-entry-fix
Fixed bug where a host entry in the inventory represented as a dict w/o ...
12 years ago
Matt Coddington 542eeeb5d6 add option to ignore $legacy variable style substitution 12 years ago
Michael DeHaan ad777f6538 Fix contrib link. 12 years ago
Stoned Elipot 75100201a2 Allow globally scoped variables with group_by module's conditionals and key argument 12 years ago
David Simon 190ce16bab Dealing with invalid symlinks and symlink permissions 12 years ago
Timothy Appnel 20bf5f130d Adds fuzzy matching of localhost to 127.0.0.1 host entries and vice versa. 12 years ago
Timothy Appnel b15cc3e2b4 Fixed bug where a host entry in the inventory represented as a dict w/o a hosts or vars key was treated as a group and its vars essentially ignored. 12 years ago
Michael DeHaan d1d3f4b4d2 Merge pull request #2842 from bcoca/cleanup
generalized cleanup and removed atomic_move return
12 years ago
Brian Coca 3ac6c45499 generalized cleanup function, in case modules want to use
removed return code as it doesn't make sense anymore
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan f87ac5ce29 Merge pull request #2841 from jimi1283/issue_2820
BUGFIX - --start-at-task= works only with --step
12 years ago
Michael DeHaan 9ed177e25e Merge pull request #2840 from toshywoshy/devel
Patch so that delegate_to also uses ansible_ssh_private_key_file
12 years ago
James Cammarata 2440861b1b BUGFIX - --start-at-task= works only with --step
From issue #2820, --start-at-task does not actually run tasks
unless --step is specified. This appears to be because skip_task
is being evaluated as True in PlayBook._run_task(). This patch
ensures skip_task is set to False in the callback.
12 years ago
Toshaan Bharvani 62b53f4d2c changed the delegate_to to also use ansible_ssh_private_key_file from the inventory file 12 years ago
Gilles Cornu 68f7ea6099 Apply Gilles's patch to atomic_move based on github comment. (Email address not supplied
since wasn't from a pull request)
12 years ago
Brian Coca bdeb370d79 fixed case in which move fails after remote user copies file and sudo to non root does the move
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan c3547a2308 Moar SELinux. 12 years ago
Michael DeHaan fb7bfa61a9 Fix SELinux context on atomic_move 12 years ago
Michael DeHaan 4ecc7ea2e0 Merge pull request #2817 from sfromm/issue2810
Set selinux context on file after shutil.move in atomic_move()
12 years ago
Serge van Ginderachter 53a7ab74c8 use os.path.join instead of hardcoded unix separator in first_found lookup plugin 12 years ago
Stephen Fromm 50e94e4a2f Set selinux context on file after shutil.move in atomic_move()
This is intended to fix #2810.  It sets the context of the tmp_dest file
after shutil.move() operation and before os.rename().  This should
retain the selinux context of the file across moves.
12 years ago
Michael DeHaan 7117ca5395 Allow modules in a "./library" directory to be referenced by their shortforms "modulename:" instead of just "action: modulename" 12 years ago
Michael DeHaan e90023281d Slightly refine log output to include username in addition to pid. 12 years ago
Michael DeHaan ba8f2fca26 Merge branch 'add_pid_to_logging' of git://github.com/mcodd/ansible into devel 12 years ago
Stoned Elipot df3c4849e9 Also load Jinja2 extensions when processing template from string 12 years ago
Michael DeHaan 4bea9a612f Don't use "finally" here as it's not 2.4 compliant. 12 years ago
Michael DeHaan 68f711d5ae teach plugin loader to find modules in subdirectories 12 years ago
Michael DeHaan 391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago
Michael DeHaan a81089231e Register skipped tasks so we can at least check their changed/not-changed status. 12 years ago
Kahlil (Kal) Hodgson 9f90f0e856 fix arguments to isinstance() in env lookup 12 years ago
Matt Coddington 3b8f69bac8 add pid to log 12 years ago
Stoned Elipot 75b51f79b4 Add module path library/ if it exists in role directory 12 years ago
Michael DeHaan 75cf5c985b Allow playbook tags to be comma seperated strings as well as lists 12 years ago
Michael DeHaan bcac289667 Cows don't need to display brackets around strings. 12 years ago
Michael DeHaan 016b04dff1 Merge branch 'roles_dir_search_order' of git://github.com/mcodd/ansible into devel 12 years ago
Brian Coca caf6bd6ce5 Changed atomic_replace to atomic_move, now ti DOES move atomically in the last
step
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan b8fdcff524 Merge branch 'nocows' of git://github.com/jpmens/ansible into devel
Conflicts:
	lib/ansible/callbacks.py
	lib/ansible/constants.py
12 years ago
Michael DeHaan 553751aee1 Merge branch 'numeric_ids_refactor' of git://github.com/insom/ansible into testing_427 12 years ago
Michael DeHaan aa55268514 Adds a logfile for ansible playbooks that can be set by the environment or configuration file. 12 years ago
Michael DeHaan 515fbd5a17 Restructure output to prevent rare cases of interlaced I/O in multiprocessing paths. 12 years ago
Matt Coddington c164609dd6 typo fix 12 years ago
Matt Coddington c83c534a7d Search for roles in the roles subdir first. Throw an error when no role .yml files are found. 12 years ago
Michael DeHaan 5af271911b Fix duplicate handler notification issue in 1.2 devel 12 years ago
Michael DeHaan 224e20ca60 complex_arg templating should be smarter. Make it so! 12 years ago
Aaron Brady bd226eb826 Refactor user_and_group so it works off of numbers
There are various cases where a UID to username to UID mapping breaks
down. One UID can be used by two usernames, or no username. If we
always use UIDs internally, then these ambiguous cases won't be a
problem.
12 years ago
Aaron Brady d2e457f81f Accept numeric user and group parameters 12 years ago
Jeroen Hoekx ac7a632711 Remove leftover debug statement in template code. 12 years ago
Michael DeHaan 21fe750cef Flush handlers before pre and post task sections change, but not between task and roles, as this seems
to be confusing to people (and not usually neccessary)
12 years ago
Michael DeHaan 6fdfbb1a34 Improve variable smushing so it only has to be done in one place. This is related to shlex.split being called
on untemplated variables in some rare cases.
12 years ago
Michael DeHaan af2fb56a10 Changes to allow WANT_JSON to allow JSON to non-Python modules 12 years ago
Stephen Fromm 189b210f5a Catch exception when logging to systemd journal fails
systemd journal will throw IOError exception when journal.sendv() fails.
This catches that and falls back to syslog.  See issue #2773.
12 years ago
Jan-Piet Mens dfd885a012 Make ANSIBLE_NOCOWS configurable
nocows = 1 in ansible.cfg
	or old environment variable ANSIBLE_NOCOWS=1
add to ansible.cfg example
12 years ago
Michael DeHaan bd0c22868e With fileglob should return full paths as in 1.1 12 years ago
Michael DeHaan 35e61d8f16 Merge pull request #2688 from dagwieers/module-global
New module 'set_fact' to define host facts
12 years ago
Michael DeHaan be947e5266 Resolve merge conflict 12 years ago
Michael DeHaan 9871707998 If sudoing and the sudo user is not root, the original file is saved as you, therefore delete that file as you. 12 years ago
Michael DeHaan e12f91799c Allow args: var to be used to pass a variable in bare, and also templated versions should also DWIM. 12 years ago
Michael DeHaan 6c778acd91 Smush the braces in various places (hey, that rhymes) to avoid undo key=value splitting surprises
in new template system.
12 years ago
Michael DeHaan 5cced79cf3 Allow variables to be used raw in with_nested 12 years ago
Michael DeHaan fbea88b9d9 Allow the environment string to be referenced by a bare variable name like:
environment: foo
12 years ago
Michael DeHaan f9f1d5ee42 Merge pull request #2745 from sfromm/issue2742
Fix test so that it is /bin/sh compliant (issue #2742)
12 years ago
Stephen Fromm ab3cb4912e Fix test so that it is /bin/sh compliant (issue #2742)
The old test used syntax that appeared to be bash-specific and did not
work on platforms where /bin/sh did not point to bash.  See issue #2742
where copy to solaris hosts failed with the error:

    output: {'stdout': '', 'stderr': '/bin/sh: test: argument expected\n',
             'rc': 1}
12 years ago
Michael DeHaan 3e0c33c1fa Empty plays should still gather facts 12 years ago
Michael DeHaan b08181e9b4 Merge pull request #2731 from stoned/flush_handlers-cleanup
handlers must be run once
12 years ago
Michael DeHaan 08324cb5d7 Allow play tagging in context of new meta-tasks. 12 years ago
Stoned Elipot 747c7f0dff handlers must be run once
so remove all occurences of each host from the handlers notified by
lists
12 years ago
Michael DeHaan 32fb6c807c Allow handlers to run in between pre_tasks, roles, tasks, and post_tasks. 12 years ago
Michael DeHaan 37789a852a Rename set_up and tear_down to pre_tasks and post_tasks 12 years ago
Michael DeHaan d7623d1f91 Added a 'set_up' and 'tear_down' which are like tasks, but execute before and after roles. 12 years ago
Michael DeHaan e6bf01a6b0 Make plugin loader path operations more efficient. 12 years ago
Michael DeHaan 5a8dff5bce Instantiate inventory plugins only once for efficiency reasons. 12 years ago
Michael DeHaan 817b0cdc80 Instantiate filter plugins only once to save some efficiency. 12 years ago
Michael DeHaan 6e1514e975 Merge pull request #2727 from dsedivec/devel
Don't send unicode instances to the selinux module
12 years ago
Michael DeHaan 5b44c3d52c Merge commit '53ac0bb' into devel 12 years ago
Michael DeHaan 87788b1d17 Ignore inventory config files when using an inventory directory. 12 years ago
Michael DeHaan 53ac0bbec2 Instantiate callback plugins only once so we can set play/task objects on them and they'll stick. 12 years ago
Dale Sedivec c8f4a56cad Don't send unicode instances to the selinux module
This fixes #2632.  Briefly: specifying things like paths using complex
args in a playbook will make the objects unicode instances.  The selinux
module does not accept unicode instances for its char * arguments; it
wants str instances.

Per mpdehaan's comment on #2632 I just went ahead and converted all
paths to UTF-8.  I don't know if it would be better to do something like
converting to locale.getpreferredencoding(), but I factored all the
conversions out into new method _to_filesystem_str, so there's only one
place that needs to be changed in the future.
12 years ago
Michael DeHaan df93d7dd97 Ignore inventory config files when using an inventory directory. 12 years ago
Michael DeHaan 8e7dc3c79c Remove an extra space in the module execution line if no environment was set. 12 years ago
Dag Wieers b13beb3689 New module 'set_fact' to define host facts
This module allows you to set host facts (or export play variables to the playbook scope if you fancy that).

The module also accepts complex arguments.

```yaml
 - action: set_fact fact="something" global_fact="${local_var}"'
 - action: set_fact
   args:
      fact: something
      global_fact: ${local_var}
```
12 years ago
Seth Vidal 7b8cec3f59 clean up first_found to fix a few issues:
- add a skip option so it won't raise an exception if you don't match anything
 - make it work as a drop-in replacement for first_available_file
 - document in the module comments all of the above cases
12 years ago
Michael DeHaan 5f1e2afc34 Revert "make atomic_replace use shutil.copy2 instead of os.rename() so it will work across filesystems".
AR function was leaving some tmp files behind, want to revert, will have better implementation soon, this is the old way now.

This reverts commit f74a1fa4f0.
12 years ago
Michael DeHaan d8bf87b008 (A) include errors in inventory scripts should they occur.
(B) allow registration with ignore_errors: True
12 years ago
Bernhard Weitzhofer fb0a99e5d8 Fix if-statement that always evaluates True 12 years ago
C. Morgan Hamill 88eb5516eb Fix 'sequence' plugin error.
If 'terms' is a string, replace it with a single item list.
12 years ago
C. Morgan Hamill 663d37b537 Fix errors in lookup plugins.
Lookup plugins 'sequence' and 'template' now import 'ansible.utils'
appropriately in order to use the 'listify_lookup_plugin_terms'
function.

Also, 'dnstxt' and 'env' now check to see if 'terms' is a string;
without this calls like '{{ lookup('env', 'HOME') }}' fail.
12 years ago
Dale Sedivec 515fd9e915 copy action plug-in check mode respects force=no
The copy action accepts force=no, which tells it not to replace an
existing file even if it differs from the source.  The copy action
plug-in wasn't respecting this option when operated in check mode, so it
would report that changes are necessary in check mode even though copy
would make no changes when run normally.

Runner._remote_md5 was changed to make the logic for setting rc perhaps
a little more clear, and to make sure that rc=0 when the file does not
exist.
12 years ago
Michael DeHaan 7c6341718e Merge branch 'combine_vars' of git://github.com/laggyluke/ansible into exp
Conflicts:
	lib/ansible/inventory/vars_plugins/group_vars.py
	lib/ansible/runner/__init__.py
	lib/ansible/utils/__init__.py
	test/TestPlayBook.py
12 years ago
C. Morgan Hamill 863cb50530 Allow '.yml'/'.yaml' extension on group_vars files.
Look for a file with the base name of the group/host, first without
a file extension, then with a '.yml' extension, and, finally, with
a '.yaml' extension, loading vars from only the first one found.
12 years ago
Michael DeHaan b54e955595 Remove a debug statement. 12 years ago
Michael DeHaan 86d47bce5f Make more lookup plugins tolerant of new variable system, with a little better 'do what I mean' logic to resolving
what happens if you get a string back as a template result.
12 years ago
Michael DeHaan c0f8af5202 Make more lookup plugins happy with newstyle variables. Not quite done, but this fixes up with_items/with_nested/file/fileglob. 12 years ago
Seth Vidal f74a1fa4f0 make atomic_replace use shutil.copy2 instead of os.rename() so it will
work across filesystems
12 years ago
Michael DeHaan 0944e7d56a Make less template calls on playbook objects. 12 years ago
Michael DeHaan 44a9352338 Also template handlers only at the end. 12 years ago
Michael DeHaan e7f5186dec Merge pull request #2623 from willthames/when_set_bug
Prevent premature variable substitution in tasks
12 years ago
Michael DeHaan 3ab0ed5fd4 Allow 'when' and 'with_items' to be applied to roles. 12 years ago
Michael DeHaan 7a2d493e67 Teach lookup plugins that if they can't evaluate something they can wait and do it later. 12 years ago
Michael DeHaan 3f3b2a9448 Smush Jinja2 braces in playbooks so unresolved variables get parsed nicely 12 years ago