Commit Graph

49007 Commits (6a1f82f1745c94cd078aa1ebf18ca5e3a8f9c236)
 

Author SHA1 Message Date
rule88 6a1f82f174
url lookup - add options to match those in urls.py (#64892)
Add 'force_basic_auth' option
By default "force_basic_auth" option is set to False, with this adjustment it is up to the user if it wants to enforce basic authentication.
5 years ago
Rick Elrod e2a57414f4 Remove `with` statement for pytest-mock unit tests
As per:
https://github.com/pytest-dev/pytest-mock#note-about-usage-as-context-manager
pytest-mock is not meant to be used within a `with` context or as a
decorator. Instead, pytest-mock will automatically unpatch the mocked
methods when each test is complete.

In newer pytest-mock, this use actually throws an exception and causes
the tests to fail.

This hasn't been hit in Ansible's CI yet, because the docker image
that the tests run in uses an older version of pytest-mock. However,
there is no constraint on the upper bound of pytest-mock in
test/lib/ansible_test/_data/requirements/constraints.txt which means
that when running the tests locally, outside of that docker image, the
tests never pass.

This patch removes the `with` context in each such case.

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
Mark Chappell 1156962cde
Forbid `state=(list|info)` in modules via ansible-test sanity check
PR #66898

This change introduces a new sanity check with code
`parameter-state-invalid-choice` in the `ansible-test sanity`
validator. It enforces modules not to support `list` or `info`
as their `state`.

Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-Authored-By: Felix Fontein <felix@fontein.de>
5 years ago
Gonéri Le Bouder 6e2fff1acc vmware_vswitch/test: clean up vmswitch_0002
Ensure `vmswitch_0002` get removed from ESXi2 at the end of the test.
5 years ago
Matt Clay e64b279ea1 Add CS smoketest group for CI. 5 years ago
Jiri Hnidek 6f1bb37feb
When no pool quantity is set, then do not set quantity to 1 (#66807)
* Fixes #66478
* When no quantity is set, then candlepin server usually uses
  default value 1. When more quantities are required, then
  candlepin server can automatically choose correct minimal
  value.
5 years ago
Sam Doran 9276dd2007
file - change warning to error (#66671)
When 'src' is specified without 'state', raise an exception
5 years ago
René Moser 91063f40d6
tests: ipify_facts: retry on fail (#66897) 5 years ago
ngp-star 8ba324a33d
VMware: shares and io limits support while adding new disk (#64087)
Fixes: #25714
5 years ago
Joseph Hobbs 72fbbbeb34
Typo correction (#66869)
* Corrected typo in documentation
* Corrected typo in the log statement
5 years ago
Andrew Klychkov 308723c3ca
postgresql_idx: revert PR for 64138 (#66889) 5 years ago
René Moser 4752547d35
ecs_tag: remove state=list (#66811)
* ecs_tag: remove state=list

* adjust tests
5 years ago
Matt Clay 3c3cf50e7a Fix ansible-test coverage of ansible-connection. 5 years ago
Matt Clay 21069c84d9 Fix ansible-test color `ls` logic. 5 years ago
Matt Clay 428aaf7e65 Keep SSH authorized keys in ansible-test setup. 5 years ago
Matt Clay efd2dd8929 Add more ansible-test args to delegation config. 5 years ago
Matt Clay ee50792416 Add a `--no-pip-check` option to ansible-test. 5 years ago
Matt Clay 0971a0e7bc Consolidate remote Shippable scripts. 5 years ago
Eitan Adler 86663abf37 all: fix all the the duplicate words (#66784) 5 years ago
Geri Jennings b482857fd3 Update conjur_variable.py (#66763)
Update the link in the Conjur documentation to point to the correct current URL
for information on Conjur machine identity.
5 years ago
Slawek Zachcial 9656811e7c Fix virtual private gateway filters reference link (#66772) 5 years ago
Mark Chappell 35652ca788 Add tests to make sure that the documented 'elements' matches that defined in argument_spec (#66385)
* Add tests to make sure that the documented 'elements' matches that defined in argument_spec

* Mass-add test/sanity/ignore.txt
5 years ago
Sam Doran 3461c682c3
Add mechanism for storing warnings and deprecations outside of AnsibleModule (#58993)
* Move warn() and deprecate() methods out of basic.py
* Use _global_warnings and _global_deprications and create accessor functions
    - This lays the foundation for future functions being moved outside of AnsibleModule
       that need an interface to warnings and deprecations without modifying them.
* Add unit tests for new warn and deprecate functions
5 years ago
Sam Doran cc2376b782 include_vars - fix stack trace when run ad-hoc with dirs parameter (#66581)
Add integration test

There are a number of other parameters that result in stack traces as well when this module is used ad-hoc. I'm not sure if we're interested in fixing them all since this module isn't meant to be run ad-hoc.
5 years ago
Aldo Bongio 3f16752ed2 Remove misleading slash on prefix examples (#66842)
##### SUMMARY
S3 lifecycle rule prefixes starting with slash (/) have no effects. If an S3 bucket contains a file 'apache.log' under the (virtual) folder 'logs/', for the lifecycle rule to be effective the prefix to be configured must be 'logs/'. If you put '/logs/' (with a trailing slash) as a prefix the file will never be matched by the lifecycle rule.
5 years ago
Martin Nečas b74ca2fe4f ovirt_network: correct when not specified external_provider (#66859) 5 years ago
Marko Kohtala d385a648c4 uri: Document cookies_string, cookies and content (#66612)
The example with set_cookie value in cookie header can fail if the server
has set many cookies. The set_cookie value is the cookies sent by server in
set-cookie header, not what the client should send in cookie header to
server.

#33792 introduced cookies_string to solve the problem, but did not update
the uri module example.

content and cookies were also missing from RETURN.
5 years ago
Martin Krizek 365f2aaed1 get_url: remove deprecated headers string format (#66649)
Fixes #61891
5 years ago
Toshio Kuratomi abc8b0ae73 This was changed to python 2.7 but should have remained python 2.6 (#66836)
* Modules are still python-2.6+ unless there's a compelling reason not
  to be.
5 years ago
Mark Chappell 5ff899662d Add sanity test to require elements entry when argument type=list (#66386)
* Require elements entry for lists

* Bulk add initial test/sanity/ignore.txt
5 years ago
John R Barker 6901c9c61c botmeta: Fix f5_modules typo (#66847) 5 years ago
Abhijeet Kasurde e3ce0d3612 Assign team_aireos to team_ansible (#66798)
Since there are no members in team_aireos, assign maintainership
to team_ansible for now.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
René Moser 78e666dd39
vultr: improve handling of dicontinued plans (#66792)
* vultr: improve handling of dicontinued plans

* add changelog
5 years ago
Walter Sosa 2dc9841806 doc: Fix tiny typo in example: change --> changed (#66835)
##### SUMMARY
Fixed another tiny typo: change --> changed

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
5 years ago
willtome 94f30b3815 Migrate ServiceNow modules to Collection (#66818)
* adding snow files

* remove duplicate
5 years ago
digi 5409904c35 vmware_cluster_facts: adds list of host in cluster (#61006) 5 years ago
sky-joker 65aedc5d4a VMware: Change node_wwn and port_wwn for FC HBA to hexadecimal value
Fixes: #63045
5 years ago
Matt Clay 5c1fe78685
Move CI coverage stub to sanity/5. (#66827) 5 years ago
Alex Stephen cba0feab18 folder support on gcp_compute (#66511)
* folder support on gcp_compute

* fixed issues associated with projects with no vms

* linter fix

* more linter

* linter
5 years ago
Matt Clay 965854fbd2
Add constraints for Jinja2 on Python 2.6. (#66826)
* Add constraint for Jinja2 on Python 2.6.

* Fix constraint in inventory_aws_conformance test.

* Add constrraints for template_jinja2_latest test.
5 years ago
Martin Krizek 4ca0c7f116 Fix case sensitivity for lookup() (#66521)
This brings consistency to lookup(), with_ and ansible-doc.

Fixes #66464

* Add a porting guide entry
5 years ago
Gonéri Le Bouder 3ce6440515 vmware_export_ovf: increase default timeout
I consistently reach a timeout with the current (10s) timeout. This
commit increases the default value to 30s, this should simplify the life
of our users.
Also, the documentation was incorrect. The value is in second, not minute.
5 years ago
Gonéri Le Bouder bdceab379e vmware: adjust the module/Zuul jobs mapping
- vmware_host_active_directory: we need an Active Directory to run the
  test
- vmware_vm_storage_policy_info: we just need a vcenter
5 years ago
Felix Fontein 8cff585891
Schema validation for argument_spec (#65747)
* Start of schema for argument_spec

* Add changelog.

* Remove superfluous import.

* Update ignore.txt

Co-authored-by: Matt Martz <matt@sivel.net>
5 years ago
Sergey 8f2e30a0cf Update botmeta with migrated openstack modules (#66789) 5 years ago
Markus Fischbacher 055cf91d02 zabbix_template - enable new update rule to delete missing linked templates (#66747)
* enable new update rule to delete missing linked templates

New update rule is available from 4.0.16 and 4.4.4 up. Add check for version and enable new update rule.

fixes #66720

* adding fragment file

* Update zabbix_template.py

* Update zabbix_template.py
5 years ago
Mark Chappell 99d7f15087 Mark the hacking AWS policies as owned by team_aws (#66793) 5 years ago
Martin Nečas d7a1917c17 ovirt_host: add iscsi portal (#66750)
* ovirt_host: add iscsi portal

* correct version_added to 2.10
5 years ago
Fred-sun f1ec48429a Add changed condition (#66230) 5 years ago
Jill R a1f6c611b7 Add team_aws for aws modules, and add new maintainer (#66774) 5 years ago