Commit Graph

8802 Commits (5272eab40c18e96ff42c5f421d81c6ed8bdffcc1)
 

Author SHA1 Message Date
Rob Smith 761fe8cc04 Fix an issue where git-pull fails with AttributeError
As part of 94f3b9bfab the code was changed to support dynamically adding localhost to the inventory. This change introduced an crash when run via ansible-pull

```
Starting ansible-pull at 2014-01-20 23:09:57
Traceback (most recent call last):
  File "/tmp/ansible/bin/ansible", line 157, in <module>
    (runner, results) = cli.run(options, args)
  File "/tmp/ansible/bin/ansible", line 82, in run
    hosts = inventory_manager.list_hosts(pattern)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 372, in list_hosts
    result = [ h.name for h in self.get_hosts(pattern) ]
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 136, in get_hosts
    subset = self._get_hosts(self._subset)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 177, in _get_hosts
    that = self.__get_hosts(p)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 198, in __get_hosts
    hpat = self._hosts_in_unenumerated_pattern(name)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 275, in _hosts_in_unenumerated_pattern
    ungrouped.add_host(new_host)
AttributeError: 'NoneType' object has no attribute 'add_host'
```

The root cause is there is no group for the host to be added to. I fixed this case by creating the ungrouped group when it doesn't exist and then adding the host to the newly added group. This fixes the regression for me.
11 years ago
jctanner 4b9127f0af Merge pull request #5695 from kormoc/fix_git_check_hostkey_2
Fix case where there is a ~/.ssh/known_hosts file and the host key is only in /etc/ssh/ssh_known_hosts
11 years ago
Rob Smith 953dc6b345 When not finding a host in ~/.ssh/known_hosts, the return value is 0 if the host just is not found. We then never check the system host file in /etc. This fixes the code to check /etc on any failure, not just a bad return code. 11 years ago
Paul Durivage f72f5a20df Revert "Revert "Merge pull request #5325 from angstwad/add-su-support""
This reverts commit c17d0e0357.

Conflicts:
	lib/ansible/runner/connection_plugins/paramiko_ssh.py
11 years ago
Paul Durivage 4c84ba74b0 Resolve su bug in paramiko libs 11 years ago
Jesse Keating 6013f0738e Store the list of hosts to run on in runner object
This reduces the number of times inventory.list_hosts is called, which
can be costly. When coming from a playbook that data is already known.
11 years ago
Jesse Keating e8ad36c8d4 Store hosts for a play as a play attribute
Operate on that play attribute to make things faster for larger
inventories. Instead of making a round trip through inventory.list_hosts
and working through some lengthy list comprehensions over and over
again, calculate the potenital hosts for a play once, then reduce from
it the unavailable hosts when necessary.

Also moves how the %fail is done. The host count is a play level count
of available hosts, which then is compared after each task to the
current number of available hosts for the play. This used to get a new
count every task which was also time expensive.
11 years ago
Michael DeHaan 24f11168d9 Update CHANGELOG.md 11 years ago
Michael DeHaan f420af0676 Update CHANGELOG.md 11 years ago
James Tanner 94f3b9bfab Fixes #3129 Do not require localhost to be in inventory 11 years ago
Matt Martz 89fbc64b60 Fix regex match, the printf match should work with 0 or more numeric padding characters, not 1 or more 11 years ago
James Tanner c17d0e0357 Revert "Merge pull request #5325 from angstwad/add-su-support"
This reverts commit 6f4bfa2cff, reversing
changes made to c91ba3a7c7.
11 years ago
jctanner 6f4bfa2cff Merge pull request #5325 from angstwad/add-su-support
Proposing fix for Issue #4324; adding support for su
11 years ago
Michael DeHaan c91ba3a7c7 Merge pull request #5680 from biolds/devel
Mark stat module as supporting check_mode
11 years ago
Paul Durivage 8cf071f697 Hostvars support for su 11 years ago
Paul Durivage dec9131735 Ensure playbook support for su params 11 years ago
Paul Durivage d21281ff43 Resolve rebase conflicts 11 years ago
Paul Durivage ab6ee1a282 Enable su support in paramkio; disable su support in fireball, local, accelerate, chroot, jail, funcd connection plugins 11 years ago
Paul Durivage c95be4ceaa Make sudo and su command line arguments mutually exclusive 11 years ago
Paul Durivage 4088243deb Proposing fix for Issue #4324; adding support for su in connection plugins ssh, ssh_alt
Fixes for ssh_alt support, adding in references to in_data where appropriate
11 years ago
jctanner 297a28aa79 Merge pull request #5333 from mvermaes/yum_fix
yum module: Attempt #2 to cause yum to fail on invalid url
11 years ago
jctanner 7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
11 years ago
Michael DeHaan 2060ae550a Update changelog 11 years ago
Michael DeHaan 26676ce2e2 update default EC2 exclude regions -- this should be the best configuration for most users, but some may still want to tweak. 11 years ago
Jakub Jirutka 012e3ae206 Fixes #5679: lineinfile ignores newline in line argument 11 years ago
Laurent Defert f93b951bdd Mark stat module as supporting check_mode 11 years ago
Simon Zimmermann 3db808c840 correctly compare the values, better func name 11 years ago
Simon Zimmermann 055b404f13 Correctly compare values as returned from 'sysctl -e -n' 11 years ago
Michael DeHaan e3e6f02835 Merge pull request #5669 from mscherer/fix_synchronize_local
Make synchronize module work better with local transport, fix #5668
11 years ago
Michael DeHaan 0afa0b4aed Merge pull request #5672 from simonz05/patch-1
fix str format error due to missing '%' in sysctl module
11 years ago
Simon Zimmermann 7495095496 fix str format error due to missing '%' in sysctl module 11 years ago
Michael DeHaan b8676203b9 Merge pull request #5586 from tbielawa/spiff_up_plugins
Spiff up the 'Developing Plugins' page
11 years ago
Michael Scherer 5c5c8fd7ce Make synchronize module work better with local transport, fix #5668 11 years ago
James Tanner 3bd99903a4 Fixes #5661 Handle null values for sysctl parameters 11 years ago
Michael DeHaan 3064ca94e9 Merge pull request #5665 from Taytay/devel
Colon in example failure message causes a YAML compile error
11 years ago
Taylor Brown 5fce765601 Removing colon from example failure message
The example failure message was given as - fail: msg="Bailing out: this play requires 'bar'"

The colon in the example causes a YAML compile error, so I am replacing it with a '.'
11 years ago
Rutger Spiertz dec6345fe6 PlayBook: better error message
When a PlayBook has missing arguments the error message now shows which ones are missing.
11 years ago
Michael DeHaan 2a46022bc7 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
11 years ago
jctanner 450bb37c8c Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
11 years ago
James Tanner 19cb22b6df Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
11 years ago
rishid 34f9349b5e Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
11 years ago
James Tanner 559e89036b Fixes #5631 Return a unique list of hosts when joining groups 11 years ago
James Cammarata 02ce5af6df Added ANSIBLE_SSH_PIPELINING option to enable/disable pipelining support
Pipelining will be disabled by default, since it requires users remove
the 'requiretty' option from the servers sudoers configuration.
11 years ago
Scott Gilbert 0aedd0c0b2 Allow keystring passed to authorized_key to contain blank lines and comments 11 years ago
James Tanner 2c39576e80 Remove unused variable from authorized_key 11 years ago
jctanner 1f1fa6c09a Merge pull request #5322 from bcrochet/neutron-fip-select
quantum_* modules: Neutron name change, keeping backward compatibility
11 years ago
James Cammarata 233aae5861 Reverting paramiko_ssh/alt changes from yesterday 11 years ago
Rene Moser 849aab0a12 apt: fixed pkg=<name>=<version> fails if package is not yet installed.
Reported and patch provided by https://github.com/msolo. Closes GH-5625.
11 years ago
Michael DeHaan 87e7b9e5cc Merge pull request #5640 from willthames/ec2_elb_docs
ec2_elb module: Minor improvements to documentation
11 years ago
willthames 238da3cb02 ec2_elb module: Minor improvements to documentation
ELB(s) cause a weird formatting behaviour - it appears as EL**s**
Added choices documentation to the state option
11 years ago