Commit Graph

27652 Commits (48dee1b6d010143e72c35aba911c0d5fc4d647e5)
 

Author SHA1 Message Date
Brian Coca 48dee1b6d0 still needs static for task object 8 years ago
Dag Wieers 39c9c6b942 Ensure that command/shell errors are displayed
This fix ensures that if there are specific module errors (in our case
the python interpreter was not found) then command and shell returns a
proper error.

It also fixes a few other imperfections that we noticed during
troubleshooting:

- Return the real RC if it were available
- Improve a dictionary evaluation using .get()
- Return an RC of -1 if it is unknown (instead of returning 0)

This fixes #18846
8 years ago
Dag Wieers 41614fd8e6 Display proper error on group_vars syntax error
This fix ensures a proper error is shown when a group_vars files cannot
be parsed correctly. Without this patch you get:

```
[dag@moria ansible.testing]$ ansible-playbook test132.yml
ERROR! Unexpected Exception: dictionary update sequence element #0 has length 1; 2 is required
to see the full traceback, use -vvv
```

With this patch you get:
```
[dag@moria ansible.testing]$ ansible-playbook test132.yml
ERROR! Problem parsing file '/home/dag/home-made/ansible.testing/group_vars/test135': line 1, column 1
```

This fixes #18843
8 years ago
Brian Coca 5d82fe545f minor docs and option fixes 8 years ago
Brian Coca 884b529195 removed unused 'static' option
the task level directive is what actually controls this, this option was never used
8 years ago
Simon Wydooghe f97e6f8903 Bracket forgotten in inventory file 8 years ago
Jake Morrison 00859a4ced Handle inability to read /proc for ansible_service_mgr. Fixes #18957 8 years ago
Adrian Likins 5cd7a08418 Check solaris 'smbios' is exists before running it
smbios could potentially be None here, possibly causing
the solaris 8/9 failures seen at #19282

Fixes #19282
8 years ago
Ryan S. Brown 5204024f35 `s3_sync` module: Add ANSIBLE_METADATA parameter 8 years ago
tedder be7a568b33 New module `s3_sync`: boto3-powered s3 synchronization
Syncs groups of files faster than the `s3` module and support content
type detection/overriding and globbing.
8 years ago
Fabio Alessandro Locati f1b5dde4cb Improve YAML examples - packaging/kibana_plugin.py (#19409) 8 years ago
Dag Wieers 2f90091f0a Add an important example for SSHd
Sudoers is a great example to show how you can prevent shutting yourself
out. But SSHd is at least as important to avoid syntax errors causing a
lot of grieve. So I think it deserves a spot in this list :-)
8 years ago
Fabio Alessandro Locati fb0779f657 Improve YAML examples - windows/win_regedit.py (#19400) 8 years ago
Fabio Alessandro Locati b6f2565d60 Improve YAML examples - windows/win_template.py (#19408) 8 years ago
Fabio Alessandro Locati beb6ed08cd Improve YAML examples - windows/win_owner.py (#19406) 8 years ago
Fabio Alessandro Locati 12205598c3 Improve YAML examples - windows/win_acl_inheritance.py (#19405) 8 years ago
Fabio Alessandro Locati 5a87f26658 Improve YAML examples - windows/win_get_url.py (#19404) 8 years ago
Fabio Alessandro Locati 5f8f1fa782 Improve YAML examples - windows/win_iis_webapppool.py (#19403) 8 years ago
Fabio Alessandro Locati 83d0f621da Improve YAML examples - windows/win_iis_webapplication.py (#19402) 8 years ago
Fabio Alessandro Locati f57418c2c1 Improve YAML examples - windows/win_user.py (#19401) 8 years ago
Fabio Alessandro Locati 9b3d9e1780 Improve YAML examples - windows/win_file_version.py (#19399) 8 years ago
Fabio Alessandro Locati 0aa16b36b7 Make the example in proper yaml format - windows/win_iis_virtualdirectory.py (#18829)
* Make the example in proper yaml format

* Add r
8 years ago
Fabio Alessandro Locati 75bcec0ef5 Fix conflict and typos (#18831) 8 years ago
Nathaniel Case 2405c0bbef Hopefully clear up some junos issues. (#17616) 8 years ago
Eric Beahan dce8f3899e Modify an initial value causing exception when vlan_range param is present (#19019) 8 years ago
Tim Rupp e0e1d3b561 Adds description parameter to pools (#19362)
This patch adds the description parameter as a supported param of
the bigip_pool module.

Tests for this change are available here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_pool/tasks/main.yaml#L732
8 years ago
Nathaniel Case 7900319fc3 Assorted python3 fixes for network code. (#18777) 8 years ago
ikelos c49eac5645 Fix the junos zeroize function (#19142)
Currently this function directs to the standard NetworkModule,
whose run_commands function takes no arguments (other than self).

This directs the call to the connection's cli method to run the command
directly on the device.
8 years ago
Ganesh Nalawade ee5d5c3e84 Fix #4103 Support json format in junos_command module (#19045) 8 years ago
Peter Sprygada ad99d52679 adds feature to allow connection to set action plugin (#18762)
Connection plugin can define default action plugin to use by providing
action_handler instance variable.  This will override the default
action plugin normal
8 years ago
Peter Sprygada 0cef38cf02 adds feature to all modules to be run locally (#18763)
* adds new error AnsibleModuleExit to handle module returns
* adds new action plugin network for attaching connection to network modules
* adds new shared module local to receive connection
* splits out function to update task_args with common updates

This commit provides a mechansim for running local modules that require
a connection object for interative commands tyically implemented for
network devices.  It provides a way to locally import modules (post fork)
and run them using exception handling to exit.
8 years ago
Fabio Alessandro Locati 066872cdc6 Improve examples (#18830) 8 years ago
Fabio Alessandro Locati 8dc3b60d0f Remove unneeded quotes - windows/win_uri.py (#18828) 8 years ago
Fabio Alessandro Locati cf5449c5d9 Remove unneeded quotes - windows/win_unzip.py (#18827) 8 years ago
Fabio Alessandro Locati 439f98005f Highly rewrite and fix the examples - windows/win_iis_webbinding.py (#18823) 8 years ago
saller d8c97ac275 Fix typo.
Fix typo in section "Installing multiple roles from a file".
8 years ago
Sam Doran 73fc4e42f1 Correct type-o on support statement 8 years ago
Artur Molchanov a8d5358d7f systemd module: Allow to stop activating service (#19383)
* systemd module: Allow to stop activating service

Allow to stop service with ActiveState=activating.

* systemd: Fix incompatibility with Python 2.4
8 years ago
Adrian Likins d48ad47fda add coverage/test and misc items to .gitignore (#19384) 8 years ago
John R Barker 7dc86648c4 Docs typo (#19380) 8 years ago
Matt Clay 39f6368015 Update `aliases` file for `uri` integration test. 8 years ago
Matt Clay 9b5c782a0b Use `docker pull` by default in ansible-test. 8 years ago
Matt Clay 80c559bdef Test sftp and scp for ssh connection. 8 years ago
Ryan S. Brown 197658aff4 Handle when the AMI launch permissions are unset.
Use an empty list to avoid a TypeError because `'NoneType' is not iterable``
8 years ago
Michael Gugino 250f862573 Fix bug #5328 apache module loading (#19355)
* Fix bug #5328 apache module loading

Currently, the apache2_module module parses apache configs
for correctness when enabling or disabling apache2 modules.

This behavior introduced a conflict condition when transitioning
between mpm modules, such as mpm_worker and mpm_event.

This change accounts for the specific error condition raised
by ``apachectl -M``:
``AH00534: apache2: Configuration error: No MPM loaded.``
When loading or unloading a module with a name that contains 'mpm_',
apache2_module will ignore the error raised by apachectl if stderr
contains 'AH00534'.

Fixes #5328

* Add AH00534 warning

* Added changes from PR #5629

* Modified ignore_configcheck behavior
8 years ago
Toshio Kuratomi 0b440a9289 Code smell test for iteritems and itervalues (#19292)
* Code smell test for iteritems and itervalues

* Change the keydict object in authorized_keys so it doesn't throw a false postive

keydict is a bad data structure anyway.  We don't use the iteritems and
itervalues methods so just disable them so that the code-smell tests do
not trigger on it.

* Change release templates so they work with py3
8 years ago
Brian Coca f550b4541f bad/missing fact plugin is a warning (#19350) 8 years ago
John R Barker 739a310382 Formatting (#19353) 8 years ago
Steve Kuznetsov d5324c11a0 Factored polling std{out,err} reads into a function
The process to poll for data in the stdout and/or stderr pipes during a
low-level command execution was repetitive. Factoring this out into a
function DRYs out the code.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
8 years ago
Tim Rupp 362c86d323 Fixes map call usage
For the comparisions that need to be done, this map call needs
to convert to a list because the six import in ansible changes
the behavior of map to return an iterator instead of a list
8 years ago