Commit Graph

33565 Commits (47eccd366b8be1abc575ea58274a324ae37db267)
 

Author SHA1 Message Date
Sam Doran 47eccd366b
Cherry pick Tower credential fixes to stable-2.4 (#36807)
* Fix credentials for Tower API V2

(cherry picked from commit 640749d54f)

* tower cred: implement credential /api/v1/ kind compatability

(cherry picked from commit 9cb4b70e27)

* tower cred: filter user name lookup by the proper key

(cherry picked from commit cd6855275e)

* tower cred: update kind options in documentation

(cherry picked from commit 8a41233202)

* tower cred: support credential kind/type for /api/v1/ and /api/v2/ (#36662)

older versions of Tower (3.1) don't have a concept of CredentialTypes
(this was introduced in Tower 3.2).  This change detects older versions
of pre-3.2 tower-cli that *only* support the deprecated `kind`
attribute.

(cherry picked from commit 641f8b4ef6)

* Add CHANGELOG entry for Ansible Tower module credential fix

* properly detect the absence of credential_type in older tower-cli (#36908)

(cherry picked from commit a82043939b)

* Do not import HAS_TOWER_CLI since it does not exist in stable-2.4

* properly pass /api/v1/ credential fields for older Towers (#36917)

(cherry picked from commit 0e7106b106)
8 years ago
Brian Coca 0d57282a1a remove extra fields from debug output
fixes #35493

updated tests

(cherry picked from commit a79378fccb)
8 years ago
Brian Coca 4546e7d1d7 fix loop_control templating (#36124)
* fix loop_control templating

- properly template ALL properites for loop_control
- loop_control inherits from base, it should not, but needs validate/attribute functionality

fixes #24719

(cherry picked from commit 8de4f7cd9f)
8 years ago
Toshio Kuratomi 990254efb1 Add protection for inventory plugins using verify incorrectly to changelog 8 years ago
Brian Coca 18359b0cec protect against plugins using verify incorrectly
assume false on any errors

(cherry picked from commit ef40e5e3b2)
8 years ago
Trishna Guha 92cea82a4e
vyos_l3_interface fix (#36721)
* vyos_l3_interface fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update test and changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Matt Clay 2d05ecb26c Temporarily disable subversion test on osx.
(cherry picked from commit f283edcb19)
8 years ago
Matt Clay 1f43d5fc75 Fix rst link syntax. 8 years ago
Matt Clay 29e7d5ecd9 Fix unclosed anchor in changelog. 8 years ago
Matt Martz 668a17cfba
Backport #36602 for stable-2.4 (#36607)
* Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules (#36602)

(cherry picked from commit a7062b7587)

* Modify test to work on 2.4 due to lacking templar kwarg
8 years ago
Deepak Agrawal 3b0686ffe8
vyos_config IndexError in sanitize_config (#36375) (#36566)
* Bug in del(list) logic. Say you have a list of 4 elements a[0-3]
and you have to remove index 1 and 3, if you remove index 1 first
then list is cut short a[0-2] and does not have index 3

Fix: Remove indexes in reverse sorted order e.g. 3 and 1 in above
example so that order of indexes remain preserved even after deleting

fix is to remove indexes in reverse sorted order

* Add test cases for failed case

(cherry picked from commit 0bbea9a579)
8 years ago
Toshio Kuratomi 52c85f6c66 New release v2.4.4-0.1.beta1 8 years ago
Toshio Kuratomi fe7e44a5d7 Add python3 ansible_*_interpreter fix to the changelog 8 years ago
Matt Martz a8582663b1 Fix types when evaluating interpreter (#36541)
* Fix types when evaluating interpreter. Fixes #36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)

(cherry picked from commit a4df4d33ac)
8 years ago
Sam Doran 23289bd2f2 Check for regexp match when using insertbefore or insertafter (#36474)
Add tests to cover this scenario
Fixes #36156

(cherry picked from commit 723daf3e3a)

# Conflicts:
#	lib/ansible/modules/files/lineinfile.py
8 years ago
Sam Doran 0231cd9c93 Add note to use script module rather than inline here documents (#32863)
* Add example on how to use a here document with shell module

* Remove here doc example and add note to use script module instead

(cherry picked from commit 5e7ee9df0a)
8 years ago
Matt Martz 4e4cd7ee67
cherry-pick #36470 for 2.4 (#36526)
* Re-use logic from StrategyBase._load_included_file in StrategyModule.run for free and linear (#36470)

This improves include_role performance and recursion limits

(cherry picked from commit 10fefc7156)

* Add changelog for 36470
8 years ago
Abhijeet Kasurde 101578b63f
VMware: set extra configs for virtual machine (#36521)
This fixes implementation of extra config for virtual machine.

Fixes: #32004

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 80fb836ce5)
8 years ago
Jordan Borean a3e02a2417
fetch: changed docs around behaviour for default fail_on_missing 8 years ago
Sam Doran 8b6184472b Update CHANGELOG 8 years ago
Sam Doran 6598c8e361
Always show prompt, even if seconds or minutes are specified (#36258)
Fixes #36057
8 years ago
Jordan Borean 55f903eafd
winrm: Fix kerberos auth encoding for Python 3 (#36465) 8 years ago
Toshio Kuratomi f3a395b783 Add deb packaging fix for ubuntu12.04 to changelog 8 years ago
Grant Slater 858a1f802f Use pycrypto backend, rather than python-cryptography, on Ubuntu Precise
(cherry picked from commit e3192fb3a4)
8 years ago
David Newswanger a98700917f added support for --testcase flag in ansible-test (#36134)
* added support for --testcase flag in ansible-test

* fixed command format

* added tab completion

* fixed sanity issues

* added documenation for --testcase

* don't autocomplete when multiple modules are selected

(cherry picked from commit 3f5caf659e)
8 years ago
Toshio Kuratomi 4a08e07da0 Add changelog entries for some more 2.4.4 fixes 8 years ago
Adam Miller 1ab84b1cfd fix new EC2 C5 instance virtualization_type identification (#35063)
* fix new EC2 C5 instance virtualization_type identification

Fixes #35051

Signed-off-by: Adam Miller <admiller@redhat.com>

(cherry picked from commit f95adcce8e)
8 years ago
John R Barker 37334ca3ee Clarify when and how to enable ANSIBLE_DEBUG (#35220)
(cherry picked from commit 181085821b)
8 years ago
Dag Wieers 0d5aa161e8 Improve convert_bool error message
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

(cherry picked from commit 487cf0ee8d)
8 years ago
Adam Miller 291c1eb57d make v2_playbook_on_notify method signatures consistent
This was causing an exception in the TaskQueueManager when a third
party handler plugin was processed that inherited or explicitly
called the callback method from super because the method signature
was incorrect in callback/__init__ and it processed the arguments as
incorrect data types as a side effect.

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit dd9b2c0774)
8 years ago
Adrian Likins 7e32010bdb Fix ansible-console always asking for vault passwords
ansible-console was calling setup_vault_secrets
twice. Once directly and once via _play_prereqs()

The direct invocation was not setting auto_prompt=False.

However, the direct invocation isn't need at all so
this removes it so only _play_reqs() is used.
That fixes the unrequested vault password
prompting.

Fixes #33027

(cherry picked from commit 810fa7046b)
8 years ago
tedder 7d6e3f3bba fix spelling. Seriously, that's it.
(cherry picked from commit e8fc269cd3)
8 years ago
Martin Krizek acea14b392 add_host: check if name or hostname arg is provided
(cherry picked from commit 39d9496282)
8 years ago
Brian Coca dfa3ecaf84 fixes to virtual facts
fixes #36038

(cherry picked from commit 97b6e99479)
8 years ago
Michael Nugent 0c4f6c3f68 False matches the docs and intentions of the previous developer (#35762)
(cherry picked from commit d212ca11b3)
8 years ago
Toshio Kuratomi 5c937b21f3 Add oom_killer fix for docker_container to the changelog 8 years ago
PikachuEXE 14e7432467 Backport fix in PR #30712 into 2.4
https://github.com/ansible/ansible/pull/30712
8 years ago
Jordan Borean 71b1a1e982
updated changelog for win_uri fix 8 years ago
Jordan Borean f37cba14ac
win_uri: fix creates/remotes - manual cherry-picking for pull 36016 for stable-2.4 8 years ago
Matt Martz cc7dfdeb52 Add changelog entry for reparenting fix (#36075) 8 years ago
Matt Martz 103e569f5e Prevent reparenting a block with itself (#36075)
* Prevent reparenting a block with itself

* Move __eq__ to Block, to avoid some unexpected problems

(cherry picked from commit 76ff3e9efc)
8 years ago
Trishna Guha 9fcff68ae1
Fix nxos_igmp_interface for diff nxos versions (#35959) (#36020)
* Fix nxos_igmp_interface for diff nxos versions (#35959)

(cherry picked from commit 7a711cf942)

* update CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Matt Martz c6a5a27531 Add changelog entry for memory ballooning fix 8 years ago
Matt Martz a889576d39 Address memory ballooning caused by task caching changes (#35921)
* Exclude parent when copying included task to avoid memory issues. Fixes #35796

* Simplify implicit block squashing to pre-group, instead of post re-parenting

(cherry picked from commit 7d1eb88ecf)
8 years ago
Trishna Guha 7c4e343864
networking fix cherry-pick (#35936)
* Add minor conditional checks to nxos_bgp sanity test (#35476)

* Add minor conditional checks to nxos_bgp sanity test

* Make ansibot happy

(cherry picked from commit 5a198e1e6a)

* fixing the removed_in_version to 2.6. (#35853)

(cherry picked from commit 73650cf854)

* fix eos_config second-level indent idempotece (#35588)

* fix eos_config second-level indent idempotece

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address ganeshrn's comment - update doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit b30f3b9f4d)

* update CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Toshio Kuratomi 458968ed00 Add dest in copy return fix to changelog 8 years ago
Tomasz Kontusz 0ac4722b29 Fix for #31477: return 'dest' from copy when file wasn't changed
(cherry picked from commit 89ad40b129)
8 years ago
Trishna Guha 3c4d6a25ed
fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules (#35590)
* fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Abhijeet Kasurde 9a64ee4d87
device operations are recursive if serialized (#35727)
(cherry picked from commit 0bb3c4379c)
8 years ago
Matt Clay 61fe2efa48 Temp install of setuptools for import coverage. (#35752)
(cherry picked from commit f46f6c8dec)
8 years ago