Commit Graph

721 Commits (44486223ed1b6a8ffa195d62178916685934801b)
 

Author SHA1 Message Date
jkleint 44486223ed Unify normal and sudo remote command execution.
Commit SHA: 87b1cf45 that put temp files in `$HOME/.ansible` instead of `/home/<user>/.ansible` was producing a directory literally called `$HOME` (no expansion) with non-sudo remote execution.  I'll take the blame for this one, as `ParamikoConnection.exec_command()` was not using the shell for non-sudo commands.  This does sudo and non-sudo execution the same way, using the shell, so environment variables should get expanded.
13 years ago
Michael DeHaan bb1d72f2b4 Merge pull request #235 from skvidal/devel
fix for issue #230 - handle template taking 3  args
13 years ago
Seth Vidal fa2aebc8a6 fix for issue #230 - handle template taking 3 args 13 years ago
Michael DeHaan 283b897a1f Merge pull request #233 from cocoy/devel
Bugfix for issue #229
13 years ago
cocoy 7a19a46e24 Bugfix for issue no. 229 13 years ago
Michael DeHaan 87b1cf45a4 Merge pull request #226 from cread/make-osx-tests-pass
Use the $HOME env var instead of hard coding /home/<username>
13 years ago
Michael DeHaan decc46ad17 Merge pull request #224 from jkleint/devel
Support YAML list of hosts in playbook.
13 years ago
jkleint 4e1bc43645 Support YAML lists of hosts in playbooks.
Reading the docs, I was a bit confused as to how to specify multiple hosts/groups in a playbook.  Being YAML, I assumed a normal YAML list would work:

    ---
    - hosts: [host1, host2]

But this crashes when inventory._matches() assumes hosts is a string.  This patch just checks if hosts is a list, and turns it into a string joined by ';'.
13 years ago
Michael DeHaan 2999b6b2c4 Merge pull request #223 from jkleint/devel
runner._chain_file_module() calls .get() on error string
13 years ago
Chris Read dbb4afff50 Use the /Users/cread env var instead of hard coding /home/<username> 13 years ago
jkleint b50c50748e _chain_file_module() calls .get() on error string
runner._return_from_module() normally returns a list (?) of `[str,bool,dict,str]`, but on error it returns `[str,bool,str,str]`.  runner._chain_file_module() then tries to call .get() on the third item (`data2`), which fails when it's a string.  This patch only accesses `data2` if the return value was `ok`.  It might be better to return consistent types in both cases, but I'm not sure where/how else the return value is used.
13 years ago
Michael DeHaan 90a8893418 Merge pull request #220 from skvidal/devel
handle issues when the hostlist is inadvertently set executable
13 years ago
Seth Vidal 730cc89c5b Merge branch 'devel' of git://github.com/ansible/ansible into devel
* 'devel' of git://github.com/ansible/ansible: (2 commits)
  Fix tests for facter and the ansible_facts API.
  ...
13 years ago
Michael DeHaan 5f1bbb1de2 Merge pull request #219 from jhoekx/revert-facts-modules
Ohai and facter modules should not use the ansible_facts API.
13 years ago
Seth Vidal 41619278e5 handle issues when the hostlist is inadvertently set executable
and/or executing it fails. This produces a nicer error message than
a traceback
13 years ago
Jeroen Hoekx cc579a8aa2 Fix tests for facter and the ansible_facts API. 13 years ago
Jeroen Hoekx d3d26d0cd6 Ohai and facter modules should not use the ansible_facts API. 13 years ago
Michael DeHaan 02abb5a83b Merge pull request #217 from jhoekx/connection-fixes
Expand user in ssh identity file
13 years ago
Michael DeHaan 46b3dc744e Merge pull request #218 from jhoekx/ansible-facts-fixes
Fix incorrect merge of custom-facts branch.
13 years ago
Jeroen Hoekx 973b1fe02e Fix incorrect merge of custom-facts branch.
This fixes #216.
13 years ago
Jeroen Hoekx c2f1aefaf1 Expand user in SSH identity file. 13 years ago
Jeroen Hoekx 1804df0bae Whitespace fixes in connection.py 13 years ago
Michael DeHaan 80e6d83660 Fix bug in library/file 13 years ago
Michael DeHaan 66ba31aeb0 Fix bug in library/file 13 years ago
Michael DeHaan 3311763225 Merge pull request #213 from mcodd/devel
bugfix for ssh_config patch
13 years ago
Matt Coddington d34160ed26 cast ssh port number as integer 13 years ago
Michael DeHaan 89c013035e Merge branch 'integration' of https://github.com/cocoy/ansible into cocoy-integration 13 years ago
Michael DeHaan bced4c9db1 Merge branch 'jhoekx-custom-facts' into devel 13 years ago
Michael DeHaan 49cca98f1e Merge branch 'custom-facts' of https://github.com/jhoekx/ansible into jhoekx-custom-facts
Conflicts:
	lib/ansible/runner.py
13 years ago
Michael DeHaan d60efc235d Merge branch 'jkleint-integration' into devel 13 years ago
Michael DeHaan 346df537b4 Merge branch 'integration' of https://github.com/jkleint/ansible into jkleint-integration 13 years ago
Michael DeHaan d37a7115a8 Merge branch 'master' into devel 13 years ago
Michael DeHaan 6ba91a715e Update README to indicate new branch name 13 years ago
Michael DeHaan 7de90c4e64 Version bump for integration branch (soon to be renamed 'devel'), didn't update package
changelogs yet since this isn't released yet (but 0.3 is)
13 years ago
Michael DeHaan 4d62510997 Version bump for 0.3 release 13 years ago
Michael DeHaan a8707e48e8 Fix merge issue 13 years ago
Michael DeHaan c00699d0ef Merge branch 'integration'
Conflicts:
	lib/ansible/playbook.py
	lib/ansible/runner.py
	library/apt
13 years ago
Michael DeHaan 321ed53e3a Fetch module doesn't set invocation parameter as it invokes nothing, so don't let that be an error. 13 years ago
Michael DeHaan 39f912899f Merge pull request #212 from sideswipewvu/debmake
Debmake
13 years ago
Henry Graham 21269a845f debian packaging 13 years ago
jkleint e69e078569 More robust remote sudo.
The basic idea is sudo /bin/sh -c 'quoted_command'.  We use Paramiko's low-level API to set a timeout, get a pseudo tty, execute sudo and the (shell quoted) command atomically, wait just until sudo is ready to accept the password before sending it down the pipe, and then return the command's stdout and stderr.

This should be faster, as there are no unneeded sleeps.  There are no permissions issues reading the output.  It will raise socket.timeout if the command takes too long.  However, this is a per-read timeout, not a total execution timeout, so as long as the command is writing output and you are reading it, it will not time out.

Local and non-sudo commands remain unchanged, but should probably adopt a similar approach.

Since this is a significant change, it needs a lot of testing.  Also, someone smarter than I should double-check the quoting and execution, since it is a security issue.
13 years ago
Jeroen Hoekx 2dc9a563ef Allow modules to return facts.
If the module result contains "ansible_facts", that will be added to the setup
cache.
13 years ago
cocoy c844a2d072 Fix to skip /.ssh/config if don't exist rather than raise an error. 13 years ago
cocoy 645b7a2dff Add .ssh/config support 13 years ago
Michael DeHaan ec56b30248 Merge pull request #198 from dne/apt-default-release
Implemented optional "default-release" argument for apt module
13 years ago
Daniel Néri d5f3760acc Add optional "default-release" argument for apt module
The value is passed to apt-get's "-t" option. Useful for installing backports, e.g.:

  ansible webservers -m apt -a "pkg=nginx state=latest default-release=squeeze-backports"
13 years ago
Michael DeHaan 1c5bcb606e Merge pull request #197 from sfermigier/master
Add missing deps in setup.py
13 years ago
Stefane Fermigier f7469f8704 Add requirements in setup.py. 13 years ago
Michael DeHaan 9dc1b6d79d Merge pull request #192 from sfromm/selinux
Update secontext behavior in file module
13 years ago
Stephen Fromm bcfa6a7865 Add another example to file_secontext.yml
Demonstrate what happens when there is no default context in the policy.
13 years ago