9032 Commits (3f2d1e6bfa6bb8e2ff47fe1118021657d5e072cf)

Author	SHA1	Message	Date
Nathaniel	935550d20d	Update set_fact.py ... Context: I recently discovered that when setting a fact, key=value pairs and complex arguments differ in how the fact is stored. For example, when attempting to use complex arguments using key=values, the result can be stored as a unicode string as opposed to an object/list/etc. I'm hoping the above example update will better demonstrate to and instruct people to use complex arguments instead of key=value pairs in certain situations.	8 years ago
Matt Martz	65508bb21a	Python2.4 fixes ... * Ignore accelerate.py * Don't use a lambda or a ternary	8 years ago
macbeth76	fce97365a4	Update user.py ... M in date format is minutes. m is for months.	8 years ago
Chris Lundquist	7b4107a169	fix ami_search doc copy pasta	8 years ago
Toshio Kuratomi	dd02483b26	Explain why the apt module does not do implicit regex matches on package name since this is different than the apt-get command line tool. ... Fixes #1258	8 years ago
Dominic Hargreaves	535f0e9b11	apt_key documentation: add a note explaining the benefit of including 'id'	8 years ago
Benno Joy	fc1ad5e1f1	fixes issue 122, where the module recreates the route table in each run	8 years ago
Ratnadeep Debnath	a99d7da0c1	Fixed typo in cloud docker module.	8 years ago
Toshio Kuratomi	5844a04061	Fix documentation formatting	8 years ago
Bret Martin	b2453bf9a3	ec2_vpc module: add route table resource tagging	8 years ago
Jonathan Mainguy	f662a48de7	Adds the exclude= option to the yum module. Works the same way --exclude does when yum install or yum update	8 years ago
Herby Gillot	6a39dc891a	Use existing ec2_eip address if already associated ... If an EC2 instance is already associated with an EIP address, we use that, rather than allocating a new EIP address and associating it with that. Fixes #35.	8 years ago
louis	9d20a3091e	added skeleton support in user module	8 years ago
(@cewood)	17b5d851f2	Support specifying cidr_ip as a list ... Update/fix to Support specifying cidr_ip as a list Unicode isn't compatible with python2, so we needed some other solution to this problem. The simplest approach is if the ip item isn't already a list, simply convert it to one, and we're done. Thanks to @mspiegle for this suggestion.	8 years ago
Jonathan Mainguy	1ba2e34ae1	Adds all_databases option which allows a user to dump or import all databases at once, identical to mysqldump --all-databases ... fix line 132 Update to name=all cleaned up all_database per abadger's suggestions	8 years ago
Sam Doiron	a3ec0a1562	Fix Issue #1216 (ValueError with Amazon RDS) ... Fix typo where wrong variable was used, causing ValueError.	8 years ago
Alex Feinberg	1ac9c20b6e	Fix a typo in create_instances ... Fix a typo in create_instances: use 'placement_group' instead of placement_group when calling boto_siupports_param_in_spot_request().	8 years ago
Brian Coca	fb527955c9	added deprecated doc entry	8 years ago
James Cammarata	d7ce6b0d4b	Fix bug in service where upstart services incorrectly use init scripts ... Fixes #1170	8 years ago
Toshio Kuratomi	c2bf2c7c54	Fix error when container has no names. ... Rename loop variable from "i" to more informative "container" Fixes #1188	8 years ago
David Shrewsbury	dd6b153700	Update os_server for shade flavor API changes ... Latest shade fixes the flavor API so that raw objects are not returned.	8 years ago
Chris Meyers	cec3c8c209	better timeout logic when deleting vm disks. Python 2.4 safe excepts	8 years ago
Chris Meyers	cdcaa2d6a0	correctly delete disks associated with vms	8 years ago
Will Thames	9aff204f63	Usage is not a valid database or table privilege ... Remove `USAGE` from the `VALID_PRIVS` dict for both database and table because it is not a valid privilege for either (and breaks the implementation of `has_table_privilege` and `has_database_privilege` See http://www.postgresql.org/docs/9.0/static/sql-grant.html	8 years ago
Will Thames	43bad27948	Update postgresql users only when necessary ... For read-only databases, users should not change when no changes are required. Don't issue ALTER ROLE when role attribute flags, users password or expiry time is not changing. In certain cases (hashed passwords in the DB, but the password argument is not hashed) passlib.hash is required to avoid running ALTER ROLE.	8 years ago
Monty Taylor	78daf52994	Add OpenStack Server module ... Also deprecated old nova_compute module	8 years ago
Ryan Hartkopf	118382ca70	synchronize: don't add ssh_args to ssh_opts when false or null	8 years ago
Brian Coca	2e9462aa21	minor doc fixes, set version added for new tags: parameter should Fix #10894	8 years ago
Toshio Kuratomi	8bc34613bc	Second try at fixing #1227 -- set e default value earlier	8 years ago
Toshio Kuratomi	030858df67	Return empty list if an image has no repo_tags	8 years ago
Julia Kreger	6f7cd5c307	Set default for mysql_user config_file ... The default value set by the module was a value of None for the config_file parameter, which propogates into the connect method call overriding the stated default in the method. Instead, the default should be set with-in the parameter specification so the file check is not requested to check None.	8 years ago
Toshio Kuratomi	0d468a3aa0	Get docker's default api version definition from both 1.2 location and pre-1.2 location ... Fixes #1227	8 years ago
Brian Coca	018b0118dc	removed deprecated docs, not true anymore	8 years ago
Toshio Kuratomi	4592b795d9	Only split on the first colon. ... Fixes #1214	8 years ago
Brian Coca	b5b34f6931	removed unused and undefined aws_regions	8 years ago
Evgenii Terechkov	37d6c10133	Add ALT Linux support to hostname module	8 years ago
Brian Coca	953ed0aecc	avoid exception when boto is not available	8 years ago
Brian Coca	5e892b894b	removed redundant region def	8 years ago
David Shrewsbury	c29ae705f0	Update os_server_volume for latest shade ... The shade volume API was updated to return a dict rather than the object as returned by cinder.	8 years ago
David Shrewsbury	4ea6bded61	Update os_volume for latest shade ... The shade volume API was updated to return a dict rather than the object as returned by cinder.	8 years ago
Sven Schliesing	90d434d66d	use default value for parameter config_file in connect()	8 years ago
mcameron	dcb8fa0cb9	Net_id already present, remove unnecessary lookup.	8 years ago
mcameron	1cc057ca97	Valodate fip is on the correct network	8 years ago
mcameron	9f30125876	Adding openstack multiregion support	8 years ago
David Shrewsbury	4699e5b905	Recognize when volume attach/detach is not necessary ... Do not attempt to attach an already attached volume. Likewise, do not attempt to detach a volume that is not attached. This version adds support for check mode.	8 years ago
Heikki Partanen	ec566d86b3	Add support for extra_hosts to docker module ... extra_hosts parameter (maps to --add-host in 'docker run' syntax) is used to add host-to-ip mappings to the container.	8 years ago
Matt Martz	1ceaa78dc0	Add version_added for the use_ssh_args option	8 years ago
Matt Martz	4faf0d59da	Add ability to specify using ssh_args in synchronize	8 years ago
Monty Taylor	63a0c0999a	Add OpenStack Volume module	8 years ago
Monty Taylor	15013cde32	Add OpenStack Server facts module	8 years ago
Monty Taylor	522a28b75c	Add OpenStack Server Volume module	8 years ago
muffl0n	62bc6f2ba6	Use MySQLdbs read_default_file	8 years ago
Bobby Calderwood	cd14b8115b	Fixes regression introduced by edf1ac1ea6	8 years ago
Toshio Kuratomi	9133ae8c55	Allow yum module to take a yaml list of package names and also ", " separated string-list (in addition to comma separated string-list)	8 years ago
bw-will-usher	efd2cc6089	Fixed MS SQL port number in documentation (1443->1433) per: https://support.microsoft.com/en-us/kb/287932	8 years ago
Romain Dartigues	cf86c9b29f	Issue #1161 DigitalOcean API 2 ssh_key_ids problem ... * fix documentation: show a valid syntax * make ssh_key_ids a list and not a string	8 years ago
Michael Scherer	f7707ea137	Name is a required parameter, fix https://github.com/ansible/ansible/issues/10335	8 years ago
Brian Coca	88e3c19e9a	added new ec2_ami_find as per #905	8 years ago
Brian Coca	2733705a19	deprecated ec2_ami_search	8 years ago
sisso	17a409f20d	fixed bug where scaling policy return a random policy if many autoscale group have policies with same name.	8 years ago
Toshio Kuratomi	1ddae11bd1	Implement feature to return list of files in the archive	8 years ago
Brian Coca	9dc1f5693c	updated content description to discourage using as a tempalte module	8 years ago
Toshio Kuratomi	02b8e17f61	Tar --diff only sends output to stderr if a file is missing. Handle that case ... Fixes #1064	8 years ago
James Cammarata	5a0a9d9f72	Add version_added string to new org_id param in rhn_subscription	8 years ago
Brian Coca	a6107e35e9	simplified bad if chain hopefully fixes #1136	8 years ago
Keith Johnson	06579c560e	Make link clickable	8 years ago
bugchecker	b7b6367ad5	prevent using undefined variable	8 years ago
Jan Brauer	31abdc7ace	Add missing comma	8 years ago
Brian Coca	b6e3ddba9a	ifxed error message as code remove the repo r var	8 years ago
Schmitt Christian	cc71372182	Removed the wrong Note ... Currently as already in the description, this module works with proxy settings.	8 years ago
Daekwon Kim	a22bdd8356	Fix indent of "register" key	8 years ago
Daekwon Kim	4591761c73	Fix typo (volue -> volume)	8 years ago
Brian Coca	00a327bdaa	added docs to show wait_for default timeout settings ... Fixes #400	8 years ago
Brian Coca	3f325408df	find module updated to be able to get checksums and stat data, also now it only stats a file once so it should be quite faster on large file sets	8 years ago
David Wittman	be0d28a4ac	Set disabled repos before enabled repos ... The ordering of disabling/enabling yum repositories matters, and the yum module was mixing and matching the order. Specifically, when yum-utils isn't installed, the codepath which uses the yum python module was incorrectly ordering enabling and disabling. The preferred order is to disable repositories and then enable them to prevent clobbering. This was previously discussed in ansible/ansible#5255 and incompletely addressed in 0cca4a3.	8 years ago
Jaanus Torp	0f0cb9dc16	Added support for tagging images in ec2_ami.py	8 years ago
Niels de Vos	ca9fd7e136	redhat_subscription: add the `org_id` parameter ... When subscribing a system with an activationkey, it seems (sometimes?) required to pass the "--org <number>" parameter to subscription-manager. Activation Keys can be created through the Red Hat Customer Portal, and a subscription can be attached to those. This makes is easy to register systems without passing username/passwords around. The organisation ID can be retrieved by executing the following command on a registered system (*not* the account number): # subscription-manager identity URL: https://access.redhat.com/management/activation_keys Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-by: Ken Dreyer <kdreyer@redhat.com>	8 years ago
Michael Scherer	1559bccdb3	Remove unused option in the repoquery call ... Citing the man page: -q, --query For rpmquery compatibility, doesn't do anything.	8 years ago
Andrey Trubachev	ac5b0ca59b	Fix mess of ipv6 and ipv4 addresses in private_ip	8 years ago
James Cammarata	68a07a2bb5	Merge branch 'osx_user_fix' of https://github.com/bambou42/ansible-modules-core into bambou42-osx_user_fix ... Includes commits for: * Don't return change if the password is not set * Set the group to nogroup if none is specified * Set an uid if none is specified * Test if SHADOWFILE is set (for Darwin) * remove unused uid	8 years ago
Kyle Johnson	cf61778689	Fix typo in rds_subnet_group.py ... aws_connection_kwargs should be aws_connect_kwargs	8 years ago
Matt Martz	0b4fec0a06	Don't use a dict comprehension, be more verbose	8 years ago
Brian Coca	a014bde3f0	switched to use python's built in os.separator vs using /	8 years ago
Brian Coca	7f618bd787	minor docfixes	8 years ago
Ken Dreyer	46372842e8	redhat_subscription: fix activationkeys argument ... Prior to this commit, Ansible would pass '--activationkeys <value>' as a literal string, which the remote server would interpret as a single argument to subscription-manager. This led to the following failure message when using an activation key: subscription-manager: error: no such option: --activationkey "mykey" Update the arguments so that the remote server will properly interpret them as two separate values.	8 years ago
Monty Taylor	0283791d5f	Add OpenStack Auth module ... Use this to pre-auth or to get a copy of the service catalog.	8 years ago
Jesse Rusak	9d93f052c2	Update rds module for RDS2 parameter name change. ... boto's rds2 renamed `vpc_security_groups` to `vpc_security_group_ids` and changed from a list of `VPCSecurityGroupMembership` to just a list of ids. This accommodates that change when rds2 is being used.	8 years ago
steenzout	67f769d9a6	issue #994: use HAS_BOTO to determine if import was successful: - removed import of sys module. - HAS_BOTO constant to check if import was successful. - trigger a failure when import fails. - removed unnecessary imports.	8 years ago
Richard Tier	0a48d54c1c	added version to docstring	8 years ago
Monty Taylor	ea809efe7b	Revert "Add OpenStack Router Gateway module"	8 years ago
Monty Taylor	c4db70a133	Add OpenStack Router Gateway module ... Also deprecate old quantum_router_gateway module	8 years ago
Ash Wilson	c6b0656c1c	Record facts for each changed container.	8 years ago
Brian Coca	7985682c94	added support for postgres9.4 which is now available from amazon	8 years ago
Brian Coca	706db441b4	really fixed docs this time	8 years ago
Brian Coca	2dafff3f97	fixed doc issues on cloudformation	8 years ago
tedder	9fd568f655	code review fixes per #957	8 years ago
Richard Tier	0c1624f9b7	allow setting header	8 years ago
Tor Åke Fransson	459fd81435	Remove all reference to obsolete client_id and rename api_key to the for v2 more correct api_token	8 years ago
Tor Åke Fransson	02883a460b	Make digital_ocean ssh command use API v2	8 years ago
David Wittman	15235a718d	Fix bug with upstart detection ... Upstart scripts are being incorrectly identified as SysV init scripts due to a logic error in the `service` module. Because upstart uses multiple commands (`/sbin/start`, `/sbin/stop`, etc.) for managing service state, the codepath for upstart sets `self.svc_cmd` to an empty string on line 451. Empty strings are considered a non-truthy value in Python, so conditionals which are checking the state of `self.svc_cmd` should explicitly compare it to `None` to avoid overlooking the fact that the service may be controlled by an upstart script.	8 years ago
Tor Åke Fransson	5faa882138	WIP: DigitalOcean API version 2 with user_data option	8 years ago
tedder	35ce9fb095	skip password changes so pg_authid isn't needed ... Some places ([AWS RDS](https://forums.aws.amazon.com/thread.jspa?threadID=151248)) don't have, or don't allow, access to the `pg_authid` table. The only reason that is necessary is to check for a password change. This flag is a workaround so passwords can only be set at creation time. It isn't as elegant as changing the password down the line, but it fixes the longstanding issue #297 that prevented this from being useful on AWS RDS.	8 years ago
Solomon Gifford	d14bbf514e	mysql_user #829: add update_password to mysql_user	8 years ago
Richard Lander	2091278ff0	azure check for hosted service and vm before creating	8 years ago
Rob Johnson	d8af3f3b67	allow both template and template_url parameters	8 years ago
Sébastien Bocahu	f88f895795	Removes YAML body_format option ... It would require adding a dependency to the YAML module while it might not provide much benefit (has anybody seen a HTTP API taking YAML as input ?)	8 years ago
Mick Bass	5de4c053b6	clean rebase of https://github.com/ansible/ansible-modules-core/pull/1024 on a new branch	8 years ago
Brian Coca	4f7bc895d2	removed requirements/boto as it broke documentation as it is duplicated in shared aws fragements	8 years ago
Florian Apolloner	a925a075a6	Added os.path.expanduser to app_path in django_manage	8 years ago
Florian Apolloner	f07096bfe5	Added os.path.expanduser when searching for pip executable.	8 years ago
Adam Chainz	21339664ce	Make cloudformation module's template argument not required in case of stack deletion	8 years ago
Jonathan Davila	de85294d2d	allow boto profile use with s3	8 years ago
Sébastien Bocahu	4af3b60167	Add body_format for handling of JSON and YAML body ... body_format is a new optional argument that enables handling of JSON or YAML serialization format for the body argument. When set to either 'json' or 'yaml', the body argument can be a dict or list. The body will be encoded, and the Content-Type HTTP header will be set, accordingly to the body_format argument. Example: - name: Facette - Create memory graph uri: method: POST url: http://facette/api/v1/library/graphs status_code: 201 body_format: json body: name: "{{ ansible_fqdn }} - Memory usage" attributes: Source": "{{ ansible_fqdn }}" link: "1947a490-8ac6-4bf2-47c1-ff74272f8b32"	8 years ago
Lorin Hochstein	5224375a5a	Use the correct alias syntax	8 years ago
Lorin Hochstein	17e6be671b	ec2 module: add instance_id alias ... Create an alias named instance_id for the instance_ids parameter.	8 years ago
Robert Estelle	268763995c	ec2_group allow empty rules.	8 years ago
Kohei YOSHIDA	f0db5c0cd0	support secure connection on fakes3	8 years ago
Ryan Trauntvein	eaa0ce0ceb	Specify that "state: reloaded" was added in Ansible 1.9	8 years ago
Scott Miller	751434de9d	describe choices in alias documentation	8 years ago
Mick Bass	9980205edc	Add support for AWS Security Token Service (temporary credentials) to all AWS cloud modules.	8 years ago
Toshio Kuratomi	e710e46ff2	Make lack of boto call fail_json instead of sys.exit ... Fixes #994	8 years ago
Brandon W Maister	c1571928e5	Make cache_subnet_group default to empty security groups ... Since they can't be specified together, it seems like setting the default to no security groups is the right option.	8 years ago
Tom Wadley	ad248376b1	use aws connect call in rds_subnet_group that allows boto profile use	8 years ago
Dan Abel	2250a95638	use simpler ec2_connect ec2 util call ... This allows boto profile use	8 years ago
David Fritzsche	14720b54ac	Add working status detection for pf on FreeBSD ... The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.	8 years ago
Mick Bass	e9a0fad36b	add retry with exponential backoff when we receive throttling error code from cloudformation	8 years ago
Brandon W Maister	cffb2bdee9	Add `cache_subnet_group` to elasticache module ... According to the [docs] cache subnet groups are required inside a VPC. [docs]: http://docs.aws.amazon.com/AmazonElastiCache/latest/UserGuide/CacheSubnetGroups.html	8 years ago
Brian Coca	7cd7bad2e8	added patch to workaround some s3 connection faliures	8 years ago
Brian Coca	252df8685a	refactrored connection exception handling, added check to see if we actually get a connection before proceeding ... Fixes #964	8 years ago
Toshio Kuratomi	a6643160c5	Fix stat code to return name of group owning the file rather than name of group that the file's owner belongs to. ... Followup to #17	8 years ago
Ash Wilson	2dde45cea9	Only fetch details when necessary.	8 years ago
Ash Wilson	93b620ea8a	Compare container images to Config.Image.	8 years ago
Sarah Zelechoski	17334b21ea	fix syntax in last example	8 years ago
Sam Thursfield	5d2652f31b	Fix authorized_key module crashing when given an invalid key ... I tried a playbook with the following (accidentally wrong) task: tasks: - name: authorized key test authorized_key: key=/home/sam/.ssh/id_rsa.pub key_options='command="/foo/bar"' user=sam I got the following traceback: TASK: [authorized key test] *************************************************** failed: [localhost] => {"failed": true, "parsed": false} Traceback (most recent call last): File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 2515, in <module> main() File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 460, in main results = enforce_state(module, module.params) File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 385, in enforce_state parsed_new_key = (parsed_new_key[0], parsed_new_key[1], parsed_options, parsed_new_key[3]) TypeError: 'NoneType' object has no attribute '__getitem__' With this fix, I see the expected error instead: TASK: [authorized key test] *************************************************** failed: [localhost] => {"failed": true} msg: invalid key specified: /home/sam/.ssh/id_rsa.pub	8 years ago
Brian Coca	c04c84887e	fix to return vals docs	8 years ago
James Martin	57cf6e8bb4	Re-wording of feature.	8 years ago
Toshio Kuratomi	e5149f3b30	Fix review comments from @bcoca in #745	8 years ago
Toshio Kuratomi	5378b5db98	Minor code formatting	8 years ago
Tim Rupp	db6c2bac75	Add missing import of apt.debfile ... In cases when the python-apt package is not installed, ansible will attempt to install it. After this attempt, it tries to import the needed apt modules, but forgets to import the apt.debfile module. The result is that playbooks that use the dpkg argument on a machine that does not initially have the python-apt package available will fail with the following error AttributeError: 'module' object has no attribute 'debfile' This patch adds the appropriate import to the apt module to ensure that necessary libraries are available in cases when the dpkg argument is being used on a system that does not initially have the python-apt package installed	8 years ago
Rowan Wookey	04fcfdad2c	Fixed group name not being passed to wait_for_new_instances when replacing instances ... Fixed group_name not being passed to wait_for_elb Minor code clean up	8 years ago
moe	bd09ebe5b4	Woops, make collect/delete loop more efficient.	8 years ago
moe	5e1e1a4dff	Fixes #744. ... The following cases work for me now: - Create new ASG with tags - Update tags on ASG (create/change/delete) In short, the module should now work as expected wrt tagging. The previous code did not work at all with latest boto for me (serialization errors) and the logic was buggy anyway; e.g. removed tags would never get deleted from ec2.	8 years ago
James Martin	cadfd56304	check lb for instance healthy and some refactoring of rolling replace functions. ... Optionally waiting for new instances to be in viable state on ASG creation/update. Properly updating properties and terminating group.	8 years ago
Brian Coca	7f8094e977	undeprecated openstack modules as new ones are not making into release	8 years ago
moncho	0156188a54	Update docker.py ... Fix typo that prevents use_tls 'encrypt' option from working properly.	8 years ago
Toshio Kuratomi	5262d768e0	Add another valid status from downloading images	8 years ago
nemunaire	7eebab43ae	Convert tuple items to string before format	8 years ago
Robert Marsa	b7649cc5ca	Added multiple allowed ranges.	8 years ago
Julien Syx	c676adde0b	Fix the issue #931 ... Checking that the parameter doesn't exist. The old code had a bug when the parameter was 0.	8 years ago
Toshio Kuratomi	d5e3abc5d5	Some code cleanup (removed unused variables and imports)	8 years ago
Toshio Kuratomi	f892ca5b8f	Also use DOCKER_TLS_VERIFY env var to turn on tls verification	8 years ago
Toshio Kuratomi	1bb98542d3	Fix a potential bug in docker pull	8 years ago
Toshio Kuratomi	0ad023a0ac	When no use_tls is not specified and no tls parameters are given we need to not attempt tls.	8 years ago
Alex Rowley	eeb867daf0	cloud/amazon/s3: update documentation ... update description to show that module can do more than just put files into s3	8 years ago
Toshio Kuratomi	2e93f8e9f7	Make state=running work for backwards compatibility with 1.8	8 years ago
Toshio Kuratomi	1946f05baf	Fix lookup of parameter name to be pid instead of pid_mode	8 years ago
Toshio Kuratomi	09a0db1e1f	Make pid_mode parameter do minimum docker-py/docker server version checks	8 years ago
Toshio Kuratomi	95df4bcbee	Fix for problems found by @dguerri ... * TLSConfig['verify'] has to be set to False if we're only encrypting the connection, not verifying the host. * tls_hostname was not set if tls_ca_cert was not present https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78573877	8 years ago
Toshio Kuratomi	7c261b3954	Implement comments from @smashwilson: ... * if tls_ca_cert is set then use tls to verify the server * take tls_hostname from the environment variable DOCKER_TLS_HOSTNAME if it's not specified in the playbook https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78542210	8 years ago
Ian Babrou	3bfe9a7b50	fixed: global name 'e' is not defined	8 years ago
Toshio Kuratomi	3284359894	Alternative implementation of tls for docker ... Alternative to #854	8 years ago
Toshio Kuratomi	c9b33d5de2	Fix for py2.6 (no dict comprehensions on py2.6)	8 years ago
Toshio Kuratomi	c9cc8d0b70	Initialize the value of vpc_id variable	8 years ago
Mario Loria	00613cd4f3	Setting the actual passno and dump defaults, and warning user of consequences in nulling ... Using ansible 1.8.4, I found that these two options actually work slightly different than advertised.	8 years ago
Toshio Kuratomi	ba90eea165	Also don't fail if files are different and overwrite is false for uploads (this mimics copy and template). ... Related to #489	8 years ago
Hagai Kariti	7d16ec283e	Fix KeyError in public zones in route53	8 years ago
Toshio Kuratomi	a02641b4f3	Documentation style changes	8 years ago
James Bowes	0d3aed3e1f	Fix C() formatting typo in file module	8 years ago
Matt Martz	bcd9f83521	Prevent an empty error message	8 years ago
Brian Coca	34dbd69e12	updated to keep same info as in extras repo	8 years ago
Ian Babrou	005d02b185	not triggering reload for links and not string env variables	8 years ago
Ash Wilson	7c4e8774d8	Use {0}, {1} style format indices for 2.6 compat	8 years ago
Ash Wilson	ff0d0ceb70	Expect module env vars to override Dockerfile ones.	8 years ago
Ash Wilson	4e7d766e8f	Include bind mounts in VOLUMES check.	8 years ago
Ash Wilson	959d135b60	Exposed ports, env vars, volumes from the image. ... This will account for settings that are provided by the hierarchy of Dockerfiles used to construct your image, rather than only accounting for settings provided to the module directly.	8 years ago
Ash Wilson	0d822c0c02	Full image inspection and just repo tags ... Hat tip to @bobrik.	8 years ago
Toshio Kuratomi	bba322a10e	Sort subnets by the order they are specified in the play ... Fixes #172	8 years ago
Bret Martin	650a7365f9	Allow vpc_subnet_id to remain unspecified (see bc0c169)	8 years ago
Sam Yaple	42fd85f041	Updated version and fixed default	8 years ago
Sam Yaple	24f1cf80bd	Add pid mode support to docker module ... This allows setting the pid namespace for a container. Currently only the 'host' pid namespace is supported. This requires Docker 1.4.1 and docker-py 1.0.0	8 years ago
Ash Wilson	1c5601a0b5	Connect to Docker with optional TLS.	8 years ago
Ash Wilson	4224dd1acb	Rework docker module states. ... Organize each state into a distinct function for readability and composability. Rework `present` to create but not start containers. Add a `restarted` state to unconditionally restart a container and a `reloaded` state to restart a container if and only if its configuration is incorrect. Store our most recent knowledge about container states in a ContainerSet object. Improve the value registered by this task to include not only the inspect data from any changed containers, but also action counters in their native form, a summary message for all actions taken, and a `reload_reasons` key to store a human-readable diagnostic to determine why each container was reloaded.	8 years ago
Matt Ferrante	aaca9b5127	check keys is in dim2 before evaluating	8 years ago
Lorin Hochstein	09e10ea031	Don't pass volumes_from to create_container ... Don't pass the volumes_from argument to the Docker create_container method. If the volumes_from argument is passed to the create_container method, Docker raises the following exception: docker.errors.DockerException: 'volumes_from' parameter has no effect on create_container(). It has been moved to start()	8 years ago
zitterbacke	264a16d822	fix uri modul for JSON-escape quotation marks ... consider the following response body (content) of a REST/JSON webservice containing escaped quotation marks: ```json { "key": "\"works\"" } ``` decoding this string not as raw will lose the backslash as JSON escape. later json.loads will fail to parse. Inspired by [this thread](https://groups.google.com/forum/#!topic/ansible-project/kymtiloDme4) on the mailing list and the following python shell code: ```python import json string=r'{ "key": "\"works\"" }' json.loads(string) json.loads(string.decode('raw_unicode_escape')) json.loads(string.decode('unicode_escape')) ```	8 years ago
Ash Wilson	338bbf6efc	Pull newer image versions when requested.	8 years ago
Ash Wilson	6505ce3940	Another documentation commit.	8 years ago
Dag Wieers	43ef3a2bd9	Update authorized_key.py ... Fix a (common) error in the examples. This is something that may go unnoticed during troubleshooting when copy&pasting the example.	8 years ago
Lev Popov	5f31654704	Allow to keep instance boot disk after instance deletion in google cloud module	8 years ago
Toshio Kuratomi	e5ba4e87d8	Fix for int port assignment in a playbook failing ... Ports are integer values but the old code was assuming they were strings. When login_port is put into playbook complex_args as an integer the code would fail. This update should make the argument validating make sure we have an integer and then we can send that value directly to the relevant APIs. Fixes #818	8 years ago
Toshio Kuratomi	49511ea078	Small code cleanup	8 years ago
Toshio Kuratomi	86f8a3d381	Clarify the documented behaviour of insertbefore slightly.	8 years ago
Toshio Kuratomi	9fa04de137	In service_enable, the default of changed is True so we have to set it to False explicitly if it is False. ... Fixes #875	8 years ago
Brandon W Maister	2121bbc208	ec2: Apply all security groups at instance-creation ... The code was picking out the first instance from the security groups specified, even when multiple groups were specified. Now we use all of them.	8 years ago
Lev Popov	6d1fd1afcc	Allow to spawn instances without external ip in google cloud module	8 years ago
Michael Laccetti	8efb138fdc	Moving the import to the top of the file and getting rid of the redundancy ... I sure do wish I knew where the whitespace change was coming from, though. Frustrating.	8 years ago
Michael Laccetti	0bd25a9a38	Change s3 to use connect_to_region ... * Allows us to use Ansible/s3 for GovCloud when accessing a pre-existing bucket	8 years ago
Jonathan Mainguy	1608163b26	Now correctly gzip/bzips file back up in case of import failure ... Removed gunzip and bunzip2 dependency	8 years ago
Peter Gehres	878ff1e929	Issue #489: s3 should not fail on checksum mismtach when overwrite=no	8 years ago
Piotr Gosławski	9dd4f22430	update docs for insertbefore/insertafter	8 years ago
Piotr Gosławski	d388516046	Fix behavior when insert* doesn't match anything ... If insertbefore/insertafter didn't match anything, lineinfile module was doing nothing, instead of adding the line at end of fille as it's supposed to.	8 years ago
Achilleas Pipinellis	302c6f9b82	Add note about using version 1 of DigitalOcean API.	8 years ago
Feanil Patel	a0caaf7f42	Compare DNS names case insensitively.	8 years ago
Carlo Mandelli	1f93a052d6	Added HP-UX subclass	8 years ago
James Cammarata	7fd7cffb61	Updating version added fields for new alias parameters in route53	8 years ago
Monty Taylor	3e3486b813	One more OpenStack deprecation notice ... Fixes #858	8 years ago
Oleg A. Mamontov	845b6d78be	On FreeBSD apply 'login_class' only if there is real change.	8 years ago
James Cammarata	657d9d1f25	Add private_zone parameter for route53 ... Fixes #473	8 years ago
Monty Taylor	411c7e22b6	Add deprecation notices for old OpenStack modules	8 years ago
Brian Coca	fb61d5e795	fixed add_host docs indentation	8 years ago
Monty Taylor	7c9a36a999	Deprecate old OpenStack modules ... There are a completely new set of modules that do all of the things like keystone v3 and auth_plugins and the like correctly. Structurally upgrading these would have been massively disruptive and there is no real good way to do so without breaking people. These modules should be kept around for several releases - they still work for people - and they should get bug fixes. But they should not take new features. New features should go to the os_ modules.	8 years ago
Brian Coca	d6305bc938	fixed file module to use realpath when following links, readlink could be relative and fail in corner cases as per #852	8 years ago
Edward Larkey	d17726bae9	Fix typo in authorized key module documentation. ... Added opening double quote	8 years ago
Toshio Kuratomi	b9984b1dfe	Fix documentation to have correct param name	8 years ago
Dann Bohn	2cbaf16bcd	rhn_channel using depriciated methods. swapped out with their replacements	8 years ago
Brian Coca	5c90040626	undeprecated docker_image until replacement actually arives	8 years ago
blxd	35c414c271	Added check mode support to the ini_file module	8 years ago
Gerard Lynch	1fcc1a7374	wait_for: updated docs, must be resolvable hostname, updated example	8 years ago
Brian Coca	1ca1a2ed98	fixed typo on isgid	8 years ago
Brian Coca	49c10e4359	now captures connection exceptions and returns in 'nicer' module failure	8 years ago
Brian Coca	6e08dea567	fixed issues with stats return docs as per feedback	8 years ago
Brian Coca	47f84190a0	removed always for success, as data wont show on fail	8 years ago
Brian Coca	4124f8c381	now module fails gracefully instead of stacktrace when trying to install missing deb file	8 years ago
Brian Coca	8f197aed48	added missing docs on connection_timeout for wait_for	8 years ago
Brian Coca	d07d41b914	added note to add_hosts about loop bypass	8 years ago
Brian Coca	bcd6a6a3d5	draft for documenting module returns	8 years ago
Coderah	0fbe26273d	add alias support to route53 module	8 years ago
Coderah	40c41ed4ec	add hosted_zone information to ec2_elb_lb return	8 years ago
Capi Etheriel	103caa2853	add ec2 instance tags and groups info	8 years ago
Joel Thompson	646657e325	Fixes issue 697 -- only purge the grants that need to be purged	8 years ago
Stefan J. Betz	aca24caa19	Create SSH Keys always after creating $HOME	8 years ago
Jorge-Rodriguez	ad9379ad7d	Added optional parameter scheduler_hints.	8 years ago
Bret Martin	ed3f1a133b	ec2: make group only match group names in this VPC	8 years ago
Edward	bad5aafd30	Fixes #816 Backups not enabled on new droplets. ... Convert backups_enabled string to lowercase. Similar to fix for private networking.	8 years ago
Brian Coca	2278a69f7b	fix for mount w/o opts (bug introduced when fixing bind mounts)	8 years ago
Brian Coca	70856d5228	fix instance=None documentation	8 years ago
Brian Coca	cd7f498755	Revert "Revert "Don't use 'tenancy' in ec2 spot requests""	8 years ago
Brian Coca	6e55a0324b	Revert "Don't use 'tenancy' in ec2 spot requests"	8 years ago
Dan Rue	d3c686d632	Do not mark "skipped" when changed is false ... When using the "creates" option with the uri module, set changed to False if the file already exists. This behavior is consistent with other modules which use "creates", such as command and shell.	8 years ago
Matt Martz	8e4755728e	DRY up duplicate code	8 years ago
mrsheepuk	31421374c0	Doc change - make clearer usage for existing remote file ... Having read the doc for this module several times and completely missing that it can be used for existing remote archives, I propose this update to the wording to make clear from the top the two ways in which this module can be used.	8 years ago
Gauvain Pocentek	6c7b202a63	fetch: fix the flat parameter description ... ansible-doc expects the value of the description field to be a list, otherwise the output is not correct. This patch updates the flat description to be a list.	8 years ago
Matt Martz	cf50526cb5	Don't hardcode minimum for boot_volume_size	8 years ago
Sergey Zhukov	d013652dc7	Fixed broken volumes_from for client API >= 1.10	8 years ago
Marek Chodor	35ab6d15df	Fixes docker.errors.DockerException: 'dns' parameter has no effect on create_container(). It has been moved to start()	8 years ago
Matt Martz	724ae97898	Fix order of logic to determine required args	8 years ago
Richard Lander	a0dad8e683	password required	8 years ago
Richard Lander	f5532b7904	set network_config.public_ips attribute	8 years ago
Matt Martz	1f51a5effd	Add boot from volume functionality to rax and rax_cbs modules	8 years ago
Toshio Kuratomi	3aba0d5272	Fix for recursion traceback in copy with relative paths ... This is a further fix for: https://github.com/ansible/ansible/issues/9092 when the relative path contains a subdirectory. Like: ansible localhost -m copy -a 'src=/etc/group dest=foo/bar/'	8 years ago
Matt Martz	cce6cb8d7f	Don't hardcode a minimum size of a volume	8 years ago
mcameron	f799180a58	More general output.	8 years ago
Toshio Kuratomi	af6c625cc2	When recursing subdirectories, honor the follow parameter for setting file attributes. ... One half of the fix for https://github.com/ansible/ansible-modules-core/issues/778 The other half is in basic.py	8 years ago
mcameron	751e268f0d	Useful log output.	8 years ago
Rahul Mehrotra	fe08f52d92	Fixed Documentation issue concerning file mode when specified using numberical value	8 years ago
David Hummel	63e9de3170	Fix issue #793: mysql_db: for state={absent,present} connections to database mysql fail for users other than root	8 years ago
Robert Marsa	4737b41f26	Added the ability to set an instance to forward ip.	8 years ago
Jon Hadfield	90f5a23f34	use is-enabled to check systemd service status.	8 years ago
Matt Martz	a078a99fae	Support accounts with more than 100 load balancers	8 years ago
Brendan Jurd	fdc52b8277	Add word boundary in apache2_module regexp ... Add a word boundary \b to the regexp for checking the output of a2{en,dis}mod, to avoid a false positive for a module that ends with the same text as the module we're working on. For example, the previous regexp r'.*spam already enabled' would also match against 'eggs_spam already enabled'. Also, get rid of the redundant '.*' from the end of the regexp.	8 years ago
Graham Hay	15fcbcb0ee	Use insserv where available	8 years ago
Henry Finucane	464c502f95	dpkg does not take a --force-yes option	8 years ago
Doug Ellwanger	cc6cc6e302	Pull SSL certificate IDs from existing ELBs	8 years ago
Petros Moisiadis	f5961f9ecf	synchronize: use a single -F instead of -FF ... This small change corrects behavior when one uses an .rsync-filter file to exclude some paths from both being transferred and being deleted, so that these excluded paths can be handled separately with different tasks (e.g. in order to deploy the excluded paths independently from the rest paths and notify handlers appropriately). The problem with the double -FF option is that it excludes the .rsync-filter file from being transferred to the receiver. However, deletions are done on the side of the receiver, so it is absolutely necessary the .rsync-filter file to be transferred to the receiver, so that the receiver knows what files to delete and what not to delete.	8 years ago
Sébastien Gross	164d518370	Add basic support for OSX groups.	8 years ago
Sébastien Gross	624be0e239	Add basic support for OS X (Darwin) user management.	8 years ago
Robert Marsa	bf3cb32c1b	Added target_tags to gce_module.	8 years ago
Dagobert Michelsen	9991e8d8f1	Solaris SMF is already supported and should be mentioned in the docs,	8 years ago
Brian Coca	132c43a84f	added note that url src is only avaialable from 1.9 on	8 years ago
Toshio Kuratomi	691f4cc049	Tabs to spaces	8 years ago
Tomer Paz	76ee9a6a04	resolve issue 764 ... https://github.com/ansible/ansible-modules-core/issues/764 added 'domainname' attribute in addition to existing 'hostname'. That's the most elegant way to delegate domain name to docker-py...	8 years ago
Paul Geraghty	5f24584010	Correct grammar of comment relating to example	8 years ago
giovtorres	1f034a6573	Added pip example installing from local tarball	8 years ago
moussa taifi	742c10a1a0	Adds the currently available instance types for azure to the available dict(choices.....	8 years ago
Luc Bourlier	ae97d76a12	Don't use 'tenancy' in ec2 spot requests ... The problem was introduced in commit f5789e8e. 'tenancy' is a parameter of ec2.run_instances, but not in ec2.request_spot_instances. So it was breaking the support for spot requests.	8 years ago
Jesse Keating	6f4273a3ff	Add exclusive option to authorized_keys ... This option allows the module to ensure that ONLY the specified keys exist in the authorized_keys file. All others will be removed. This is quite useful when rotating keys and ensuring no other key will be accepted.	8 years ago
Philippe ALEXANDRE	5b48ecc80a	Add Linuxmint support in hostname module	8 years ago
Jeff Gonzalez	7ea6650d6c	Refactored code to use module utility fetch_url function.	8 years ago
Jeff Gonzalez	04fb952d49	Added documentation for using url as key source	8 years ago
Brian Coca	b6a1927f13	now allows for case in which someone removed the K* links and is trying to reenable a service	8 years ago
Brian Coca	03273e06c7	simplified update-rc.d enable/disable handling, removed forced defaults creation as that breaks local customizations	8 years ago
Jean-Baptiste Barth	c0b2960892	Improve formatting after previous commit	8 years ago
Jean-Baptiste Barth	58ff9bece2	EC2: move logic about terminated instances up (#423) ... As stated in #423, the commit 7f11c3d broke ec2 spot instance launching after 1.7.2. This is because it acts on the 'res' variable which have 2 different types in the method, and in case we request spot instances, the resulting object is not a result of ec2.run_instances() but ec2.request_spot_instances(). Actually this fix doesn't seem to be relevant in the spot instances case, because by construction we won't retrieve 'terminated' instances in the end.	8 years ago
Toshio Kuratomi	52d769d36c	Reverse the force parameter for the hg module	8 years ago
Peter Mooshammer	d741b57b91	adding disk_type option to choose from pd-ssd or pd-standard	8 years ago
Toshio Kuratomi	49f5b28fbd	Change the git force parameter to default to no as a safety change. ... Fixes #306	8 years ago
Toshio Kuratomi	245dce0e30	Make documentation list when force changed defaults	8 years ago
Toshio Kuratomi	36a483dacd	Update force documentation to reflect default=no	8 years ago
Brian Coca	b853ad6c90	corrected version added for latest features	8 years ago
Brian Coca	83e0516478	minor fixes on new rds refactor	8 years ago
AlejandroF	2e40773034	Example added ... How to define specific version of the package we need...	8 years ago
Brian Coca	884471a6b5	implemented account expiration as flag and not state, removed from unsupported platforms	8 years ago
Toshio Kuratomi	84f27cfa68	Remove str.format() usage for python2.4 compat. ... Fixes #10036	8 years ago
Conrado Buhrer	09082e6e7f	fixed: namespace clash #710	8 years ago
Conrado Buhrer	abde33c615	fixed: erroneous logic	8 years ago
Conrado Buhrer	a6315043ef	fixed: missing check for upgrade flag	8 years ago
Conrado Buhrer	807b168590	fixed: removed build-deb from required_one_of	8 years ago
Toshio Kuratomi	e4a3e5fdd7	Prefer gtar to tar ... Fixes #702	8 years ago
Conrado Buhrer	3165b39d21	changed: state=build-dep; refactored into install()	8 years ago
Conrado Buhrer	442663a13a	added: build-dep to apt module #349 ... Original code provided by @nathanhruby	8 years ago
Johannes Steger	1a440d6a06	Fix function identifier quoting	8 years ago
sysadmin75	2990358cd5	Fix #10059 - replace module does not obey follow=yes	8 years ago
Toshio Kuratomi	dd79a27e73	Spelling and grammar fix	8 years ago
Matt Martz	ff90273021	Remove unnecessary logic, return the database on delete	8 years ago
Toshio Kuratomi	a73bd8dcbc	More information about distutils on Solaris in case we run into this again	8 years ago
Toshio Kuratomi	52bcf4a195	Don't fial if virtualenv is not installed and we do not need to initialize the virtualenv ... Fixes #688	8 years ago
Brian Coca	f90da6b2ba	ec2 fix docs format	8 years ago
Brian Coca	ed0f5045eb	moved defaulting to module constant to after when it is defined	8 years ago
Toshio Kuratomi	547c90554a	Standardize class names on Archive suffix. ... This also removes the collision between the stdlib ZipFile class and the module's ZipFile class Fixes #681	8 years ago
Brian Coca	1f1ebf248f	updated tenancy version added	8 years ago
Ryan Rawson	e318ef2d70	Fixes #581 - digitalocean module cannot create private_networking=true droplets	8 years ago
Ben Konrath	96a20de9ff	Add support for SL7 to hostname module.	8 years ago
Brian Coca	8405edd5a2	now handles non string values for sysctl	8 years ago
Alex Clifford	4097cbf317	ttl should always be used during a delete	8 years ago
Matt Martz	8b60fb7181	Remove unnecessary required arg logic, and remove 'absent' as a valid choice since it isn't implemented	8 years ago
Matt Martz	5ae50eb8cf	Small fix-ups to convert objects to dicts, update volume details at the appropriate time, and remove unnecessary required argument logic	8 years ago
Matt Martz	19d99e0da6	Remove some broken and unnecessary required args logic	8 years ago
Matt Martz	63e5d5dcc4	Use rax_to_dict and make sure to return the volume details after deletion	8 years ago
Brian Coca	02a1cb62df	corrected release when this feature was added	8 years ago
Patrik Lundin	88fe45d7e7	Update OpenBSD rcctl handling to use new syntax. ... See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2	8 years ago
Matt Martz	3a46c79451	Clean up some required argument logic	8 years ago
Matt Martz	db5f2bf3df	Just use built in required functionality for arguments	8 years ago
Matt Martz	617048b717	It is not correct that you need at least 1 primary node	8 years ago
Tim G	b2e39265e1	Load distutils on all platforms EXCEPT Solaris. ... Solaris doesn't ship distutils with with the default Python package. This patch fixes "service" on Solaris since 30d6713.	8 years ago
Toshio Kuratomi	1728f9bba7	Add detection of uid,gid,mode changes when deciding whether an archive needs to be unarchived again.	8 years ago
Brian Coca	65d3b167e6	now captures cache fetch failures	8 years ago
Toshio Kuratomi	f9a6ec95b0	Implement user,group,mode,selinux settings for unarchive. ... This is a partial fix for #234. Still have to figure out how to make change reporting work as we can no longer rely on tar's --compare option	8 years ago
Toshio Kuratomi	44354e31e4	Better error messages if a2enmod/a2dismod are not found	8 years ago
Toshio Kuratomi	f3d41cdb06	Potential fix for 640	8 years ago
Tim G	ea77ac076b	distutils is not available on some non-Linux OS's	8 years ago
Alex Clifford	d4c4dd31d8	Fix slight typo in doco	8 years ago
Toshio Kuratomi	e11ea4b402	Also catch mysql errors so we can give the error message back through json rather than tracebacking	8 years ago
Michael Scherer	0a745de765	Do not use echo shell builtin for password ... Using \t in a password may result in a different password being set : $ echo 'a\ta' a a Problem report originally found by Pilou- ( https://github.com/ansible/ansible-modules-extras/pull/198 )	8 years ago
Michael Scherer	b154bf967e	Remove unused code ... There is no call to yum_base using 'cachedir' argument, so while it work fine from a cursory look, that's useless code, and so should be removed to clarify the code.	8 years ago
Michael Scherer	2dfc7122af	Use the rpm python module rather than execing rpm ... Using the rpm module prevent a uneeded fork, and permit to skip the signature checking which slow down a bit the operation, and which would be done by yum on installation anyway.	8 years ago
Bruce Pennypacker	605a5a5b53	requested changes	8 years ago
Bruce Pennypacker	9cbe3eb8ae	Added support for 'REQUIRE SSL' grant option	8 years ago
Brian Coca	a3de4db57d	fix for allowing permissions on hard links and soft links + follow=yes	8 years ago
Toshio Kuratomi	e75dc7e5a6	Clarify documented behaviour of user module's ssh_key_file parameter ... Fixes #9873	8 years ago
Brian Coca	c5dfc66cb1	added version added for new template options	8 years ago
Vasyl Kaigorodov	d41ec7027f	gce_net - creating firewall rule, src_range value seems to get lost or set to empty string -- fixes #252	8 years ago
James Martin	07dbc333b2	vpc_zone_identifier must be a csv string when an asg is updated.	8 years ago
Brian Coca	9eb77bdb4f	fix for when state=directory, follow=yes and target is symlink to directory	8 years ago
Philip Misiowiec	f3abfa0f19	Adds tenancy state to returning json	8 years ago
Johnny Robeson	6fc04862a4	rename FedoraStratgy to SystemdStrategy	8 years ago
Michael J. Schultz	588d03db8d	Build the db connection on `"postgres"` instead of `"template1"` ... According to the postgresql docs[1], you should not have a connection with `"template1"` when copying multiple databases. [1]: http://www.postgresql.org/docs/9.1/static/manage-ag-templatedbs.html	8 years ago
Jeff Gonzalez	30822706dd	Added ability to use url as key source	8 years ago
Michael Scherer	d357f309b5	Fix #370, by allowing to export over a existing repository ... This requires to use force=True	8 years ago
Michael Scherer	e1194116b2	Make force parameter work for export operation ... The default is changed from 'yes' to 'no' to follow subversion behavior (ie, requiring explicit confirmation to erase a existing repository). Since that was not working before cf #370 and since the option was ignored before and unused, this should be safe to change.	8 years ago
Patrik Lundin	9803938663	Handle string returned by 'default' correctly. ... We need to handle the string returned by 'default' in the same way we handle the string returned by 'status' since the resulting flags are compared later.	8 years ago