Commit Graph

5781 Commits (38c11e22397a0b93f121268527669d7318812a4d)

Author SHA1 Message Date
James Cammarata 5d92b00d9c Cleanup some include logic
* Properly mark hosts with failures in includes as failed
* Don't send callbacks until we're sure we're done, and also fix how
  we increment stats so failures don't show up as ok's
* Fix a bug in the include file logic where a failed include could lead
  to an infinite loop in the task iteration logic

Fixes #12933
9 years ago
Toshio Kuratomi 56b310b18d Update submodule refs 9 years ago
James Cammarata 299054852a Allow tags to be specified in included file params
Fixes #12940
9 years ago
Brian Coca b2fc5142eb moved sudo -S and -n into configurable flags as they might be absent in much older systems
if password is supplied exsiting -n would get remove from flags
9 years ago
Toshio Kuratomi e3e2db1119 Improve the warning message about duplicate yaml dict keys 9 years ago
James Cammarata 87269599a0 Also consider the full role name when searching for --start-at-task 9 years ago
Toshio Kuratomi acbea65b1d Update core submodule ref to fix doc build 9 years ago
Toshio Kuratomi 2c5da0923a Update submodule refs 9 years ago
Toshio Kuratomi 7334389de6 Merge pull request #12930 from ansible/dict-key-overwrite-warning
Break apart a looped dependency to show a warning when parsing playbooks
9 years ago
Toshio Kuratomi 4203850d1a Break apart a looped dependency to show a warning when parsing playbooks
Display a warning when a dict key is overwritten by pyyaml
Fixes #12888
9 years ago
James Cammarata 3fc2209ca0 Fixing retry/until logic and default value for retries
Fixes #12928
Fixes #12929
9 years ago
James Cammarata 57fe0d6aed Merge pull request #12911 from bcoca/manpage_fixes
Manpage fixes
9 years ago
James Cammarata 1dc23ea779 Merge pull request #12866 from bcoca/more_inheritence
More inheritence
9 years ago
James Cammarata cace91df56 Allow hostvars cache to be invalidated so hostvars contain all hosts after add_host
Fixes #12925
9 years ago
James Cammarata 2825c188bd Merge pull request #12901 from bcoca/sanitize_results
sanatize results
9 years ago
Jason O'Donnell 9dfa3719be Fixing typo 9 years ago
Jason O'Donnell ac9b35cc2b Found another typo 9 years ago
Jason O'Donnell 80433c2a2d Fxing typo 9 years ago
Toshio Kuratomi de54f26376 Update submodule refs 9 years ago
Brian Coca c271c0eb04 added setting of ansible_ssh_user to current user as backwards compatibilty issue 9 years ago
Brian Coca 4486e136ea Merge pull request #12899 from bcoca/vault_fixes
simplified vault password functions
9 years ago
Brian Coca 5b33b0ddfd Merge pull request #12896 from bcoca/ssh_current_user_config
don't set user to current user
9 years ago
James Cammarata 677a2f95e5 Make sure Base attributes are copied cleanly
Fixes #12882
9 years ago
Toshio Kuratomi 8f77dd1cf2 Update submodule refs 9 years ago
Brian Coca f3a0adcfa5 added info about using -i 'hostname,' to usage/help 9 years ago
Brian Coca 7ebfe72015 added missing string_types 9 years ago
Brian Coca 8ce864db6f sanatize results 9 years ago
Brian Coca 368f4448dc simplified vault password functions
also fixes #12864
9 years ago
Toshio Kuratomi 92dd563a75 Fix invocation from bad merge and note where it would need to go to keep
it out of registered vars as well.
9 years ago
Brian Coca f78c82b9ee don't set user to current user
also remove condition to bypass setting user if user matches current user
this enables forcing user when set to the same user as current user and ignoring .ssh/config
while keeping .ssh/config with current user if nothing is specified.
9 years ago
Brian Coca 25e3fe04a8 finalized changed to use abridtged_result instead of result
removed no longer defined no_log
9 years ago
Toshio Kuratomi b109b83809 Update submodule refs 9 years ago
Toshio Kuratomi ca32d5bacc Potential fix for #12816 9 years ago
James Cammarata 3eea4e23d5 Manually add plugin directories when running the adhoc command
Fixes #12891
9 years ago
Toshio Kuratomi 3812ec8d1d Implement invocation hiding for all callbacks if the verbosity is low 9 years ago
Brian Coca 275764d4a5 avoid showing invokation when no_log is set or verbosity is low 9 years ago
James Cammarata 63ea614b4c Version bump for 2.0.0-0.4.beta2 9 years ago
Toshio Kuratomi 99c6f77e59 Fix callback 9 years ago
Jens Peter Schroer ecae636160 allowing json in lookup template calls 9 years ago
James Cammarata 4fd4f3374a Merge pull request #12879 from larsks/bug/12876
allow include: directive to work during exception processing
9 years ago
Lars Kellogg-Stedman 914f68f9af allow include: directive to work during exception processing
prior to this commit, an attempt to use the `include:` directive would
fail in a `rescue:` or `always:` block if there were failures in the
main block task list.

Resolves #12876.
9 years ago
Toshio Kuratomi ce2b18174e Merge pull request #12878 from ansible/invocation-fix
Invocation fix
9 years ago
Toshio Kuratomi 2e87c1f74e Two fixes to action plugins
* Fix the task_vars parameter to not default to a mutable type (dict)
* Implement invocation in the base class's run() method have each action
  module call the run() method's implemention in the base class.
* Return values from the action plugins' run() method takes the return
  value from the base class run() method into account so that invocation
  makes its way to the output.

Fixes #12869
9 years ago
Brian Coca 5017a96948 Revert "make callbacks declare needing whitelisting"
another premature merge
This reverts commit df8ff85787.
9 years ago
James Cammarata 86de1429e5 Cleaning up FIXMEs 9 years ago
Toshio Kuratomi 1e50d31cdc Update submodule refs 9 years ago
Brian Coca df8ff85787 make callbacks declare needing whitelisting
this will allow for custom or v1 callbacks locally loaded to automatically be triggered as they were in 1.x
9 years ago
Toshio Kuratomi 75cff7129c Fix for invocation not being added to output.
We want invocation to be omitted when we are running async, not when we
aren't running async.
9 years ago
Toshio Kuratomi 6b6d03290a Restore the automatic addition of invocation to the output
Revert "Remove auto-added invocation return value as it is not used by v2 and could leak sensitive data."

This reverts commit 6ce6b20268.

Remove the note that invocation was removed as we've now restored it.

Revert "keyword not in ubuntu 14.04"

This reverts commit 5c01622457.

Revert "remove invocation keyword check"

This reverts commit 5177cb3f74.
9 years ago
James Cammarata 498c27d09a Re-adding role_names magic variable
Fixes #12863
9 years ago
Brian Coca c267c23020 make callbacks declare needing whitelisting
this will allow for custom or v1 callbacks locally loaded to automatically be triggered as they were in 1.x
9 years ago
Brian Coca 54e821ca94 added deprecation warning to comma separated role spec 9 years ago
Brian Coca 09899b7c43 Merge pull request #12783 from larsks/bug/12782
correct value of remote_user for local connections
9 years ago
Brian Coca 9886829e40 Merge pull request #12861 from willthames/galaxy_spec_in_meta_main_fix
Allow meta/main.yml to include roles through spec file
9 years ago
Brian Coca d861e7dd5d moved several directives so they are not settable at play, block, role and task levels 9 years ago
Brian Coca fc3a44485b skip errors on conditional if task is include
fixes #12843
9 years ago
Will Thames 002972c6cf Allow meta/main.yml to include roles through spec file
ansible-playbook now works when run with a playbook
that includes a role that includes another role
specified using csv format

Updated one of the roles used in the tests to fix
broken tests - `make test_galaxy` now works

Fixes #11486. Also addresses the problem alluded to in #10620.
9 years ago
Brian Coca 08c9e70307 made display part of variable manager and corrected reference to it
fixes #12859
9 years ago
James Cammarata 2b3c5aa41e Support cmd param in Tasks by assigning it to _raw_params
Fixes #12856
9 years ago
James Cammarata 0e447e3f41 Merge branch 'devel' of https://github.com/mathieumd/ansible into mathieumd-devel 9 years ago
James Cammarata 4b20884719 Return correct changed flag when using check mode with template and force=no
Fixes #12844
9 years ago
Brian Coca 04aa7701d1 fix prompt, static methods don't get 'self'
fixes #12833
9 years ago
Toshio Kuratomi 42ce3de8d0 Merge pull request #12853 from ansible/winrm-return-bytes
In v2, exec_command should return bytes and the caller will take responsibility for converting to unicode
9 years ago
Toshio Kuratomi 3d57a202b5 And another fix for docs 9 years ago
Toshio Kuratomi 9dc9a606f6 Correct docs build 9 years ago
Toshio Kuratomi 632d356d22 Update submodule refs 9 years ago
Toshio Kuratomi 6e5055e786 Update the use of no_log values to cover everything that heuristic_log_sanitize does.
Fixes #12792
9 years ago
James Cammarata ec56b29ba4 Fix setting of interpreter values for delegated hosts
Fixes #12772
9 years ago
Toshio Kuratomi c845181dc1 In v2, exec_command should return bytes and the caller will take responsibility for converting to unicode 9 years ago
gduke 744679601f Remove mutable default arguments. 9 years ago
Toshio Kuratomi 10e2fc6f60 Update submodule ref 9 years ago
Toshio Kuratomi 1126ce34e3 Merge pull request #12846 from ansible/nolog-for-return-value
Hide values in json returns which were given in parameters marked no_log.
9 years ago
Toshio Kuratomi c2d188baff Hide values in json returns which were given in parameters marked no_log. 9 years ago
James Cammarata 3ddda2f460 Merge pull request #12842 from mcsalgado/include_with_items
Revert back to copying self._task.args
9 years ago
Brian Coca 1ecad5aed2 now galaxy correctly detects empty requirements file
also allow for 'scm' and 'src' not to be populated in requirements entries
9 years ago
Victor Salgado c5c5f3bf7a Revert back to copying self._task.args 9 years ago
Victor Salgado 0e671baa33 Fix typo 9 years ago
James Cammarata b46ce47a84 Don't use local transport for delegated hosts if the inventory_hostname isn't local
For some situations like Vagrant, the remote_addr may be a localhost addr, but ssh
is still desired. This corrects the assumption that any localhost remote_addr should
be using the local connection by checking the inventory_hostname value as well.

Fixes #12817
9 years ago
Toshio Kuratomi 99e7bb35c1 Simplify UnsafeProxy as we don't need to use it for byte strings, only text 9 years ago
James Cammarata 3c87c44af5 Fixing bug in includes caused by 892d9b8
Fixes #12837
9 years ago
Toshio Kuratomi 31ebafcbdd Update submodule refs 9 years ago
Toshio Kuratomi f34b55ac2b Add python3-compat boilerplate to all .py files in lib/ansible 9 years ago
Brian Coca de3ca57a33 avoid relative shlex import
fixes #12777
9 years ago
James Cammarata e5b6d802bf Removing some cruft related to _local_action value on Task, which was removed
Fixes #12819
9 years ago
Mathieu 260a3e5ce7 Fixes #11055 - Set locale via LC_ALL 9 years ago
Toshio Kuratomi 923fc9fb15 Cleanup pyflakes warning (real error) 9 years ago
Toshio Kuratomi 7aa9f6754a Cleanup more pyflakes warnings (2 real problems) 9 years ago
James Cammarata 1fa975d81a Simplify group_by by removing BYPASS_HOST_LOOP from the action
Fixes #12825
9 years ago
Toshio Kuratomi 0888d78b84 Cleanup some pyflakes warning (1 real error) 9 years ago
Toshio Kuratomi c6d44738ad Clean up some more pyflakes warnings 9 years ago
Toshio Kuratomi 3da8bab3ff Cleanup pyflakes warning (real error) 9 years ago
Toshio Kuratomi a526eae543 Clean up a few more pyflakes warnings 9 years ago
Toshio Kuratomi a17ae6f07e Clean up pyflakes warnings in inventory 9 years ago
James Cammarata 892d9b8dfb Move post_validate for tasks after checking for an include
Simplifies logic and prevents us from accidentally post_validating
an include that would otherwise be skipped due to tags causing a
problem because of potentially missing variables.

Fixes #12793
9 years ago
James Cammarata 1cfd941179 Adding a v2 callback for task includes 9 years ago
Toshio Kuratomi dc33d30c6d Update submodule refs 9 years ago
Toshio Kuratomi b67e51ea06 Information on when to use to_str() and what a native string is 9 years ago
Toshio Kuratomi 39d9bc3564 Update submodule refs 9 years ago
Toshio Kuratomi 6ce6b20268 Remove auto-added invocation return value as it is not used by v2 and could leak sensitive data. 9 years ago
Brian Coca 1280e2296c changed warning to debug and expanded info on what is really happening, it was a bit misleading 9 years ago
Brian Coca 2d1d21228a updated skippy to match default output 9 years ago
James Cammarata 0bbe9d5bd0 Make hostvars json/yaml serializable in filters
Fixes #12615
9 years ago
James Cammarata a88c59f451 Reset basedir for plays that are not from a PlaybookInclude
Fixes #12524 (again)
9 years ago
James Cammarata 0aa018337a Fixing logic in json cache plugin get()
Fixes #12722
9 years ago
James Cammarata 5f617c601b Remove obsolute tag evaluation in free strategy
Fixes #12784
9 years ago
Brian Coca 6c8cf8acb7 now profile_tasks callback handles handlers correctly
fixes #12762
9 years ago
James Cammarata 1ab0e0e228 Disable RuntimeWarnings during all() plugin loading
Fixes #12778
9 years ago
Brian Coca 71ffb86c30 don't let cowsay issues stop execution
fixes #12773
9 years ago
Brian Coca 6d87bd405d Merge pull request #12765 from bcoca/lookup_inventory_hostname
implemented inventory_hostname lookup in v2
9 years ago
Toshio Kuratomi a567f28657 Update submodules for docs fixes# Please enter the commit message for your changes. Lines starting 9 years ago
Toshio Kuratomi 5d8ab9b01b Update module refs 9 years ago
Toshio Kuratomi b23a083776 Make vault use a mapping of cipher name to classes instead of formatting the name for safety. 9 years ago
Toshio Kuratomi baa309309d Bundle a new version of python-six for compatibility along with some code to make it easy for distributions to override the bunndled copy if they have a new enough version. 9 years ago
Lars Kellogg-Stedman aa0b7536c9 correct value of remote_user for local connections
When using 'local' connections, privilege escalation would fail if
ansible_ssh_user was in the current context to the same value as
become_user.

This commit ensures that for 'local' connections we reset remote_user to
the local username.

This fixes #12782.
9 years ago
Toshio Kuratomi 28c933ce5e properly fail_json when we don't have ssl on a non-redhat distro 9 years ago
Marius Gedminas 98958ec990 Simplify join expression 9 years ago
Marius Gedminas 56184a3d8c Python 3: avoid %-formatting of byte strings
This is needed for Python 3.4 compatibility; Python 3.5 can use
`b'%s\n' bytestring` again.
9 years ago
Brian Coca 9b088a1e40 implemented inventory_hostname lookup in v2 9 years ago
Brian Coca aee6de5a76 group_names should not include implied 'all', fixes #12763 9 years ago
James Cammarata dce58a78c9 Make random cowsay truly random
Also adds a cowsay whitelist config option, because there are some
truly NSFW stencils that come with cowsay by default.
9 years ago
Marius Gedminas 4fb6f62f1b Fix Unexpected Exception: global name 'os' is not defined
I inadvertently introduced it in
ca826508d9 and didn't notice, because
there are no unit tests for playbook_executor.py.  Sorry!

(The "from ansible.errors import *" was used *only* to get the 'os'
module, which makes go "what?")
9 years ago
Marius Gedminas ab569cea22 Move to_str alias into ansible.utils.unicode
@abadger suggested on IRC that it's useful enough to go into
ansible.utils.unicode.
9 years ago
Marius Gedminas ca826508d9 Python 3: fix AnsibleError formatting
If you convert the error string to bytes and embed it inside another
error string, you get

  Prefix:

  b'Embedded\nerror\nstring'

which is not what we want.

But we also don't want Unicode in error messages causing unexpected
UnicodeEncodeErrors when on Python 2.

So let's convert the error message into the native string type (bytes on
Python 2, unicode on Python 3).
9 years ago
Toshio Kuratomi 5617f6aad4 Update synchronize to use the correct host when delegating
Fixes #12752
9 years ago
Toshio Kuratomi 85abd61001 Add some more info to docstring 9 years ago
James Cammarata d923d05a33 Reworking the way all() works in plugin_loader
* Don't throw away the full path of the module code being loaded,
  as this can cause conflicts when files of the same name are being
  instantiated
* Generalize the module loading code

Fixes #12738
9 years ago
James Cammarata 45b803efb4 Properly use test_loader from SharedPluginLoaderObj 9 years ago
Toshio Kuratomi c8ad55103e Update extras modules ref to fix docs 9 years ago
Toshio Kuratomi e00eeba9c3 Update submodule refs 9 years ago
James Cammarata 91b0b4d40c Check is_directory() before not is_file() in inventory basedir
Fixes #12742
9 years ago
Brian Coca c57200925f made syslog import optional as intel's edison custom compiles python w/o it 9 years ago
James Cammarata ee559e03f7 Merge pull request #12725 from mgedmin/py3k
Python 3: there's no basestring
9 years ago
James Cammarata e6d3c6745f Revert to using local file/dir tests in inventory instead of loader's
Fixes #12719
9 years ago
Brian Coca c637d60a8d fixed deprecation message 9 years ago
Brian Coca f5227d494b added missing cachefile and changed str(e) to to_bytes(e) 9 years ago
Marius Gedminas 9ba6c087d3 Python 3: there's no basestring 9 years ago
Marius Gedminas f03da5be42 Python 3: there's no iteritems() 9 years ago
James Cammarata 2d77c643e4 Merge pull request #12723 from mgedmin/py3k
Make ansible.vars.unsafe_proxy Python 3 friendly
9 years ago
Marius Gedminas e511d6d458 Make UnsafeProxy work on Python 3
Instead of str and unicode we have to deal with bytes and str.
9 years ago
Marius Gedminas af6a316d9b Remove unused import
Fixes ImportError: No module named '__builtin__' on Python 3.
9 years ago
James Cammarata 426187489f Add variable for format parameter 9 years ago
Toshio Kuratomi 8277747a04 Fix password lookup when password file exists and the password is not encrypted 9 years ago
James Cammarata cd2cb178ae Totally rework the way UnsafeProxy does things 9 years ago
Toshio Kuratomi 15d7f53846 AnsibleModules.log() fix for python3
Also add unittests for AnsibleModules.log()

Fixes #12586
9 years ago
Toshio Kuratomi b49e0995cb Fix typo 9 years ago
Toshio Kuratomi b58d7470d4 Cleanup logic and be more paranoid about passwords with spaces 9 years ago
James Cammarata 5c5806d669 Fixing bugs related to jfonfile cache plugin
* corrupt/invalid file causes tracebacks
* incorrect initialization of display/_display in BaseCacheModule class
* tweaking the way errors in get() on jsonfile caches work, to raise
  a proper AnsibleError in that situation so the playbook/task is stopped

Fixes #12708
9 years ago
Toshio Kuratomi b441bcb678 Fix display when run through a testing framework that overrides stderr/stdout 9 years ago
James Cammarata d15fcf05f0 Fix bug in the way temp vars were created for templating vars_files
Fixes #12711
9 years ago
Brian Coca f5f3bf06e4 Merge pull request #12550 from redrampage/remove-pw-salt-deletion
Removed deletion of salt by 'password' lookup
9 years ago
James Cammarata 73661d1761 Merge branch 'devel' of https://github.com/ansible/ansible into devel 9 years ago
Charles Paul 3d533cb423 fixing calls to fail_json 9 years ago
Brian Coca 50372eecc9 Merge pull request #12455 from privateip/devel
added methods for retrieving vapp and vm
9 years ago
James Cammarata 82e76e42e5 Tweak to the way serial percentages are handled 9 years ago
James Cammarata 63e288354e Fix bug in way omitted values were set 9 years ago
James Cammarata 4c85ae0712 Merge branch 'serial_should_be_string' of https://github.com/klshxsh/ansible into klshxsh-serial_should_be_string 9 years ago
klshxsh ac00c9ced7 changed 'string' to 'percent' for _serial
Note that this allows both integers (e.g. 3) and percentages (e.g. "30%")
Also changed default back to 0 rather than '0'
9 years ago
James Cammarata eb60ce1b6e Merge pull request #12703 from keitwb/inventory_file_var
Adding the inventory_file var back
9 years ago
James Cammarata 71a1a3c903 Submodule pointer update 9 years ago
Ben Keith 1f82971283 Adding the inventory_file var back 9 years ago
Toshio Kuratomi 45a161b0a1 Merge pull request #12429 from edmstudio/devel
Update synchronize module plugin to work on OS X
9 years ago
Petr Mifek 6e035a3e94 Move nested function test for ipv6 to top level in synchronize module. 9 years ago
Brian Coca 45788fbfad <homer>doh!</homer> 9 years ago
Brian Coca d24532757c remove fix for local_action/connection local that is now not needed 9 years ago
klshxsh 4a5e52b2d2 The serial keyword can be specified as a percentage, e.g '30%' or a number e.g. '3'; therefore it needs to be a string to allow both types 9 years ago
Brian Coca b9d54e9a01 corrects previous fix to deal with missing item key in results dict 9 years ago
Brian Coca abf2e13955 Revert "Track local_action internally to prevent it from being overridden"
This reverts commit 49ca0eb797.
9 years ago
Brian Coca 101c8785ec removed changes to make local action equate connection=local and brought it back to equate delegate_to=localhost 9 years ago
Brian Coca bcb173996b Merge pull request #12695 from matburt/fix_cache_plugins_for_v2
Fix an issue where cache plugins weren't updated in certain scenarios
9 years ago
Brian Coca fbf4cafab5 on skipped you 'might' not have an item, changed to getattr to avoid keyerror
fixes #12683
9 years ago
Matthew Jones 7da478a4f4 Fix an issue where cache plugins weren't updated
The first call to persisting facts would work due to the assignment of a
MutableMapping calling __setitem__ but subsequent module fact data would
not be propogated to the fact cache plugins because update() doesn't
invoke __setitem__.  This changes the behavior a little bit and ensures
set() is called on cache plugins.
9 years ago
Brian Coca ec02b255c3 Merge pull request #12689 from soarpenguin/bugfix
Remove some warning of undefined name and fix classmethod syntax error.
9 years ago
James Cammarata 770032648a Show -> localhost for local_action tasks 9 years ago
James Cammarata f415d39dfd Merge pull request #12690 from stelligent/devel
Use AWS_DEFAULT_REGION env var if none specified
9 years ago
James Cammarata cfa62e7a2a Submodule pointer update 9 years ago
James Cammarata 868819f9fa Make sure shlex split is returning properly encoded strings
Fixes #12676
9 years ago
Shayne Clausson 55b3f9e4e5 Use AWS_DEFAULT_REGION env var if none specified 9 years ago
soarpenguin b11ea17385 fix classmethod syntax error. 9 years ago
soarpenguin 5efa4d29e3 fix some warning of undefined name. 9 years ago
James Cammarata 59d655c543 Double echo temp directory name to handle spaces and ~ expansion both
Fixes #12667
9 years ago
Toshio Kuratomi d1b98ec776 Correct typo 9 years ago
Toshio Kuratomi 2f5e817007 Do not mix byte str with unicode type 9 years ago
Toshio Kuratomi 01ba2e94c0 Wait until later to convert to byte strings for output
Also some pre-emptive python3 compat and a code simplification
9 years ago
Brian Coca 76feba00c4 avoid callbacks during syntax check and listing
fixes #12682
9 years ago
Brian Coca 4463ced8ba simpler safe output 9 years ago
James Cammarata de792ba3c2 Improve handling of unicode errors
Fixes #12669
9 years ago
James Cammarata 5a0f5f1254 Load vars for localhost when created implicitly
Fixes #12666
9 years ago
Brian Coca d8769c93c7 updated ec2 region description to add missing other env var 9 years ago
Brian Coca c77733e64e added docs for commonly used region parameter in some ec2 modules 9 years ago
Brian Coca 638bc14566 now deps is always a list 9 years ago
Brian Coca dac3684fd1 changed task color to dark gray to keep it from being confused with ignore/skip 9 years ago
Brian Coca c459dd4e18 Merge pull request #12663 from Juraci/task-path
Displays the absolute path of a given task when verbosity is above level 3
9 years ago
James Cammarata dbae110f6f Merge pull request #12660 from apollo13/fix_galaxy_init
Show a nice error if the role name is missing.
9 years ago
Juraci e52950a939 Displaying task_path on task start when verbosity is more than 3 9 years ago
Juraci 254d6be520 Adding get_path method to Task class 9 years ago
Florian Apolloner 354383874f Show a nice error if the role name is missing. 9 years ago
= 345ce424c6 Explictly set the version of strict mode to use for powershell modules. 9 years ago
James Cammarata 9e364c2eb5 Don't modify results in callbacks
Fixes #12654
9 years ago
James Cammarata 8107c4efc7 Fixing a bug in galaxy parsing of text spec file lines 9 years ago
James Cammarata 7a815b7296 Force connection to local when localhost is delegated to 9 years ago
Toshio Kuratomi 97e8d25eb4 Fix for encoding errors when a command returns non-utf8 encoded values 9 years ago
Toshio Kuratomi 4f6f2c21e8 range vs xrange doesn't matter here and six.moves.range isn't available in six-1.3.0 (rhel7) 9 years ago
James Cammarata 5ae74f7d38 Version bump for 2.0.0-0.3.beta1 9 years ago
James Cammarata d9b79b1bbc Also template the role name when loading roles
Fixes #12602
9 years ago
James Cammarata 9c9897805f More ansible-galaxy fixes for the old spec file format 9 years ago
James Cammarata fb822a4305 Merge pull request #12637 from rcleere/rekey_fix
Fix ansible-vault rekey
9 years ago
James Cammarata 3b8eaf6128 Cleaning up some ansible-galaxy stuff 9 years ago
Ryan Cleere 0400ab8c0f Fix ansible-vault rekey 9 years ago
James Cammarata d91b3c6b9d Make sure magic variables are available when templating vars_files
Also does some reorganization/cleanup on the magic vars/delegated
variable generation portions of VariableManager to make the above
possible.

Fixes #12633
9 years ago
James Cammarata 284bd118a0 Properly switch to the default transport when delegating from localhost 9 years ago
Brian Coca 6f88f79de9 removed dupe install code, now trap errors forom role.install 9 years ago
Brian Coca f73329401b galaxy updates
better error reporting on fetching errors
use scm if it exists over src
unified functions in requirements
simplified logic
added verbose to tests
cleanup code refs, unused options and dead code
moved get_opt to base class
fixes #11920
fixes #12612
fixes #10454
9 years ago
Brian Coca a3ed9fc131 updated to 'fixed' get_url so docs build again 9 years ago
Brian Coca f3d0468726 updated submodule refs 9 years ago
James Cammarata 323012be2e Pop tags out of playbook include params
Fixes #12605
9 years ago
Toshio Kuratomi 10a4a4e986 Quote any file paths that we have to use with dd to copy.
This is because we pass the whole dd command string into the shell
that's running on the contained environment rather than running it
directly from python via subprocess without a shell.
9 years ago
Toshio Kuratomi b83988d9fb Port libvirt_lxc connection plugin to v2 9 years ago
Toshio Kuratomi 567deb5ac2 Add explicit substitution of relative paths on the remote host just in case the connection programs do something unexpected. 9 years ago
Brian Coca 8528b20702 fixed usage text 9 years ago
Brian Coca 04a2b221b9 removed conflicting short options 9 years ago
James Cammarata 38528c8ef3 Show more info in the minimal callback for unreachable hosts
Fixes #12621
9 years ago
Toshio Kuratomi 613e87db6c FIx typo arg_path (not plural) 9 years ago
Brian Coca 4ba5ebd1c8 Merge pull request #12538 from yesbox/url_lookup_plugin_httperror_fix
Fix url lookup plugin HTTPError message not being reachable
9 years ago
Peter Sprygada ab3239ecd7 added methods for retrieving vapp and vm 9 years ago
Toshio Kuratomi 10750214ea Since Connection.execute_command() returns bytes, deal with the repurcussions here. 9 years ago
Brian Coca e2ae3215f6 corrected no_log for items and skipped tasks
corrected output from default callback
added new tests for no_log loops
updated makefile test to check for both positive and negative occurrences of no_log
9 years ago
James Cammarata c28758d2a8 Merge branch 'ssh-args' of https://github.com/amenonsen/ansible into amenonsen-ssh-args 9 years ago
James Cammarata 82faba619e Also add args_path param to powershell shell plugin 9 years ago
James Cammarata 30d481ac57 Fix old-style (non-python) module support 9 years ago
Toshio Kuratomi e40e08d799 Update core sumodule ref to fix docs 9 years ago
Abhijit Menon-Sen b127221f50 Pass default None to getattr, remove repeated call 9 years ago
Abhijit Menon-Sen 96c4dc273a Set explicit default for ANSIBLE_SSH_ARGS
The earlier code behaved exactly as though this default had been set,
but it was actually handled as a(n unnecessary) special case inside the
connection plugin, rather than set as an explicit default.

If the default is overriden either in ansible.cfg or the environment,
the new code will continue to work (in fact, it won't know or care,
since it just uses the value set in the PlayContext).

This is submitted as a separate commit for easier review to address
backwards-compatibility concerns.
9 years ago
Abhijit Menon-Sen 1981bf2b95 Aggregate ssh arguments in PlayContext instead of the connection plugin
Using set_host_overrides() in the connection plugin to access the ssh
argument variables from the inventory didn't see group_vars/host_vars
settings, as noted earlier. Instead, we can set the correct values in
the PlayContext, which has access to all command-line options, task
settings, and variables.

The only downside of doing so is that the source of the settings is no
longer available in ssh.py, and therefore can't be logged. But the code
is simpler, and it actually works.

This change was suggested by @jimi-c in response to the FIXME in the
earlier commit.
9 years ago
Abhijit Menon-Sen 3ad9b4cba6 Rework additional ssh argument handling
Now we have the following ways to set additional arguments:

1. [ssh_connection]ssh_args in ansible.cfg: global setting, prepended to
   every command line for ssh/scp/sftp. Overrides default ControlPersist
   settings.
2. ansible_ssh_common_args inventory variable. Appended to every command
   line for ssh/scp/sftp. Used in addition to ssh_args, if set above, or
   the default settings.
3. ansible_{sftp,scp,ssh}_extra_args inventory variables. Appended to
   every command line for the relevant binary only. Used in addition to
   #1 and #2, if set above, or the default settings.
3. Using the --ssh-common-args or --{sftp,scp,ssh}-extra-args command
   line options (which are overriden by #2 and #3 above).

This preserves backwards compatibility (for ssh_args in ansible.cfg),
but also permits global settings (e.g. ProxyCommand via _common_args) or
ssh-specific options (e.g. -R via ssh_extra_args).

Fixes #12576
9 years ago
Toshio Kuratomi f13d5201b8 Update module refs 9 years ago
Brian Coca 4c9f58a152 added no_log censoring to item output
should be last commit that fixes #12214
9 years ago
Brian Coca ba4afcbbb6 added no_log to results
normalized outputs to use display class
cleaned up unused imports
9 years ago
Brian Coca c27bd4fab0 {sudo,su}_user does not imply become 9 years ago
James Cammarata 57372906aa Pull host/group vars when adding hosts/groups
Fixes #12582
9 years ago
James Cammarata aa3687d736 Fix syntax error for octal in encrypt methods 9 years ago
James Cammarata 538568305a Submodule pointer update for accelerate module fixes 9 years ago
James Cammarata 8ef78b1cf8 Fixing accelerated connection plugin 9 years ago
Brian Coca 3705d54485 fixed error reporting on splitter 9 years ago
Brian Coca de2f62bd9e fixed error reporting for unkown become user 9 years ago
Brian Coca 6d6bfbc3d2 added missing import for pwd, was being obscured by exception catching and fallback 9 years ago
Brian Coca a680ef66dd fixed vault password file script execution 9 years ago
Brian Coca 6b842d9c49 fixed incorrect data passing on certain events 9 years ago
Brian Coca 2463922306 fixed error reporting when missing redis import 9 years ago
Brian Coca 6e96188085 added missing entry for dealing with bcc 9 years ago
Brian Coca 6ec5abf1c3 fixed some pyflakes 9 years ago
Abhijit Menon-Sen 49b35ad5dd Remove mysterious old cruft
The two lines were added in 2673eb0a and modified in 60e1a1f8, but foo
is completely unused. Removing it doesn't break anything: out it goes!
9 years ago
Brian Coca fe0e4f27ad Merge pull request #12584 from amenonsen/fixups
Remove an unwanted FIXME annotation
ok, confirmed we don't want to support it
9 years ago
Brian Coca 6c190aa8a4 updated ansible-doc to ignore more stuff that has been added to the module repos 9 years ago
Brian Coca 1a56a5c442 created debug method, renamed debug attribute to _debug 9 years ago
James Cammarata deff045aa9 Fix bug caused by options not having start_at_task when used through adhoc
Fixes #12590
9 years ago
Toshio Kuratomi a0920c06e1 Pull submodule refs to fix docs builds 9 years ago
Toshio Kuratomi 4dae7eeca1 Update submodule refs 9 years ago
Toshio Kuratomi 56fa9a5098 Port to v2 API 9 years ago
Toshio Kuratomi d35c9a30fb Minor refactorings 9 years ago
Toshio Kuratomi 888bcd65a8 Create error messages instead of tracebacks. 9 years ago
Abhijit Menon-Sen 93515468c4 Remove an unwanted FIXME annotation
<crab> jimi|ansible: do you think it should be possible to add both
       foo:22 and foo:23 to the inventory?
<jimi|ansible> no

…so we don't want an invitation to FIXME.
9 years ago
Toshio Kuratomi 4cfcf5d61b Merge pull request #12568 from mgedmin/py3k
Python 3: fix most tests for ansible.module_utils.basic
9 years ago
Trond Hindenes 94cfbe7ee9 Get-AnsibleParam 9 years ago
James Cammarata dcb8caf9e8 Remember if we already skipped tasks via --start-at-task
Fixes #12482
9 years ago
chouseknecht 57adf11262 Fix metadata description for galaxy_tags. 9 years ago
chouseknecht f4690e3bfe Changing tag to galaxy_tag. 9 years ago
chouseknecht 8360a1b3f2 Replace categories with tags.
Also added --ignore-certs option for use with install and search commands. Helpful when
overriding server and server has self signed cert.
9 years ago
Abhijit Menon-Sen 0bb34fd076 Make «ansible-vault view» not write plaintext to a tempfile
CLI already provides a pager() method that feeds $PAGER on stdin, so we
just feed that the plaintext from the vault file. We can also eliminate
the redundant and now-unused shell_pager_command method in VaultEditor.
9 years ago
Brian Coca bf06e36382 updated async to pass along no_log setting 9 years ago
Marius Gedminas cc1e1648f5 Tweak comment style 9 years ago
Marius Gedminas 213029a21e Python 3: don't convert unicode to unicode 9 years ago
Marius Gedminas c7be004c19 Python 3 has no dict.iteritems()
(Reminder: cannot use six here, module_utils get shipped to remote
machines that may not have six installed -- besides six doens't support
Python 2.4.)
9 years ago
Marius Gedminas 9f3e5ceb14 Make sure 'basestring', 'bytes' and 'unicode' are defined
Python 3 doesn't have 'basestring' and 'unicode'.

Python 2.4 doesn't have 'bytes'
9 years ago
Brian Coca ddafed4403 Merge pull request #12528 from bcoca/task_logging
task logging revamp
9 years ago
Brian Coca 7b64126c9d pushed up openvz detection for cases of 'stacked' virtualization 9 years ago
Linus Unnebäck 45f9800754 facts: correctly detect docker inside a xen host 9 years ago
James Cammarata 3bd71d0619 Use delegated_to field for play context remote_addr, if none other exists
Fixes #12527
9 years ago
James Cammarata 40bdf09998 Merge pull request #12561 from srvg/anotherdirpy
Inject existing groups at InventoryDir initialization
9 years ago
James Cammarata 6fcd292c5e Merge pull request #12569 from amenonsen/fixes
Bring groups handling in ini.py up-to-date (trivial fix)
9 years ago
James Cammarata dfa33d0f23 Tweak variable manager use in role includes to avoid test failures 9 years ago
Abhijit Menon-Sen 50d75f8d6d Bring groups handling in ini.py up-to-date
Since c8f2483d, ini.py expects to always be passed in a pre-created list
of groups, and can no longer deal sensibly with an empty list; this just
makes that expectation clear.
9 years ago
James Cammarata a89412ecb1 Fail all hosts if a run_once task fails
Fixes #12563
9 years ago
James Cammarata 7173f587ed Allow delegate_to on a role again
Fixes #12560
9 years ago
James Cammarata a3e913da62 Don't assume handlers exist in the same role (if any)
Fixes #12536
9 years ago
Serge van Ginderachter 7461ba9998 Inject existing groups at InventoryDir initialization
This fixes a corner case where ini files live in a subdir
of the main inventory directory.

Reproducing the original error:

mkdir -p inventory/ini
cat > inventory/ini/hosts << EOF
[www]
www1
EOF

$ ansible -i inventory/ all -m ping
ERROR! 'all'

(or without the [www] group, it would complain about 'ungrouped')
9 years ago
James Cammarata 79e364d98b Properly template role dependency names
Fixes #12505
9 years ago
Marius Gedminas 5edd6d9be4 Python 3: there's no basestring
Fixes another failing test.

(I don't want to do a global search/replace for 'basestring' because I
want to have unit tests covering each occurrence.  When I run out of
existing failing tests, I'll try to write new ones.)
9 years ago
Toshio Kuratomi 95ede22a1e Add a comment about the docker connection and usage by non-root users 9 years ago
Toshio Kuratomi 0e110d23f8 Misc cleanups and some fixes for docker connection plugin
* Remove extraneous imports
* Fix some error handling
* Enable pipelining
* Disable su since it doesn't work
* Add error message when installed docker is not recent enough to
  support this plugin
* Move nested functions to class level
* Make transport a class attribute
* Make exec_command, put_file and fetch_file more robust
9 years ago
Toshio Kuratomi 1d119a1f46 Cleanup some extraneous imports 9 years ago
James Cammarata ffdba96668 Save the included directory for playbook includes for use as the basedir
Fixes #12524
9 years ago
Konstantin Manna 4226e49bc6 bugfix: statement had no effect => statement now has assumed effect 9 years ago
Konstantin Manna 1ccfeafa76 bugfix: use correct close calls 9 years ago
Brian Coca c1ad96e5cf removed fixme as it is already implemented below. 9 years ago
RedRampage 922b5c8109 Removed deletion of salt by 'password' lookup
Removed deletion of salt param from lookup file by 'password' lookup_filter.
Old behaviour leads to constant changed status when two tasks uses same lookup,
one with 'encrypt' parameter, and other without.

For example:

    tasks:
      - name: Create user
        user:
          password: "{{ lookup('password', inventory_dir + '/creds/user/pass' ncrypt=sha512_crypt) }}"
          ...
    # Lookup file 'creds/user/pass' now contain password with salt
      - name: Create htpasswd
        htpasswd:
          password: "{{ lookup('password', inventory_dir + '/creds/user/pass') }}"
          ...
    # Salt gets deleted from lookup file 'creds/user/pass'
    # Next run of "Create user" task will create it again and will have 'changed' status
9 years ago
Toshio Kuratomi 12a2585e84 chroot plugin minor touchups:
* Disable su as it's not currently working 100% (and was disabled in v1).
* Move BUFSIZE out of the class to match other conenction plugins
* _connect shouldn't return self.
9 years ago
Toshio Kuratomi 7a4266e9c5 One more try -- the error message should reference the become method
requested via play context
9 years ago
Toshio Kuratomi 696cf32d63 Correct name of variable 9 years ago
Brian Coca 8d024c3747 Merge pull request #12472 from resmo/for_ansible
cloudstack: improvements and tests
9 years ago
Toshio Kuratomi 0dfa1fb43a Correct call to method typo 9 years ago