James Cammarata
38c11e2239
Default msg param to AnsibleError to avoid serialization problems
9 years ago
James Cammarata
ed4a06d8ef
Don't use play vars in HostVars
...
Fixes #13398
9 years ago
Matt Martz
ca838d75e3
Get v2_playbook_on_start working
...
* Move self._tqm.load_callbacks() earlier to ensure that v2_on_playbook_start can fire
* Pass the playbook instance to v2_on_playbook_start
* Add a _file_name instance attribute to the playbook
9 years ago
Abhijit Menon-Sen
f339184e29
Use CLI.expand_tilde also for the vault --output file
9 years ago
Abhijit Menon-Sen
f2f310472f
Make module_lang default to whatever LANG is set to on the control node
9 years ago
Matt Martz
de7dc5d07f
Catch additional assertion errors for load_list_of_blocks
9 years ago
Brian Coca
ae5cfb2898
better error on invalid task lists
9 years ago
James Cammarata
381409140e
Minor tweak and comment addition to 974a0ce3
9 years ago
Christoph Dittmann
be92f909ee
Update debug messages and comments
...
The comment was taken literally from lib/plugins/strategy/linear.py and
makes no sense in free.py where we have no noop tasks.
Also update the debug messages.
9 years ago
Christoph Dittmann
974a0ce3fb
Fix issue #13370
...
all_blocks is referenced after the loop over included_files, so it needs
to be initialized before this loop, not inside.
9 years ago
Christoph Dittmann
1f1febaa0d
Let PlayIterator.add_tasks accept empty task lists
...
PlayIterator.add_tasks raised an error when trying to add an empty task
list. This was the root cause of ansible issue #13370 .
9 years ago
Brian Coca
346a9fe87d
unconditionally set vars on init to avoid issues with var precedence
9 years ago
Peter Sprygada
5b5c6c4f47
fixes a syntax issue with module_utils/eapi.py
...
This patch fixes an issue with the common args dict in the eapi shared
module. This patch is required for the eapi shared module to be properly
imported and is therefore should be applied to all instances.
9 years ago
Peter Sprygada
02d059271c
initial add of ssh shared module.
...
This ssh shared module is used for building modules that require an
interactive shell environment such as those required for connecting
to network devices
9 years ago
Peter Sprygada
a6771b2255
adds module create function for eapi.py shared module
...
This commit changes the way modules create an instance of AnsibleModule to
now use a common function, eapi_module. This function will now automatically
append the common argument spec to the module argument_spec. Module
arguments can override common module arguments
9 years ago
Peter Sprygada
a9e8b54246
initial add of the ios shared module
...
This adds shared module support for building modules that connect to Cisco
IOS devices. It builds on the module_utils/ssh.py shared module.
9 years ago
Brian Coca
d2108e9ff3
fixed signature for init on callbacks
...
also removed passing display to base class which already handles this
9 years ago
nitzmahone
59dadc4f6b
allow shell plugin to affect remote module filename
...
Fix for 13368, added get_remote_filename to shell plugins, powershell version appends .ps1 if necessary, base shell plugin no-ops
9 years ago
Toshio Kuratomi
b0e22d7701
_connect no longer takes a port argument
9 years ago
Brian Coca
ca8c6e8e1c
ignore password flags in become conflict check
...
since all the --ask pass options end up triggering the same code
and are functionally equivalent, ignore them when it comes to checking
privilege escalation conflicts. This allows using -K when --become-method=su
and so on.
9 years ago
Brian Coca
204e27ca66
avoid inheritance issues with default=dict declaration at class level
...
this should avoid the issue of subsequent plays not prompting for a var
prompted for in a previous play.
fixes #13363
9 years ago
James Cammarata
f96730003b
Also make sure remote_user is defaulted correctly for delegated hosts
...
Fixes #13323
9 years ago
Toshio Kuratomi
4f3f79d37b
Call the function :-)
...
Fixes #13330
9 years ago
James Cammarata
89f0207007
Ensure port is (re)set for delegated-to hosts
...
Fixes #13265
9 years ago
Brian Coca
f8ed1c003a
fixed typo
9 years ago
Brian Coca
c5cd908c33
allow for bad stdout return from make temp dir command
...
fixes #13359
9 years ago
Brian Coca
958da26d18
corrected become_methods class variable in winrm
...
This should now correctly react when using become with winrm
fixes #13331
9 years ago
James Cammarata
a5d6be6dd2
Make sure run_once tasks properly set variables for all active hosts
...
Fixes #13267
9 years ago
James Cammarata
7af506e7cf
Use text_type instead of unicode
9 years ago
James Cammarata
3a0f2475b2
Make sure the uuid in vars is string
9 years ago
James Cammarata
2db3f12027
Re-implement lookup wantlist
...
Fixes #13285
9 years ago
Yannig Perré
bb52b45ea0
Do not copy variable_manager each time. Instead, keep host and local variable_manager sync.
...
Fix https://github.com/ansible/ansible/issues/13221
9 years ago
James Cammarata
4114a3097f
Tweak location of stats callback execution and properly relocate stats output code
9 years ago
Monty Taylor
73a269f9a5
Put in trap for args being None
...
_normalize_old_style_args can return None. If it does, the loop
"for args in args" blows up.
9 years ago
James Cammarata
737e467b8a
Trigger on_stats just once, not once for each play
...
Fixes #13271
9 years ago
Abhijit Menon-Sen
cac0eea291
Explicitly accept become_success in awaiting_prompt state
...
If we request escalation with a password, we start in expecting_prompt
state. If the escalation then succeeds without the password, i.e., the
become_success response arrives, we must explicitly move into the next
state (awaiting_escalation, which immediately goes into ready_to_send),
so that we no longer try to apply the timeout.
Otherwise, we would leak the success notification and eventually
timeout. But if the module response did arrive before the timeout
expired, the "process has already exited" test would do the right
thing by accident (which is why it didn't fail more often).
Fixes #13289
9 years ago
James Cammarata
54843d88ee
Re-adding role_name/role_uuid variables
9 years ago
Yannig Perré
47651e6c22
More restrictive test against variable name to allow setting variable starting with _.
9 years ago
Yannig Perré
9e6ec4c6b0
Switch parameters validation after parsing in order to be more consistent between old and new style.
9 years ago
Brian Coca
dbedcd3538
avoids prompting for vars during syntax check
...
fixes #13319
9 years ago
Toshio Kuratomi
056372690f
Do not double transform to unicode
9 years ago
Charles Paul
9cee982a62
fixing errors with utf-8 values
...
removing utf-8 stanza
changing cast to binary_type instead
using to_unicode
9 years ago
Brian Coca
b69942a6d2
added missing :
9 years ago
Brian Coca
d9858ee73a
added missing events to base class
9 years ago
Brian Coca
64bcab9253
fixes to fetch action module
...
* now only runs remote checksum when needed (fixes #12290 )
* unified return points to simplify program flow
9 years ago
James Cammarata
fc4326dc0c
Fix ssh state issues by simply assuming it's never connected
9 years ago
James Cammarata
92ea5c9f7b
Properly check for prompting state when re-using ssh connection
...
Fixes #13278
9 years ago
Yannig Perré
90021104d5
Use to_unicode instead of str()
9 years ago
Yannig Perré
8bd5abaf1e
Allow debug var parameter to accept a list or dict. Fix https://github.com/ansible/ansible/issues/13252
9 years ago
Sebastien Couture
2859933a79
We should give pipes.quote() a string every time
9 years ago