35a04ff134
Resolves issue with vmware_migrate_vmk module for v2.0
...
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_migrate_vmk module.
@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568
Playbook
```
- name: Migrate Management vmk
local_action:
module: vmware_migrate_vmk
hostname: "{{ mgmt_ip_address }}"
username: "{{ vcsa_user }}"
password: "{{ vcsa_pass }}"
esxi_hostname: "{{ hostvars[item].hostname }}"
device: vmk1
current_switch_name: temp_vswitch
current_portgroup_name: esx-mgmt
migrate_switch_name: dvSwitch
migrate_portgroup_name: Management
with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Migrate Management vmk] **************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/migrate_vmk.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" )
localhost PUT /tmp/tmpdlhr6t TO /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" )
localhost PUT /tmp/tmpqfZqh1 TO /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" )
localhost PUT /tmp/tmpf3rKZq TO /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/" > /dev/null 2>&1
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-01"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-02"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-03"}
```
9 years ago
ff8806eaee
Merge pull request #1601 from mixmatch/patch-1
...
Fix indent
9 years ago
a1c2cb0a2e
Fix indent
9 years ago
14a62fb5d6
Merge pull request #1415 from jtyr/jtyr-yumrepo_params
...
Adding params option into the yumrepo module
9 years ago
73b7b70332
Merge pull request #1582 from caphrim007/fix-missing-validate-certs
...
Fixes missing validate_certs parameter
9 years ago
ec5c03381b
Merge pull request #1378 from johanwiren/fix_properties_handling
...
Fix zfs properties handling
9 years ago
f6add50969
Merge pull request #1293 from gerph/gerph-fix-docs-patch
...
Update 'patch' documentation for src, remote_src, backup and binary.
9 years ago
b1e9dc0b52
Allow dnf to remove dependent packages of a package that is being removed
...
Fixes #1517
9 years ago
1b5c9ee7f9
Merge pull request #1584 from sivel/doc-fix-ec2_vpc_dhcp_options
...
DOCUMENTATION and RETURN fixes for modules
9 years ago
d2e3909443
Fix DOCUMENTATION for ec2_vpc_dhcp_options.py and add missing RETURN to ec2_vol_facts.py
9 years ago
9aac5784d3
Merge pull request #1565 from mjschultz/welex91
...
Ensure that port_path is split into at most 2 components.
9 years ago
14f0ad07ab
Merge pull request #1548 from vvanholl/devel
...
Do not fail when action is delete and volume is not present
9 years ago
284032efff
Merge pull request #1538 from bibliotechy/patch-1
...
Doc wrongly indicates firewalld permanent flag is required
9 years ago
5b61c75fa5
added missing verison_added
9 years ago
0f2cdbeee4
Merge pull request #1532 from mbobakov/devel
...
Add custom parameter for a sensu_check
9 years ago
cd64f20034
added missing version_added
9 years ago
ff554a76d7
Merge pull request #1402 from doalitic/iptables-add-limit-burst
...
Add limit-burst support to iptables module
9 years ago
a2532862d8
Merge pull request #1330 from joelthompson/feature/ec2_vpc_dhcp_options
...
Add new ec2_vpc_dhcp_options module
9 years ago
20caf29213
Merge pull request #1113 from shawnsi/vpc-route-table-continued
...
Additional check mode fixes for ec2_vpc_route_table module
9 years ago
166133b1f8
Merge pull request #1111 from h0nIg/devel
...
win_acl: windows 2008 fix + special account fix + strict fix
9 years ago
7e81c60c96
corrected version added
9 years ago
76feff5b4d
Merge pull request #1109 from wimnat/feature/ec2_vol_facts
...
New module - ec2_vol_facts
9 years ago
3ca2c51ed9
Merge pull request #1077 from blakfeld/fix_win_unzip
...
Made win_unzip Powershell Strict Complient
9 years ago
7c50f4cc8f
Merge pull request #831 from viruxel/devel
...
Enable managing multiple user permissions from one shot
9 years ago
56a517b054
Fixes missing validate_certs parameter
...
The bigip_api method was changed in the module_utils function definition
to include the validate_certs option but the bigip_virtual_server module
was not updated accordingly. This patch updates the method so that the
error message below is not returned to the user
received exception: bigip_api() takes exactly 4 arguments (3 given)
9 years ago
bec32094ae
Merge pull request #1577 from bmillemathias/patch-2
...
fix typo
9 years ago
7f918b375f
Adding params option into the yumrepo module
9 years ago
a11220228c
fix typo
...
conainerization => containerization
9 years ago
fff5ae6994
Merge pull request #1567 from danieljakots/devel
...
fix the spelling of vim's flavor in the example
9 years ago
d24721f651
fix the spelling of vim's flavor in the example
9 years ago
36be779888
Remove duplicate documentation fields
9 years ago
eaec3cb45f
Merge pull request #1564 from dalees/devel
...
Fix regression of #821 in puppet of show_diff
9 years ago
acc51c2944
Ensure that port_path is split into at most 2 components.
...
cloudstack: cs_instance: fix do not require name to be set to avoid clashes
Require one of display_name or name. If both is given, name is used as identifier.
cloudstack: fix name is not case insensitive
cloudstack: cs_template: implement state=extracted
Update f5 validate_certs functionality to do the right thing on multiple python versions
This requires the implementation in the module_utils code here
https://github.com/ansible/ansible/pull/13667 to funciton
fixed domain_id to actually be supported
also added domain as an alias
alt fixes #1437
Simplify the code and remove use_unsafe_shell=True
While there is no security issue with this shell snippet, it
is better to not rely on shell and avoid use_unsafe_shell.
Fix for issue #1074 . Now able to create volume without replica's.
Improved fix for #1074 . Both None and '' transform to fqdn.
Fix for ansible-modules-extras issue #1080
9 years ago
27cd172900
Fix regression of #821 in puppet of show_diff
...
Issue #821 fix: 13825761006912ca0aca#821
9 years ago
c4aa5ee024
Add custom parameter for a sensu_check. revert newline
9 years ago
6ef3697c52
Add custom parameter for a sensu_check. Fixes.
...
JSON replaced within dict.
Added more docs.
9 years ago
7eb3d6e15b
Merge pull request #1559 from apenney/more-fixes
...
DOCS: Fix package list for nmcli module.
9 years ago
25262c2238
Fix package list for nmcli module.
...
There was a missing package that causes this to fail.
9 years ago
3ed8a2ff67
Merge pull request #1558 from apenney/fix-mtu-docs
...
Change example to include ethernet as the type.
9 years ago
f5bfc4f9e9
Change example to include ethernet as the type.
9 years ago
cecff17de3
Merge pull request #1513 from AbletonDevTools/devel
...
Fix #1512 add missing property in win_firewall_rule
9 years ago
33213dbc24
Merge pull request #1508 from RajeevNambiar/devel
...
Update sts_assume_role.py for showing the correct example syntax role…
9 years ago
ffefe5dde8
Merge pull request #1505 from Yannig/devel_fix_pvcreate
...
Use -f when pvcreate to avoid interactive input.
9 years ago
98eeb689ce
Merge pull request #1514 from doalitic/iptables-fix-append_csv
...
iptables: fix param check in append_csv function
9 years ago
a7ad0bc7be
Merge pull request #1499 from specnazzz/fix-seport-ports
...
seport module fails when the `ports` argument is a integer
9 years ago
ec8bf56448
Merge pull request #1493 from abulimov/filesystem_recreate_with_force
...
Allow recreation of same FS with force=yes in filesystem module
9 years ago
1f2b6bf3fd
Merge pull request #1492 from alxgu/filesystem_idemponent
...
Make fileystem module idemponent. Compare devicesize and filesystemsize.
9 years ago
65686221af
Merge pull request #1488 from robbwagoner/ec2-elb-facts-with-instance-health
...
Include instance states (InService or OutOfService) as ELB facts
9 years ago
6dfad7d157
Merge pull request #923 from mliudev/fix-rabbitmq_user-list_users
...
Check that the current output from 'list_users' command contains a '\t'.
9 years ago
7286ff5024
Merge pull request #1546 from wimnat/feature/missing-doc-fragment
...
Add missing doc fragments
9 years ago
Joseph Callen