Commit Graph

27860 Commits (22c9428776b10ff060fcb8c115c9ed1fe14d938b)
 

Author SHA1 Message Date
Toshio Kuratomi 22c9428776 eval() should be avoided when at all possible
eval can have security consequences.  It doesn't look bad here but it
does introduce unnecessary complexity and would make it harder if we
ever want to use static analysis to detect and prohibit eval.  So we
should get rid of it.

Note: this could be even more efficient if we combined the checks into
a single condition instead of looping but that does change the error
messages a bit.  For instance:
-        for arg in ('name', 'linode_id'):
-            if not eval(arg):
+        if not (name and linode_id):
+            module.fail_json(msg='name and linode_id are required for active state')
8 years ago
Samuel Boucher ed624876d1 Update atomic_image.py (#19756)
Doc update typo
8 years ago
Dag Wieers e1fe403075 Inform user that the yum metadata cache remains (#19753)
This PR improves the documentation so that it is clear that this module does
not clean the repository metadata cache on removal, and add an example
notification handler to the removal example as an extra reminder.

This fixes #19730
8 years ago
Toshio Kuratomi 74db76ec9c Not my day... Remove extraneous vim typo 8 years ago
Toshio Kuratomi d001d250f0 Whitelist the hacking/cherrypick script's use of python3 8 years ago
Toshio Kuratomi 8f6009de0f Add initial script to aid in cherrypicking from devel to stable-2.2 8 years ago
Dag Wieers 9ddcf16b4b vmware_guest: add support for more virtual NICs (#19932)
This patch adds support for all other virtual NICs, including:

 - pcnet32
 - vmxnet2
 - e1000e
 - sriov

Without this change, VMs with one of these NICs will fail with a
fault.NicSettingMismatch.summary error as it will only add interfaces,
not edit these.

This fixes #19860
8 years ago
Tyrone Tudehope 38d42e8b36 module is a property of the global object client (#19744)
Fixes #5466
8 years ago
René Moser 7ae3539eb5 changelog: add new cloudstack modules (#19940) 8 years ago
Will Thames 5402d0210f Add new mailmap entry for @willthames 8 years ago
René Moser cb8cc51fdf cloudstack: new module cs_host (#19331) 8 years ago
Ryan S. Brown 3519f2c1c9 Add new AWS KMS module to changelog 8 years ago
Ted Timmons 12495e4b42 New module: aws_kms for managing access grants on AWS KMS keys (#19309)
New module by @tedder for handling granting/revoking access to KMS secrets. 

For example:

```
- name: grant user-style access to production secrets
  kms:
  args:
    mode: grant
    key_alias: "alias/my_production_secrets"
    role_name: "prod-appServerRole-1R5AQG2BSEL6L"
    grant_types: "role,role grant"
```
8 years ago
Peter Sprygada 5a14f1d705 adds new module ios_system (#19916)
adds new module ios_system
8 years ago
Toshio Kuratomi 84e755b252 Disable the yuminstallroot tests that are failing until the submitter can take a look. 8 years ago
Toshio Kuratomi cd2516bf8d Revert "Revert "Add --installroot to YUM and DNF modules, issue #11310""
This reverts commit b73ddd5212.
8 years ago
Matt Clay b73ddd5212 Revert "Add --installroot to YUM and DNF modules, issue #11310" 8 years ago
Matt Martz 9048cf2758 Changes to the httptester docker image to support new client cert functionality in tests (#19912)
* Fix Dockerfile
* Add changes to docker image to support new client cert functionality
* Update repo:tag for docker
8 years ago
Peter Sprygada 1c16c1db2b adds new module ios_vrf (#19915)
adds new module ios_vrf
8 years ago
Peter Sprygada d182b271db updates netcfg and refactors Config class (#19920)
* refactors Config into network module
* fixes minor bugs with netcfg
8 years ago
Peter Sprygada f842bc0b91 adds network_common shared module (#19919)
* support for ComplexList and ComplexDict
8 years ago
Peter Sprygada 6b7742fd75 Revert "cleans up the netcfg implementation" (#19917) 8 years ago
berenddeschouwer 1fdcda0996 Add --installroot to YUM and DNF modules, issue #11310 (#19861)
* Add --installroot to YUM and DNF modules, issue #11310

This continues ansible-modules-core#1558, and
ansible-modules-core#1669

Allow specifying installroot for the yum and dnf modules
to install and remove packages in a location other than /.

* Remove empty aliases

* Simpler installroot set default logic
8 years ago
Peter Sprygada d424a0468a refactors ios shared module (#19850)
This allows the ios_* modules to take advantage of the new network_cli
connection plugin by refactoring the ios shared module.  Individual modules
need to be udpated as well
8 years ago
Peter Sprygada 630d10a27a updates action plugins for network_cli connection (#19849)
* net_config now subclasses action plugin network
* net_template now subclasses action plugin network

This will break existing modules until those modules have been refactored.
8 years ago
Peter Sprygada fdb24bb5d7 cleans up the netcfg implementation (#19847)
* moves parse() into the instance
* removes old Config instance and supporting code
* adds net_common shared module
* minor tweaks to NetworkConfig class for parsing config files
8 years ago
Patrik Lundin ee5364f983 openbsd_pkg: make "name" take a list.
This commit also adds the module to DEFAULT_SQUASH_ACTIONS which is
possible with this change.

The module still calls the pkg_* tools once per name internally, so the only
difference is less invocations of the module itself when using with_items.
8 years ago
Jiri Tyr 579b6a0f9d Changing author's e-mail for ldap_* modules (#19900) 8 years ago
Toshio Kuratomi a33e34894b Move some modules into proper categories 8 years ago
Toshio Kuratomi 8469ea93d9 Remove unnecessary use of iteritems so that this compiles under python3 8 years ago
THEBAULT Julien ee1dee08b6 Check the command result status in easy_install plugin (#16519) 8 years ago
Joe Adams 337ea4d65c Add pulp_repo module for interacting with repositories on a pulp server. 8 years ago
Ondra Machacek 8a3e80eb09 cloud: ovirt: add kernel boot parameters to vms module 8 years ago
Fabrizio Colonna b6f9b0be1f Added arbiter support to gluster_volume module. 8 years ago
Andy Freeland 778a189a59 Fix letsencrypt remaining_days docs 8 years ago
Enis Ozgen d4d9a48205 Fix typo in ec2_vpc_peer.py documentation 8 years ago
Paulo Matias d51064a05e os_user: fix typo (self is not defined) 8 years ago
Matt Clay 95b59cd76c Remove `needs/privileged` from postgresql test. (#19907)
* Remove `needs/privileged` from postgresql test.
* Add python 3 support to postgresql tests.
8 years ago
Matt Clay 709a3aa42b Run service test on py3 + unprivileged on docker. (#19841)
* Run service test on py3 + unprivileged on docker.
* Fix service integration test for python 3.
8 years ago
Matt Clay a1d30c853c Enable FreeBSD 11.0 for CI. 8 years ago
Sergio Millan 08b671990d Fixing Issue#18995 8 years ago
Toshio Kuratomi f129977e2b Fix 4d355f8bf2
default values can contain nonstrings and those should not be converted
via to_text.
8 years ago
Toshio Kuratomi 91242b8cc3 Leave a comment that .format() can lead to security risks
Couldn't find any code that does this now but left a comment so that we
don't change something in the future without seeing that it could be
a problem.
8 years ago
Dag Wieers ecaa0202b9 vmware_guest: assorted fixes and improvements (#19842)
A small collection of fixes and improvements:
- Simplify should_deploy_from_template()
- Bugfix for x.config that can be None
- Bugfix for mandatory guest_id (not when using templates)
- Simplify key testing and defaults
- Fix an incorrect reference to the last network
- Duplicate alias 'folder' removed
8 years ago
Toshio Kuratomi 02e3f4b526 Fix for atomic_move on RHEL5
When becoming an unprivileged user using non-sudo on a platform where
getlogin() failed in our situation we were not able to detect that the
user had switched.  This meant that all of our logic to use move vs copy
if the user had switched was attempting the wrong thing.  This change
tries the to do the right thing but then falls back to an acceptable
second choice if it doesn't work.

The bug wasn't easily detected because:
* sudo was not affected because sudo records that the user's have been
  switched so we were able to detect that.
* getlogin() works on most platforms.  RHEL5 with python-2.4 seems to be
  the only platform we still care about where getlogin() fails for this
  case.
* It had to be becoming an unprivileged user.  When becoming
  a privileged user, the user would be able to successfully perform the
  best case tasks.
8 years ago
Toshio Kuratomi 4d355f8bf2 Transform config values to text immediately when they enter ansible
Convert configuration values from ENV VARS, config files, and defaults
in constants.py.
8 years ago
Corwin Brown 9b7c9931db Issue #19575: Adding Dest Param to win_uri (#19577)
* Issue #19575: Adding Dest Param to win_uri

Added `dest` param to win_uri. Outputs the response body to a specified
file.

Addresses Issue #19575

* Was setting the wrong attribute
8 years ago
Matt Clay b7780ca530 Pass DOCKER_* env vars to docker in ansible-test. 8 years ago
James Cammarata a0b4d37dea Removing unused files in playbook/ directory 8 years ago
Brian Coca 92e8c53879 fixed id queries, should rely on effective 8 years ago