Marius Gedminas
f91b28ef23
Fix safe_eval() of set literals
...
There was code to support set literals (on Python 2.7 and newer), but it
was buggy: SAFE_NODES.union() doesn't modify SAFE_NODES in place,
instead it returns a new set object that is then silently discarded.
I added a unit test and fixed the code. I also changed the version
check to use sys.version_tuple instead of a string comparison, for
consistency with the subsequent Python 3.4 version check that I added in
the previous commit.
9 years ago
Marius Gedminas
2b73002044
Python 3: make ansible.template.safe_eval() work
...
Two things changed in Python 3.4:
- 'basestring' is no longer defined, so use six.string_types
- True/False are now special AST node types (NamedConstant) rather than
just names
(Good thing we had tests, or I wouldn't have noticed the 2nd thing!)
I found only one place where safe_eval() is called inside the ansible
codebase: in lib/template/__init__.py. The call to safe_eval(result,
...) is protected by result.startswith('...'), which means result cannot
possibly be a byte string on Python 3 (or startswith() would raise, so
six.string_types (which excludes byte strings on Python 3) is fine here.
9 years ago
James Cammarata
0c5bbe3c32
Use the original (un-templated) args for include params
...
Fixes #12314
9 years ago
Brian Coca
5809a2e81d
Merge pull request #12299 from resmo/feature/test_cs_user
...
cloudstack: new integration test role test_cs_user
9 years ago
James Cammarata
292e2da4e1
Fix some bugs related to facts/nonpersistent-facts cache split
...
Fixes #12313
9 years ago
Brian Coca
1e2dc212bd
added openvswitch_db
9 years ago
James Cammarata
444987cde6
Fix unit test for plugins after basedir/push_basedir removal
9 years ago
Brian Coca
91c9df2154
added verbosity to ansible-doc to make it easier to trace down issues
9 years ago
James Cammarata
b35529b09f
Submodule pointer update
9 years ago
James Cammarata
95a58d1178
Properly serialize UnsafeProxy objects
...
Required as part of fix for #12123
9 years ago
James Cammarata
a410bf26d3
Wrap registered variables in UnsafeProxy
...
Fixes #12123
9 years ago
Toshio Kuratomi
46bf3d1bc1
Remove plugin._basedirs as we now use different data structures to achieve that functionality.
9 years ago
Brian Coca
e6c9efec63
Merge pull request #12310 from amenonsen/hostport
...
Rename ansible_ssh_{host,port,user} in docs to ansible_*
9 years ago
Abhijit Menon-Sen
f56a6e0951
Rename ansible_ssh_{host,port,user} in docs to ansible_*
...
The _ssh variants will continue to work, but the shorter, more generic
names are preferred now.
9 years ago
Brian Coca
6dac8512a1
Merge pull request #12307 from jtyr/doc_fixes
...
Doc fixes
9 years ago
Jiri tyr
14dc16ca54
Adding missing colon to fix the block formating
9 years ago
Brian Coca
1fed03a6bd
Merge pull request #12308 from jtyr/comment_filter_v2
...
Resurrection of the comment filter
9 years ago
Jiri tyr
174f805fb3
Resurrection of the comment filter
9 years ago
Toshio Kuratomi
90e005d234
Merge pull request #12302 from mgedmin/py3k
...
Python 3: use the right PyYAML SafeRepresenter for unicode
9 years ago
Marius Gedminas
b95e3d18a7
Python 3: use the right PyYAML SafeRepresenter for unicode
...
PyYAML has a SafeRepresenter in lib/... that defines
def represent_unicode(self, data):
return self.represent_scalar(u'tag:yaml.org,2002:str', data)
and a different SafeRepresenter in lib3/... that defines
def represent_str(self, data):
return self.represent_scalar('tag:yaml.org,2002:str', data)
so the right thing to do on Python 3 is to use represent_str.
(AnsibleUnicode is a subclass of six.text_type, i.e. 'str' on Python 3.)
9 years ago
Benno Joy
6de13c3062
Merge pull request #11818 from Java1Guy/module_utils_ec2_for_ecs
...
change ec2 util to create only requested objects
9 years ago
James Cammarata
ee7905c7e1
Compare include params against deprecated param names too
...
Fixes #12282
9 years ago
James Cammarata
950e067d2f
Merge pull request #12295 from napkindrawing/patch-3
...
Typo in comment: "bsaename" → "basename"
9 years ago
James Cammarata
f576e0f1af
Merge pull request #12300 from robusto/devel
...
Vault missing DataLoader for pwd file #12293
9 years ago
James Cammarata
22639a2a22
Fix mistake in fact setting to nonpersistent cache in VariableManager
...
Fixes #12301
9 years ago
James Cammarata
aa3b290efd
Fix indent on line in playbook executor
9 years ago
Toshio Kuratomi
4b895f04e3
Fix order of loading of modules.
...
Allows ANSIBLE_LIBRARY to overload core modules even if the module in
ANSIBLE_LIBRARY doesn't have a .py extension.
9 years ago
James Cammarata
e81947c3b4
Fix vars_prompt short form support (and mark deprecated)
9 years ago
Rene Moser
f6382a160d
cloudstack: new integration test role test_cs_user
9 years ago
Blake Atkinson
6062519986
Vault missing DataLoader for pwd file #12293
9 years ago
James Cammarata
be7bd392cb
Fix unreachable host detection and have plays continue after unreachable failures
...
Fixes #12284
9 years ago
Toshio Kuratomi
25c97fff69
Merge pull request #12294 from ansible/fix-password-lookup
...
Fix problem with "=" in the initial file path.
9 years ago
Brian Coca
0dbebfddaa
Revert "remove closing connections after every task, this goes against conneciton caching and was not expected behaviuor nor inhertited from v1"
...
needed for winrm, disabled closing connections in ssh to avoid issues with that persistance, need to normalize all this in future
This reverts commit 23a22397bf
.
9 years ago
Brian Coca
3f0e14c2a0
disabled ssh closing connections
9 years ago
Toshio Kuratomi
e2c49b4ef4
Fix problem with "=" in the initial file path.
9 years ago
James Cammarata
56d7f3889d
Add new level of vars to deal with set_fact/register precedence rules
9 years ago
napkindrawing
172bbac97a
Typo in comment: "bsaename" → "basename"
9 years ago
James Cammarata
926f127245
set_fact should put facts in the fact_cache, not vars_cache
...
Also fixes a template path lookup issue when using an include
Fixes #12277
9 years ago
Toshio Kuratomi
e2e9319f06
Merge pull request #12287 from mgedmin/py3k
...
Python 3: use six.string_types instead of basestring
9 years ago
Toshio Kuratomi
fa2edfa1ef
* Make sure we don't sometimes get byte strings instead of unicode strings
...
* Turn strings into byte strings before passing to shlex and turn them
back into unicode strings after they are retyurned from there
Fixes #12257
9 years ago
Toshio Kuratomi
e67459df86
Fix docstring of parse_value() to be informative
9 years ago
Marius Gedminas
ba0cf42ce9
Python 3: use six.string_types instead of basestring
...
Reduces the number of failing tests from 35 to 17.
9 years ago
Toshio Kuratomi
3a50393cf7
Merge pull request #12269 from mgedmin/py3k
...
Python 3: fix TypeError: unorderable types in test
9 years ago
Brian Coca
1f4c65ab9a
Merge pull request #12283 from kennethgillen/patch-1
...
s/rpmbuild/rpm-build
9 years ago
Kenny Gillen
00d2a80542
s/rpmbuild/rpm-build
...
When I followed these instructions, the generated path was 'rpm-build', not 'rpmbuild'. My rpm-build version is rpm-build-4.11.1-25.el7.x86_64 if that's relevant. Maybe this is 'just me', but wanted to feed back in case it's the same for everyone.
9 years ago
Toshio Kuratomi
1d7b493db3
Fix inclusion of the dynamic inventory scripts
9 years ago
Toshio Kuratomi
c1039de70c
Compatibility with six-1.3.0
9 years ago
James Cammarata
30399edada
Use UnsafeProxy for lookup results too
...
Also fixes a couple of bugs that popped up when using the proxy class
9 years ago
Brian Coca
f0411217e6
Merge pull request #12281 from wenottingham/patch-8
...
Update intro_windows.rst
9 years ago
Bill Nottingham
e2e15992b7
Update intro_windows.rst
...
Fix typo that broke RST -> html parsing.
9 years ago