Toshio Kuratomi
20fb9f8e96
Catch ValueError as well because of El Capitan provoking a bug in python2's subprocess
...
Fixes #14895
9 years ago
Brian Coca
8141eacafc
ensure we use delegated vars on delegation
...
this prevents falling back to connection vars from the inventory_hostname
when matching connection var is not in delegated host.
9 years ago
James Cammarata
25bca5e59f
Make sure tuples returned by _get_item() are handled correctly in formatting
...
Fixes #14800
9 years ago
qqo
ba46b15826
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
9 years ago
Dag Wieers
d011bbf8f2
Fix the color when unreachable in default cb plugin
...
The dedicated color for unreachable errors was not being used in the default cb plugin.
This corrects the color.
9 years ago
Brian Coca
45317ec205
fix lsb fact gathering
...
was erroring out when rc !=0 also fixed redundant paths
fixes #14965
9 years ago
Daniel Kempkens
ca35822aaa
Check return value of get_distribution()
...
On none-Linux systems `get_distribution()` returns `None`, which fails in `fetch_url`, because the return value of `get_distribution()` is not checked before calling `lower()` on the result.
9 years ago
Toshio Kuratomi
2c5468d270
Document the issue with modules being created world-readable on the client in certain circumstances
9 years ago
Brian Coca
ed4cf3d54b
don't raise exceptoins on bad hosts files
...
fixes #14969
9 years ago
Brian Coca
01115c7aec
now item callback honors display_skipped_hosts
...
fixes #14956
9 years ago
Brian Coca
0426b8e872
avoid creating extra tmp dirs we don't delete
...
fixes #14867
9 years ago
James Cammarata
a75e2204fa
Revert "Removing explicit setting of failed/failed_when"
...
This reverts commit 31f29a17d9
.
9 years ago
James Cammarata
31f29a17d9
Removing explicit setting of failed/failed_when
9 years ago
nitzmahone
db038252b8
Fix blind override in failed_when
...
caused all task failures to be success
9 years ago
nitzmahone
8187b23a6a
update core submodule ref for async_status fix
9 years ago
James Cammarata
1ccd534cec
Clean up jsonify unit test with format to remove json lib differences
9 years ago
James Cammarata
b71fbb9364
Fixing up jsonify and adding unit tests
9 years ago
Brian Coca
928a0863c2
corrected changed_when handling
9 years ago
James Cammarata
f7dc7e3aab
Make sure dict strings are unicode for jsonify
9 years ago
James Cammarata
b0c72c59e4
Adding coding header to action plugin unit test file
9 years ago
Brian Coca
500fc50a48
make all conditionals lists
...
this brings them to equivalence with when:
fixes #13905
9 years ago
Matt Clay
a5b0b96b25
Fix misplaced paren.
9 years ago
Brian Coca
d2345015db
fix assemble to not pass extra args to copy/file
...
also small refactor to dedupe code
fixes https://github.com/ansible/ansible-modules-core/issues/3154
9 years ago
Matt Martz
8b52e57529
Strip proc_1 before testing it. Fixes #14858
9 years ago
Brian Coca
5f7b573d61
template also when only comments present
9 years ago
Brian Coca
76bcb9d0e2
avoid basename on none
9 years ago
Brian Coca
162b041925
make sure group_names is always sorted
...
this makes it consistent with previous ansilbe versions and other
paths that create the group_names variable
9 years ago
Brian Coca
3ee95f2d33
dont erase previous nameservers in fact gathering
...
fixes #14806
9 years ago
Brian Coca
b16a6a5309
don't tempalte register
9 years ago
James Cammarata
2347e5c14c
More unit tests for ActionBase
9 years ago
Brian Coca
bb008fb235
avoid issues when stdin is a closed file
...
this seems to happen when nohup is involved, so the check tty
does not get a chance to fail, it just works with pipes
fixes http://github.com/ansible/ansible-modules-core/issues/3166
9 years ago
Brian Coca
db2ec71672
only do squash when 'squashable field' present
9 years ago
nitzmahone
23151a2484
update core submodule ref
9 years ago
Brian Coca
88af81eca8
added warning for when host file doesn't exist
...
fixes #14692
9 years ago
Etherdaemon
8b381ba248
Fixup boto3_conn as commit 6ea772931f
broke commit 27398131cf
9 years ago
Brian Coca
ef7fe461fa
added note about fact gathering task change
...
fixes #14655
9 years ago
Toshio Kuratomi
61e9841e08
normalize path components to unicode before combining or operating on them
...
Note that this will break if we deal with non-utf8 paths. Fixing this
way because converting everythig to byte strings instead is a very
invasive task so it should be done as a specific feature to provide
support for non-utf8 paths at some point in the future (if needed).
9 years ago
Toshio Kuratomi
8c26d6d4f6
Use a unicode format string so that we don't convert to byte strings
...
Fixes #14349
9 years ago
Brian Coca
de7aaf93f3
fixed issue with failed item ignoring no_log
...
backported from devel
9 years ago
Brian Coca
0782f33f0f
dont error out on new internal vars
9 years ago
Brian Coca
62186efc91
pass diff and verbosity settings to modules
...
also simplifies and guarantees that all flags are always passed, even when false
this should make checks simpler as you always expect them to exist
9 years ago
Brian Coca
6925ab604e
hosts can be list or string
9 years ago
Brian Coca
7733ff0a82
default play name to hosts entry
...
return to previous behaviour as now the name was left blank
9 years ago
Brian Coca
6648d42985
output color is now configurable
9 years ago
James Cammarata
292be2a982
Use abspath instead of realpath for group/host vars files
...
The use of realpath means when following symlinks the actual path is
used when loading these files in the VariableManager, which may not
line up with the host or group name specified.
Fixes #14545
9 years ago
James Cammarata
f74ccadb8e
Fix logic error when copying files recursively to a directory
9 years ago
Brian Coca
57626720ce
preserve no_log for async also
9 years ago
James Cammarata
55d1235487
Don't inject PlayContext properties as variables if they're None
...
Fixes bug introduced in 078ebb0
9 years ago
James Cammarata
971b471595
issue callbacks per item and retry fails
...
- now workers passes queue to task_executor so it can send back events per item and on retry attempt
- updated result class to pass along events to strategy
- base strategy updated to forward new events to callback
- callbacks now remove 'items' on final result but process them directly when invoked per item
- new callback method to deal with retry attempt messages (also now obeys nolog)
- updated tests to match new signature of task_executor
fixes #14558
fixes #14072
9 years ago
Brian Coca
8f606e83f6
always return a checksum key, even if empty
9 years ago