Commit Graph

3277 Commits (20c65bf854c656fdde41c2f17dd7a4b4ee3894fd)
 

Author SHA1 Message Date
Michael DeHaan 20c65bf854 Merge pull request #1629 from dagwieers/list-hosts-plays
Make --list-hosts consider all plays (in multiple playbooks)
12 years ago
Michael DeHaan 9d5ce86a4c Merge pull request #1628 from dagwieers/fail-on-empty-host_list
Fail ansible-playbook when the hosts list (with applied subset) is empty
12 years ago
Michael DeHaan c9aef42ac4 Merge pull request #1636 from romeotheriault/add-sunos-subclass-to-group-mod
Add sunos subclass to group mod
12 years ago
Michael DeHaan e13d67bbf1 Merge pull request #1635 from romeotheriault/classify-group-module
convert group module to be platform sub-classable
12 years ago
Michael DeHaan 3bc0adacbf Merge pull request #1634 from dhozac/ssh-password
Add password support to -c ssh via sshpass
12 years ago
Michael DeHaan 3e9a408682 Merge pull request #1633 from dhozac/root-remote_tmp
Use the configured remote_tmp even for root
12 years ago
Michael DeHaan 709818105e Merge pull request #1630 from leucos/devel
Updates Arch linux packaging files
12 years ago
Michael DeHaan 5c8597e4cb Merge pull request #1631 from arrfab/ec2-doc-fix
Added a requirement on euca2ools external package and ec2 url example
12 years ago
Romeo Theriault bb976ddfe0 add solaris subclass to group module 12 years ago
Romeo Theriault a52faa841f convert group module to be platform sub-classable 12 years ago
Daniel Hokka Zakrisson e6fed9f216 Add password support to -c ssh via sshpass 12 years ago
Daniel Hokka Zakrisson 021172f78d Use the configured remote_tmp even for root 12 years ago
Fabian Arrotin 269a0779b4 Added a requirement on euca2ools external package and ec2 url example 12 years ago
Michel Blanc d5f4e033b9 Updates Arch linux packaging files
Added a README.md to explain the purpose of the directory
Fixed dependencies in PKGBUILD
Added patch to change python binary name for arch users, so they
don't end up using python 3 (python links to python3 by default on arch
linux).
12 years ago
Dag Wieers 9ea26c75f9 Make --list-hosts consider all plays (in multiple playbooks)
Currently when more than one playbook is provided on the commandline, ansible-playbook --list-hosts will only consider the first playbook and stop. This change will make it work for the various different playbooks.
12 years ago
Dag Wieers a259b95556 Fail ansible-playbook when the hosts list (with applied subset) is empty
When the inventory is empty, or the provided --limit subset returns an empty intersection, we don't want to loop over all plays but bail out at the very start.
12 years ago
Michael DeHaan 0ab3bd0034 Fix for #1577 (python 2.4 compliance for mysql_user), tested only for syntax, please exercise MySQL fans! 12 years ago
Michael DeHaan ab5c0dfe7e __new__ does not take arguments, remove deprecation warning 12 years ago
Michael DeHaan 89bb1b8368 Fixup fireball installation playbook 12 years ago
Michael DeHaan 096607eea4 Allow fireball to transfer binary files, fixup fireball docs, make fetch work with fireball. 12 years ago
Michael DeHaan 8c0f83a2c9 Update "Who Uses Ansible" 12 years ago
Michael DeHaan 613539810e Missing import 12 years ago
Michael DeHaan d500398e76 Merge pull request #1616 from dagwieers/skip-register
Do not register variable if host has been skipped
12 years ago
Michael DeHaan 52e2654faf Merge pull request #1621 from dhozac/lookup-with-vars
Lookup plugin arguments need to be templated
12 years ago
Michael DeHaan 73ae930659 Merge pull request #1623 from dhozac/group-hosts-set
Create a set of all the hosts in a group to prevent duplicates
12 years ago
Daniel Hokka Zakrisson 17e4ce97a4 Create a set of all the hosts in a group to prevent duplicates
Fixes #1516.
12 years ago
Daniel Hokka Zakrisson e74ffd6764 Lookup plugin arguments need to be templated 12 years ago
Dag Wieers 302eeae65d Do not register variable if host has been skipped
Executive summary: skipping a host corrupts a variable (when it is registered)

We have a play existing out of multiple tasks that check a condition, if one of these tasks fails we want to skip all next tasks in the playbook. I noticed that if we skip a task because a certain condition is met, and this task has a register-attribute, I loose the value in the variable. Which means we cannot use that variable in subsequent tasks to evaluate because it was skipped:

```
- action: command test -d /some/directory
  register: task

- action: command test -f /some/directory/file
  register: task
  only_if: '${task.rc} == 0'

- action: do something else
  only_if: '${task.rc} == 0'
```

In the above example, if the second task is skipped (because the first failed), the third action will end with a "SyntaxError: invalid syntax" complaining about the unsubstituted ${task.rc} (even though it was set by the first task and used for skipping the second).

The following play demonstrates the problem:

```
- name: Test register on ignored tasks
  hosts: all
  gather_facts: no

  vars:
    skip: true
    task: { 'rc': 666 }

  tasks:
  - action: debug msg='skip = ${skip}, task.rc = ${task.rc}'

  - name: Skip this task, just to test if task has changed
    action: command ls
    register: task
    only_if: '${skip} != True'

  - action: debug msg='skip = ${skip}, task.rc = ${task.rc}'

  - name: Now use task value
    action: command echo 'Works !'
    only_if: '${task.rc} == 0'
```

And the enclosed fix, fixes the above problem.
12 years ago
Michael DeHaan 44af1408ee Merge pull request #1611 from dhozac/no-hostvars-templating
Keep hostvars from being templated
12 years ago
Michael DeHaan 6793bcbe4d Merge pull request #1613 from dhozac/use-all-vars-for-hosts-template
Use all available vars for hosts:, user: and sudo_user:
12 years ago
Michael DeHaan 2303f65a1a Merge pull request #1614 from dagwieers/missing-action-error
Print the task name (if any) when complaining
12 years ago
Michael DeHaan 7a48525357 Merge pull request #1612 from dhozac/play-vars-list
Make parameterized playbook includes work with vars as a list
12 years ago
Dag Wieers b96877e5aa Print the task name (if any) when complaining
After spending 10 minutes to find which playbook had an action/local_action missing, I changed the error to include the task name (if set). The error eventually was caused because I added a name to a task, but the dash before the existing action was not removed.
12 years ago
Daniel Hokka Zakrisson 0be1f11ed5 Use all available vars for hosts:, user: and sudo_user: 12 years ago
Daniel Hokka Zakrisson eebbbd3f0e Make parameterized playbook includes work with vars as a list
Fixes #1610.
12 years ago
Daniel Hokka Zakrisson 5752d2a850 Fix lookup plugin test properly 12 years ago
Daniel Hokka Zakrisson c200c26ced Keep hostvars from being templated 12 years ago
Michael DeHaan e3f7f86ac4 Merge pull request #1608 from dhozac/when_set-non-string
Try to ensure the entire value is quoted
12 years ago
Michael DeHaan d5be13c3f0 Merge pull request #1605 from romeotheriault/add-md5-support-to-fetch-module
add bsd md5 support to fetch module
12 years ago
Michael DeHaan 96e5408046 Merge pull request #1607 from dhozac/j2-templated-vars
Templating fixes and features
12 years ago
Daniel Hokka Zakrisson 0ca1775bda Try to ensure the entire value is quoted 12 years ago
Daniel Hokka Zakrisson 25a8787e95 Template all variables before returning them to Jinja2 12 years ago
Michael DeHaan df458fb3b5 Merge pull request #1606 from romeotheriault/minor-linux-user-fixes
minor linux user module fixups
12 years ago
Daniel Hokka Zakrisson d2dce1d63f Make lookup plugin replacements part of the main variable logic 12 years ago
Daniel Hokka Zakrisson f91fa9f765 Fix lookup plugin test 12 years ago
Daniel Hokka Zakrisson a2bb3a09d2 Completely ignore stray $ in input
Previously, "a $ string $var" would not have gotten replaced at all.
12 years ago
Daniel Hokka Zakrisson 24b536d7ed Add some comments to templating system 12 years ago
Romeo Theriault ae36fb1dc6 minor linux user module fixups 12 years ago
Romeo Theriault 4cd133ed8f add bsd md5 support to fetch module 12 years ago
Michael DeHaan 8f9bef9d51 Merge pull request #1604 from dhozac/consume-module_vars-early
Template using module_vars early
12 years ago